Got questions, comments, patches, etc.?
Contact Jason Woofenden
gitweb
/
spectrwm.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
convert XSetWindowBorder()'s and unmanage_window() to XCB
[spectrwm.git]
/
spectrwm.c
diff --git
a/spectrwm.c
b/spectrwm.c
index
87fa847
..
f7ed89b
100644
(file)
--- a/
spectrwm.c
+++ b/
spectrwm.c
@@
-486,7
+486,7
@@
struct swm_screen {
/* colors */
struct {
/* colors */
struct {
- unsigned long color;
+ uint32_t color;
char *name;
} c[SWM_S_COLOR_MAX];
char *name;
} c[SWM_S_COLOR_MAX];
@@
-626,6
+626,18
@@
void update_window(struct ws_win *);
void spawn_select(struct swm_region *, union arg *, char *, int *);
unsigned char *get_win_name(xcb_window_t);
xcb_atom_t get_atom_from_string(const char *);
void spawn_select(struct swm_region *, union arg *, char *, int *);
unsigned char *get_win_name(xcb_window_t);
xcb_atom_t get_atom_from_string(const char *);
+void map_window_raised(xcb_window_t);
+
+void
+map_window_raised(xcb_window_t win)
+{
+ uint32_t val = XCB_STACK_MODE_ABOVE;
+
+ xcb_configure_window(conn, win,
+ XCB_CONFIG_WINDOW_STACK_MODE, &val);
+
+ xcb_map_window(conn, win);
+}
xcb_atom_t
get_atom_from_string(const char *str)
xcb_atom_t
get_atom_from_string(const char *str)
@@
-1810,7
+1822,7
@@
bar_toggle(struct swm_region *r, union arg *args)
for (i = 0; i < num_screens; i++)
TAILQ_FOREACH(tmpr, &screens[i].rl, entry)
if (tmpr->bar)
for (i = 0; i < num_screens; i++)
TAILQ_FOREACH(tmpr, &screens[i].rl, entry)
if (tmpr->bar)
- XMapRaised(display, tmpr->bar->id);
+ map_window_raised(tmpr->bar->id);
}
bar_enabled = !bar_enabled;
}
bar_enabled = !bar_enabled;
@@
-1933,7
+1945,7
@@
bar_setup(struct swm_region *r)
XCB_RANDR_NOTIFY_MASK_OUTPUT_CHANGE);
if (bar_enabled)
XCB_RANDR_NOTIFY_MASK_OUTPUT_CHANGE);
if (bar_enabled)
- XMapRaised(display, r->bar->id);
+ map_window_raised(r->bar->id);
DNPRINTF(SWM_D_BAR, "bar_setup: window: 0x%lx, (x,y) w x h: (%d,%d) "
"%d x %d\n", WINID(r->bar), X(r->bar), Y(r->bar), WIDTH(r->bar),
DNPRINTF(SWM_D_BAR, "bar_setup: window: 0x%lx, (x,y) w x h: (%d,%d) "
"%d x %d\n", WINID(r->bar), X(r->bar), Y(r->bar), WIDTH(r->bar),
@@
-2011,21
+2023,23
@@
version(struct swm_region *r, union arg *args)
}
void
}
void
-client_msg(struct ws_win *win, Atom a)
+client_msg(struct ws_win *win, xcb_atom_t a)
{
{
- XClientMessageEvent cm;
+ xcb_client_message_event_t ev;
if (win == NULL)
return;
if (win == NULL)
return;
- bzero(&cm, sizeof cm);
- cm.type = ClientMessage;
- cm.window = win->id;
- cm.message_type = aprot;
- cm.format = 32;
- cm.data.l[0] = a;
- cm.data.l[1] = CurrentTime;
- XSendEvent(display, win->id, False, 0L, (XEvent *)&cm);
+ bzero(&ev, sizeof ev);
+ ev.response_type = XCB_CLIENT_MESSAGE;
+ ev.window = win->id;
+ ev.type = aprot;
+ ev.format = 32;
+ ev.data.data32[0] = a;
+ ev.data.data32[1] = XCB_CURRENT_TIME;
+
+ xcb_send_event(conn, False, win->id,
+ XCB_EVENT_MASK_NO_EVENT, (const char *)&ev);
}
/* synthetic response to a ConfigureRequest when not making a change */
}
/* synthetic response to a ConfigureRequest when not making a change */
@@
-2148,8
+2162,8
@@
unmap_window(struct ws_win *win)
set_win_state(win, XCB_WM_STATE_ICONIC);
xcb_unmap_window(conn, win->id);
set_win_state(win, XCB_WM_STATE_ICONIC);
xcb_unmap_window(conn, win->id);
- XSetWindowBorder(display, win->id,
- win->s->c[SWM_S_COLOR_UNFOCUS].color);
+ xcb_change_window_attributes(conn, win->id,
+ XCB_CW_BORDER_PIXEL, &win->s->c[SWM_S_COLOR_UNFOCUS].color);
}
void
}
void
@@
-2215,29
+2229,32
@@
restart(struct swm_region *r, union arg *args)
}
struct swm_region *
}
struct swm_region *
-root_to_region(Window root)
+root_to_region(xcb_window_t root)
{
struct swm_region *r = NULL;
{
struct swm_region *r = NULL;
- Window rr, cr;
- int i, x, y, wx, wy, num_screens;
- unsigned int mask;
+ int i, num_screens;
+ xcb_query_pointer_cookie_t qpc;
+ xcb_query_pointer_reply_t *qpr;
- DNPRINTF(SWM_D_MISC, "root_to_region: window: 0x%lx\n", root);
+ DNPRINTF(SWM_D_MISC, "root_to_region: window: 0x%x\n", root);
num_screens = xcb_setup_roots_length(xcb_get_setup(conn));
for (i = 0; i < num_screens; i++)
if (screens[i].root == root)
break;
num_screens = xcb_setup_roots_length(xcb_get_setup(conn));
for (i = 0; i < num_screens; i++)
if (screens[i].root == root)
break;
- if (XQueryPointer(display, screens[i].root,
- &rr, &cr, &x, &y, &wx, &wy, &mask) != False) {
+ qpc = xcb_query_pointer(conn, screens[i].root);
+ qpr = xcb_query_pointer_reply(conn, qpc, NULL);
+
+ if (qpr) {
DNPRINTF(SWM_D_MISC, "root_to_region: pointer: (%d,%d)\n",
DNPRINTF(SWM_D_MISC, "root_to_region: pointer: (%d,%d)\n",
- x, y);
+ qpr->root_x, qpr->root_y);
/* choose a region based on pointer location */
TAILQ_FOREACH(r, &screens[i].rl, entry)
/* choose a region based on pointer location */
TAILQ_FOREACH(r, &screens[i].rl, entry)
- if (X(r) <= x && x < MAX_X(r) &&
- Y(r) <= y && y < MAX_Y(r))
+ if (X(r) <= qpr->root_x && qpr->root_x < MAX_X(r) &&
+ Y(r) <= qpr->root_y && qpr->root_y < MAX_Y(r))
break;
break;
+ free(qpr);
}
if (r == NULL)
}
if (r == NULL)
@@
-2462,9
+2479,8
@@
unfocus_win(struct ws_win *win)
;
grabbuttons(win, 0);
;
grabbuttons(win, 0);
- XSetWindowBorder(display, win->id,
- win->ws->r->s->c[SWM_S_COLOR_UNFOCUS].color);
-
+ xcb_change_window_attributes(conn, win->id, XCB_CW_BORDER_PIXEL,
+ &win->ws->r->s->c[SWM_S_COLOR_UNFOCUS].color);
xcb_change_property(conn, XCB_PROP_MODE_REPLACE, win->s->root,
ewmh[_NET_ACTIVE_WINDOW].atom, XCB_ATOM_WINDOW, 32, 1,
&none);
xcb_change_property(conn, XCB_PROP_MODE_REPLACE, win->s->root,
ewmh[_NET_ACTIVE_WINDOW].atom, XCB_ATOM_WINDOW, 32, 1,
&none);
@@
-2526,8
+2542,9
@@
focus_win(struct ws_win *win)
/* use larger hammer since the window was killed somehow */
TAILQ_FOREACH(cfw, &win->ws->winlist, entry)
if (cfw->ws && cfw->ws->r && cfw->ws->r->s)
/* use larger hammer since the window was killed somehow */
TAILQ_FOREACH(cfw, &win->ws->winlist, entry)
if (cfw->ws && cfw->ws->r && cfw->ws->r->s)
- XSetWindowBorder(display, cfw->id,
- cfw->ws->r->s->c[SWM_S_COLOR_UNFOCUS].color);
+ xcb_change_window_attributes(conn, cfw->id,
+ XCB_CW_BORDER_PIXEL,
+ &cfw->ws->r->s->c[SWM_S_COLOR_UNFOCUS].color);
}
win->ws->focus = win;
}
win->ws->focus = win;
@@
-2541,11
+2558,12
@@
focus_win(struct ws_win *win)
xcb_set_input_focus(conn, XCB_INPUT_FOCUS_PARENT,
win->id, XCB_CURRENT_TIME);
grabbuttons(win, 1);
xcb_set_input_focus(conn, XCB_INPUT_FOCUS_PARENT,
win->id, XCB_CURRENT_TIME);
grabbuttons(win, 1);
- XSetWindowBorder(display, win->id,
- win->ws->r->s->c[SWM_S_COLOR_FOCUS].color);
+ xcb_change_window_attributes(conn, win->id,
+ XCB_CW_BORDER_PIXEL,
+ &win->ws->r->s->c[SWM_S_COLOR_FOCUS].color);
if (win->ws->cur_layout->flags & SWM_L_MAPONFOCUS ||
win->ws->always_raise)
if (win->ws->cur_layout->flags & SWM_L_MAPONFOCUS ||
win->ws->always_raise)
- XMapRaised(display, win->id);
+ map_window_raised(win->id);
xcb_change_property(conn, XCB_PROP_MODE_REPLACE, win->s->root,
ewmh[_NET_ACTIVE_WINDOW].atom, XCB_ATOM_WINDOW, 32, 1,
xcb_change_property(conn, XCB_PROP_MODE_REPLACE, win->s->root,
ewmh[_NET_ACTIVE_WINDOW].atom, XCB_ATOM_WINDOW, 32, 1,
@@
-3376,7
+3394,7
@@
stack_master(struct workspace *ws, struct swm_geometry *g, int rot, int flip)
if (XGetWindowAttributes(display, win->id, &wa))
if (wa.map_state == IsUnmapped)
if (XGetWindowAttributes(display, win->id, &wa))
if (wa.map_state == IsUnmapped)
- XMapRaised(display, win->id);
+ map_window_raised(win->id);
last_h = win_g.h;
i++;
last_h = win_g.h;
i++;
@@
-3396,12
+3414,12
@@
notiles:
}
stack_floater(win, ws->r);
}
stack_floater(win, ws->r);
- XMapRaised(display, win->id);
+ map_window_raised(win->id);
}
if (fs_win) {
stack_floater(fs_win, ws->r);
}
if (fs_win) {
stack_floater(fs_win, ws->r);
- XMapRaised(display, fs_win->id);
+ map_window_raised(fs_win->id);
}
}
}
}
@@
-3563,7
+3581,7
@@
max_stack(struct workspace *ws, struct swm_geometry *g)
/* put the last transient on top */
if (wintrans) {
if (parent)
/* put the last transient on top */
if (wintrans) {
if (parent)
- XMapRaised(display, parent->id);
+ map_window_raised(parent->id);
stack_floater(wintrans, ws->r);
focus_magic(wintrans);
}
stack_floater(wintrans, ws->r);
focus_magic(wintrans);
}
@@
-3575,8
+3593,8
@@
send_to_ws(struct swm_region *r, union arg *args)
int wsid = args->id;
struct ws_win *win = NULL, *parent;
struct workspace *ws, *nws;
int wsid = args->id;
struct ws_win *win = NULL, *parent;
struct workspace *ws, *nws;
- Atom ws_idx_atom = 0;
- unsigned char ws_idx_str[SWM_PROPLEN];
+ xcb_atom_t ws_idx_atom = XCB_ATOM_NONE;
+ char ws_idx_str[SWM_PROPLEN];
union arg a;
if (wsid >= workspace_limit)
union arg a;
if (wsid >= workspace_limit)
@@
-3615,14
+3633,15
@@
send_to_ws(struct swm_region *r, union arg *args)
win->ws = nws;
/* Try to update the window's workspace property */
win->ws = nws;
/* Try to update the window's workspace property */
- ws_idx_atom = XInternAtom(display, "_SWM_WS", False);
+ ws_idx_atom = get_atom_from_string("_SWM_WS");
if (ws_idx_atom &&
if (ws_idx_atom &&
- snprintf((char *)ws_idx_str, SWM_PROPLEN, "%d", nws->idx) <
+ snprintf(ws_idx_str, SWM_PROPLEN, "%d", nws->idx) <
SWM_PROPLEN) {
DNPRINTF(SWM_D_PROP, "send_to_ws: set property: _SWM_WS: %s\n",
ws_idx_str);
SWM_PROPLEN) {
DNPRINTF(SWM_D_PROP, "send_to_ws: set property: _SWM_WS: %s\n",
ws_idx_str);
- XChangeProperty(display, win->id, ws_idx_atom, XA_STRING, 8,
- PropModeReplace, ws_idx_str, strlen((char *)ws_idx_str));
+ xcb_change_property(conn, XCB_PROP_MODE_REPLACE, win->id,
+ ws_idx_atom, XCB_ATOM_STRING, 8, strlen(ws_idx_str),
+ ws_idx_str);
}
stack();
}
stack();
@@
-3860,7
+3879,7
@@
search_win(struct swm_region *r, union arg *args)
TAILQ_INSERT_TAIL(&search_wl, sw, entry);
sw->gc = XCreateGC(display, w, 0, &gcv);
TAILQ_INSERT_TAIL(&search_wl, sw, entry);
sw->gc = XCreateGC(display, w, 0, &gcv);
- XMapRaised(display, w);
+ map_window_raised(w);
XSetForeground(display, sw->gc, r->s->c[SWM_S_COLOR_BAR].color);
DRAWSTRING(display, w, bar_fs, sw->gc, 2,
XSetForeground(display, sw->gc, r->s->c[SWM_S_COLOR_BAR].color);
DRAWSTRING(display, w, bar_fs, sw->gc, 2,
@@
-6490,7
+6509,7
@@
manage_window(xcb_window_t id)
/* floaters need to be mapped if they are in the current workspace */
if ((win->floating || win->transient) && (ws->idx == r->ws->idx))
/* floaters need to be mapped if they are in the current workspace */
if ((win->floating || win->transient) && (ws->idx == r->ws->idx))
- XMapRaised(display, win->id);
+ map_window_raised(win->id);
return (win);
}
return (win);
}
@@
-6525,6
+6544,7
@@
void
unmanage_window(struct ws_win *win)
{
struct ws_win *parent;
unmanage_window(struct ws_win *win)
{
struct ws_win *parent;
+ xcb_screen_t *screen;
if (win == NULL)
return;
if (win == NULL)
return;
@@
-6538,8
+6558,10
@@
unmanage_window(struct ws_win *win)
}
/* focus on root just in case */
}
/* focus on root just in case */
- XSetInputFocus(display, PointerRoot, PointerRoot, CurrentTime);
-
+ screen = xcb_setup_roots_iterator(xcb_get_setup(conn)).data;
+ xcb_set_input_focus(conn, XCB_INPUT_FOCUS_POINTER_ROOT,
+ screen->root, XCB_CURRENT_TIME);
+
focus_prev(win);
if (win->hints) {
focus_prev(win);
if (win->hints) {
@@
-6969,7
+6991,7
@@
propertynotify(XEvent *e)
if (ev->state == PropertyDelete && ev->atom == a_swm_iconic) {
update_iconic(win, 0);
if (ev->state == PropertyDelete && ev->atom == a_swm_iconic) {
update_iconic(win, 0);
- XMapRaised(display, win->id);
+ map_window_raised(win->id);
stack();
focus_win(win);
return;
stack();
focus_win(win);
return;