JasonWoof Got questions, comments, patches, etc.? Contact Jason Woofenden
One more of cur_focus fallout
[spectrwm.git] / scrotwm.c
index be09f03..a6aa81f 100644 (file)
--- a/scrotwm.c
+++ b/scrotwm.c
@@ -158,6 +158,7 @@ Atom                        astate;
 Atom                   aprot;
 Atom                   adelete;
 volatile sig_atomic_t   running = 1;
+int                    outputs = 0;
 int                    (*xerrorxlib)(Display *, XErrorEvent *);
 int                    other_wm;
 int                    ss_enabled = 0;
@@ -197,7 +198,7 @@ GC                  bar_gc;
 XGCValues              bar_gcv;
 int                    bar_fidx = 0;
 XFontStruct            *bar_fs;
-char                   *bar_fonts[] = { NULL, NULL, NULL };    /* XXX Make fully dynamic */
+char                   *bar_fonts[] = { NULL, NULL, NULL, NULL };/* XXX Make fully dynamic */
 char                   *spawn_term[] = { NULL, NULL };         /* XXX Make fully dynamic */
 
 #define SWM_MENU_FN    (2)
@@ -231,7 +232,6 @@ struct ws_win {
        TAILQ_ENTRY(ws_win)     entry;
        Window                  id;
        struct swm_geometry     g;
-       int                     got_focus;
        int                     floating;
        int                     transient;
        int                     manual;
@@ -1137,19 +1137,17 @@ unfocus_win(struct ws_win *win)
        if (win == NULL)
                return;
 
-       if (win->ws->focus != win && win->ws->focus != NULL)
-               win->ws->focus_prev = win->ws->focus;
-
        if (win->ws->r == NULL)
                return;
 
        grabbuttons(win, 0);
        XSetWindowBorder(display, win->id,
            win->ws->r->s->c[SWM_S_COLOR_UNFOCUS].color);
-       win->got_focus = 0;
 
-       if (win->ws->focus == win)
+       if (win->ws->focus == win) {
                win->ws->focus = NULL;
+               win->ws->focus_prev = win;
+       }
 }
 
 void
@@ -1164,37 +1162,28 @@ unfocus_all(void)
                for (j = 0; j < SWM_WS_MAX; j++)
                        TAILQ_FOREACH(win, &screens[i].ws[j].winlist, entry)
                                unfocus_win(win);
+       XSync(display, False);
 }
 
 void
 focus_win(struct ws_win *win)
 {
-       struct ws_win           *cur_focus;
        DNPRINTF(SWM_D_FOCUS, "focus_win: id: %lu\n", win ? win->id : 0);
 
        if (win == NULL)
                return;
 
-       cur_focus = win->ws->focus;
-       if (cur_focus)
-               unfocus_win(cur_focus);
-       if (win->ws->focus) {
-               /* probably shouldn't happen due to the previous unfocus_win */
-               DNPRINTF(SWM_D_FOCUS, "unfocusing win->ws->focus: %lu\n",
-                   win->ws->focus->id);
-               unfocus_win(win->ws->focus);
-       }
+       /* use big hammer to make sure it works under all use cases */
+       unfocus_all();
        win->ws->focus = win;
+
        if (win->ws->r != NULL) {
-               cur_focus = win;
-               if (win->got_focus == 0) {
-                       XSetWindowBorder(display, win->id,
-                           win->ws->r->s->c[SWM_S_COLOR_FOCUS].color);
-                       grabbuttons(win, 1);
-               }
-               win->got_focus = 1;
+               XSetWindowBorder(display, win->id,
+                   win->ws->r->s->c[SWM_S_COLOR_FOCUS].color);
+               grabbuttons(win, 1);
                XSetInputFocus(display, win->id,
                    RevertToPointerRoot, CurrentTime);
+               XSync(display, False);
        }
 }
 
@@ -1203,7 +1192,7 @@ switchws(struct swm_region *r, union arg *args)
 {
        int                     wsid = args->id;
        struct swm_region       *this_r, *other_r;
-       struct ws_win           *win, *winfocus;
+       struct ws_win           *win, *winfocus = NULL;
        struct workspace        *new_ws, *old_ws;
 
        this_r = r;
@@ -1217,8 +1206,16 @@ switchws(struct swm_region *r, union arg *args)
        if (new_ws == old_ws)
                return;
 
+       /* get focus window */
+       if (new_ws->focus)
+               winfocus = new_ws->focus;
+       else if (new_ws->focus_prev)
+               winfocus = new_ws->focus_prev;
+       else
+               winfocus = TAILQ_FIRST(&new_ws->winlist);
+
        other_r = new_ws->r;
-       if (!other_r) {
+       if (other_r == NULL) {
                /* if the other workspace is hidden, switch windows */
                /* map new window first to prevent ugly blinking */
                old_ws->r = NULL;
@@ -1236,15 +1233,8 @@ switchws(struct swm_region *r, union arg *args)
        this_r->ws = new_ws;
        new_ws->r = this_r;
 
-       /* get focus window */
-       if (new_ws->focus == NULL)
-               winfocus = TAILQ_FIRST(&new_ws->winlist);
-       else
-               winfocus = new_ws->focus;
-
        ignore_enter = 1;
        stack();
-       unfocus_all(); /* we need this after a M-q */
        focus_win(winfocus);
        bar_update();
 }
@@ -1429,14 +1419,19 @@ void
 cycle_layout(struct swm_region *r, union arg *args)
 {
        struct workspace        *ws = r->ws;
+       struct ws_win           *winfocus;
 
        DNPRINTF(SWM_D_EVENT, "cycle_layout: workspace: %d\n", ws->idx);
 
+       winfocus = ws->focus;
+
        ws->cur_layout++;
        if (ws->cur_layout->l_stack == NULL)
                ws->cur_layout = &layouts[0];
+
        ignore_enter = 1;
        stack();
+       focus_win(winfocus);
 }
 
 void
@@ -1817,7 +1812,6 @@ max_stack(struct workspace *ws, struct swm_geometry *g)
        XWindowChanges          wc;
        struct swm_geometry     gg = *g;
        struct ws_win           *win, *winfocus;
-       struct ws_win           *cur_focus;
        unsigned int            mask;
        int                     winno;
 
@@ -1831,8 +1825,7 @@ max_stack(struct workspace *ws, struct swm_geometry *g)
 
        if (ws->focus == NULL)
                ws->focus = TAILQ_FIRST(&ws->winlist);
-       cur_focus = ws->focus;
-       winfocus = cur_focus ? cur_focus : ws->focus;
+       winfocus = ws->focus;
 
        TAILQ_FOREACH(win, &ws->winlist, entry) {
                if (win->transient != 0 || win->floating != 0) {
@@ -1869,7 +1862,7 @@ void
 send_to_ws(struct swm_region *r, union arg *args)
 {
        int                     wsid = args->id;
-       struct ws_win           *win = r->ws->focus;
+       struct ws_win           *win = r->ws->focus, *winfocus = NULL;
        struct workspace        *ws, *nws;
        Atom                    ws_idx_atom = 0;
        unsigned char           ws_idx_str[SWM_PROPLEN];
@@ -1882,14 +1875,20 @@ send_to_ws(struct swm_region *r, union arg *args)
        ws = win->ws;
        nws = &win->s->ws[wsid];
 
-       XUnmapWindow(display, win->id);
-
        /* find a window to focus */
-       ws->focus = TAILQ_PREV(win, ws_win_list, entry);
-       if (ws->focus == NULL)
-               ws->focus = TAILQ_FIRST(&ws->winlist);
-       if (ws->focus == win)
-               ws->focus = NULL;
+       winfocus = TAILQ_PREV(win, ws_win_list, entry);
+       if (TAILQ_FIRST(&ws->winlist) == win)
+               winfocus = TAILQ_NEXT(win, entry);
+       else {
+               winfocus = TAILQ_PREV(ws->focus, ws_win_list, entry);
+               if (winfocus == NULL)
+                       winfocus = TAILQ_LAST(&ws->winlist, ws_win_list);
+       }
+       /* out of windows in ws so focus on nws instead */
+       if (winfocus == NULL)
+               winfocus = win;
+
+       XUnmapWindow(display, win->id);
 
        TAILQ_REMOVE(&ws->winlist, win, entry);
 
@@ -1912,6 +1911,7 @@ send_to_ws(struct swm_region *r, union arg *args)
        nws->restack = 1;
 
        stack();
+       focus_win(winfocus);
 }
 
 void
@@ -3200,7 +3200,7 @@ manage_window(Window id)
 {
        Window                  trans;
        struct workspace        *ws;
-       struct ws_win           *win;
+       struct ws_win           *win, *ww;
        int                     format, i, ws_idx, n;
        unsigned long           nitems, bytes;
        Atom                    ws_idx_atom = 0, type;
@@ -3253,8 +3253,17 @@ manage_window(Window id)
                            errstr, prop);
                }
                ws = &r->s->ws[ws_idx];
-       } else
+       } else {
                ws = r->ws;
+               /* this should launch transients in the same ws as parent */
+               /* XXX doesn't work for intel xrandr */
+               if (id && trans) {
+                       if ((ww = find_window(trans)) != NULL) {
+                               ws = ww->ws;
+                               r = ws->r;
+                       }
+               }
+       }
 
        /* set up the window layout */
        win->id = id;
@@ -3327,9 +3336,6 @@ manage_window(Window id)
        if (win->floating && (ws->idx == r->ws->idx))
                XMapRaised(display, win->id);
 
-       /* make new win focused */
-       focus_win(win);
-
        return (win);
 }
 
@@ -3344,20 +3350,6 @@ unmanage_window(struct ws_win *win)
        DNPRINTF(SWM_D_MISC, "unmanage_window:  %lu\n", win->id);
 
        ws = win->ws;
-
-       /* find a window to focus */
-       if (ws->focus == win)
-               ws->focus = TAILQ_PREV(win, ws_win_list, entry);
-       if (ws->focus == NULL)
-               ws->focus = TAILQ_FIRST(&ws->winlist);
-       if (ws->focus == NULL || ws->focus == win) {
-               ws->focus = NULL;
-               unfocus_win(win);
-       } else
-               focus_win(ws->focus);
-       if (ws->focus_prev == win)
-               ws->focus_prev = NULL;
-
        TAILQ_REMOVE(&win->ws->winlist, win, entry);
        set_win_state(win, WithdrawnState);
        if (win->ch.res_class)
@@ -3449,14 +3441,32 @@ configurenotify(XEvent *e)
 void
 destroynotify(XEvent *e)
 {
-       struct ws_win           *win;
+       struct ws_win           *win, *winfocus = NULL;
+       struct workspace        *ws;
+       struct ws_win_list      *wl;
+
        XDestroyWindowEvent     *ev = &e->xdestroywindow;
 
        DNPRINTF(SWM_D_EVENT, "destroynotify: window %lu\n", ev->window);
 
        if ((win = find_window(ev->window)) != NULL) {
+               /* find a window to focus */
+               ws = win->ws;
+               wl = &ws->winlist;
+               if (ws->focus == win) {
+                       if (TAILQ_FIRST(wl) == win)
+                               winfocus = TAILQ_NEXT(win, entry);
+                       else {
+                               winfocus = TAILQ_PREV(ws->focus, ws_win_list, entry);
+                               if (winfocus == NULL)
+                                       winfocus = TAILQ_LAST(wl, ws_win_list);
+                       }
+               }
+
                unmanage_window(win);
                stack();
+               if (winfocus)
+                       focus_win(winfocus);
        }
 }
 
@@ -3473,6 +3483,12 @@ enternotify(XEvent *e)
                ignore_enter--;
                return;
        }
+       /*
+        * happens when a window is created or destroyed and the border
+        * crosses the mouse pointer
+        */
+       if (QLength(display))
+               return;
 
        if ((win = find_window(ev->window)) != NULL)
                focus_win(win);
@@ -3487,28 +3503,7 @@ focusin(XEvent *e)
 void
 focusout(XEvent *e)
 {
-       struct swm_screen       *s;
-       struct ws_win           *win, *cur_focus;
-       Window                  rr, cr;
-       int                     x, y, wx, wy;
-       unsigned int            mask;
-
        DNPRINTF(SWM_D_EVENT, "focusout: window: %lu\n", e->xfocus.window);
-
-       win = find_window(e->xany.window);
-       if (win)
-               cur_focus = win->ws->focus;
-
-       if (cur_focus && cur_focus->ws->r &&
-           cur_focus->id == e->xfocus.window) {
-               s = cur_focus->ws->r->s;
-               if (XQueryPointer(display, cur_focus->id,
-                   &rr, &cr, &x, &y, &wx, &wy, &mask) != False &&
-                   cr == 0 && !mask &&
-                   x == DisplayWidth(display, s->idx) / 2 &&
-                   y == DisplayHeight(display, s->idx) / 2)
-                       unfocus_win(cur_focus);
-       }
 }
 
 void
@@ -3526,6 +3521,9 @@ mappingnotify(XEvent *e)
 void
 maprequest(XEvent *e)
 {
+       struct ws_win           *win;
+       struct swm_region       *r;
+
        XMapRequestEvent        *ev = &e->xmaprequest;
        XWindowAttributes       wa;
 
@@ -3536,9 +3534,16 @@ maprequest(XEvent *e)
                return;
        if (wa.override_redirect)
                return;
+
        manage_window(e->xmaprequest.window);
 
        stack();
+
+       /* make new win focused */
+       win = find_window(ev->window);
+       r = root_to_region(win->wa.root);
+       if (win->ws == r->ws) /* XXX this probably breaks multi screen */
+               focus_win(win);
 }
 
 void
@@ -3742,6 +3747,7 @@ scan_xrandr(int i)
 
        /* map virtual screens onto physical screens */
 #ifdef SWM_XRR_HAS_CRTC
+       outputs = 0;
        if (xrandr_support) {
                sr = XRRGetScreenResources(display, screens[i].root);
                if (sr == NULL)
@@ -3755,6 +3761,7 @@ scan_xrandr(int i)
                        ci = XRRGetCrtcInfo(display, sr, sr->crtcs[c]);
                        if (ci->noutput == 0)
                                continue;
+                       outputs++;
 
                        if (ci != NULL && ci->mode == None)
                                new_region(&screens[i], 0, 0,
@@ -3913,6 +3920,9 @@ setup_globals(void)
        if ((bar_fonts[1] = strdup("-*-times-medium-r-*-*-*-*-*-*-*-*-*-*"))
            == NULL)
                err(1, "setup_globals: strdup");
+       if ((bar_fonts[2] = strdup("-misc-fixed-medium-r-*-*-*-*-*-*-*-*-*-*"))
+           == NULL)
+               err(1, "setup_globals: strdup");
        if ((spawn_term[0] = strdup("xterm")) == NULL)
                err(1, "setup_globals: strdup");
 }
@@ -3941,8 +3951,8 @@ int
 main(int argc, char *argv[])
 {
        struct passwd           *pwd;
-       struct swm_region       *r;
-       struct swm_win          *winfocus = NULL;
+       struct swm_region       *r, *rr;
+       struct ws_win           *winfocus = NULL;
        char                    conf[PATH_MAX], *cfile = NULL;
        struct stat             sb;
        XEvent                  e;
@@ -4015,6 +4025,8 @@ main(int argc, char *argv[])
        while (running) {
                while (XPending(display)) {
                        XNextEvent(display, &e);
+                       if (running == 0)
+                               goto done;
                        if (e.type < LASTEvent) {
                                dumpevent(&e);
                                if (handler[e.type])
@@ -4039,6 +4051,13 @@ main(int argc, char *argv[])
 
                /* if we are being restarted go focus on first window */
                if (winfocus) {
+                       rr = TAILQ_FIRST(&screens[0].rl);
+                       /* move pointer to first screen if multi screen */
+                       if (ScreenCount(display) > 1 || outputs > 1)
+                               XWarpPointer(display, None, rr->s[0].root,
+                                   0, 0, 0, 0, rr->g.x,
+                                   rr->g.y + bar_enabled ? bar_height : 0);
+
                        focus_win(winfocus);
                        winfocus = NULL;
                        continue;
@@ -4048,13 +4067,15 @@ main(int argc, char *argv[])
                FD_SET(xfd, &rd);
                if (select(xfd + 1, &rd, NULL, NULL, NULL) == -1)
                        if (errno != EINTR)
-                               errx(1, "select failed");
+                               DNPRINTF(SWM_D_MISC, "select failed");
+               if (running == 0)
+                       goto done;
                if (bar_alarm) {
                        bar_alarm = 0;
                        bar_update();
                }
        }
-
+done:
        bar_extra_stop();
 
        XCloseDisplay(display);