JasonWoof Got questions, comments, patches, etc.? Contact Jason Woofenden
Oops forgot to commit this
[spectrwm.git] / scrotwm.c
index 3f1566a..c14e854 100644 (file)
--- a/scrotwm.c
+++ b/scrotwm.c
@@ -52,7 +52,7 @@
 
 static const char      *cvstag = "$scrotwm$";
 
-#define        SWM_VERSION     "1.0"
+#define        SWM_VERSION     "0.9.14"
 
 #include <stdio.h>
 #include <stdlib.h>
@@ -304,6 +304,7 @@ enum keyfuncid {
        kf_screenshot_wind,
        kf_float_toggle,
        kf_version,
+       kf_dumpwins,
        kf_spawn_lock,
        kf_spawn_initscr,
        kf_spawn_custom,
@@ -321,6 +322,7 @@ void        max_stack(struct workspace *, struct swm_geometry *);
 void   grabbuttons(struct ws_win *, int);
 void   new_region(struct swm_screen *, int, int, int, int);
 void   unmanage_window(struct ws_win *);
+long   getstate(Window);
 
 struct layout {
        void            (*l_stack)(struct workspace *, struct swm_geometry *);
@@ -344,13 +346,13 @@ struct layout {
 /* define work spaces */
 struct workspace {
        int                     idx;            /* workspace index */
-       int                     restack;        /* restack on switch */
        struct layout           *cur_layout;    /* current layout handlers */
        struct ws_win           *focus;         /* may be NULL */
        struct ws_win           *focus_prev;    /* may be NULL */
        struct swm_region       *r;             /* may be NULL */
        struct swm_region       *old_r;         /* may be NULL */
        struct ws_win_list      winlist;        /* list of windows in ws */
+       struct ws_win_list      unmanagedlist;  /* list of dead windows in ws */
 
        /* stacker state */
        struct {
@@ -546,8 +548,48 @@ dumpevent(XEvent *e)
                    "remaining\n",
                    e->xany.window, e->type, QLength(display));
 }
+
+void
+dumpwins(struct swm_region *r, union arg *args)
+{
+       struct ws_win           *win;
+       unsigned int            state;
+       XWindowAttributes       wa;
+
+       if (r->ws == NULL) {
+               fprintf(stderr, "invalid workspace\n");
+               return;
+       }
+
+       fprintf(stderr, "=== managed window list ws %02d ===\n", r->ws->idx);
+
+       TAILQ_FOREACH(win, &r->ws->winlist, entry) {
+               state = getstate(win->id);
+               if (!XGetWindowAttributes(display, win->id, &wa))
+                       fprintf(stderr, "window: %lu failed "
+                           "XGetWindowAttributes\n", win->id);
+               fprintf(stderr, "window: %lu map_state: %d state: %d\n",
+                   win->id, wa.map_state, state);
+       }
+
+       fprintf(stderr, "===== unmanaged window list =====\n");
+       TAILQ_FOREACH(win, &r->ws->unmanagedlist, entry) {
+               state = getstate(win->id);
+               if (!XGetWindowAttributes(display, win->id, &wa))
+                       fprintf(stderr, "window: %lu failed "
+                           "XGetWindowAttributes\n", win->id);
+               fprintf(stderr, "window: %lu map_state: %d state: %d\n",
+                   win->id, wa.map_state, state);
+       }
+
+       fprintf(stderr, "=================================\n");
+}
 #else
 #define dumpevent(e)
+void
+dumpwins(struct swm_region *r, union arg *args)
+{
+}
 #endif /* SWM_DEBUG */
 
 void                   expose(XEvent *);
@@ -821,7 +863,7 @@ void
 bar_toggle(struct swm_region *r, union arg *args)
 {
        struct swm_region       *tmpr;
-       int                     i, j, sc = ScreenCount(display);
+       int                     i, sc = ScreenCount(display);
 
        DNPRINTF(SWM_D_MISC, "bar_toggle\n");
 
@@ -835,9 +877,6 @@ bar_toggle(struct swm_region *r, union arg *args)
                                XMapRaised(display, tmpr->bar_window);
 
        bar_enabled = !bar_enabled;
-       for (i = 0; i < sc; i++)
-               for (j = 0; j < SWM_WS_MAX; j++)
-                       screens[i].ws[j].restack = 1;
 
        stack();
        /* must be after stack */
@@ -925,40 +964,18 @@ bar_setup(struct swm_region *r)
        bar_refresh();
 }
 
-Bool
-set_win_notify_cb(Display *d, XEvent *e, char *arg)
-{
-       struct ws_win           *win = (struct ws_win *)arg;
-
-       if (win && win->id == e->xany.window && e->xany.type == PropertyNotify)
-                       return (True);
-       return (False);
-}
-
 void
 set_win_state(struct ws_win *win, long state)
 {
        long                    data[] = {state, None};
-       XEvent                  ev;
-       XWindowAttributes       wa;
 
        DNPRINTF(SWM_D_EVENT, "set_win_state: window: %lu\n", win->id);
 
        if (win == NULL)
                return;
-       /* make sure we drain everything */
-       XSync(display, True);
-
-       /* make sure we still exist too */
-       if (XGetWindowAttributes(display, win->id, &wa) == BadWindow)
-               return;
 
        XChangeProperty(display, win->id, astate, astate, 32, PropModeReplace,
            (unsigned char *)data, 2);
-
-       /* wait for completion of XChangeProperty */
-       while (XCheckIfEvent(display, &ev, set_win_notify_cb, (char *)win))
-               ;
 }
 
 long
@@ -997,6 +1014,9 @@ client_msg(struct ws_win *win, Atom a)
 {
        XClientMessageEvent     cm;
 
+       if (win == NULL)
+               return;
+
        bzero(&cm, sizeof cm);
        cm.type = ClientMessage;
        cm.window = win->id;
@@ -1008,12 +1028,38 @@ client_msg(struct ws_win *win, Atom a)
 }
 
 void
+configreq_win(struct ws_win *win)
+{
+       XConfigureRequestEvent  cr;
+
+       if (win == NULL)
+               return;
+
+       bzero(&cr, sizeof cr);
+       cr.type = ConfigureRequest;
+       cr.display = display;
+       cr.parent = win->id;
+       cr.window = win->id;
+       cr.x = win->g.x;
+       cr.y = win->g.y;
+       cr.width = win->g.w;
+       cr.height = win->g.h;
+       cr.border_width = 1;
+
+       XSendEvent(display, win->id, False, StructureNotifyMask, (XEvent *)&cr);
+}
+
+void
 config_win(struct ws_win *win)
 {
        XConfigureEvent         ce;
 
        DNPRINTF(SWM_D_MISC, "config_win: win %lu x %d y %d w %d h %d\n",
            win->id, win->g.x, win->g.y, win->g.w, win->g.h);
+
+       if (win == NULL)
+               return;
+
        ce.type = ConfigureNotify;
        ce.display = display;
        ce.event = win->id;
@@ -1033,21 +1079,6 @@ count_win(struct workspace *ws, int count_transient)
 {
        struct ws_win           *win;
        int                     count = 0;
-       int                     state;
-
-       /*
-        * Under stress conditions windows sometimes do not get removed from
-        * the managed list quickly enough.  Use a very large hammer to get rid
-        * of them.  A smaller hammer would be nice.
-        */
-       TAILQ_FOREACH(win, &ws->winlist, entry) {
-               state = getstate(win->id);
-               if (state == -1) {
-                       DNPRINTF(SWM_D_MISC, "count_win:removing: %lu\n",
-                           win->id);
-                       unmanage_window(win);
-               }
-       }
 
        TAILQ_FOREACH(win, &ws->winlist, entry) {
                if (count_transient == 0 && win->floating)
@@ -1068,42 +1099,19 @@ quit(struct swm_region *r, union arg *args)
        running = 0;
 }
 
-Bool
-unmap_window_cb(Display *d, XEvent *e, char *arg)
-{
-       struct ws_win           *win = (struct ws_win *)arg;
-
-       if (win && win->id == e->xany.window && e->xany.type == UnmapNotify)
-                       return (True);
-       return (False);
-}
-
 void
 unmap_window(struct ws_win *win)
 {
-       XEvent                  ev;
-       XWindowAttributes       wa;
-
        if (win == NULL)
                return;
 
-       /* make sure we still exist too */
-       if (XGetWindowAttributes(display, win->id, &wa) == BadWindow)
-               return;
-
        /* don't unmap again */
-       if (wa.map_state == IsUnmapped && getstate(win->id) == IconicState)
+       if (getstate(win->id) == IconicState)
                return;
 
-       /* java shits itself when windows are set to iconic state */
-       if (win->java == 0)
-               set_win_state(win, IconicState);
+       set_win_state(win, IconicState);
 
        XUnmapWindow(display, win->id);
-
-       /* make sure we wait for XUnmapWindow completion */
-       while (XCheckIfEvent(display, &ev, unmap_window_cb, (char *)win))
-               ;
 }
 
 void
@@ -1123,6 +1131,9 @@ fake_keypress(struct ws_win *win, int keysym, int modifiers)
 {
        XKeyEvent event;
 
+       if (win == NULL)
+               return;
+
        event.display = display;        /* Ignored, but what the hell */
        event.window = win->id;
        event.root = win->s->root;
@@ -1194,6 +1205,21 @@ root_to_region(Window root)
 }
 
 struct ws_win *
+find_unmanaged_window(Window id)
+{
+       struct ws_win           *win;
+       int                     i, j;
+
+       for (i = 0; i < ScreenCount(display); i++)
+               for (j = 0; j < SWM_WS_MAX; j++)
+                       TAILQ_FOREACH(win, &screens[i].ws[j].unmanagedlist,
+                           entry)
+                               if (id == win->id)
+                                       return (win);
+       return (NULL);
+}
+
+struct ws_win *
 find_window(Window id)
 {
        struct ws_win           *win;
@@ -1261,7 +1287,8 @@ unfocus_win(struct ws_win *win)
 {
        if (win == NULL)
                return;
-
+       if (win->ws == NULL)
+               return;
        if (win->ws->r == NULL)
                return;
 
@@ -1296,17 +1323,19 @@ focus_win(struct ws_win *win)
 
        if (win == NULL)
                return;
+       if (win->ws == NULL)
+               return;
 
        /* use big hammer to make sure it works under all use cases */
        unfocus_all();
        win->ws->focus = win;
 
        if (win->ws->r != NULL) {
-               XSetWindowBorder(display, win->id,
-                   win->ws->r->s->c[SWM_S_COLOR_FOCUS].color);
                grabbuttons(win, 1);
                if (win->ws->cur_layout->flags & SWM_L_MAPONFOCUS)
                        XMapRaised(display, win->id);
+               XSetWindowBorder(display, win->id,
+                   win->ws->r->s->c[SWM_S_COLOR_FOCUS].color);
                if (win->java == 0)
                        XSetInputFocus(display, win->id,
                            RevertToPointerRoot, CurrentTime);
@@ -1321,6 +1350,9 @@ switchws(struct swm_region *r, union arg *args)
        struct ws_win           *win, *winfocus = NULL, *parent = NULL;
        struct workspace        *new_ws, *old_ws;
 
+       if (!(r && r->s))
+               return;
+
        this_r = r;
        old_ws = this_r->ws;
        new_ws = &this_r->s->ws[wsid];
@@ -1329,6 +1361,8 @@ switchws(struct swm_region *r, union arg *args)
            "%d -> %d\n", r->s->idx, WIDTH(r), HEIGHT(r), X(r), Y(r),
            old_ws->idx, wsid);
 
+       if (new_ws == NULL || old_ws == NULL)
+               return;
        if (new_ws == old_ws)
                return;
 
@@ -1346,17 +1380,6 @@ switchws(struct swm_region *r, union arg *args)
                if (old_ws->r != NULL)
                        old_ws->old_r = old_ws->r;
                old_ws->r = NULL;
-               old_ws->restack = 1;
-
-               /*
-                * Map new windows first if they were here before
-                * to minimize ugly blinking.
-                */
-               if (new_ws->old_r == this_r)
-                       TAILQ_FOREACH(win, &new_ws->winlist, entry)
-                               if (!(win->ws->cur_layout->flags &
-                                   SWM_L_MAPONFOCUS))
-                                       XMapRaised(display, win->id);
 
                TAILQ_FOREACH(win, &old_ws->winlist, entry)
                        unmap_window(win);
@@ -1518,6 +1541,8 @@ swapwin(struct swm_region *r, union arg *args)
                        else
                                return;
                 }
+               if (target == NULL || source == NULL)
+                       return;
                source->ws->focus_prev = target;
                TAILQ_REMOVE(wl, target, entry);
                TAILQ_INSERT_BEFORE(source, target, entry);
@@ -1645,8 +1670,6 @@ stack(void) {
                                g.y += bar_height;
                                g.h -= bar_height;
                        }
-
-                       r->ws->restack = 0;
                        r->ws->cur_layout->l_stack(r->ws, &g);
                }
        }
@@ -1738,7 +1761,7 @@ stack_master(struct workspace *ws, struct swm_geometry *g, int rot, int flip)
        int                     w_inc = 1, h_inc, w_base = 1, h_base;
        int                     hrh, extra = 0, h_slice, last_h = 0;
        int                     split, colno, winno, mwin, msize, mscale;
-       int                     remain, missing, v_slice;
+       int                     remain, missing, v_slice, reconfigure;
        unsigned int            mask;
 
        DNPRINTF(SWM_D_STACK, "stack_master: workspace: %d\n rot=%s flip=%s",
@@ -1859,20 +1882,32 @@ stack_master(struct workspace *ws, struct swm_geometry *g, int rot, int flip)
 
                bzero(&wc, sizeof wc);
                wc.border_width = 1;
+               reconfigure = 0;
                if (rot) {
-                       win->g.x = wc.x = win_g.y;
-                       win->g.y = wc.y = win_g.x;
-                       win->g.w = wc.width = win_g.h;
-                       win->g.h = wc.height = win_g.w;
+                       if (win->g.x != win_g.y || win->g.y != win_g.x ||
+                           win->g.w != win_g.h || win->g.h != win_g.w) {
+                               reconfigure = 1;
+                               win->g.x = wc.x = win_g.y;
+                               win->g.y = wc.y = win_g.x;
+                               win->g.w = wc.width = win_g.h;
+                               win->g.h = wc.height = win_g.w;
+                       }
                } else {
-                       win->g.x = wc.x = win_g.x;
-                       win->g.y = wc.y = win_g.y;
-                       win->g.w = wc.width = win_g.w;
-                       win->g.h = wc.height = win_g.h;
+                       if (win->g.x != win_g.x || win->g.y != win_g.y ||
+                           win->g.w != win_g.w || win->g.h != win_g.h) {
+                               reconfigure = 1;
+                               win->g.x = wc.x = win_g.x;
+                               win->g.y = wc.y = win_g.y;
+                               win->g.w = wc.width = win_g.w;
+                               win->g.h = wc.height = win_g.h;
+                       }
+               }
+               if (reconfigure) {
+                       adjust_font(win);
+                       mask = CWX | CWY | CWWidth | CWHeight | CWBorderWidth;
+                       XConfigureWindow(display, win->id, mask, &wc);
+                       configreq_win(win);
                }
-               adjust_font(win);
-               mask = CWX | CWY | CWWidth | CWHeight | CWBorderWidth;
-               XConfigureWindow(display, win->id, mask, &wc);
                XMapRaised(display, win->id);
 
                last_h = win_g.h;
@@ -2005,9 +2040,14 @@ max_stack(struct workspace *ws, struct swm_geometry *g)
                return;
 
        TAILQ_FOREACH(win, &ws->winlist, entry) {
-               if (win->transient != 0) {
+               if (win->transient) {
                        wintrans = win;
-               } else {
+                       continue;
+               }
+
+               /* only reconfigure if necessary */
+               if (win->g.x != gg.x || win->g.y != gg.y || win->g.w != gg.w ||
+                   win->g.h != gg.h) {
                        bzero(&wc, sizeof wc);
                        wc.border_width = 1;
                        win->g.x = wc.x = gg.x;
@@ -2016,12 +2056,12 @@ max_stack(struct workspace *ws, struct swm_geometry *g)
                        win->g.h = wc.height = gg.h;
                        mask = CWX | CWY | CWWidth | CWHeight | CWBorderWidth;
                        XConfigureWindow(display, win->id, mask, &wc);
-
-                       /* unmap only if we don't have multi screen */
-                       if (win != ws->focus)
-                               if (!(ScreenCount(display) > 1 || outputs > 1))
-                                       unmap_window(win);
+                       configreq_win(win);
                }
+               /* unmap only if we don't have multi screen */
+               if (win != ws->focus)
+                       if (!(ScreenCount(display) > 1 || outputs > 1))
+                               unmap_window(win);
        }
 
        /* put the last transient on top */
@@ -2083,8 +2123,6 @@ send_to_ws(struct swm_region *r, union arg *args)
 
        if (count_win(nws, 1) == 1)
                nws->focus = win;
-       ws->restack = 1;
-       nws->restack = 1;
 
        stack();
        if (winfocus)
@@ -2344,6 +2382,7 @@ struct keyfunc {
        { "spawn_lock",         legacyfunc,     {0} },
        { "spawn_initscr",      legacyfunc,     {0} },
        { "spawn_custom",       dummykeyfunc,   {0} },
+       { "dumpwins",           dumpwins,       {0} },
        { "invalid key func",   NULL,           {0} },
 };
 struct key {
@@ -2866,6 +2905,9 @@ setup_keys(void)
        setkeybinding(MODKEY|ShiftMask, XK_v,           kf_version,     NULL);
        setkeybinding(MODKEY|ShiftMask, XK_Delete,      kf_spawn_custom,        "lock");
        setkeybinding(MODKEY|ShiftMask, XK_i,           kf_spawn_custom,        "initscr");
+#ifdef SWM_DEBUG
+       setkeybinding(MODKEY|ShiftMask, XK_d,           kf_dumpwins,    NULL);
+#endif
 }
 
 void
@@ -3340,7 +3382,16 @@ manage_window(Window id)
        XWindowChanges          wc;
 
        if ((win = find_window(id)) != NULL)
-                       return (win);   /* already being managed */
+               return (win);   /* already being managed */
+
+       /* see if we are on the unmanaged list */
+       if ((win = find_unmanaged_window(id)) != NULL) {
+               DNPRINTF(SWM_D_MISC, "manage previously unmanaged window "
+                   "%lu\n", win->id);
+               TAILQ_REMOVE(&win->ws->unmanagedlist, win, entry);
+               TAILQ_INSERT_TAIL(&win->ws->winlist, win, entry);
+               return (win);
+       }
 
        if ((win = calloc(1, sizeof(struct ws_win))) == NULL)
                errx(1, "calloc: failed to allocate memory for new window");
@@ -3444,8 +3495,6 @@ manage_window(Window id)
                }
        }
 
-       if (win->java && win->transient) {
-       }
        /* alter window position if quirky */
        if (win->quirks & SWM_Q_ANYWHERE) {
                win->manual = 1; /* don't center the quirky windows */
@@ -3476,6 +3525,7 @@ manage_window(Window id)
                wc.border_width = 1;
                mask = CWBorderWidth;
                XConfigureWindow(display, win->id, mask, &wc);
+               configreq_win(win);
        }
 
        XSelectInput(display, id, EnterWindowMask | FocusChangeMask |
@@ -3491,9 +3541,28 @@ manage_window(Window id)
 }
 
 void
+free_window(struct ws_win *win)
+{
+       DNPRINTF(SWM_D_MISC, "free_window:  %lu\n", win->id);
+
+       if (win == NULL)
+               return;
+
+       /* needed for restart wm */
+       set_win_state(win, WithdrawnState);
+
+       TAILQ_REMOVE(&win->ws->unmanagedlist, win, entry);
+
+       if (win->ch.res_class)
+               XFree(win->ch.res_class);
+       if (win->ch.res_name)
+               XFree(win->ch.res_name);
+       free(win);
+}
+
+void
 unmanage_window(struct ws_win *win)
 {
-       struct workspace        *ws;
        struct ws_win           *parent;
 
        if (win == NULL)
@@ -3507,13 +3576,8 @@ unmanage_window(struct ws_win *win)
                        parent->child_trans = NULL;
        }
 
-       ws = win->ws;
        TAILQ_REMOVE(&win->ws->winlist, win, entry);
-       if (win->ch.res_class)
-               XFree(win->ch.res_class);
-       if (win->ch.res_name)
-               XFree(win->ch.res_name);
-       free(win);
+       TAILQ_INSERT_TAIL(&win->ws->unmanagedlist, win, entry);
 }
 
 void
@@ -3538,6 +3602,15 @@ focus_magic(struct ws_win *win)
        }
 }
 
+Bool
+destroy_notify_cb(Display *d, XEvent *e, char *arg)
+{
+       struct ws_win           *win = (struct ws_win *)arg;
+       if (win && win->id == e->xany.window && e->xany.type == DestroyNotify)
+                       return (True);
+       return (False);
+}
+
 void
 expose(XEvent *e)
 {
@@ -3645,11 +3718,11 @@ configurerequest(XEvent *e)
                                        ev->value_mask |= CWY | CWHeight;
                                }
                        }
+                       XMoveResizeWindow(display, win->id,
+                           win->g.x, win->g.y, win->g.w, win->g.h);
                        if ((ev->value_mask & (CWX | CWY)) &&
                            !(ev->value_mask & (CWWidth | CWHeight)))
                                config_win(win);
-                       XMoveResizeWindow(display, win->id,
-                           win->g.x, win->g.y, win->g.w, win->g.h);
                } else
                        config_win(win);
        }
@@ -3664,12 +3737,10 @@ configurenotify(XEvent *e)
        DNPRINTF(SWM_D_EVENT, "configurenotify: window: %lu\n",
            e->xconfigure.window);
 
-       XMapWindow(display, e->xconfigure.window);
        win = find_window(e->xconfigure.window);
        if (win) {
                XGetWMNormalHints(display, win->id, &win->sh, &mask);
                adjust_font(win);
-               XMapWindow(display, win->id);
                if (font_adjusted)
                        stack();
        }
@@ -3678,51 +3749,67 @@ configurenotify(XEvent *e)
 void
 destroynotify(XEvent *e)
 {
-       struct ws_win           *win, *winfocus = NULL;
+       struct ws_win           *win, *w, *wn, *winfocus = NULL;
        struct workspace        *ws;
        struct ws_win_list      *wl;
        XDestroyWindowEvent     *ev = &e->xdestroywindow;
+       int                     unmanaged = 0;
 
        DNPRINTF(SWM_D_EVENT, "destroynotify: window %lu\n", ev->window);
 
-       if ((win = find_window(ev->window)) != NULL) {
-               /* find a window to focus */
-               ws = win->ws;
-               wl = &ws->winlist;
-
-               /* if we are transient give focus to parent */
-               if (win->transient)
-                       winfocus = find_window(win->transient);
-               else if (ws->focus == win) {
-                       /* if in max_stack try harder */
-                       if (ws->cur_layout->flags & SWM_L_FOCUSPREV) {
-                               if (win != ws->focus_prev)
-                                       winfocus = ws->focus_prev;
-                               else if (win != ws->focus)
-                                       winfocus = ws->focus;
-                       }
+       if ((win = find_window(ev->window)) == NULL) {
+               if ((win = find_unmanaged_window(ev->window)) == NULL)
+                       return;
+               unmanaged = 1;
+       }
 
-                       /* fallback and normal handling */
-                       if (winfocus == NULL) {
-                               if (TAILQ_FIRST(wl) == win)
-                                       winfocus = TAILQ_NEXT(win, entry);
-                               else {
-                                       winfocus = TAILQ_PREV(ws->focus,
-                                           ws_win_list, entry);
-                                       if (winfocus == NULL)
-                                               winfocus = TAILQ_LAST(wl,
-                                                   ws_win_list);
-                               }
+       /* find a window to focus */
+       ws = win->ws;
+       wl = &ws->winlist;
+
+       for (w = TAILQ_FIRST(&ws->winlist); w != TAILQ_END(&ws->winlist); w = wn) {
+               wn = TAILQ_NEXT(w, entry);
+               if (win == w)
+                       continue; /* can't happen but oh well */
+
+               if (getstate(w->id) != -1)
+                       continue;
+               unmanage_window(w);
+       }
+       /* if we are transient give focus to parent */
+       if (win->transient)
+               winfocus = find_window(win->transient);
+       else if (ws->focus == win) {
+               /* if in max_stack try harder */
+               if (ws->cur_layout->flags & SWM_L_FOCUSPREV) {
+                       if (win != ws->focus_prev)
+                               winfocus = ws->focus_prev;
+                       else if (win != ws->focus)
+                               winfocus = ws->focus;
+               }
+
+               /* fallback and normal handling */
+               if (winfocus == NULL) {
+                       if (TAILQ_FIRST(wl) == win)
+                               winfocus = TAILQ_NEXT(win, entry);
+                       else {
+                               winfocus = TAILQ_PREV(ws->focus,
+                                   ws_win_list, entry);
+                               if (winfocus == NULL)
+                                       winfocus = TAILQ_LAST(wl,
+                                           ws_win_list);
                        }
                }
+       }
+       if (unmanaged == 0)
                unmanage_window(win);
+       free_window(win);
 
-               ignore_enter = 1;
-               stack();
-               if (winfocus)
-                       focus_win(winfocus);
-               ignore_enter = 0;
-       }
+       ignore_enter = 1;
+       stack();
+       if (winfocus)
+               focus_win(winfocus);
+       ignore_enter = 0;
 }
 
 void
@@ -3771,7 +3858,7 @@ mapnotify(XEvent *e)
 
        DNPRINTF(SWM_D_EVENT, "mapnotify: window: %lu\n", ev->window);
 
-       win = find_window(ev->window);
+       win = manage_window(ev->window);
        if (win)
                set_win_state(win, NormalState);
 }
@@ -4158,11 +4245,11 @@ setup_screens(void)
                for (j = 0; j < SWM_WS_MAX; j++) {
                        ws = &screens[i].ws[j];
                        ws->idx = j;
-                       ws->restack = 1;
                        ws->focus = NULL;
                        ws->r = NULL;
                        ws->old_r = NULL;
                        TAILQ_INIT(&ws->winlist);
+                       TAILQ_INIT(&ws->unmanagedlist);
 
                        for (k = 0; layouts[k].l_stack != NULL; k++)
                                if (layouts[k].l_config != NULL)
@@ -4183,24 +4270,24 @@ setup_screens(void)
                /* attach windows to a region */
                /* normal windows */
                for (j = 0; j < no; j++) {
-                        XGetWindowAttributes(display, wins[j], &wa);
                        if (!XGetWindowAttributes(display, wins[j], &wa) ||
                            wa.override_redirect ||
                            XGetTransientForHint(display, wins[j], &d1))
                                continue;
 
                        state = getstate(wins[j]);
-                       manage = state == NormalState || state == IconicState;
+                       manage = state == IconicState;
                        if (wa.map_state == IsViewable || manage)
                                manage_window(wins[j]);
                }
                /* transient windows */
                for (j = 0; j < no; j++) {
-                       if (!XGetWindowAttributes(display, wins[j], &wa))
+                       if (!XGetWindowAttributes(display, wins[j], &wa) ||
+                           wa.override_redirect)
                                continue;
 
                        state = getstate(wins[j]);
-                       manage = state == NormalState || state == IconicState;
+                       manage = state == IconicState;
                        if (XGetTransientForHint(display, wins[j], &d1) &&
                            manage)
                                manage_window(wins[j]);
@@ -4254,6 +4341,7 @@ main(int argc, char *argv[])
        struct passwd           *pwd;
        struct swm_region       *r, *rr;
        struct ws_win           *winfocus = NULL;
+       struct timeval          tv;
        char                    conf[PATH_MAX], *cfile = NULL;
        struct stat             sb;
        XEvent                  e;
@@ -4367,7 +4455,9 @@ main(int argc, char *argv[])
 
                FD_ZERO(&rd);
                FD_SET(xfd, &rd);
-               if (select(xfd + 1, &rd, NULL, NULL, NULL) == -1)
+               tv.tv_sec = 1;
+               tv.tv_usec = 0;
+               if (select(xfd + 1, &rd, NULL, NULL, &tv) == -1)
                        if (errno != EINTR)
                                DNPRINTF(SWM_D_MISC, "select failed");
                if (running == 0)