JasonWoof Got questions, comments, patches, etc.? Contact Jason Woofenden
Add color_focus_maximized and color_unfocus_maximized config options.
[spectrwm.git] / spectrwm.c
index 43eaea9..62afbb0 100644 (file)
@@ -572,7 +572,9 @@ enum {
        SWM_S_COLOR_BAR_BORDER_UNFOCUS,
        SWM_S_COLOR_BAR_FONT,
        SWM_S_COLOR_FOCUS,
+       SWM_S_COLOR_FOCUS_MAXIMIZED,
        SWM_S_COLOR_UNFOCUS,
+       SWM_S_COLOR_UNFOCUS_MAXIMIZED,
        SWM_S_COLOR_MAX
 };
 
@@ -592,6 +594,7 @@ struct swm_screen {
        struct {
                uint32_t        pixel;
                char            *name;
+               int             manual;
        } c[SWM_S_COLOR_MAX];
 
        xcb_gcontext_t          bar_gc;
@@ -641,6 +644,8 @@ union arg {
 #define SWM_ARG_ID_MOVEDOWN    (101)
 #define SWM_ARG_ID_MOVELEFT    (102)
 #define SWM_ARG_ID_MOVERIGHT   (103)
+#define SWM_ARG_ID_RAISE       (105)
+#define SWM_ARG_ID_LOWER       (106)
 #define SWM_ARG_ID_BAR_TOGGLE  (110)
 #define SWM_ARG_ID_BAR_TOGGLE_WS       (111)
        char                    **argv;
@@ -1150,6 +1155,7 @@ void       update_floater(struct ws_win *);
 void    update_modkey(unsigned int);
 void    update_win_stacking(struct ws_win *);
 void    update_window(struct ws_win *);
+void    update_window_color(struct ws_win *);
 void    update_wm_state(struct  ws_win *win);
 void    validate_spawns(void);
 int     validate_win(struct ws_win *);
@@ -1630,6 +1636,8 @@ ewmh_apply_flags(struct ws_win *win, uint32_t pending)
                                        ws->focus_pending = win;
                        }
                }
+
+               update_window_color(win);
                raise_window(win);
        }
 
@@ -3003,6 +3011,9 @@ raise_window(struct ws_win *win)
                        continue;
                if (ws->cur_layout == &layouts[SWM_MAX_STACK])
                        break;
+               if (TRANS(win) && (win->transient == target->transient ||
+                   win->transient == target->id))
+                       break;
                if (FULLSCREEN(win))
                        break;
                if (FULLSCREEN(target))
@@ -3024,6 +3035,17 @@ raise_window(struct ws_win *win)
                update_win_stacking(win);
        }
 
+#ifdef SWM_DEBUG
+       if (swm_debug & SWM_D_STACK) {
+               DPRINTF("=== stacking order (top down) === \n");
+               TAILQ_FOREACH(target, &r->ws->stack, stack_entry) {
+                       DPRINTF("win %#x, fs: %s, maximized: %s, above: %s, "
+                           "iconic: %s\n", target->id, YESNO(FULLSCREEN(target)),
+                           YESNO(MAXIMIZED(target)), YESNO(ABOVE(target)),
+                           YESNO(ICONIC(target)));
+               }
+       }
+#endif
        DNPRINTF(SWM_D_EVENT, "raise_window: done\n");
 }
 
@@ -3452,8 +3474,7 @@ unfocus_win(struct ws_win *win)
                win->ws->focus_prev = NULL;
        }
 
-       xcb_change_window_attributes(conn, win->id, XCB_CW_BORDER_PIXEL,
-           &win->s->c[SWM_S_COLOR_UNFOCUS].pixel);
+       update_window_color(win);
 
        xcb_change_property(conn, XCB_PROP_MODE_REPLACE, win->s->root,
            ewmh[_NET_ACTIVE_WINDOW].atom, XCB_ATOM_WINDOW, 32, 1, &none);
@@ -3470,13 +3491,7 @@ focus_win(struct ws_win *win)
 
        DNPRINTF(SWM_D_FOCUS, "focus_win: win %#x\n", WINID(win));
 
-       if (win == NULL)
-               goto out;
-
-       if (win->ws == NULL)
-               goto out;
-
-       if (!win->mapped)
+       if (win == NULL || win->ws == NULL || !win->mapped)
                goto out;
 
        ws = win->ws;
@@ -3497,7 +3512,9 @@ focus_win(struct ws_win *win)
                                /* Change border to unfocused color. */
                                xcb_change_window_attributes(conn, cfw->id,
                                    XCB_CW_BORDER_PIXEL,
-                                   &cfw->s->c[SWM_S_COLOR_UNFOCUS].pixel);
+                                   &cfw->s->c[(MAXIMIZED(cfw) ?
+                                   SWM_S_COLOR_UNFOCUS_MAXIMIZED :
+                                   SWM_S_COLOR_UNFOCUS)].pixel);
                        } else {
                                unfocus_win(cfw);
                        }
@@ -3543,9 +3560,6 @@ focus_win(struct ws_win *win)
                                client_msg(win, a_takefocus, last_event_time);
                }
 
-               xcb_change_window_attributes(conn, win->id, XCB_CW_BORDER_PIXEL,
-                   &win->s->c[SWM_S_COLOR_FOCUS].pixel);
-
                if (ws->cur_layout->flags & SWM_L_MAPONFOCUS ||
                    ws->always_raise) {
                        /* If a parent exists, map it first. */
@@ -3579,6 +3593,8 @@ focus_win(struct ws_win *win)
 
                set_region(ws->r);
 
+               update_window_color(win);
+
                xcb_change_property(conn, XCB_PROP_MODE_REPLACE, win->s->root,
                    ewmh[_NET_ACTIVE_WINDOW].atom, XCB_ATOM_WINDOW, 32, 1,
                    &win->id);
@@ -3734,8 +3750,7 @@ switchws(struct swm_region *r, union arg *args)
                return;
 
        if ((win = old_ws->focus) != NULL) {
-               xcb_change_window_attributes(conn, win->id, XCB_CW_BORDER_PIXEL,
-                   &win->s->c[SWM_S_COLOR_UNFOCUS].pixel);
+               update_window_color(win);
 
                xcb_change_property(conn, XCB_PROP_MODE_REPLACE, win->s->root,
                    ewmh[_NET_ACTIVE_WINDOW].atom, XCB_ATOM_WINDOW, 32, 1,
@@ -3963,9 +3978,39 @@ swapwin(struct swm_region *r, union arg *args)
            args->id, r->s->idx, WIDTH(r), HEIGHT(r), X(r), Y(r), r->ws->idx);
 
        cur_focus = r->ws->focus;
-       if (cur_focus == NULL || ABOVE(cur_focus) || FULLSCREEN(cur_focus))
+       if (cur_focus == NULL || FULLSCREEN(cur_focus))
                return;
 
+       /* Adjust stacking in floating layer. */
+       if (ABOVE(cur_focus)) {
+               switch (args->id) {
+               case SWM_ARG_ID_SWAPPREV:
+                       target = TAILQ_PREV(cur_focus, ws_win_stack,
+                           stack_entry);
+                       if (target != NULL && FLOATING(target)) {
+                               TAILQ_REMOVE(&cur_focus->ws->stack, cur_focus,
+                                   stack_entry);
+                               TAILQ_INSERT_BEFORE(target, cur_focus,
+                                   stack_entry);
+                               update_win_stacking(cur_focus);
+                               focus_flush();
+                       }
+                       break;
+               case SWM_ARG_ID_SWAPNEXT:
+                       target = TAILQ_NEXT(cur_focus, stack_entry);
+                       if (target != NULL && FLOATING(target)) {
+                               TAILQ_REMOVE(&cur_focus->ws->stack, cur_focus,
+                                   stack_entry);
+                               TAILQ_INSERT_AFTER(&cur_focus->ws->stack,
+                                   target, cur_focus, stack_entry);
+                               update_win_stacking(cur_focus);
+                               focus_flush();
+                       }
+                       break;
+               }
+               goto out;
+       }
+
        if (r->ws->cur_layout == &layouts[SWM_MAX_STACK])
                return;
 
@@ -4025,12 +4070,12 @@ swapwin(struct swm_region *r, union arg *args)
        }
 
        sort_windows(wl);
-
        ewmh_update_client_list();
 
        stack();
-
        focus_flush();
+out:
+       DNPRINTF(SWM_D_MOVE, "swapwin: done\n");
 }
 
 struct ws_win *
@@ -5966,6 +6011,24 @@ constrain_window(struct ws_win *win, struct swm_geometry *b, int *opts)
 }
 
 void
+update_window_color(struct ws_win *win)
+{
+       uint32_t        *pixel;
+
+       if (WS_FOCUSED(win->ws) && win->ws->focus == win)
+               pixel = MAXIMIZED(win) ?
+                   &win->s->c[SWM_S_COLOR_FOCUS_MAXIMIZED].pixel :
+                   &win->s->c[SWM_S_COLOR_FOCUS].pixel;
+       else
+               pixel = MAXIMIZED(win) ?
+                   &win->s->c[SWM_S_COLOR_UNFOCUS_MAXIMIZED].pixel :
+                   &win->s->c[SWM_S_COLOR_UNFOCUS].pixel;
+
+       xcb_change_window_attributes(conn, win->id,
+           XCB_CW_BORDER_PIXEL, pixel);
+}
+
+void
 update_window(struct ws_win *win)
 {
        uint16_t        mask;
@@ -6161,6 +6224,12 @@ resize(struct ws_win *win, union arg *args)
                                xcb_flush(conn);
                        }
                        break;
+               case XCB_KEY_PRESS:
+                       /* Ignore. */
+                       xcb_allow_events(conn, XCB_ALLOW_ASYNC_KEYBOARD,
+                           ((xcb_key_press_event_t *)evt)->time);
+                       xcb_flush(conn);
+                       break;
                default:
                        event_handle(evt);
 
@@ -6343,6 +6412,12 @@ move(struct ws_win *win, union arg *args)
                                xcb_flush(conn);
                        }
                        break;
+               case XCB_KEY_PRESS:
+                       /* Ignore. */
+                       xcb_allow_events(conn, XCB_ALLOW_ASYNC_KEYBOARD,
+                           ((xcb_key_press_event_t *)evt)->time);
+                       xcb_flush(conn);
+                       break;
                default:
                        event_handle(evt);
 
@@ -6625,11 +6700,21 @@ spawn_expand(struct swm_region *r, union arg *args, const char *spawn_name,
                            strdup(r->s->c[SWM_S_COLOR_FOCUS].name))
                            == NULL)
                                err(1, "spawn_custom color focus");
+               } else if (strcasecmp(ap, "$color_focus_maximized") == 0) {
+                       if ((real_args[c] =
+                           strdup(r->s->c[SWM_S_COLOR_FOCUS_MAXIMIZED].name))
+                           == NULL)
+                               err(1, "spawn_custom color focus maximized");
                } else if (strcasecmp(ap, "$color_unfocus") == 0) {
                        if ((real_args[c] =
                            strdup(r->s->c[SWM_S_COLOR_UNFOCUS].name))
                            == NULL)
                                err(1, "spawn_custom color unfocus");
+               } else if (strcasecmp(ap, "$color_unfocus_maximized") == 0) {
+                       if ((real_args[c] =
+                           strdup(r->s->c[SWM_S_COLOR_UNFOCUS_MAXIMIZED].name))
+                           == NULL)
+                               err(1, "spawn_custom color unfocus maximized");
                } else if (strcasecmp(ap, "$region_index") == 0) {
                        if (asprintf(&real_args[c], "%d",
                            get_region_index(r) + 1) < 1)
@@ -8017,9 +8102,36 @@ setconfmodkey(const char *selector, const char *value, int flags)
 int
 setconfcolor(const char *selector, const char *value, int flags)
 {
-       setscreencolor(value,
-           (selector == NULL || strlen(selector) == 0) ? -1 : atoi(selector),
-           flags);
+       int     sid, i, num_screens;
+
+       sid = (selector == NULL || strlen(selector) == 0) ? -1 : atoi(selector);
+
+       /*
+        * When setting focus/unfocus colors, we need to also
+        * set maximize colors to match if they haven't been customized.
+        */
+       i = sid < 0 ? 0 : sid;
+       if (flags == SWM_S_COLOR_FOCUS &&
+           !screens[i].c[SWM_S_COLOR_FOCUS_MAXIMIZED].manual)
+               setscreencolor(value, sid, SWM_S_COLOR_FOCUS_MAXIMIZED);
+       else if (flags == SWM_S_COLOR_UNFOCUS &&
+           !screens[i].c[SWM_S_COLOR_UNFOCUS_MAXIMIZED].manual)
+               setscreencolor(value, sid, SWM_S_COLOR_UNFOCUS_MAXIMIZED);
+
+       setscreencolor(value, sid, flags);
+
+       /* Track override of color. */
+       num_screens = get_screen_count();
+       if (sid > 0 && sid <= num_screens) {
+               screens[i].c[flags].manual = 1;
+       } else if (sid == -1) {
+               for (i = 0; i < num_screens; ++i)
+                       screens[i].c[flags].manual = 1;
+       } else {
+               errx(1, "invalid screen index: %d out of bounds (maximum %d)",
+                   sid, num_screens);
+       }
+
        return (0);
 }
 
@@ -8218,7 +8330,9 @@ struct config_option configopt[] = {
        { "clock_enabled",              setconfvalue,   SWM_S_CLOCK_ENABLED },
        { "clock_format",               setconfvalue,   SWM_S_CLOCK_FORMAT },
        { "color_focus",                setconfcolor,   SWM_S_COLOR_FOCUS },
+       { "color_focus_maximized",      setconfcolor,   SWM_S_COLOR_FOCUS_MAXIMIZED },
        { "color_unfocus",              setconfcolor,   SWM_S_COLOR_UNFOCUS },
+       { "color_unfocus_maximized",    setconfcolor,   SWM_S_COLOR_UNFOCUS_MAXIMIZED },
        { "cycle_empty",                setconfvalue,   SWM_S_CYCLE_EMPTY },
        { "cycle_visible",              setconfvalue,   SWM_S_CYCLE_VISIBLE },
        { "dialog_ratio",               setconfvalue,   SWM_S_DIALOG_RATIO },
@@ -9121,14 +9235,18 @@ configurerequest(xcb_configure_request_event_t *e)
 
                win->g_floatvalid = 1;
 
-               if (ABOVE(win) && r && !MAXIMIZED(win) && (TRANS(win) ||
-                   win->ws->cur_layout != &layouts[SWM_MAX_STACK])) {
+               if (!MAXIMIZED(win) && !FULLSCREEN(win) &&
+                   (TRANS(win) || (ABOVE(win) &&
+                   win->ws->cur_layout != &layouts[SWM_MAX_STACK]))) {
                        WIDTH(win) = win->g_float.w;
                        HEIGHT(win) = win->g_float.h;
 
-                       if (r) {
+                       if (r != NULL) {
                                update_floater(win);
                                focus_flush();
+                       } else {
+                               config_win(win, e);
+                               xcb_flush(conn);
                        }
                } else {
                        config_win(win, e);
@@ -10227,6 +10345,8 @@ setup_screens(void)
                    SWM_S_COLOR_BAR_BORDER_UNFOCUS);
                setscreencolor("black", i + 1, SWM_S_COLOR_BAR);
                setscreencolor("rgb:a0/a0/a0", i + 1, SWM_S_COLOR_BAR_FONT);
+               setscreencolor("red", i + 1, SWM_S_COLOR_FOCUS_MAXIMIZED);
+               setscreencolor("rgb:88/88/88", i + 1, SWM_S_COLOR_UNFOCUS_MAXIMIZED);
 
                /* create graphics context on screen */
                screens[i].bar_gc = xcb_generate_id(conn);