JasonWoof Got questions, comments, patches, etc.? Contact Jason Woofenden
convert another XGetWindowAttributes to xcb
[spectrwm.git] / spectrwm.c
index 0980dd5..dc418de 100644 (file)
@@ -258,7 +258,7 @@ struct search_window {
        TAILQ_ENTRY(search_window)      entry;
        int                             idx;
        struct ws_win                   *win;
-       GC                              gc;
+       xcb_gcontext_t                  gc;
        xcb_window_t                    indicator;
 };
 TAILQ_HEAD(search_winlist, search_window);
@@ -292,12 +292,6 @@ double                     dialog_ratio = 0.6;
                                "-misc-fixed-medium-r-*-*-*-*-*-*-*-*-*-*,"  \
                                "-*-*-*-r-*--*-*-*-*-*-*-*-*"
 
-#ifdef X_HAVE_UTF8_STRING
-#define DRAWSTRING(x...)       Xutf8DrawString(x)
-#else
-#define DRAWSTRING(x...)       XmbDrawString(x)
-#endif
-
 char                   *bar_argv[] = { NULL, NULL };
 int                    bar_pipe[2];
 unsigned char          bar_ext[SWM_BAR_MAX];
@@ -396,7 +390,7 @@ struct ws_win {
        XSizeHints              sh;
        long                    sh_mask;
        XClassHint              ch;
-       XWMHints                *hints;
+       xcb_wm_hints_t          hints;
 };
 TAILQ_HEAD(ws_win_list, ws_win);
 
@@ -505,7 +499,7 @@ struct swm_screen {
                char            *name;
        } c[SWM_S_COLOR_MAX];
 
-       GC                      bar_gc;
+       xcb_gcontext_t          bar_gc;
 };
 struct swm_screen      *screens;
 
@@ -1426,6 +1420,8 @@ bar_print(struct swm_region *r, const char *s)
 {
        int                     x = 0;
        size_t                  len;
+       xcb_rectangle_t         rect;
+       uint32_t                gcv[1];
        XRectangle              ibox, lbox;
 
        len = strlen(s);
@@ -1446,21 +1442,27 @@ bar_print(struct swm_region *r, const char *s)
        if (x < SWM_BAR_OFFSET)
                x = SWM_BAR_OFFSET;
 
+       rect.x = 0;
+       rect.y = 0;
+       rect.width = WIDTH(r->bar);
+       rect.height = HEIGHT(r->bar);
+
        /* clear back buffer */
-       XSetForeground(display, r->s->bar_gc, r->s->c[SWM_S_COLOR_BAR].color);
-       XFillRectangle(display, r->bar->buffer, r->s->bar_gc, 0, 0,
-           WIDTH(r->bar), HEIGHT(r->bar));
+       gcv[0] = r->s->c[SWM_S_COLOR_BAR].color;
+       xcb_change_gc(conn, r->s->bar_gc, XCB_GC_FOREGROUND, gcv);
+       xcb_poly_fill_rectangle(conn, r->bar->buffer, r->s->bar_gc,
+               sizeof(rect), &rect);
 
        /* draw back buffer */
-       XSetForeground(display, r->s->bar_gc,
-           r->s->c[SWM_S_COLOR_BAR_FONT].color);
-       DRAWSTRING(display, r->bar->buffer, bar_fs, r->s->bar_gc,
-               x, (bar_fs_extents->max_logical_extent.height - lbox.height) / 2 -
-               lbox.y, s, len);
+       gcv[0] = r->s->c[SWM_S_COLOR_BAR_FONT].color;
+       xcb_change_gc(conn, r->s->bar_gc, XCB_GC_FOREGROUND, gcv);
+       xcb_image_text_8(conn, len, r->bar->buffer, r->s->bar_gc, x,
+               (bar_fs_extents->max_logical_extent.height - lbox.height) / 2 -
+               lbox.y, s);
 
        /* blt */
-       XCopyArea(display, r->bar->buffer, r->bar->id, r->s->bar_gc, 0, 0,
-           WIDTH(r->bar), HEIGHT(r->bar), 0, 0);
+       xcb_copy_area(conn, r->bar->buffer, r->bar->id, r->s->bar_gc, 0, 0,
+               0, 0, WIDTH(r->bar), HEIGHT(r->bar));
 }
 
 void
@@ -1526,7 +1528,7 @@ bar_window_name(char *s, size_t sz, struct swm_region *r)
        if ((title = get_win_name(r->ws->focus->id)) == NULL)
                return;
 
-       strlcat(s, (char *)title, sz);
+       strlcat(s, title, sz);
        free(title);
 }
 
@@ -1921,7 +1923,8 @@ bar_setup(struct swm_region *r)
        int                     num_missing_charsets = 0;
        int                     i;
        xcb_screen_t            *screen = get_screen(r->s->idx);
-
+       uint32_t                wa[2];
+       
        if (bar_fs) {
                XFreeFontSet(display, bar_fs);
                bar_fs = NULL;
@@ -1966,13 +1969,18 @@ bar_setup(struct swm_region *r)
        WIDTH(r->bar) = WIDTH(r) - 2 * bar_border_width;
        HEIGHT(r->bar) = bar_height - 2 * bar_border_width;
 
-       r->bar->id = XCreateSimpleWindow(display,
-           r->s->root, X(r->bar), Y(r->bar), WIDTH(r->bar), HEIGHT(r->bar),
-           bar_border_width, r->s->c[SWM_S_COLOR_BAR_BORDER].color,
-           r->s->c[SWM_S_COLOR_BAR].color);
+       r->bar->id = xcb_generate_id(conn);
+       wa[0] = r->s->c[SWM_S_COLOR_BAR].color;
+       wa[1] = r->s->c[SWM_S_COLOR_BAR_BORDER].color;
+       xcb_create_window(conn, screen->root_depth, r->bar->id, r->s->root,
+               X(r->bar), Y(r->bar), WIDTH(r->bar), HEIGHT(r->bar),
+               bar_border_width, XCB_WINDOW_CLASS_INPUT_OUTPUT,
+               screen->root_visual, XCB_CW_BACK_PIXEL | XCB_CW_BORDER_PIXEL,
+               wa);
 
-       r->bar->buffer = XCreatePixmap(display, r->bar->id, WIDTH(r->bar),
-           HEIGHT(r->bar), screen->root_depth);
+       r->bar->buffer = xcb_generate_id(conn);
+       xcb_create_pixmap(conn, screen->root_depth, r->bar->buffer, r->bar->id,
+               WIDTH(r->bar), HEIGHT(r->bar)); 
 
        xcb_randr_select_input(conn, r->bar->id,
                XCB_RANDR_NOTIFY_MASK_OUTPUT_CHANGE);
@@ -2275,7 +2283,6 @@ root_to_region(xcb_window_t root)
 {
        struct swm_region       *r = NULL;
        int                     i, num_screens;
-       xcb_query_pointer_cookie_t      qpc;
        xcb_query_pointer_reply_t       *qpr;
 
        DNPRINTF(SWM_D_MISC, "root_to_region: window: 0x%x\n", root);
@@ -2285,8 +2292,8 @@ root_to_region(xcb_window_t root)
                if (screens[i].root == root)
                        break;
 
-       qpc = xcb_query_pointer(conn, screens[i].root);
-       qpr = xcb_query_pointer_reply(conn, qpc, NULL);
+       qpr = xcb_query_pointer_reply(conn, xcb_query_pointer(conn,
+               screens[i].root), NULL);
 
        if (qpr) {
                DNPRINTF(SWM_D_MISC, "root_to_region: pointer: (%d,%d)\n",
@@ -3738,12 +3745,12 @@ get_win_name(xcb_window_t win)
 
        c = xcb_icccm_get_wm_name(conn, win);
        if (xcb_icccm_get_wm_name_reply(conn, c, &r, NULL)) {
-               name = malloc((r.name_len + 1) * sizeof(char *));
+               name = malloc(r.name_len + 1);
                if (!name) {
                        xcb_get_text_property_reply_wipe(&r);
                        return (NULL);
                }
-               memcpy(name, r.name, r.name_len * sizeof(char *));
+               memcpy(name, r.name, r.name_len);
                name[r.name_len] = '\0';
        }
 
@@ -3860,7 +3867,7 @@ search_win_cleanup(void)
 
        while ((sw = TAILQ_FIRST(&search_wl)) != NULL) {
                xcb_destroy_window(conn, sw->indicator);
-               XFreeGC(display, sw->gc);
+               xcb_free_gc(conn, sw->gc);
                TAILQ_REMOVE(&search_wl, sw, entry);
                free(sw);
        }
@@ -3872,13 +3879,13 @@ search_win(struct swm_region *r, union arg *args)
        struct ws_win           *win = NULL;
        struct search_window    *sw = NULL;
        xcb_window_t            w;
-       XGCValues               gcv;
+       uint32_t                gcv[1], wa[2];
        int                     i;
        char                    s[8];
        FILE                    *lfile;
        size_t                  len;
        XRectangle              ibox, lbox;
-
+       xcb_screen_t            *screen; 
        DNPRINTF(SWM_D_MISC, "search_win\n");
 
        search_r = r;
@@ -3905,28 +3912,33 @@ search_win(struct swm_region *r, union arg *args)
                }
                sw->idx = i;
                sw->win = win;
+               screen = get_screen(sw->idx);
 
                snprintf(s, sizeof s, "%d", i);
                len = strlen(s);
 
                XmbTextExtents(bar_fs, s, len, &ibox, &lbox);
 
-               w = XCreateSimpleWindow(display,
-                   win->id, 0, 0,lbox.width + 4,
-                   bar_fs_extents->max_logical_extent.height, 1,
-                   r->s->c[SWM_S_COLOR_UNFOCUS].color,
-                   r->s->c[SWM_S_COLOR_FOCUS].color);
-
+               w = xcb_generate_id(conn);
+               wa[0] = r->s->c[SWM_S_COLOR_FOCUS].color;
+               wa[1] = r->s->c[SWM_S_COLOR_UNFOCUS].color;
+               xcb_create_window(conn, screen->root_depth, w, win->id,
+                       0, 0, lbox.width + 4,
+                       bar_fs_extents->max_logical_extent.height, 1,
+                       XCB_WINDOW_CLASS_INPUT_OUTPUT, screen->root_visual,
+                       XCB_CW_BACK_PIXEL | XCB_CW_BORDER_PIXEL, wa);   
+               
                sw->indicator = w;
                TAILQ_INSERT_TAIL(&search_wl, sw, entry);
 
-               sw->gc = XCreateGC(display, w, 0, &gcv);
+               sw->gc = xcb_generate_id(conn);
+               gcv[0] = r->s->c[SWM_S_COLOR_BAR].color;                
+               xcb_create_gc(conn, sw->gc, w, XCB_GC_FOREGROUND, gcv); 
                map_window_raised(w);
-               XSetForeground(display, sw->gc, r->s->c[SWM_S_COLOR_BAR].color);
 
-               DRAWSTRING(display, w, bar_fs, sw->gc, 2,
+               xcb_image_text_8(conn, len, w, sw->gc, 2,
                    (bar_fs_extents->max_logical_extent.height -
-                   lbox.height) / 2 - lbox.y, s, len);
+                   lbox.height) / 2 - lbox.y, s);
 
                fprintf(lfile, "%d\n", i);
                i++;
@@ -4259,14 +4271,14 @@ resize(struct ws_win *win, union arg *args)
        Time                    time = 0;
        struct swm_region       *r = NULL;
        int                     resize_step = 0;
-       Window                  rr, cr;
-       int                     x, y, wx, wy;
-       unsigned int            mask;
        struct swm_geometry     g;
        int                     top = 0, left = 0;
        int                     dx, dy;
-       Cursor                  cursor;
        unsigned int            shape; /* cursor style */
+       xcb_cursor_t            cursor;
+       xcb_font_t              cursor_font;
+       xcb_grab_pointer_reply_t        *gpr;
+       xcb_query_pointer_reply_t       *xpr;
 
        if (win == NULL)
                return;
@@ -4323,15 +4335,17 @@ resize(struct ws_win *win, union arg *args)
                drain_enter_notify();
 
        /* get cursor offset from window root */
-       if (!XQueryPointer(display, win->id, &rr, &cr, &x, &y, &wx, &wy, &mask))
-           return;
-
+       xpr = xcb_query_pointer_reply(conn, xcb_query_pointer(conn, win->id),
+               NULL);
+       if (!xpr)
+               return;
+       
        g = win->g;
 
-       if (wx < WIDTH(win) / 2)
+       if (xpr->win_x < WIDTH(win) / 2)
                left = 1;
 
-       if (wy < HEIGHT(win) / 2)
+       if (xpr->win_y < HEIGHT(win) / 2)
                top = 1;
 
        if (args->id == SWM_ARG_ID_CENTER)
@@ -4341,11 +4355,22 @@ resize(struct ws_win *win, union arg *args)
        else
                shape = (left) ? XC_bottom_left_corner : XC_bottom_right_corner;
 
-       cursor = XCreateFontCursor(display, shape);
-
-       if (XGrabPointer(display, win->id, False, MOUSEMASK, GrabModeAsync,
-           GrabModeAsync, None, cursor, CurrentTime) != GrabSuccess) {
-               XFreeCursor(display, cursor);
+       cursor_font = xcb_generate_id(conn);
+       xcb_open_font(conn, cursor_font, strlen("cursor"), "cursor");
+
+       cursor = xcb_generate_id(conn);
+       xcb_create_glyph_cursor(conn, cursor, cursor_font, cursor_font,
+               shape, shape + 1, 0, 0, 0, 0xffff, 0xffff, 0xffff);
+
+       gpr = xcb_grab_pointer_reply(conn,
+               xcb_grab_pointer(conn, False, win->id, MOUSEMASK,
+               XCB_GRAB_MODE_ASYNC, XCB_GRAB_MODE_ASYNC, XCB_WINDOW_NONE,
+               cursor, XCB_CURRENT_TIME),
+               NULL);
+       if (!gpr) {
+               xcb_free_cursor(conn, cursor);
+               xcb_close_font(conn, cursor_font);
+               free(xpr);
                return;
        }
 
@@ -4360,8 +4385,8 @@ resize(struct ws_win *win, union arg *args)
                        break;
                case MotionNotify:
                        /* cursor offset/delta from start of the operation */
-                       dx = ev.xmotion.x_root - x;
-                       dy = ev.xmotion.y_root - y;
+                       dx = ev.xmotion.x_root - xpr->root_x;
+                       dy = ev.xmotion.y_root - xpr->root_y;
 
                        /* vertical */
                        if (top)
@@ -4421,7 +4446,10 @@ resize(struct ws_win *win, union arg *args)
        store_float_geom(win,r);
 
        xcb_ungrab_pointer(conn, XCB_CURRENT_TIME);
-       XFreeCursor(display, cursor);
+       xcb_free_cursor(conn, cursor);
+       xcb_close_font(conn, cursor_font);
+       free(gpr);
+       free(xpr);
 
        /* drain events */
        drain_enter_notify();
@@ -4449,10 +4477,10 @@ move(struct ws_win *win, union arg *args)
        Time                    time = 0;
        int                     move_step = 0;
        struct swm_region       *r = NULL;
-
-       Window                  rr, cr;
-       int                     x, y, wx, wy;
-       unsigned int            mask;
+       xcb_font_t                      cursor_font;
+       xcb_cursor_t                    cursor;
+       xcb_grab_pointer_reply_t        *gpr;
+       xcb_query_pointer_reply_t       *qpr;
 
        if (win == NULL)
                return;
@@ -4507,15 +4535,33 @@ move(struct ws_win *win, union arg *args)
                return;
        }
 
-       if (XGrabPointer(display, win->id, False, MOUSEMASK, GrabModeAsync,
-           GrabModeAsync, None, XCreateFontCursor(display, XC_fleur),
-           CurrentTime) != GrabSuccess)
+       cursor_font = xcb_generate_id(conn);
+       xcb_open_font(conn, cursor_font, strlen("cursor"), "cursor");
+       
+       cursor = xcb_generate_id(conn);
+       xcb_create_glyph_cursor(conn, cursor, cursor_font, cursor_font,
+               XC_fleur, XC_fleur + 1, 0, 0, 0, 0xffff, 0xffff, 0xffff);
+
+       gpr = xcb_grab_pointer_reply(conn,
+               xcb_grab_pointer(conn, False, win->id, MOUSEMASK,
+                       XCB_GRAB_MODE_ASYNC, XCB_GRAB_MODE_ASYNC,
+                       XCB_WINDOW_NONE, cursor, XCB_CURRENT_TIME),
+               NULL);
+       if (!gpr) {
+               xcb_free_cursor(conn, cursor);
+               xcb_close_font(conn, cursor_font);
                return;
+       }
 
        /* get cursor offset from window root */
-       if (!XQueryPointer(display, win->id, &rr, &cr, &x, &y, &wx, &wy, &mask))
-           return;
-
+       qpr = xcb_query_pointer_reply(conn, xcb_query_pointer(conn, win->id),
+               NULL);
+       if (!qpr) {
+               xcb_ungrab_pointer(conn, XCB_CURRENT_TIME);
+               xcb_free_cursor(conn, cursor);
+               xcb_close_font(conn, cursor_font);
+               return;
+       }
        do {
                XMaskEvent(display, MOUSEMASK | ExposureMask |
                    SubstructureRedirectMask, &ev);
@@ -4526,8 +4572,8 @@ move(struct ws_win *win, union arg *args)
                        handler[ev.type](&ev);
                        break;
                case MotionNotify:
-                       X(win) = ev.xmotion.x_root - wx - border_width;
-                       Y(win) = ev.xmotion.y_root - wy - border_width;
+                       X(win) = ev.xmotion.x_root - qpr->win_x - border_width;
+                       Y(win) = ev.xmotion.y_root - qpr->win_y - border_width;
 
                        constrain_window(win, r, 0);
 
@@ -4545,6 +4591,9 @@ move(struct ws_win *win, union arg *args)
                update_window(win);
        }
        store_float_geom(win, r);
+       free(qpr);
+       xcb_free_cursor(conn, cursor);
+       xcb_close_font(conn, cursor_font);
        xcb_ungrab_pointer(conn, XCB_CURRENT_TIME);
 
        /* drain events */
@@ -6227,9 +6276,9 @@ void
 set_child_transient(struct ws_win *win, Window *trans)
 {
        struct ws_win           *parent, *w;
-       XWMHints                *wmh = NULL;
        struct swm_region       *r;
        struct workspace        *ws;
+       xcb_wm_hints_t          wmh;
 
        parent = find_window(win->transient);
        if (parent)
@@ -6238,24 +6287,18 @@ set_child_transient(struct ws_win *win, Window *trans)
                DNPRINTF(SWM_D_MISC, "set_child_transient: parent doesn't exist"
                    " for 0x%x trans 0x%x\n", win->id, win->transient);
 
-               if (win->hints == NULL) {
-                       warnx("no hints for 0x%x", win->id);
-                       return;
-               }
-
                r = root_to_region(win->wa.root);
                ws = r->ws;
                /* parent doen't exist in our window list */
                TAILQ_FOREACH(w, &ws->winlist, entry) {
-                       if (wmh)
-                               XFree(wmh);
-
-                       if ((wmh = XGetWMHints(display, w->id)) == NULL) {
+                       if (xcb_icccm_get_wm_hints_reply(conn,
+                                       xcb_icccm_get_wm_hints(conn, w->id),
+                                       &wmh, NULL) != 1) {
                                warnx("can't get hints for 0x%x", w->id);
                                continue;
                        }
 
-                       if (win->hints->window_group != wmh->window_group)
+                       if (win->hints.window_group != wmh.window_group)
                                continue;
 
                        w->child_trans = win;
@@ -6266,9 +6309,6 @@ set_child_transient(struct ws_win *win, Window *trans)
                        break;
                }
        }
-
-       if (wmh)
-               XFree(wmh);
 }
 
 long
@@ -6381,7 +6421,9 @@ manage_window(xcb_window_t id)
        }
        XGetWindowAttributes(display, id, &win->wa);
        XGetWMNormalHints(display, id, &win->sh, &win->sh_mask);
-       win->hints = XGetWMHints(display, id);
+       xcb_icccm_get_wm_hints_reply(conn,
+               xcb_icccm_get_wm_hints(conn, id),
+               &win->hints, NULL);
        XGetTransientForHint(display, id, &trans);
        if (trans) {
                win->transient = trans;
@@ -6610,11 +6652,6 @@ unmanage_window(struct ws_win *win)
 
        focus_prev(win);
 
-       if (win->hints) {
-               XFree(win->hints);
-               win->hints = NULL;
-       }
-
        TAILQ_REMOVE(&win->ws->winlist, win, entry);
        TAILQ_INSERT_TAIL(&win->ws->unmanagedlist, win, entry);
 }
@@ -6995,20 +7032,27 @@ maprequest(XEvent *e)
 {
        struct ws_win           *win;
        struct swm_region       *r;
-       XWindowAttributes       wa;
        XMapRequestEvent        *ev = &e->xmaprequest;
+       xcb_get_window_attributes_reply_t *war;
 
        DNPRINTF(SWM_D_EVENT, "maprequest: window: 0x%lx\n",
            e->xmaprequest.window);
 
-       if (!XGetWindowAttributes(display, ev->window, &wa))
+       war = xcb_get_window_attributes_reply(conn,
+               xcb_get_window_attributes(conn, ev->window),
+               NULL);
+       if (!war)
                return;
-       if (wa.override_redirect)
+       if (war->override_redirect) {
+               free(war);
                return;
+       }       
+       free(war);
 
        win = manage_window(e->xmaprequest.window);
-       if (win == NULL)
+       if (win == NULL) {
                return; /* can't happen */
+       }
 
        stack();
 
@@ -7328,32 +7372,35 @@ scan_xrandr(int i)
                        screens[i].root);
                srr = xcb_randr_get_screen_resources_current_reply(conn, src,
                        NULL);
-               if (srr == NULL)
+               if (srr == NULL) {
                        new_region(&screens[i], 0, 0,
                            screen->width_in_pixels,
                            screen->height_in_pixels);
-               else
+                       return;
+               } else
                        ncrtc = srr->num_crtcs;
                for (c = 0; c < ncrtc; c++) {
                        crtc = xcb_randr_get_screen_resources_current_crtcs(srr);
                        cic = xcb_randr_get_crtc_info(conn, crtc[c],
                                XCB_CURRENT_TIME);
                        cir = xcb_randr_get_crtc_info_reply(conn, cic, NULL);
-                       if (cir && cir->num_outputs == 0)
+                       if (cir == NULL)
+                               continue;
+                       if (cir->num_outputs == 0) {
+                               free(cir);
                                continue;
+                       }
 
-                       if (cir == NULL || cir->mode == 0)
+                       if (cir->mode == 0)
                                new_region(&screens[i], 0, 0,
                                    screen->width_in_pixels,
                                    screen->height_in_pixels);
                        else
                                new_region(&screens[i],
                                    cir->x, cir->y, cir->width, cir->height);
-               }
-               if (srr)
-                       free(srr);
-               if (cir)
                        free(cir);
+               }
+               free(srr);
        } else
 #endif /* SWM_XRR_HAS_CRTC */
        {
@@ -7469,8 +7516,10 @@ setup_screens(void)
 {
        int                     i, j, k, num_screens;
        struct workspace        *ws;
-       XGCValues               gcv;
+       uint32_t                gcv[1], wa[1];
        const xcb_query_extension_reply_t *qep;
+       xcb_cursor_t                            cursor;
+       xcb_font_t                              cursor_font;
        xcb_randr_query_version_cookie_t        c;
        xcb_randr_query_version_reply_t         *r;
 
@@ -7492,6 +7541,14 @@ setup_screens(void)
        qep = xcb_get_extension_data(conn, &xcb_randr_id);
        xrandr_eventbase = qep->first_event;
 
+       cursor_font = xcb_generate_id(conn);
+       xcb_open_font(conn, cursor_font, strlen("cursor"), "cursor");
+
+       cursor = xcb_generate_id(conn);
+       xcb_create_glyph_cursor(conn, cursor, cursor_font, cursor_font,
+               XC_left_ptr, XC_left_ptr + 1, 0, 0, 0, 0xffff, 0xffff, 0xffff);
+       wa[0] = cursor;
+
        /* map physical screens */
        for (i = 0; i < num_screens; i++) {
                DNPRINTF(SWM_D_WS, "setup_screens: init screen: %d\n", i);
@@ -7508,13 +7565,14 @@ setup_screens(void)
                setscreencolor("rgb:a0/a0/a0", i + 1, SWM_S_COLOR_BAR_FONT);
 
                /* create graphics context on screen */
-               gcv.graphics_exposures = 0;
-               screens[i].bar_gc = XCreateGC(display, screens[i].root,
-                       GCGraphicsExposures, &gcv);
+               screens[i].bar_gc = xcb_generate_id(conn);
+               gcv[0] = 0;
+               xcb_create_gc(conn, screens[i].bar_gc, screens[i].root,
+                       XCB_GC_GRAPHICS_EXPOSURES, gcv);
 
                /* set default cursor */
-               XDefineCursor(display, screens[i].root,
-                   XCreateFontCursor(display, XC_left_ptr));
+               xcb_change_window_attributes(conn, screens[i].root,
+                       XCB_CW_CURSOR, wa);     
 
                /* init all workspaces */
                /* XXX these should be dynamically allocated too */
@@ -7542,6 +7600,8 @@ setup_screens(void)
                        xcb_randr_select_input(conn, screens[i].root,
                                XCB_RANDR_NOTIFY_MASK_SCREEN_CHANGE);
        }
+       xcb_free_cursor(conn, cursor);
+       xcb_close_font(conn, cursor_font);
 }
 
 void
@@ -7560,6 +7620,8 @@ workaround(void)
        int                     i, num_screens;
        xcb_atom_t              netwmcheck, netwmname, utf8_string;
        xcb_window_t            root, win;
+       xcb_screen_t            *screen;
+       uint32_t                wa[2];
 
        /* work around sun jdk bugs, code from wmname */
        netwmcheck = get_atom_from_string("_NET_SUPPORTING_WM_CHECK");
@@ -7569,9 +7631,15 @@ workaround(void)
        num_screens = xcb_setup_roots_length(xcb_get_setup(conn));
        for (i = 0; i < num_screens; i++) {
                root = screens[i].root;
-               win = XCreateSimpleWindow(display,root, 0, 0, 1, 1, 0,
-                   screens[i].c[SWM_S_COLOR_UNFOCUS].color,
-                   screens[i].c[SWM_S_COLOR_UNFOCUS].color);
+               screen = get_screen(i);
+
+               win = xcb_generate_id(conn);
+               wa[0] = screens[i].c[SWM_S_COLOR_UNFOCUS].color;
+               wa[1] = screens[i].c[SWM_S_COLOR_UNFOCUS].color;
+               xcb_create_window(conn, screen->root_depth, win, 0,
+                       0, 0, 1, 1, 0, XCB_WINDOW_CLASS_INPUT_OUTPUT,
+                       screen->root_visual,
+                       XCB_CW_BACK_PIXEL | XCB_CW_BORDER_PIXEL, wa);
 
                xcb_change_property(conn, XCB_PROP_MODE_REPLACE, root,
                        netwmcheck, XCB_ATOM_WINDOW, 32, 1, &win);
@@ -7787,8 +7855,8 @@ done:
        bar_extra_stop();
 
        for (i = 0; i < num_screens; ++i)
-               if (screens[i].bar_gc != NULL)
-                       XFreeGC(display, screens[i].bar_gc);
+               if (screens[i].bar_gc != 0)
+                       xcb_free_gc(conn, screens[i].bar_gc);
        XFreeFontSet(display, bar_fs);
        xcb_disconnect(conn);
        XCloseDisplay(display);