JasonWoof Got questions, comments, patches, etc.? Contact Jason Woofenden
create function get_atom_from_string() and initial XCB RANDR support
[spectrwm.git] / spectrwm.c
index b44e5ac..e6a36d2 100644 (file)
@@ -91,6 +91,7 @@
 #include <X11/XKBlib.h>
 #include <X11/Xatom.h>
 #include <X11/Xlib-xcb.h>
+#include <xcb/randr.h>
 #include <X11/Xproto.h>
 #include <X11/Xutil.h>
 #include <X11/extensions/Xrandr.h>
@@ -201,15 +202,15 @@ u_int32_t         swm_debug = 0
 #endif
 
 char                   **start_argv;
-Atom                   astate;
-Atom                   aprot;
-Atom                   adelete;
-Atom                   takefocus;
-Atom                   a_wmname;
-Atom                   a_netwmname;
-Atom                   a_utf8_string;
-Atom                   a_string;
-Atom                   a_swm_iconic;
+xcb_atom_t             astate;
+xcb_atom_t             aprot;
+xcb_atom_t             adelete;
+xcb_atom_t             takefocus;
+xcb_atom_t             a_wmname;
+xcb_atom_t             a_netwmname;
+xcb_atom_t             a_utf8_string;
+xcb_atom_t             a_string;
+xcb_atom_t             a_swm_iconic;
 volatile sig_atomic_t   running = 1;
 volatile sig_atomic_t   restart_wm = 0;
 int                    outputs = 0;
@@ -623,6 +624,26 @@ void                constrain_window(struct ws_win *, struct swm_region *, int);
 void            update_window(struct ws_win *);
 void            spawn_select(struct swm_region *, union arg *, char *, int *);
 unsigned char  *get_win_name(xcb_window_t);
+xcb_atom_t      get_atom_from_string(const char *);
+
+xcb_atom_t
+get_atom_from_string(const char *str)
+{
+       xcb_intern_atom_cookie_t        c;
+       xcb_intern_atom_reply_t         *r;
+       xcb_atom_t                      atom;
+
+       c = xcb_intern_atom(conn, False, strlen(str), str);
+       r = xcb_intern_atom_reply(conn, c, NULL);
+       if (r) {
+               atom = r->atom;
+               free(r);
+
+               return (atom);
+       }
+
+       return (XCB_ATOM_NONE);
+}
 
 int
 get_property(Window id, Atom atom, long count, Atom type, unsigned long *nitems,
@@ -652,17 +673,11 @@ update_iconic(struct ws_win *win, int newv)
 {
        int32_t                         v = newv;
        xcb_atom_t                      iprop;
-       xcb_intern_atom_cookie_t        c;
-       xcb_intern_atom_reply_t         *r;
 
        win->iconic = newv;
 
-       c = xcb_intern_atom(conn, False, strlen("_SWM_ICONIC"), "_SWM_ICONIC");
-       r = xcb_intern_atom_reply(conn, c, NULL);
-       if (r) {
-               iprop = r->atom;
-               free(r);
-       } else
+       iprop = get_atom_from_string("_SWM_ICONIC");
+       if (iprop == XCB_ATOM_NONE)
                return;
                
        if (newv)
@@ -677,17 +692,11 @@ get_iconic(struct ws_win *win)
 {
        int32_t v = 0, *vtmp;
        xcb_atom_t                      iprop;
-       xcb_intern_atom_cookie_t        c;
-       xcb_intern_atom_reply_t         *r;
        xcb_get_property_cookie_t       pc;
        xcb_get_property_reply_t        *pr;
 
-       c = xcb_intern_atom(conn, False, strlen("_SWM_ICONIC"), "_SWM_ICONIC");
-       r = xcb_intern_atom_reply(conn, c, NULL);
-       if (r) {
-               iprop = r->atom;
-               free(r);
-       } else
+       iprop = get_atom_from_string("_SWM_ICONIC");
+       if (iprop == XCB_ATOM_NONE)
                goto out;
 
        pc = xcb_get_property(conn, False, win->id, iprop, XCB_ATOM_INTEGER,
@@ -709,27 +718,12 @@ void
 setup_ewmh(void)
 {
        xcb_atom_t                      sup_list;
-       xcb_intern_atom_cookie_t        c;
-       xcb_intern_atom_reply_t         *r;
        int                             i, j, num_screens;
 
-       c = xcb_intern_atom(conn, False, strlen("_NET_SUPPORTED"),
-               "_NET_SUPPORTED");
-       r = xcb_intern_atom_reply(conn, c, NULL);
-       if (r) {
-               sup_list = r->atom;
-               free(r);
-       }
+       sup_list = get_atom_from_string("_NET_SUPPORTED");
        
-       for (i = 0; i < LENGTH(ewmh); i++) {
-               c = xcb_intern_atom(conn, False, strlen(ewmh[i].name),
-                       ewmh[i].name);
-               r = xcb_intern_atom_reply(conn, c, NULL);
-               if (r) {
-                       ewmh[i].atom = r->atom;
-                       free(r);
-               }
-       }
+       for (i = 0; i < LENGTH(ewmh); i++)
+               ewmh[i].atom = get_atom_from_string(ewmh[i].name);
 
        num_screens = xcb_setup_roots_length(xcb_get_setup(conn));
        for (i = 0; i < num_screens; i++) {
@@ -747,49 +741,52 @@ setup_ewmh(void)
 void
 teardown_ewmh(void)
 {
-       int                     i, success, num_screens;
-       unsigned char           *data = NULL;
-       unsigned long           n;
-       Atom                    sup_check, sup_list;
-       Window                  id;
-
-       sup_check = XInternAtom(display, "_NET_SUPPORTING_WM_CHECK", False);
-       sup_list = XInternAtom(display, "_NET_SUPPORTED", False);
+       int                             i, num_screens;
+       xcb_atom_t                      sup_check, sup_list;
+       xcb_window_t                    id;
+       xcb_get_property_cookie_t       pc;
+       xcb_get_property_reply_t        *pr;
 
+       sup_check = get_atom_from_string("_NET_SUPPORTING_WM_CHECK");
+       sup_list = get_atom_from_string("_NET_SUPPORTED");
        num_screens = xcb_setup_roots_length(xcb_get_setup(conn));
+       
        for (i = 0; i < num_screens; i++) {
                /* Get the support check window and destroy it */
-               success = get_property(screens[i].root, sup_check, 1, XA_WINDOW,
-                   &n, NULL, &data);
-
-               if (success) {
-                       id = data[0];
-                       XDestroyWindow(display, id);
-                       XDeleteProperty(display, screens[i].root, sup_check);
-                       XDeleteProperty(display, screens[i].root, sup_list);
+               pc = xcb_get_property(conn, False, screens[i].root, sup_check,
+                       XCB_ATOM_WINDOW, 0, 1);
+               pr = xcb_get_property_reply(conn, pc, NULL);
+               if (pr) {
+                       id = *((xcb_window_t *)xcb_get_property_value(pr));
+
+                       xcb_destroy_window(conn, id);
+                       xcb_delete_property(conn, screens[i].root, sup_check);
+                       xcb_delete_property(conn, screens[i].root, sup_list);
+               
+                       free(pr);
                }
-
-               XFree(data);
        }
 }
 
 void
 ewmh_autoquirk(struct ws_win *win)
 {
-       int                     success, i;
-       unsigned long           *data = NULL, n;
-       Atom                    type;
+       int                     i;
+       unsigned long           n;
+       xcb_atom_t              type;
 
-       success = get_property(win->id, ewmh[_NET_WM_WINDOW_TYPE].atom, (~0L),
-           XA_ATOM, &n, NULL, (void *)&data);
+       xcb_get_property_cookie_t       c;
+       xcb_get_property_reply_t        *r;
 
-       if (!success) {
-               XFree(data);
+       c = xcb_get_property(conn, False, win->id,
+               ewmh[_NET_WM_WINDOW_TYPE].atom, XCB_ATOM_ATOM, 0, (~0L));
+       r = xcb_get_property_reply(conn, c, NULL);
+       if (!r)
                return;
-       }
+       n = xcb_get_property_value_length(r);
 
        for (i = 0; i < n; i++) {
-               type = data[i];
+               type = *((xcb_atom_t *)xcb_get_property_value(r)); 
                if (type == ewmh[_NET_WM_WINDOW_TYPE_NORMAL].atom)
                        break;
                if (type == ewmh[_NET_WM_WINDOW_TYPE_DOCK].atom ||
@@ -806,8 +803,7 @@ ewmh_autoquirk(struct ws_win *win)
                        break;
                }
        }
-
-       XFree(data);
+       free(r);
 }
 
 #define SWM_EWMH_ACTION_COUNT_MAX      (6)
@@ -924,36 +920,37 @@ ewmh_update_win_state(struct ws_win *win, long state, long action)
                            win->ewmh_flags & EWMH_F_FULLSCREEN))
                                win->ewmh_flags = orig_flags; /* revert */
 
-       XDeleteProperty(display, win->id, ewmh[_NET_WM_STATE].atom);
+       xcb_delete_property(conn, win->id, ewmh[_NET_WM_STATE].atom);
 
        if (win->ewmh_flags & EWMH_F_FULLSCREEN)
-               XChangeProperty(display, win->id, ewmh[_NET_WM_STATE].atom,
-                   XA_ATOM, 32, PropModeAppend,
-                   (unsigned char *)&ewmh[_NET_WM_STATE_FULLSCREEN].atom, 1);
+               xcb_change_property(conn, XCB_PROP_MODE_APPEND, win->id,
+                       ewmh[_NET_WM_STATE].atom, XCB_ATOM_ATOM, 32, 1,
+                       &ewmh[_NET_WM_STATE_FULLSCREEN].atom);
        if (win->ewmh_flags & EWMH_F_SKIP_PAGER)
-               XChangeProperty(display, win->id, ewmh[_NET_WM_STATE].atom,
-                   XA_ATOM, 32, PropModeAppend,
-                   (unsigned char *)&ewmh[_NET_WM_STATE_SKIP_PAGER].atom, 1);
+               xcb_change_property(conn, XCB_PROP_MODE_APPEND, win->id,
+                       ewmh[_NET_WM_STATE].atom, XCB_ATOM_ATOM, 32, 1,
+                       &ewmh[_NET_WM_STATE_SKIP_PAGER].atom);  
        if (win->ewmh_flags & EWMH_F_SKIP_TASKBAR)
-               XChangeProperty(display, win->id, ewmh[_NET_WM_STATE].atom,
-                   XA_ATOM, 32, PropModeAppend,
-                   (unsigned char *)&ewmh[_NET_WM_STATE_SKIP_TASKBAR].atom, 1);
+               xcb_change_property(conn, XCB_PROP_MODE_APPEND, win->id,
+                       ewmh[_NET_WM_STATE].atom, XCB_ATOM_ATOM, 32, 1,
+                       &ewmh[_NET_WM_STATE_SKIP_TASKBAR].atom);
        if (win->ewmh_flags & EWMH_F_ABOVE)
-               XChangeProperty(display, win->id, ewmh[_NET_WM_STATE].atom,
-                   XA_ATOM, 32, PropModeAppend,
-                   (unsigned char *)&ewmh[_NET_WM_STATE_ABOVE].atom, 1);
+               xcb_change_property(conn, XCB_PROP_MODE_APPEND, win->id,
+                       ewmh[_NET_WM_STATE].atom, XCB_ATOM_ATOM, 32, 1,
+                       &ewmh[_NET_WM_STATE_ABOVE].atom);
        if (win->ewmh_flags & SWM_F_MANUAL)
-               XChangeProperty(display, win->id, ewmh[_NET_WM_STATE].atom,
-                   XA_ATOM, 32, PropModeAppend,
-                   (unsigned char *)&ewmh[_SWM_WM_STATE_MANUAL].atom, 1);
+               xcb_change_property(conn, XCB_PROP_MODE_APPEND, win->id,
+                       ewmh[_NET_WM_STATE].atom, XCB_ATOM_ATOM, 32, 1,
+                       &ewmh[_SWM_WM_STATE_MANUAL].atom);
 }
 
 void
 ewmh_get_win_state(struct ws_win *win)
 {
-       int                     success, i;
-       unsigned long           n;
-       Atom                    *states;
+       xcb_atom_t                      *states;
+       xcb_get_property_cookie_t       c;
+       xcb_get_property_reply_t        *r;
+       int                             i, n;
 
        if (win == NULL)
                return;
@@ -964,16 +961,19 @@ ewmh_get_win_state(struct ws_win *win)
        if (win->manual)
                win->ewmh_flags |= SWM_F_MANUAL;
 
-       success = get_property(win->id, ewmh[_NET_WM_STATE].atom,
-           (~0L), XA_ATOM, &n, NULL, (void *)&states);
-
-       if (!success)
+       c = xcb_get_property(conn, False, win->id, ewmh[_NET_WM_STATE].atom,
+               XCB_ATOM_ATOM, 0, (~0L));
+       r = xcb_get_property_reply(conn, c, NULL);
+       if (!r)
                return;
+       
+       states = xcb_get_property_value(r);
+       n = xcb_get_property_value_length(r);
+
+       free(r);
 
        for (i = 0; i < n; i++)
                ewmh_update_win_state(win, states[i], _NET_WM_STATE_ADD);
-
-       XFree(states);
 }
 
 /* events */
@@ -1251,26 +1251,34 @@ find_pid(long pid)
        return (NULL);
 }
 
-unsigned long
-name_to_color(char *colorname)
+uint32_t
+name_to_color(const char *colorname)
 {
-       Colormap                cmap;
-       Status                  status;
-       XColor                  screen_def, exact_def;
-       unsigned long           result = 0;
-       char                    cname[32] = "#";
+       uint32_t                        result = 0;
+       char                            cname[32] = "#";
+       xcb_screen_t                    *screen;
+       xcb_colormap_t                  cmap;
+       xcb_alloc_named_color_cookie_t  c;
+       xcb_alloc_named_color_reply_t   *r;
 
-       cmap = DefaultColormap(display, screens[0].idx);
-       status = XAllocNamedColor(display, cmap, colorname,
-           &screen_def, &exact_def);
-       if (!status) {
+       /* XXX - does not support rgb:/RR/GG/BB
+        *       will need to use xcb_alloc_color
+        */
+       screen = xcb_setup_roots_iterator(xcb_get_setup(conn)).data;
+       cmap = screen->default_colormap;
+
+       c = xcb_alloc_named_color(conn, cmap, strlen(colorname), colorname);
+       r = xcb_alloc_named_color_reply(conn, c, NULL);
+       if (!r) {
                strlcat(cname, colorname + 2, sizeof cname - 1);
-               status = XAllocNamedColor(display, cmap, cname, &screen_def,
-                   &exact_def);
+               c = xcb_alloc_named_color(conn, cmap, strlen(cname),
+                       cname);
+               r = xcb_alloc_named_color_reply(conn, c, NULL);
        }
-       if (status)
-               result = screen_def.pixel;
-       else
+       if (r) {
+               result = r->pixel;
+               free(r);
+       } else
                warnx("color '%s' not found", colorname);
 
        return (result);
@@ -1814,8 +1822,8 @@ bar_toggle(struct swm_region *r, union arg *args)
 void
 bar_refresh(void)
 {
-       XSetWindowAttributes    wa;
        struct swm_region       *r;
+       uint32_t                wa[2];
        int                     i, num_screens;
 
        /* do this here because the conf file is in memory */
@@ -1847,18 +1855,15 @@ bar_refresh(void)
                }
        }
 
-       bzero(&wa, sizeof wa);
        num_screens = xcb_setup_roots_length(xcb_get_setup(conn));
        for (i = 0; i < num_screens; i++)
                TAILQ_FOREACH(r, &screens[i].rl, entry) {
                        if (r->bar == NULL)
                                continue;
-                       wa.border_pixel =
-                           screens[i].c[SWM_S_COLOR_BAR_BORDER].color;
-                       wa.background_pixel =
-                           screens[i].c[SWM_S_COLOR_BAR].color;
-                       XChangeWindowAttributes(display, r->bar->id,
-                           CWBackPixel | CWBorderPixel, &wa);
+                       wa[0] = screens[i].c[SWM_S_COLOR_BAR].color;
+                       wa[1] = screens[i].c[SWM_S_COLOR_BAR_BORDER].color;
+                       xcb_change_window_attributes(conn, r->bar->id,
+                               XCB_CW_BACK_PIXEL | XCB_CW_BORDER_PIXEL, wa);
                }
        bar_update();
 }
@@ -1963,29 +1968,32 @@ drain_enter_notify(void)
 void
 set_win_state(struct ws_win *win, long state)
 {
-       long                    data[] = {state, None};
+       long                    data[] = {state, XCB_ATOM_NONE};
 
        DNPRINTF(SWM_D_EVENT, "set_win_state: window: 0x%lx\n", win->id);
 
        if (win == NULL)
                return;
 
-       XChangeProperty(display, win->id, astate, astate, 32, PropModeReplace,
-           (unsigned char *)data, 2);
+       xcb_change_property(conn, XCB_PROP_MODE_REPLACE, win->id, astate,
+               astate, 32, 2, data);
 }
 
 long
 getstate(xcb_window_t w)
 {
-       long                    result = -1;
-       unsigned char           *p = NULL;
-       unsigned long           n;
+       long                            result = -1;
+       xcb_get_property_cookie_t       c;
+       xcb_get_property_reply_t        *r;
 
-       if (!get_property(w, astate, 2L, astate, &n, NULL, &p))
-               return (-1);
-       if (n != 0)
-               result = *((long *)p);
-       XFree(p);
+       c = xcb_get_property(conn, False, w, astate, astate, 0L, 2L);
+       r = xcb_get_property_reply(conn, c, NULL);
+
+       if (r) {
+               result = *((long *)xcb_get_property_value(r));
+               free(r);
+       }
+       
        return (result);
 }
 
@@ -2199,7 +2207,6 @@ restart(struct swm_region *r, union arg *args)
        bar_extra_stop();
        bar_extra = 1;
        unmap_all();
-       xcb_disconnect(conn);
        XCloseDisplay(display);
        execvp(start_argv[0], start_argv);
        warn("execvp failed");
@@ -4155,23 +4162,23 @@ constrain_window(struct ws_win *win, struct swm_region *r, int resizable)
 void
 update_window(struct ws_win *win)
 {
-       unsigned int            mask;
-       XWindowChanges          wc;
-
-       bzero(&wc, sizeof wc);
-       mask = CWBorderWidth | CWWidth | CWHeight | CWX | CWY;
+       uint16_t        mask;
+       uint32_t        wc[5];
 
-       wc.border_width = BORDER(win);
-       wc.x = X(win);
-       wc.y = Y(win);
-       wc.width = WIDTH(win);
-       wc.height = HEIGHT(win);
+       mask = XCB_CONFIG_WINDOW_X | XCB_CONFIG_WINDOW_Y |
+               XCB_CONFIG_WINDOW_WIDTH | XCB_CONFIG_WINDOW_HEIGHT |
+               XCB_CONFIG_WINDOW_BORDER_WIDTH; 
+       wc[0] = X(win);
+       wc[1] = Y(win);
+       wc[2] = WIDTH(win);
+       wc[3] = HEIGHT(win);
+       wc[4] = BORDER(win);
 
-       DNPRINTF(SWM_D_EVENT, "update_window: window: 0x%lx, (x,y) w x h: "
-           "(%d,%d) %d x %d, bordered: %s\n", win->id, wc.x, wc.y, wc.width,
-           wc.height, YESNO(win->bordered));
+       DNPRINTF(SWM_D_EVENT, "update_window: window: 0x%x, (x,y) w x h: "
+           "(%d,%d) %d x %d, bordered: %s\n", win->id, wc[0], wc[1], wc[2],
+           wc[3], YESNO(win->bordered));
 
-       XConfigureWindow(display, win->id, mask, &wc);
+       xcb_configure_window(conn, win->id, mask, wc);
 }
 
 #define SWM_RESIZE_STEPS       (50)
@@ -5395,7 +5402,8 @@ grabkeys(void)
        for (k = 0; k < num_screens; k++) {
                if (TAILQ_EMPTY(&screens[k].rl))
                        continue;
-               XUngrabKey(display, AnyKey, AnyModifier, screens[k].root);
+               xcb_ungrab_key(conn, XCB_GRAB_ANY, screens[k].root,
+                       XCB_MOD_MASK_ANY); 
                RB_FOREACH(kp, key_tree, &keys) {
                        if ((code = XKeysymToKeycode(display, kp->keysym)))
                                for (j = 0; j < LENGTH(modifiers); j++)
@@ -6200,17 +6208,11 @@ window_get_pid(Window win)
        long                            ret = 0;
        const char                      *errstr;
        xcb_atom_t                      apid;
-       xcb_intern_atom_cookie_t        c;
-       xcb_intern_atom_reply_t         *r;
        xcb_get_property_cookie_t       pc;
-       xcb_get_property_reply_t        *pr;    
+       xcb_get_property_reply_t        *pr;
 
-       c = xcb_intern_atom(conn, False, strlen("_NET_WM_PID"), "_NET_WM_PID");
-       r = xcb_intern_atom_reply(conn, c, NULL);
-       if (r) {
-               apid = r->atom;
-               free(r);
-       } else
+       apid = get_atom_from_string("_NET_WM_PID");
+       if (apid == XCB_ATOM_NONE)
                goto tryharder;
 
        pc = xcb_get_property(conn, False, win, apid, XCB_ATOM_CARDINAL, 0, 1);
@@ -6226,12 +6228,7 @@ window_get_pid(Window win)
        return (ret);
 
 tryharder:
-       c = xcb_intern_atom(conn, False, strlen("_SWM_PID"), "_SWM_PID");
-       r = xcb_intern_atom_reply(conn, c, NULL);
-       if (r) {
-               apid = r->atom;
-               free(r);
-       }
+       apid = get_atom_from_string("_SWM_PID");
        pc = xcb_get_property(conn, False, win, apid, XCB_ATOM_STRING,
                0, SWM_PROPLEN);
        pr = xcb_get_property_reply(conn, pc, NULL);
@@ -7223,13 +7220,16 @@ void
 scan_xrandr(int i)
 {
 #ifdef SWM_XRR_HAS_CRTC
-       XRRCrtcInfo             *ci;
-       XRRScreenResources      *sr;
        int                     c;
        int                     ncrtc = 0;
 #endif /* SWM_XRR_HAS_CRTC */
        struct swm_region       *r;
        int                     num_screens;
+       xcb_randr_get_screen_resources_cookie_t src;
+       xcb_randr_get_screen_resources_reply_t  *srr;
+       xcb_randr_get_crtc_info_cookie_t        cic;
+       xcb_randr_get_crtc_info_reply_t         *cir;   
+       xcb_randr_crtc_t        *crtc;
 
        num_screens = xcb_setup_roots_length(xcb_get_setup(conn));
        if (i >= num_screens)
@@ -7247,30 +7247,34 @@ scan_xrandr(int i)
        /* map virtual screens onto physical screens */
 #ifdef SWM_XRR_HAS_CRTC
        if (xrandr_support) {
-               sr = XRRGetScreenResourcesCurrent(display, screens[i].root);
-               if (sr == NULL)
+               src = xcb_randr_get_screen_resources(conn, screens[i].root);
+               srr = xcb_randr_get_screen_resources_reply(conn, src, NULL);
+               if (srr == NULL)
                        new_region(&screens[i], 0, 0,
                            DisplayWidth(display, i),
                            DisplayHeight(display, i));
                else
-                       ncrtc = sr->ncrtc;
-
-               for (c = 0, ci = NULL; c < ncrtc; c++) {
-                       ci = XRRGetCrtcInfo(display, sr, sr->crtcs[c]);
-                       if (ci->noutput == 0)
+                       ncrtc = srr->num_crtcs; 
+               for (c = 0; c < ncrtc; c++) {
+                       crtc = xcb_randr_get_screen_resources_crtcs(srr);
+                       cic = xcb_randr_get_crtc_info(conn, crtc[c],
+                               XCB_CURRENT_TIME);                      
+                       cir = xcb_randr_get_crtc_info_reply(conn, cic, NULL);
+                       if (cir && cir->num_outputs == 0)
                                continue;
 
-                       if (ci != NULL && ci->mode == None)
+                       if (cir == NULL || cir->mode == 0)
                                new_region(&screens[i], 0, 0,
                                    DisplayWidth(display, i),
                                    DisplayHeight(display, i));
                        else
                                new_region(&screens[i],
-                                   ci->x, ci->y, ci->width, ci->height);
+                                   cir->x, cir->y, cir->width, cir->height);
                }
-               if (ci)
-                       XRRFreeCrtcInfo(ci);
-               XRRFreeScreenResources(sr);
+               if (srr)
+                       free(srr);
+               if (cir)
+                       free(cir);      
        } else
 #endif /* SWM_XRR_HAS_CRTC */
        {
@@ -7280,7 +7284,8 @@ scan_xrandr(int i)
 }
 
 void
-screenchange(XEvent *e) {
+screenchange(XEvent *e)
+{
        XRRScreenChangeNotifyEvent      *xe = (XRRScreenChangeNotifyEvent *)e;
        struct swm_region               *r;
        int                             i, num_screens;
@@ -7360,9 +7365,11 @@ void
 setup_screens(void)
 {
        int                     i, j, k, num_screens;
-       int                     errorbase, major, minor;
+       int                     errorbase;
        struct workspace        *ws;
        XGCValues               gcv;
+       xcb_randr_query_version_cookie_t        c;
+       xcb_randr_query_version_reply_t         *r;
 
        num_screens = xcb_setup_roots_length(xcb_get_setup(conn));
        if ((screens = calloc(num_screens,
@@ -7373,9 +7380,16 @@ setup_screens(void)
        /* initial Xrandr setup */
        xrandr_support = XRRQueryExtension(display,
            &xrandr_eventbase, &errorbase);
-       if (xrandr_support)
-               if (XRRQueryVersion(display, &major, &minor) && major < 1)
+       if (xrandr_support) {
+               c = xcb_randr_query_version(conn, True, False);
+               r = xcb_randr_query_version_reply(conn, c, NULL);
+               if (r) {
+                       if (r->major_version < 1)
+                               xrandr_support = 0;
+                       free(r);
+               } else
                        xrandr_support = 0;
+       }
 
        /* map physical screens */
        for (i = 0; i < num_screens; i++) {
@@ -7424,8 +7438,8 @@ setup_screens(void)
                scan_xrandr(i);
 
                if (xrandr_support)
-                       XRRSelectInput(display, screens[i].root,
-                           RRScreenChangeNotifyMask);
+                       xcb_randr_select_input(conn, screens[i].root,
+                               XCB_RANDR_NOTIFY_MASK_SCREEN_CHANGE);
        }
 }
 
@@ -7513,15 +7527,15 @@ main(int argc, char *argv[])
        sact.sa_flags = SA_NOCLDSTOP;
        sigaction(SIGCHLD, &sact, NULL);
 
-       astate = XInternAtom(display, "WM_STATE", False);
-       aprot = XInternAtom(display, "WM_PROTOCOLS", False);
-       adelete = XInternAtom(display, "WM_DELETE_WINDOW", False);
-       takefocus = XInternAtom(display, "WM_TAKE_FOCUS", False);
-       a_wmname = XInternAtom(display, "WM_NAME", False);
-       a_netwmname = XInternAtom(display, "_NET_WM_NAME", False);
-       a_utf8_string = XInternAtom(display, "UTF8_STRING", False);
-       a_string = XInternAtom(display, "STRING", False);
-       a_swm_iconic = XInternAtom(display, "_SWM_ICONIC", False);
+       astate = get_atom_from_string("WM_STATE");
+       aprot = get_atom_from_string("WM_PROTOCOLS");
+       adelete = get_atom_from_string("WM_DELETE_WINDOW");
+       takefocus = get_atom_from_string("WM_TAKE_FOCUS");
+       a_wmname = get_atom_from_string("WM_NAME");
+       a_netwmname = get_atom_from_string("_NET_WM_NAME");
+       a_utf8_string = get_atom_from_string("UTF8_STRING");
+       a_string = get_atom_from_string("STRING");
+       a_swm_iconic = get_atom_from_string("_SWM_ICONIC");
 
        /* look for local and global conf file */
        pwd = getpwuid(getuid());