X-Git-Url: https://jasonwoof.com/gitweb/?a=blobdiff_plain;f=_source%2Fplugins%2Fdialogadvtab%2Fplugin.js;h=3642e5caf49cd560b646486dadbafc6bbb34ccef;hb=039a051ccf3901311661022a30afd60fc38130c9;hp=434911c4dc34f09488959eb4d900465a29c255a4;hpb=e371ddf8abcb89013e20e6d0dd746adec344d0e5;p=ckeditor.git

diff --git a/_source/plugins/dialogadvtab/plugin.js b/_source/plugins/dialogadvtab/plugin.js
index 434911c..3642e5c 100644
--- a/_source/plugins/dialogadvtab/plugin.js
+++ b/_source/plugins/dialogadvtab/plugin.js
@@ -36,6 +36,14 @@ function commitAdvParams()
 		var attrName = this.att,
 			value = this.getValue();
 
+		// Broadcast Lang Dir change
+		if ( attrName == 'dir' )
+		{
+			var dir = element.getAttribute( attrName, value );
+			if ( dir != value && element.getParent() )
+					this._.dialog._.editor.fire( 'dirChanged', element );
+		}
+
 		if ( value )
 			element.setAttribute( attrName, value );
 		else
@@ -43,8 +51,6 @@ function commitAdvParams()
 	}
 }
 
-var isUpdating;
-
 CKEDITOR.plugins.add( 'dialogadvtab',
 {
 	/**
@@ -62,8 +68,8 @@ CKEDITOR.plugins.add( 'dialogadvtab',
 		var result =
 		{
 			id : 'advanced',
-			label : lang.advanced,
-			title : lang.advanced,
+			label : lang.advancedTab,
+			title : lang.advancedTab,
 			elements :
 				[
 					{
@@ -100,7 +106,7 @@ CKEDITOR.plugins.add( 'dialogadvtab',
 						type : 'select',
 						label : lang.langDir,
 						'default' : '',
-						style : 'width:110px',
+						style : 'width:100%',
 						items :
 						[
 							[ lang.notSet, '' ],
@@ -124,7 +130,7 @@ CKEDITOR.plugins.add( 'dialogadvtab',
 		{
 			contents = [];
 
-			if ( tabConfig.id )
+			if ( tabConfig.styles )
 			{
 				contents.push(
 					{
@@ -134,8 +140,6 @@ CKEDITOR.plugins.add( 'dialogadvtab',
 						label : lang.styles,
 						'default' : '',
 
-						onChange : function(){},
-
 						getStyle : function( name, defaultValue )
 						{
 							var match = this.getValue().match( new RegExp( name + '\\s*:\s*([^;]*)', 'i') );
@@ -144,12 +148,6 @@ CKEDITOR.plugins.add( 'dialogadvtab',
 
 						updateStyle : function( name, value )
 						{
-							if ( isUpdating )
-								return;
-
-							// Flag to avoid recursion.
-							isUpdating = 1;
-
 							var styles = this.getValue();
 
 							// Remove the current value.
@@ -167,9 +165,8 @@ CKEDITOR.plugins.add( 'dialogadvtab',
 								styles += name + ': ' + value;
 							}
 
-							this.setValue( styles );
+							this.setValue( styles, 1 );
 
-							isUpdating = 0;
 						},
 
 						setup : setupAdvParams,