X-Git-Url: https://jasonwoof.com/gitweb/?a=blobdiff_plain;f=dwm.c;h=3650ccdb8afc200f381c0256e571b6d47c51a639;hb=a785a0d71213c2ab628778727c4354ad5bb517fb;hp=a77f4c8ec8b4f73eda9084745de291f5d3db1b61;hpb=7f70d90219c4a33c79ff93b49fb24ee7a6f62b4d;p=dwm.git diff --git a/dwm.c b/dwm.c index a77f4c8..3650ccd 100644 --- a/dwm.c +++ b/dwm.c @@ -41,21 +41,13 @@ #include /* macros */ -#define MAX(a, b) ((a)>(b)?(a):(b)) -#define MIN(a, b) ((a)<(b)?(a):(b)) -#define BUTTONMASK (ButtonPressMask|ButtonReleaseMask) -#define CLEANMASK(mask) (mask & ~(numlockmask|LockMask)) -#define LENGTH(x) (sizeof x / sizeof x[0]) -#define MAXTAGLEN 16 -#define MOUSEMASK (BUTTONMASK|PointerMotionMask) -#define DEFGEOM(GEONAME,BX,BY,BW,WX,WY,WW,WH,MX,MY,MW,MH,TX,TY,TW,TH,MOX,MOY,MOW,MOH) \ -void GEONAME(void) { \ - bx = (BX); by = (BY); bw = (BW); \ - wx = (WX); wy = (WY); ww = (WW); wh = (WH); \ - mx = (MX); my = (MY); mw = (MW); mh = (MH); \ - tx = (TX); ty = (TY); tw = (TW); th = (TH); \ - mox = (MOX); moy = (MOY); mow = (MOW); moh = (MOH); \ -} +#define MAX(a, b) ((a) > (b) ? (a) : (b)) +#define MIN(a, b) ((a) < (b) ? (a) : (b)) +#define BUTTONMASK (ButtonPressMask|ButtonReleaseMask) +#define CLEANMASK(mask) (mask & ~(numlockmask|LockMask)) +#define LENGTH(x) (sizeof x / sizeof x[0]) +#define MAXTAGLEN 16 +#define MOUSEMASK (BUTTONMASK|PointerMotionMask) /* enums */ enum { CurNormal, CurResize, CurMove, CurLast }; /* cursor */ @@ -68,7 +60,6 @@ typedef struct Client Client; struct Client { char name[256]; int x, y, w, h; - int fx, fy, fw, fh; int basew, baseh, incw, inch, maxw, maxh, minw, minh; int minax, maxax, minay, maxay; long flags; @@ -97,11 +88,6 @@ typedef struct { } DC; /* draw context */ typedef struct { - const char *symbol; - void (*apply)(void); -} Geom; - -typedef struct { unsigned long mod; KeySym keysym; void (*func)(const char *arg); @@ -111,8 +97,7 @@ typedef struct { typedef struct { const char *symbol; void (*arrange)(void); - Bool isfloating; -} Layout; +} Layout; typedef struct { const char *class; @@ -160,7 +145,7 @@ void initfont(const char *fontstr); Bool isoccupied(unsigned int t); Bool isprotodel(Client *c); Bool isurgent(unsigned int t); -Bool isvisible(Client *c); +Bool isvisible(Client *c, Bool *cmp); void keypress(XEvent *e); void killclient(const char *arg); void manage(Window w, XWindowAttributes *wa); @@ -171,15 +156,12 @@ void movemouse(Client *c); Client *nexttiled(Client *c); void propertynotify(XEvent *e); void quit(const char *arg); -void reapply(const char *arg); void resize(Client *c, int x, int y, int w, int h, Bool sizehints); void resizemouse(Client *c); void restack(void); void run(void); void scan(void); void setclientstate(Client *c, long state); -void setgeom(const char *arg); -void setlayout(const char *arg); void setmfact(const char *arg); void setup(void); void spawn(const char *arg); @@ -193,12 +175,14 @@ void tileresize(Client *c, int x, int y, int w, int h); void tilev(void); void tilevstack(unsigned int n); void togglefloating(const char *arg); +void togglelayout(const char *arg); void toggletag(const char *arg); void toggleview(const char *arg); void unban(Client *c); void unmanage(Client *c); void unmapnotify(XEvent *e); -void updatebarpos(void); +void updatebar(void); +void updategeom(void); void updatesizehints(Client *c); void updatetitle(Client *c); void updatewmhints(Client *c); @@ -213,8 +197,8 @@ void zoom(const char *arg); char stext[256]; int screen, sx, sy, sw, sh; int (*xerrorxlib)(Display *, XErrorEvent *); -int bx, by, bw, bh, blw, bgw, mx, my, mw, mh, mox, moy, mow, moh, tx, ty, tw, th, wx, wy, ww, wh; -int viewtags_set = 0; +int bx, by, bw, bh, blw, mx, my, mw, mh, tx, ty, tw, th, wx, wy, ww, wh; +int seltags = 0; double mfact; unsigned int numlockmask = 0; void (*handler[LASTEvent]) (XEvent *) = { @@ -234,21 +218,20 @@ void (*handler[LASTEvent]) (XEvent *) = { Atom wmatom[WMLast], netatom[NetLast]; Bool otherwm, readin; Bool running = True; -Bool *seltags; -Bool *viewtags[2]; +Bool *tagset[2]; Client *clients = NULL; Client *sel = NULL; Client *stack = NULL; Cursor cursor[CurLast]; Display *dpy; DC dc = {0}; +Layout layouts[]; +Layout *lt = layouts; Window root, barwin; /* configuration, allows nested code to access above variables */ #include "config.h" #define TAGSZ (LENGTH(tags) * sizeof(Bool)) -Layout *lt = layouts; -Geom *geom = geoms; /* function implementations */ @@ -278,7 +261,7 @@ applyrules(Client *c) { if(ch.res_name) XFree(ch.res_name); if(!matched) - memcpy(c->tags, seltags, TAGSZ); + memcpy(c->tags, tagset[seltags], TAGSZ); } void @@ -286,10 +269,10 @@ arrange(void) { Client *c; for(c = clients; c; c = c->next) - if(isvisible(c)) { + if(isvisible(c, NULL)) { unban(c); - if(lt->isfloating || c->isfloating) - resize(c, c->fx, c->fy, c->fw, c->fh, True); + if(!lt->arrange || c->isfloating) + resize(c, c->x, c->y, c->w, c->h, True); } else ban(c); @@ -329,14 +312,10 @@ buttonpress(XEvent *e) { XButtonPressedEvent *ev = &e->xbutton; if(ev->window == barwin) { - if((ev->x < bgw) && ev->button == Button1) { - setgeom(NULL); - return; - } - x = bgw; + x = 0; for(i = 0; i < LENGTH(tags); i++) { x += textw(tags[i]); - if(ev->x >= bgw && ev->x < x) { + if(ev->x < x) { if(ev->button == Button1) { if(ev->state & MODKEY) tag(tags[i]); @@ -353,7 +332,7 @@ buttonpress(XEvent *e) { } } if((ev->x < x + blw) && ev->button == Button1) - setlayout(NULL); + togglelayout(NULL); } else if((c = getclient(ev->window))) { focus(c); @@ -364,7 +343,7 @@ buttonpress(XEvent *e) { movemouse(c); } else if(ev->button == Button2) { - if(!lt->isfloating && c->isfloating) + if(lt->arrange && c->isfloating) togglefloating(NULL); else zoom(NULL); @@ -439,7 +418,9 @@ configurenotify(XEvent *e) { if(ev->window == root && (ev->width != sw || ev->height != sh)) { sw = ev->width; sh = ev->height; - setgeom(geom->symbol); + updategeom(); + updatebar(); + arrange(); } } @@ -452,7 +433,7 @@ configurerequest(XEvent *e) { if((c = getclient(ev->window))) { if(ev->value_mask & CWBorderWidth) c->bw = ev->border_width; - if(c->isfixed || c->isfloating || lt->isfloating) { + if(c->isfixed || c->isfloating || !lt->arrange) { if(ev->value_mask & CWX) c->x = sx + ev->x; if(ev->value_mask & CWY) @@ -468,7 +449,7 @@ configurerequest(XEvent *e) { if((ev->value_mask & (CWX|CWY)) && !(ev->value_mask & (CWWidth|CWHeight))) configure(c); - if(isvisible(c)) + if(isvisible(c, NULL)) XMoveResizeWindow(dpy, c->win, c->x, c->y, c->w, c->h); } else @@ -520,7 +501,7 @@ void detachstack(Client *c) { Client **tc; - for(tc=&stack; *tc && *tc != c; tc=&(*tc)->snext); + for(tc = &stack; *tc && *tc != c; tc = &(*tc)->snext); *tc = c->snext; } @@ -530,15 +511,10 @@ drawbar(void) { Client *c; dc.x = 0; - if(bgw > 0) { - dc.w = bgw; - drawtext(geom->symbol, dc.norm, False); - dc.x += bgw; - } - for(c = stack; c && !isvisible(c); c = c->snext); + for(c = stack; c && !isvisible(c, NULL); c = c->snext); for(i = 0; i < LENGTH(tags); i++) { dc.w = textw(tags[i]); - if(seltags[i]) { + if(tagset[seltags][i]) { drawtext(tags[i], dc.sel, isurgent(i)); drawsquare(c && c->tags[i], isoccupied(i), isurgent(i), dc.sel); } @@ -616,7 +592,7 @@ drawtext(const char *text, unsigned long col[ColLast], Bool invert) { x = dc.x + (h / 2); /* shorten text if necessary */ for(; len && (w = textnw(buf, len)) > dc.w - h; len--); - if (!len) + if(!len) return; if(len < olen) { if(len > 1) @@ -675,8 +651,8 @@ expose(XEvent *e) { void focus(Client *c) { - if(!c || (c && !isvisible(c))) - for(c = stack; c && !isvisible(c); c = c->snext); + if(!c || (c && !isvisible(c, NULL))) + for(c = stack; c && !isvisible(c, NULL); c = c->snext); if(sel && sel != c) { grabbuttons(sel, False); XSetWindowBorder(dpy, sel->win, dc.norm[ColBorder]); @@ -710,9 +686,9 @@ focusnext(const char *arg) { if(!sel) return; - for(c = sel->next; c && !isvisible(c); c = c->next); + for(c = sel->next; c && !isvisible(c, arg ? sel->tags : NULL); c = c->next); if(!c) - for(c = clients; c && !isvisible(c); c = c->next); + for(c = clients; c && !isvisible(c, arg ? sel->tags : NULL); c = c->next); if(c) { focus(c); restack(); @@ -725,10 +701,10 @@ focusprev(const char *arg) { if(!sel) return; - for(c = sel->prev; c && !isvisible(c); c = c->prev); + for(c = sel->prev; c && !isvisible(c, arg ? sel->tags : NULL); c = c->prev); if(!c) { for(c = clients; c && c->next; c = c->next); - for(; c && !isvisible(c); c = c->prev); + for(; c && !isvisible(c, arg ? sel->tags : NULL); c = c->prev); } if(c) { focus(c); @@ -803,21 +779,21 @@ grabbuttons(Client *c, Bool focused) { int i, j; unsigned int buttons[] = { Button1, Button2, Button3 }; unsigned int modifiers[] = { MODKEY, MODKEY|LockMask, MODKEY|numlockmask, - MODKEY|numlockmask|LockMask} ; + MODKEY|numlockmask|LockMask} ; XUngrabButton(dpy, AnyButton, AnyModifier, c->win); if(focused) for(i = 0; i < LENGTH(buttons); i++) for(j = 0; j < LENGTH(modifiers); j++) XGrabButton(dpy, buttons[i], modifiers[j], c->win, False, - BUTTONMASK, GrabModeAsync, GrabModeSync, None, None); + BUTTONMASK, GrabModeAsync, GrabModeSync, None, None); else XGrabButton(dpy, AnyButton, AnyModifier, c->win, False, - BUTTONMASK, GrabModeAsync, GrabModeSync, None, None); + BUTTONMASK, GrabModeAsync, GrabModeSync, None, None); } void -grabkeys(void) { +grabkeys(void) { unsigned int i, j; KeyCode code; XModifierKeymap *modmap; @@ -929,11 +905,13 @@ isurgent(unsigned int t) { } Bool -isvisible(Client *c) { +isvisible(Client *c, Bool *cmp) { unsigned int i; + if(!cmp) + cmp = tagset[seltags]; for(i = 0; i < LENGTH(tags); i++) - if(c->tags[i] && seltags[i]) + if(c->tags[i] && cmp[i]) return True; return False; } @@ -988,8 +966,8 @@ manage(Window w, XWindowAttributes *wa) { /* geometry */ c->x = wa->x; c->y = wa->y; - c->w = c->fw = wa->width; - c->h = c->fh = wa->height; + c->w = wa->width; + c->h = wa->height; c->oldbw = wa->border_width; if(c->w == sw && c->h == sh) { c->x = sx; @@ -1005,8 +983,6 @@ manage(Window w, XWindowAttributes *wa) { c->y = MAX(c->y, wy); c->bw = BORDERPX; } - c->fx = c->x; - c->fy = c->y; wc.border_width = c->bw; XConfigureWindow(dpy, w, CWBorderWidth, &wc); @@ -1060,8 +1036,8 @@ monocle(void) { Client *c; for(c = clients; c; c = c->next) - if((lt->isfloating || !c->isfloating) && isvisible(c)) - resize(c, mox, moy, mow - 2 * c->bw, moh - 2 * c->bw, RESIZEHINTS); + if(!c->isfloating && isvisible(c, NULL)) + resize(c, wx, wy, ww - 2 * c->bw, wh - 2 * c->bw, RESIZEHINTS); } void @@ -1074,7 +1050,7 @@ movemouse(Client *c) { ocx = nx = c->x; ocy = ny = c->y; if(XGrabPointer(dpy, root, False, MOUSEMASK, GrabModeAsync, GrabModeAsync, - None, cursor[CurMove], CurrentTime) != GrabSuccess) + None, cursor[CurMove], CurrentTime) != GrabSuccess) return; XQueryPointer(dpy, root, &dummy, &dummy, &x1, &y1, &di, &di, &dui); for(;;) { @@ -1100,13 +1076,10 @@ movemouse(Client *c) { ny = wy; else if(abs((wy + wh) - (ny + c->h + 2 * c->bw)) < SNAP) ny = wy + wh - c->h - 2 * c->bw; - if(!c->isfloating && !lt->isfloating && (abs(nx - c->x) > SNAP || abs(ny - c->y) > SNAP)) + if(!c->isfloating && lt->arrange && (abs(nx - c->x) > SNAP || abs(ny - c->y) > SNAP)) togglefloating(NULL); - if(lt->isfloating || c->isfloating) { - c->fx = nx; - c->fy = ny; + if(!lt->arrange || c->isfloating) resize(c, nx, ny, c->w, c->h, False); - } break; } } @@ -1114,7 +1087,7 @@ movemouse(Client *c) { Client * nexttiled(Client *c) { - for(; c && (c->isfloating || !isvisible(c)); c = c->next); + for(; c && (c->isfloating || !isvisible(c, NULL)); c = c->next); return c; } @@ -1156,17 +1129,6 @@ quit(const char *arg) { } void -reapply(const char *arg) { - Client *c; - - for(c = clients; c; c = c->next) { - memset(c->tags, 0, TAGSZ); - applyrules(c); - } - arrange(); -} - -void resize(Client *c, int x, int y, int w, int h, Bool sizehints) { XWindowChanges wc; @@ -1181,8 +1143,7 @@ resize(Client *c, int x, int y, int w, int h, Bool sizehints) { /* adjust for aspect limits */ if(c->minax != c->maxax && c->minay != c->maxay - && c->minax > 0 && c->maxax > 0 && c->minay > 0 && c->maxay > 0) - { + && c->minax > 0 && c->maxax > 0 && c->minay > 0 && c->maxay > 0) { if(w * c->maxay > h * c->maxax) w = h * c->maxax / c->maxay; else if(w * c->minay < h * c->minax) @@ -1240,7 +1201,7 @@ resizemouse(Client *c) { ocx = c->x; ocy = c->y; if(XGrabPointer(dpy, root, False, MOUSEMASK, GrabModeAsync, GrabModeAsync, - None, cursor[CurResize], CurrentTime) != GrabSuccess) + None, cursor[CurResize], CurrentTime) != GrabSuccess) return; XWarpPointer(dpy, None, c->win, 0, 0, 0, 0, c->w + c->bw - 1, c->h + c->bw - 1); for(;;) { @@ -1261,16 +1222,11 @@ resizemouse(Client *c) { XSync(dpy, False); nw = MAX(ev.xmotion.x - ocx - 2 * c->bw + 1, 1); nh = MAX(ev.xmotion.y - ocy - 2 * c->bw + 1, 1); - if(!c->isfloating && !lt->isfloating && (abs(nw - c->w) > SNAP || abs(nh - c->h) > SNAP)) { - c->fx = c->x; - c->fy = c->y; + if(!c->isfloating && lt->arrange && (abs(nw - c->w) > SNAP || abs(nh - c->h) > SNAP)) { togglefloating(NULL); } - if((lt->isfloating) || c->isfloating) { + if(!lt->arrange || c->isfloating) resize(c, c->x, c->y, nw, nh, True); - c->fw = nw; - c->fh = nh; - } break; } } @@ -1285,13 +1241,13 @@ restack(void) { drawbar(); if(!sel) return; - if(sel->isfloating || lt->isfloating) + if(sel->isfloating || !lt->arrange) XRaiseWindow(dpy, sel->win); - if(!lt->isfloating) { + if(lt->arrange) { wc.stack_mode = Below; wc.sibling = barwin; for(c = stack; c; c = c->snext) - if(!c->isfloating && isvisible(c)) { + if(!c->isfloating && isvisible(c, NULL)) { XConfigureWindow(dpy, c->win, CWSibling|CWStackMode, &wc); wc.sibling = c->win; } @@ -1370,7 +1326,7 @@ scan(void) { if(XQueryTree(dpy, root, &d1, &d2, &wins, &num)) { for(i = 0; i < num; i++) { if(!XGetWindowAttributes(dpy, wins[i], &wa) - || wa.override_redirect || XGetTransientForHint(dpy, wins[i], &d1)) + || wa.override_redirect || XGetTransientForHint(dpy, wins[i], &d1)) continue; if(wa.map_state == IsViewable || getstate(wins[i]) == IconicState) manage(wins[i], &wa); @@ -1379,7 +1335,7 @@ scan(void) { if(!XGetWindowAttributes(dpy, wins[i], &wa)) continue; if(XGetTransientForHint(dpy, wins[i], &d1) - && (wa.map_state == IsViewable || getstate(wins[i]) == IconicState)) + && (wa.map_state == IsViewable || getstate(wins[i]) == IconicState)) manage(wins[i], &wa); } } @@ -1395,54 +1351,12 @@ setclientstate(Client *c, long state) { PropModeReplace, (unsigned char *)data, 2); } -void -setgeom(const char *arg) { - unsigned int i; - - if(!arg) { - if(++geom == &geoms[LENGTH(geoms)]) - geom = &geoms[0]; - } - else { - for(i = 0; i < LENGTH(geoms); i++) - if(!strcmp(geoms[i].symbol, arg)) - break; - if(i == LENGTH(geoms)) - return; - geom = &geoms[i]; - } - geom->apply(); - updatebarpos(); - arrange(); -} - -void -setlayout(const char *arg) { - unsigned int i; - - if(!arg) { - if(++lt == &layouts[LENGTH(layouts)]) - lt = &layouts[0]; - } - else { - for(i = 0; i < LENGTH(layouts); i++) - if(!strcmp(arg, layouts[i].symbol)) - break; - if(i == LENGTH(layouts)) - return; - lt = &layouts[i]; - } - if(sel) - arrange(); - else - drawbar(); -} - +/* TODO: move this into tile.c */ void setmfact(const char *arg) { double d; - if(lt->isfloating) + if(!lt->arrange) /* TODO: check this against the actual tile() function */ return; if(!arg) mfact = MFACT; @@ -1454,7 +1368,8 @@ setmfact(const char *arg) { return; mfact = d; } - setgeom(geom->symbol); + updategeom(); + arrange(); } void @@ -1466,15 +1381,13 @@ setup(void) { screen = DefaultScreen(dpy); root = RootWindow(dpy, screen); initfont(FONT); - - /* apply default geometry */ sx = 0; sy = 0; sw = DisplayWidth(dpy, screen); sh = DisplayHeight(dpy, screen); bh = dc.font.height + 2; mfact = MFACT; - geom->apply(); + updategeom(); /* init atoms */ wmatom[WMProtocols] = XInternAtom(dpy, "WM_PROTOCOLS", False); @@ -1505,28 +1418,23 @@ setup(void) { XSetFont(dpy, dc.gc, dc.font.xfont->fid); /* init tags */ - viewtags[0] = emallocz(TAGSZ); - viewtags[1] = emallocz(TAGSZ); - viewtags[0][0] = viewtags[1][0] = True; - seltags = viewtags[0]; + tagset[0] = emallocz(TAGSZ); + tagset[1] = emallocz(TAGSZ); + tagset[0][0] = tagset[1][0] = True; /* init bar */ for(blw = i = 0; LENGTH(layouts) > 1 && i < LENGTH(layouts); i++) { w = textw(layouts[i].symbol); blw = MAX(blw, w); } - for(bgw = i = 0; LENGTH(geoms) > 1 && i < LENGTH(geoms); i++) { - w = textw(geoms[i].symbol); - bgw = MAX(bgw, w); - } wa.override_redirect = 1; wa.background_pixmap = ParentRelative; wa.event_mask = ButtonPressMask|ExposureMask; barwin = XCreateWindow(dpy, root, bx, by, bw, bh, 0, DefaultDepth(dpy, screen), - CopyFromParent, DefaultVisual(dpy, screen), - CWOverrideRedirect|CWBackPixmap|CWEventMask, &wa); + CopyFromParent, DefaultVisual(dpy, screen), + CWOverrideRedirect|CWBackPixmap|CWEventMask, &wa); XDefineCursor(dpy, barwin, cursor[CurNormal]); XMapRaised(dpy, barwin); strcpy(stext, "dwm-"VERSION); @@ -1578,7 +1486,7 @@ tag(const char *arg) { if(!sel) return; for(i = 0; i < LENGTH(tags); i++) - sel->tags[i] = (NULL == arg); + sel->tags[i] = (arg == NULL); sel->tags[idxoftag(arg)] = True; arrange(); } @@ -1631,7 +1539,7 @@ tilemaster(unsigned int n) { Client *c = nexttiled(clients); if(n == 1) - tileresize(c, mox, moy, mow - 2 * c->bw, moh - 2 * c->bw); + tileresize(c, wx, wy, ww - 2 * c->bw, wh - 2 * c->bw); else tileresize(c, mx, my, mw - 2 * c->bw, mh - 2 * c->bw); return c; @@ -1683,6 +1591,28 @@ togglefloating(const char *arg) { } void +togglelayout(const char *arg) { + unsigned int i; + + if(!arg) { + if(++lt == &layouts[LENGTH(layouts)]) + lt = &layouts[0]; + } + else { + for(i = 0; i < LENGTH(layouts); i++) + if(!strcmp(arg, layouts[i].symbol)) + break; + if(i == LENGTH(layouts)) + return; + lt = &layouts[i]; + } + if(sel) + arrange(); + else + drawbar(); +} + +void toggletag(const char *arg) { unsigned int i, j; @@ -1701,10 +1631,10 @@ toggleview(const char *arg) { unsigned int i, j; i = idxoftag(arg); - seltags[i] = !seltags[i]; - for(j = 0; j < LENGTH(tags) && !seltags[j]; j++); + tagset[seltags][i] = !tagset[seltags][i]; + for(j = 0; j < LENGTH(tags) && !tagset[seltags][j]; j++); if(j == LENGTH(tags)) - seltags[i] = True; /* at least one tag must be viewed */ + tagset[seltags][i] = True; /* at least one tag must be viewed */ arrange(); } @@ -1749,8 +1679,7 @@ unmapnotify(XEvent *e) { } void -updatebarpos(void) { - +updatebar(void) { if(dc.drawable != 0) XFreePixmap(dpy, dc.drawable); dc.drawable = XCreatePixmap(dpy, root, bw, bh, DefaultDepth(dpy, screen)); @@ -1758,6 +1687,33 @@ updatebarpos(void) { } void +updategeom(void) { + + /* bar geometry */ + bx = 0; + by = 0; + bw = sw; + + /* window area geometry */ + wx = sx; + wy = sy + bh; + ww = sw; + wh = sh - bh; + + /* master area geometry */ + mx = wx; + my = wy; + mw = mfact * ww; + mh = wh; + + /* tile area geometry */ + tx = mx + mw; + ty = wy; + tw = ww - mw; + th = wh; +} + +void updatesizehints(Client *c) { long msize; XSizeHints size; @@ -1830,25 +1786,15 @@ updatewmhints(Client *c) { void view(const char *arg) { - Bool tmp[LENGTH(tags)]; - unsigned int i; - - for(i = 0; i < LENGTH(tags); i++) - tmp[i] = (NULL == arg); - tmp[idxoftag(arg)] = True; - - if(memcmp(seltags, tmp, TAGSZ) != 0) { - seltags = viewtags[viewtags_set ^= 1]; /* toggle tagset */ - memcpy(seltags, tmp, TAGSZ); - arrange(); - } - else - viewprevtag(NULL); + seltags ^= 1; /* toggle sel tagset */ + memset(tagset[seltags], (NULL == arg), TAGSZ); + tagset[seltags][idxoftag(arg)] = True; + arrange(); } void viewprevtag(const char *arg) { - seltags = viewtags[viewtags_set ^= 1]; /* toggle tagset */ + seltags ^= 1; /* toggle sel tagset */ arrange(); } @@ -1863,11 +1809,12 @@ xerror(Display *dpy, XErrorEvent *ee) { || (ee->request_code == X_PolyFillRectangle && ee->error_code == BadDrawable) || (ee->request_code == X_PolySegment && ee->error_code == BadDrawable) || (ee->request_code == X_ConfigureWindow && ee->error_code == BadMatch) + || (ee->request_code == X_GrabButton && ee->error_code == BadAccess) || (ee->request_code == X_GrabKey && ee->error_code == BadAccess) || (ee->request_code == X_CopyArea && ee->error_code == BadDrawable)) return 0; fprintf(stderr, "dwm: fatal error: request code=%d, error code=%d\n", - ee->request_code, ee->error_code); + ee->request_code, ee->error_code); return xerrorxlib(dpy, ee); /* may call exit */ } @@ -1884,6 +1831,7 @@ xerrorstart(Display *dpy, XErrorEvent *ee) { return -1; } +/* TODO: move this into tile.c */ void zoom(const char *arg) { Client *c = sel; @@ -1891,7 +1839,7 @@ zoom(const char *arg) { if(c == nexttiled(clients)) if(!c || !(c = nexttiled(c->next))) return; - if(!lt->isfloating && !sel->isfloating) { + if(lt->arrange && !sel->isfloating) { /* TODO: check this against tile() */ detach(c); attach(c); focus(c); @@ -1919,4 +1867,3 @@ main(int argc, char *argv[]) { XCloseDisplay(dpy); return 0; } -