X-Git-Url: https://jasonwoof.com/gitweb/?a=blobdiff_plain;f=dwm.c;h=79a3a33b66c559a54c657c7dc982abe87161e2d9;hb=954db46bac481fd3f514f7af50d2af7e73fb9115;hp=3d2e660610c0019fa8fa1f20923669075d1f8dc8;hpb=62b18fb9d46caa3d59f4a3ac6b6e5609da9f953f;p=dwm.git

diff --git a/dwm.c b/dwm.c
index 3d2e660..79a3a33 100644
--- a/dwm.c
+++ b/dwm.c
@@ -68,7 +68,7 @@ struct Client {
 	int minax, maxax, minay, maxay;
 	long flags;
 	unsigned int border, oldborder;
-	Bool isbanned, isfixed, isfloating;
+	Bool isbanned, isfixed, isfloating, isurgent;
 	Bool *tags;
 	Client *next;
 	Client *prev;
@@ -146,7 +146,7 @@ void detach(Client *c);
 void detachstack(Client *c);
 void drawbar(void);
 void drawsquare(Monitor *, Bool filled, Bool empty, unsigned long col[ColLast]);
-void drawtext(Monitor *, const char *text, unsigned long col[ColLast]);
+void drawtext(Monitor *, const char *text, unsigned long col[ColLast], Bool invert);
 void *emallocz(unsigned int size);
 void enternotify(XEvent *e);
 void eprint(const char *errstr, ...);
@@ -166,14 +166,15 @@ unsigned int idxoftag(const char *tag);
 void initfont(Monitor*, const char *fontstr);
 Bool isoccupied(Monitor *m, unsigned int t);
 Bool isprotodel(Client *c);
-Bool isvisible(Client *c, Monitor *m);
+Bool isurgent(int monitor, unsigned int t);
+Bool isvisible(Client *c, int monitor);
 void keypress(XEvent *e);
 void killclient(const char *arg);
 void manage(Window w, XWindowAttributes *wa);
 void mappingnotify(XEvent *e);
 void maprequest(XEvent *e);
 void movemouse(Client *c);
-Client *nexttiled(Client *c, Monitor *m);
+Client *nexttiled(Client *c, int monitor);
 void propertynotify(XEvent *e);
 void quit(const char *arg);
 void reapply(const char *arg);
@@ -198,23 +199,23 @@ void toggleview(const char *arg);
 void unban(Client *c);
 void unmanage(Client *c);
 void unmapnotify(XEvent *e);
-void updatebarpos(Monitor *s);
+void updatebarpos(Monitor *m);
 void updatesizehints(Client *c);
 void updatetitle(Client *c);
+void updatewmhints(Client *c);
 void view(const char *arg);
 void viewprevtag(const char *arg);	/* views previous selected tags */
 int xerror(Display *dpy, XErrorEvent *ee);
 int xerrordummy(Display *dsply, XErrorEvent *ee);
 int xerrorstart(Display *dsply, XErrorEvent *ee);
 void zoom(const char *arg);
-int monitorat(int, int);
+int monitorat(void);
 void movetomonitor(const char *arg);
 void selectmonitor(const char *arg);
 
 /* variables */
 char stext[256];
 int mcount = 1;
-//double mwfact;
 int (*xerrorxlib)(Display *, XErrorEvent *);
 unsigned int bh, bpos;
 unsigned int blw = 0;
@@ -234,6 +235,7 @@ void (*handler[LASTEvent]) (XEvent *) = {
 	[UnmapNotify] = unmapnotify
 };
 Atom wmatom[WMLast], netatom[NetLast];
+Bool isxinerama = False;
 Bool domwfact = True;
 Bool dozoom = True;
 Bool otherwm, readin;
@@ -288,9 +290,9 @@ applyrules(Client *c) {
 	if(ch.res_name)
 		XFree(ch.res_name);
 	if(!matched_tag)
-		memcpy(c->tags, monitors[monitorat(-1, -1)].seltags, sizeof initags);
+		memcpy(c->tags, monitors[monitorat()].seltags, sizeof initags);
 	if (!matched_monitor)
-		c->monitor = monitorat(-1, -1);
+		c->monitor = monitorat();
 }
 
 void
@@ -298,7 +300,7 @@ arrange(void) {
 	Client *c;
 
 	for(c = clients; c; c = c->next)
-		if(isvisible(c, &monitors[c->monitor]))
+		if(isvisible(c, c->monitor))
 			unban(c);
 		else
 			ban(c);
@@ -336,12 +338,12 @@ buttonpress(XEvent *e) {
 	Client *c;
 	XButtonPressedEvent *ev = &e->xbutton;
 
-	Monitor s = monitors[monitorat(-1, -1)];
+	Monitor *m = &monitors[monitorat()];
 
-	if(ev->window == s.barwin) {
+	if(ev->window == m->barwin) {
 		x = 0;
 		for(i = 0; i < LENGTH(tags); i++) {
-			x += textw(&s, tags[i]);
+			x += textw(m, tags[i]);
 			if(ev->x < x) {
 				if(ev->button == Button1) {
 					if(ev->state & MODKEY)
@@ -366,23 +368,17 @@ buttonpress(XEvent *e) {
 		if(CLEANMASK(ev->state) != MODKEY)
 			return;
 		if(ev->button == Button1) {
-			if((s.layout->arrange == floating) || c->isfloating)
-				restack();
-			else
-				togglefloating(NULL);
+			restack();
 			movemouse(c);
 		}
 		else if(ev->button == Button2) {
-			if((floating != s.layout->arrange) && c->isfloating)
+			if((floating != m->layout->arrange) && c->isfloating)
 				togglefloating(NULL);
 			else
 				zoom(NULL);
 		}
 		else if(ev->button == Button3 && !c->isfixed) {
-			if((floating == s.layout->arrange) || c->isfloating)
-				restack();
-			else
-				togglefloating(NULL);
+			restack();
 			resizemouse(c);
 		}
 	}
@@ -516,7 +512,7 @@ configurerequest(XEvent *e) {
 			if((ev->value_mask & (CWX | CWY))
 			&& !(ev->value_mask & (CWWidth | CWHeight)))
 				configure(c);
-			if(isvisible(c, &monitors[monitorat(-1,-1)]))
+			if(isvisible(c, monitorat()))
 				XMoveResizeWindow(dpy, c->win, c->x, c->y, c->w, c->h);
 		}
 		else
@@ -565,25 +561,25 @@ detachstack(Client *c) {
 
 void
 drawbar(void) {
-	int i, x, s;
+	int i, j, x;
 
-	for(s = 0; s < mcount; ++s) {
-		Monitor *m = &monitors[s];
+	for(i = 0; i < mcount; i++) {
+		Monitor *m = &monitors[i];
 		m->dc.x = 0;
-		for(i = 0; i < LENGTH(tags); i++) {
-			m->dc.w = textw(m, tags[i]);
-			if(m->seltags[i]) {
-				drawtext(m, tags[i], m->dc.sel);
-				drawsquare(m, sel && sel->tags[i] && sel->monitor == selmonitor, isoccupied(m, i), m->dc.sel);
+		for(j = 0; j < LENGTH(tags); j++) {
+			m->dc.w = textw(m, tags[j]);
+			if(m->seltags[j]) {
+				drawtext(m, tags[j], m->dc.sel, isurgent(i, j));
+				drawsquare(m, sel && sel->tags[j] && sel->monitor == selmonitor, isoccupied(m, j), m->dc.sel);
 			}
 			else {
-				drawtext(m, tags[i], m->dc.norm);
-				drawsquare(m, sel && sel->tags[i] && sel->monitor == selmonitor, isoccupied(m, i), m->dc.norm);
+				drawtext(m, tags[j], m->dc.norm, isurgent(i, j));
+				drawsquare(m, sel && sel->tags[j] && sel->monitor == selmonitor, isoccupied(m, j), m->dc.norm);
 			}
 			m->dc.x += m->dc.w;
 		}
 		m->dc.w = blw;
-		drawtext(m, m->layout->symbol, m->dc.norm);
+		drawtext(m, m->layout->symbol, m->dc.norm, False);
 		x = m->dc.x + m->dc.w;
 		m->dc.w = textw(m, stext);
 		m->dc.x = m->sw - m->dc.w;
@@ -591,15 +587,15 @@ drawbar(void) {
 			m->dc.x = x;
 			m->dc.w = m->sw - x;
 		}
-		drawtext(m, stext, m->dc.norm);
+		drawtext(m, stext, m->dc.norm, False);
 		if((m->dc.w = m->dc.x - x) > bh) {
 			m->dc.x = x;
 			if(sel && sel->monitor == selmonitor) {
-				drawtext(m, sel->name, m->dc.sel);
+				drawtext(m, sel->name, m->dc.sel, False);
 				drawsquare(m, False, sel->isfloating, m->dc.sel);
 			}
 			else
-				drawtext(m, NULL, m->dc.norm);
+				drawtext(m, NULL, m->dc.norm, False);
 		}
 		XCopyArea(dpy, m->dc.drawable, m->barwin, m->dc.gc, 0, 0, m->sw, bh, 0, 0);
 		XSync(dpy, False);
@@ -628,13 +624,13 @@ drawsquare(Monitor *m, Bool filled, Bool empty, unsigned long col[ColLast]) {
 }
 
 void
-drawtext(Monitor *m, const char *text, unsigned long col[ColLast]) {
+drawtext(Monitor *m, const char *text, unsigned long col[ColLast], Bool invert) {
 	int x, y, w, h;
 	static char buf[256];
 	unsigned int len, olen;
 	XRectangle r = { m->dc.x, m->dc.y, m->dc.w, m->dc.h };
 
-	XSetForeground(dpy, m->dc.gc, col[ColBG]);
+	XSetForeground(dpy, m->dc.gc, col[invert ? ColFG : ColBG]);
 	XFillRectangles(dpy, m->dc.drawable, m->dc.gc, &r, 1);
 	if(!text)
 		return;
@@ -660,7 +656,7 @@ drawtext(Monitor *m, const char *text, unsigned long col[ColLast]) {
 	}
 	if(w > m->dc.w)
 		return; /* too long */
-	XSetForeground(dpy, m->dc.gc, col[ColFG]);
+	XSetForeground(dpy, m->dc.gc, col[invert ? ColBG : ColFG]);
 	if(m->dc.font.set)
 		XmbDrawString(dpy, m->dc.drawable, m->dc.font.set, m->dc.gc, x, y, buf, len);
 	else
@@ -678,21 +674,17 @@ emallocz(unsigned int size) {
 
 void
 enternotify(XEvent *e) {
-	unsigned int i;
 	Client *c;
 	XCrossingEvent *ev = &e->xcrossing;
 
-	if(ev->mode != NotifyNormal || ev->detail == NotifyInferior)
-		return;
+	if(ev->mode != NotifyNormal || ev->detail == NotifyInferior);
+		//return;
 	if((c = getclient(ev->window)))
 		focus(c);
 	else {
-		for(i = 0; i < mcount; i++)
-			if(ev->window == monitors[i].root) {
-				selmonitor = i;
-				focus(NULL);
-				break;
-			}
+		selmonitor = monitorat();
+		fprintf(stderr, "updating selmonitor %d\n", selmonitor);
+		focus(NULL);
 	}
 }
 
@@ -722,15 +714,19 @@ floating(void) { /* default floating layout */
 
 	domwfact = dozoom = False;
 	for(c = clients; c; c = c->next)
-		if(isvisible(c, &monitors[selmonitor]))
+		if(isvisible(c, selmonitor))
 			resize(c, c->x, c->y, c->w, c->h, True);
 }
 
 void
 focus(Client *c) {
-	Monitor *m = &monitors[c ? c->monitor : selmonitor];
-	if(!c || (c && !isvisible(c, m)))
-		for(c = stack; c && !isvisible(c, m); c = c->snext);
+	Monitor *m;
+
+	if(c)
+		selmonitor = c->monitor;
+	m = &monitors[selmonitor];
+	if(!c || (c && !isvisible(c, selmonitor)))
+		for(c = stack; c && !isvisible(c, c->monitor); c = c->snext);
 	if(sel && sel != c) {
 		grabbuttons(sel, False);
 		XSetWindowBorder(dpy, sel->win, monitors[sel->monitor].dc.norm[ColBorder]);
@@ -763,13 +759,12 @@ focusin(XEvent *e) { /* there are some broken focus acquiring clients */
 void
 focusnext(const char *arg) {
 	Client *c;
-	Monitor *m = &monitors[selmonitor];
 
 	if(!sel)
 		return;
-	for(c = sel->next; c && !isvisible(c, m); c = c->next);
+	for(c = sel->next; c && !isvisible(c, selmonitor); c = c->next);
 	if(!c)
-		for(c = clients; c && !isvisible(c, m); c = c->next);
+		for(c = clients; c && !isvisible(c, selmonitor); c = c->next);
 	if(c) {
 		focus(c);
 		restack();
@@ -779,14 +774,13 @@ focusnext(const char *arg) {
 void
 focusprev(const char *arg) {
 	Client *c;
-	Monitor *m = &monitors[selmonitor];
 
 	if(!sel)
 		return;
-	for(c = sel->prev; c && !isvisible(c, m); c = c->prev);
+	for(c = sel->prev; c && !isvisible(c, selmonitor); c = c->prev);
 	if(!c) {
 		for(c = clients; c && c->next; c = c->next);
-		for(; c && !isvisible(c, m); c = c->prev);
+		for(; c && !isvisible(c, selmonitor); c = c->prev);
 	}
 	if(c) {
 		focus(c);
@@ -1001,11 +995,21 @@ isprotodel(Client *c) {
 }
 
 Bool
-isvisible(Client *c, Monitor *m) {
+isurgent(int monitor, unsigned int t) {
+	Client *c;
+
+	for(c = clients; c; c = c->next)
+		if(c->monitor == monitor && c->isurgent && c->tags[t])
+			return True;
+	return False;
+}
+
+Bool
+isvisible(Client *c, int monitor) {
 	unsigned int i;
 
 	for(i = 0; i < LENGTH(tags); i++)
-		if(c->tags[i] && monitors[c->monitor].seltags[i] && c->monitor == selmonitor)
+		if(c->tags[i] && monitors[c->monitor].seltags[i] && c->monitor == monitor)
 			return True;
 	return False;
 }
@@ -1049,7 +1053,7 @@ killclient(const char *arg) {
 void
 manage(Window w, XWindowAttributes *wa) {
 	Client *c, *t = NULL;
-	Monitor *m = &monitors[selmonitor];
+	Monitor *m;
 	Status rettrans;
 	Window trans;
 	XWindowChanges wc;
@@ -1060,17 +1064,14 @@ manage(Window w, XWindowAttributes *wa) {
 
 	applyrules(c);
 
+	m = &monitors[c->monitor];
+
 	c->x = wa->x + m->sx;
 	c->y = wa->y + m->sy;
 	c->w = wa->width;
 	c->h = wa->height;
 	c->oldborder = wa->border_width;
 
-	if (monitorat(c->x, c->y) != c->monitor) {
-		c->x = m->sx;
-		c->y = m->sy;
-	}
-
 	if(c->w == m->sw && c->h == m->sh) {
 		c->x = m->sx;
 		c->y = m->sy;
@@ -1132,6 +1133,25 @@ maprequest(XEvent *e) {
 		manage(ev->window, &wa);
 }
 
+int
+monitorat() {
+	int i, x, y;
+	Window win;
+	unsigned int mask;
+
+	XQueryPointer(dpy, monitors[selmonitor].root, &win, &win, &x, &y, &i, &i, &mask);
+	for(i = 0; i < mcount; i++) {
+		fprintf(stderr, "checking monitor[%d]: %d %d %d %d\n", i, monitors[i].sx, monitors[i].sy, monitors[i].sw, monitors[i].sh);
+		if((x >= monitors[i].sx && x < monitors[i].sx + monitors[i].sw)
+		&& (y >= monitors[i].sy && y < monitors[i].sy + monitors[i].sh)) {
+			fprintf(stderr, "%d,%d -> %d\n", x, y, i);
+			return i;
+		}
+	}
+	fprintf(stderr, "?,? -> 0\n");
+	return 0;
+}
+
 void
 movemouse(Client *c) {
 	int x1, y1, ocx, ocy, di, nx, ny;
@@ -1160,7 +1180,7 @@ movemouse(Client *c) {
 			XSync(dpy, False);
 			nx = ocx + (ev.xmotion.x - x1);
 			ny = ocy + (ev.xmotion.y - y1);
-			Monitor *m = &monitors[monitorat(nx, ny)];
+			Monitor *m = &monitors[monitorat()];
 			if(abs(m->wax - nx) < SNAP)
 				nx = m->wax;
 			else if(abs((m->wax + m->waw) - (nx + c->w + 2 * c->border)) < SNAP)
@@ -1169,16 +1189,19 @@ movemouse(Client *c) {
 				ny = m->way;
 			else if(abs((m->way + m->wah) - (ny + c->h + 2 * c->border)) < SNAP)
 				ny = m->way + m->wah - c->h - 2 * c->border;
-			resize(c, nx, ny, c->w, c->h, False);
-			memcpy(c->tags, monitors[monitorat(nx, ny)].seltags, sizeof initags);
+			if((monitors[selmonitor].layout->arrange != floating) && (abs(nx - c->x) > SNAP || abs(ny - c->y) > SNAP))
+				togglefloating(NULL);
+			if((monitors[selmonitor].layout->arrange == floating) || c->isfloating)
+				resize(c, nx, ny, c->w, c->h, False);
+			memcpy(c->tags, monitors[monitorat()].seltags, sizeof initags);
 			break;
 		}
 	}
 }
 
 Client *
-nexttiled(Client *c, Monitor *m) {
-	for(; c && (c->isfloating || !isvisible(c, m)); c = c->next);
+nexttiled(Client *c, int monitor) {
+	for(; c && (c->isfloating || !isvisible(c, monitor)); c = c->next);
 	return c;
 }
 
@@ -1201,6 +1224,10 @@ propertynotify(XEvent *e) {
 			case XA_WM_NORMAL_HINTS:
 				updatesizehints(c);
 				break;
+			case XA_WM_HINTS:
+				updatewmhints(c);
+				drawbar();
+				break;
 		}
 		if(ev->atom == XA_WM_NAME || ev->atom == netatom[NetWMName]) {
 			updatetitle(c);
@@ -1230,8 +1257,8 @@ reapply(const char *arg) {
 void
 resize(Client *c, int x, int y, int w, int h, Bool sizehints) {
 	XWindowChanges wc;
-	Monitor scr = monitors[monitorat(x, y)];
-	c->monitor = monitorat(x, y);
+	//Monitor scr = monitors[monitorat()];
+//	c->monitor = monitorat();
 
 	if(sizehints) {
 		/* set minimum possible */
@@ -1328,7 +1355,10 @@ resizemouse(Client *c) {
 				nw = 1;
 			if((nh = ev.xmotion.y - ocy - 2 * c->border + 1) <= 0)
 				nh = 1;
-			resize(c, c->x, c->y, nw, nh, True);
+			if((monitors[selmonitor].layout->arrange != floating) && (abs(nw - c->w) > SNAP || abs(nh - c->h) > SNAP))
+				togglefloating(NULL);
+			if((monitors[selmonitor].layout->arrange == floating) || c->isfloating)
+				resize(c, c->x, c->y, nw, nh, True);
 			break;
 		}
 	}
@@ -1336,10 +1366,10 @@ resizemouse(Client *c) {
 
 void
 restack(void) {
+	unsigned int i;
 	Client *c;
 	XEvent ev;
 	XWindowChanges wc;
-	int s;
 
 	drawbar();
 	if(!sel)
@@ -1353,8 +1383,8 @@ restack(void) {
 			XConfigureWindow(dpy, sel->win, CWSibling | CWStackMode, &wc);
 			wc.sibling = sel->win;
 		}
-		for(s = 0; s < mcount; s++) {
-			for(c = nexttiled(clients, &monitors[s]); c; c = nexttiled(c->next, &monitors[s])) {
+		for(i = 0; i < mcount; i++) {
+			for(c = nexttiled(clients, i); c; c = nexttiled(c->next, i)) {
 				if(c == sel)
 					continue;
 				XConfigureWindow(dpy, c->win, CWSibling | CWStackMode, &wc);
@@ -1467,7 +1497,7 @@ setclientstate(Client *c, long state) {
 void
 setlayout(const char *arg) {
 	unsigned int i;
-	Monitor *m = &monitors[monitorat(-1, -1)];
+	Monitor *m = &monitors[monitorat()];
 
 	if(!arg) {
 		m->layout++;
@@ -1492,7 +1522,7 @@ void
 setmwfact(const char *arg) {
 	double delta;
 
-	Monitor *m = &monitors[monitorat(-1, -1)];
+	Monitor *m = &monitors[monitorat()];
 
 	if(!domwfact)
 		return;
@@ -1533,24 +1563,24 @@ setup(void) {
 	cursor[CurMove] = XCreateFontCursor(dpy, XC_fleur);
 
 	// init screens/monitors first
-	if (XineramaIsActive(dpy)) {
-		info = XineramaQueryScreens(dpy, &mcount);
-	}
 	mcount = 1;
+	if((isxinerama = XineramaIsActive(dpy)))
+		info = XineramaQueryScreens(dpy, &mcount);
 	monitors = emallocz(mcount * sizeof(Monitor));
 
 	for(i = 0; i < mcount; i++) {
 		/* init geometry */
 		m = &monitors[i];
 
-		m->screen = i;
-		m->root = RootWindow(dpy, i);
+		m->screen = isxinerama ? 0 : i;
+		m->root = RootWindow(dpy, m->screen);
 
-		if (mcount != 1) { // TODO: Xinerama
+		if (mcount != 1 && isxinerama) {
 			m->sx = info[i].x_org;
 			m->sy = info[i].y_org;
 			m->sw = info[i].width;
 			m->sh = info[i].height;
+			fprintf(stderr, "monitor[%d]: %d,%d,%d,%d\n", i, m->sx, m->sy, m->sw, m->sh);
 		}
 		else {
 			m->sx = 0;
@@ -1566,12 +1596,12 @@ setup(void) {
 		memcpy(m->prevtags, initags, sizeof initags);
 
 		/* init appearance */
-		m->dc.norm[ColBorder] = getcolor(NORMBORDERCOLOR, i);
-		m->dc.norm[ColBG] = getcolor(NORMBGCOLOR, i);
-		m->dc.norm[ColFG] = getcolor(NORMFGCOLOR, i);
-		m->dc.sel[ColBorder] = getcolor(SELBORDERCOLOR, i);
-		m->dc.sel[ColBG] = getcolor(SELBGCOLOR, i);
-		m->dc.sel[ColFG] = getcolor(SELFGCOLOR, i);
+		m->dc.norm[ColBorder] = getcolor(NORMBORDERCOLOR, m->screen);
+		m->dc.norm[ColBG] = getcolor(NORMBGCOLOR, m->screen);
+		m->dc.norm[ColFG] = getcolor(NORMFGCOLOR, m->screen);
+		m->dc.sel[ColBorder] = getcolor(SELBORDERCOLOR, m->screen);
+		m->dc.sel[ColBG] = getcolor(SELBGCOLOR, m->screen);
+		m->dc.sel[ColFG] = getcolor(SELFGCOLOR, m->screen);
 		initfont(m, FONT);
 		m->dc.h = bh = m->dc.font.height + 2;
 
@@ -1614,12 +1644,17 @@ setup(void) {
 		XChangeWindowAttributes(dpy, m->root, CWEventMask | CWCursor, &wa);
 		XSelectInput(dpy, m->root, wa.event_mask);
 	}
+	if(info)
+		XFree(info);
 
 	/* grab keys */
 	grabkeys();
 
 	/* init tags */
 	compileregs();
+
+	selmonitor = monitorat();
+	fprintf(stderr, "selmonitor == %d\n", selmonitor);
 }
 
 void
@@ -1676,43 +1711,44 @@ textw(Monitor *m, const char *text) {
 
 void
 tile(void) {
-	unsigned int i, n, nx, ny, nw, nh, mw, th;
-	int s;
+	unsigned int i, j, n, nx, ny, nw, nh, mw, th;
 	Client *c, *mc;
 
 	domwfact = dozoom = True;
 
-	nw = 0; /* gcc stupidity requires this */
+	nx = ny = nw = 0; /* gcc stupidity requires this */
 
-	for (s = 0; s < mcount; s++) {
-		Monitor *m = &monitors[s];
+	for (i = 0; i < mcount; i++) {
+		Monitor *m = &monitors[i];
 
-		for(n = 0, c = nexttiled(clients, m); c; c = nexttiled(c->next, m))
+		for(n = 0, c = nexttiled(clients, i); c; c = nexttiled(c->next, i))
 			n++;
 
-		for(i = 0, c = mc = nexttiled(clients, m); c; c = nexttiled(c->next, m)) {
-			/* window geoms */
-			mw = (n == 1) ? m->waw : m->mwfact * m->waw;
-			th = (n > 1) ? m->wah / (n - 1) : 0;
-			if(n > 1 && th < bh)
-				th = m->wah;
-			if(i == 0) { /* master */
+		/* window geoms */
+		mw = (n == 1) ? m->waw : m->mwfact * m->waw;
+		th = (n > 1) ? m->wah / (n - 1) : 0;
+		if(n > 1 && th < bh)
+			th = m->wah;
+
+		for(j = 0, c = mc = nexttiled(clients, i); c; c = nexttiled(c->next, i)) {
+			if(j == 0) { /* master */
 				nx = m->wax;
 				ny = m->way;
 				nw = mw - 2 * c->border;
 				nh = m->wah - 2 * c->border;
 			}
 			else {  /* tile window */
-				if(i == 1) {
+				if(j == 1) {
 					ny = m->way;
 					nx += mc->w + 2 * mc->border;
 					nw = m->waw - mw - 2 * c->border;
 				}
-				if(i + 1 == n) /* remainder */
+				if(j + 1 == n) /* remainder */
 					nh = (m->way + m->wah) - ny - 2 * c->border;
 				else
 					nh = th - 2 * c->border;
 			}
+			fprintf(stderr, "tile(%d, %d, %d, %d)\n", nx, ny, nw, nh);
 			resize(c, nx, ny, nw, nh, RESIZEHINTS);
 			if((RESIZEHINTS) && ((c->h < bh) || (c->h > nh) || (c->w < bh) || (c->w > nw)))
 				/* client doesn't accept size constraints */
@@ -1720,9 +1756,10 @@ tile(void) {
 			if(n > 1 && th != m->wah)
 				ny = c->y + c->h + 2 * c->border;
 
-			i++;
+			j++;
 		}
 	}
+	fprintf(stderr, "done\n");
 }
 void
 togglebar(const char *arg) {
@@ -1730,7 +1767,7 @@ togglebar(const char *arg) {
 		bpos = (BARPOS == BarOff) ? BarTop : BARPOS;
 	else
 		bpos = BarOff;
-	updatebarpos(&monitors[monitorat(-1,-1)]);
+	updatebarpos(&monitors[monitorat()]);
 	arrange();
 }
 
@@ -1762,7 +1799,7 @@ void
 toggleview(const char *arg) {
 	unsigned int i, j;
 
-	Monitor *m = &monitors[monitorat(-1, -1)];
+	Monitor *m = &monitors[monitorat()];
 
 	i = idxoftag(arg);
 	m->seltags[i] = !m->seltags[i];
@@ -1813,25 +1850,25 @@ unmapnotify(XEvent *e) {
 }
 
 void
-updatebarpos(Monitor *s) {
+updatebarpos(Monitor *m) {
 	XEvent ev;
 
-	s->wax = s->sx;
-	s->way = s->sy;
-	s->wah = s->sh;
-	s->waw = s->sw;
+	m->wax = m->sx;
+	m->way = m->sy;
+	m->wah = m->sh;
+	m->waw = m->sw;
 	switch(bpos) {
 	default:
-		s->wah -= bh;
-		s->way += bh;
-		XMoveWindow(dpy, s->barwin, s->sx, s->sy);
+		m->wah -= bh;
+		m->way += bh;
+		XMoveWindow(dpy, m->barwin, m->sx, m->sy);
 		break;
 	case BarBot:
-		s->wah -= bh;
-		XMoveWindow(dpy, s->barwin, s->sx, s->sy + s->wah);
+		m->wah -= bh;
+		XMoveWindow(dpy, m->barwin, m->sx, m->sy + m->wah);
 		break;
 	case BarOff:
-		XMoveWindow(dpy, s->barwin, s->sx, s->sy - bh);
+		XMoveWindow(dpy, m->barwin, m->sx, m->sy - bh);
 		break;
 	}
 	XSync(dpy, False);
@@ -1896,6 +1933,16 @@ updatetitle(Client *c) {
 		gettextprop(c->win, wmatom[WMName], c->name, sizeof c->name);
 }
 
+void
+updatewmhints(Client *c) {
+	XWMHints *wmh;
+
+	if((wmh = XGetWMHints(dpy, c->win))) {
+		c->isurgent = (wmh->flags & XUrgencyHint) ? True : False;
+		XFree(wmh);
+	}
+}
+
 /* There's no way to check accesses to destroyed windows, thus those cases are
  * ignored (especially on UnmapNotify's).  Other types of errors call Xlibs
  * default error handler, which may call exit.  */
@@ -1931,21 +1978,24 @@ xerrorstart(Display *dsply, XErrorEvent *ee) {
 void
 view(const char *arg) {
 	unsigned int i;
+	Bool tmp[LENGTH(tags)];
+	Monitor *m = &monitors[monitorat()];
 
-	Monitor *m = &monitors[monitorat(-1, -1)];
-
-	memcpy(m->prevtags, m->seltags, sizeof initags);
 	for(i = 0; i < LENGTH(tags); i++)
-		m->seltags[i] = (NULL == arg);
-	m->seltags[idxoftag(arg)] = True;
-	arrange();
+		tmp[i] = (NULL == arg);
+	tmp[idxoftag(arg)] = True;
+	if(memcmp(m->seltags, tmp, sizeof initags) != 0) {
+		memcpy(m->prevtags, m->seltags, sizeof initags);
+		memcpy(m->seltags, tmp, sizeof initags);
+		arrange();
+	}
 }
 
 void
 viewprevtag(const char *arg) {
 	static Bool tmp[LENGTH(tags)];
 
-	Monitor *m = &monitors[monitorat(-1, -1)];
+	Monitor *m = &monitors[monitorat()];
 
 	memcpy(tmp, m->seltags, sizeof initags);
 	memcpy(m->seltags, m->prevtags, sizeof initags);
@@ -1959,8 +2009,8 @@ zoom(const char *arg) {
 
 	if(!sel || !dozoom || sel->isfloating)
 		return;
-	if((c = sel) == nexttiled(clients, &monitors[c->monitor]))
-		if(!(c = nexttiled(c->next, &monitors[c->monitor])))
+	if((c = sel) == nexttiled(clients, c->monitor))
+		if(!(c = nexttiled(c->next, c->monitor)))
 			return;
 	detach(c);
 	attach(c);
@@ -1968,31 +2018,6 @@ zoom(const char *arg) {
 	arrange();
 }
 
-int
-monitorat(int x, int y) {
-	int i;
-
-	return 0;
-	if(!XineramaIsActive(dpy))
-		return 0;
-
-	if (x < 0 || y < 0) {
-		Window win;
-		unsigned int mask;
-		XQueryPointer(dpy, DefaultRootWindow(dpy), &win, &win, &x, &y, &i, &i, &mask);
-	}
-
-	for(i = 0; i < mcount; i++) {
-		Monitor *m = &monitors[i];
-		if((x < 0 || (x >= m->sx && x < m->sx + m->sw))
-				&& (y < 0 || (y >= m->sy && y < m->sy + m->sh)))
-		{
-			return i;
-		}
-	}
-	return 0;
-}
-
 void
 movetomonitor(const char *arg) {
 	if (sel) {
@@ -2006,7 +2031,7 @@ movetomonitor(const char *arg) {
 
 void
 selectmonitor(const char *arg) {
-	Monitor *m = &monitors[arg ? atoi(arg) : (monitorat(-1, -1)+1) % mcount];
+	Monitor *m = &monitors[arg ? atoi(arg) : (monitorat()+1) % mcount];
 
 	XWarpPointer(dpy, None, m->root, 0, 0, 0, 0, m->wax+m->waw/2, m->way+m->wah/2);
 	focus(NULL);