X-Git-Url: https://jasonwoof.com/gitweb/?a=blobdiff_plain;f=util.c;h=91df00b17e6461d0fa7cda22f5c33e62bb253d2f;hb=a50b15a9e9663b1a7ee11d39ddf246427aecaeef;hp=99d7bebb773c42658a79032ba566986f54d401dc;hpb=08d85d6d66bc4493414d76e470e473fa689c5990;p=dwm.git

diff --git a/util.c b/util.c
index 99d7beb..91df00b 100644
--- a/util.c
+++ b/util.c
@@ -9,14 +9,6 @@
 #include <sys/wait.h>
 #include <unistd.h>
 
-/* static */
-
-static void
-badmalloc(unsigned int size)
-{
-	eprint("fatal: could not malloc() %u bytes\n", size);
-}
-
 /* extern */
 
 void *
@@ -25,7 +17,7 @@ emallocz(unsigned int size)
 	void *res = calloc(1, size);
 
 	if(!res)
-		badmalloc(size);
+		eprint("fatal: could not malloc() %u bytes\n", size);
 	return res;
 }
 
@@ -45,7 +37,7 @@ erealloc(void *ptr, unsigned int size)
 {
 	void *res = realloc(ptr, size);
 	if(!res)
-		badmalloc(size);
+		eprint("fatal: could not malloc() %u bytes\n", size);
 	return res;
 }
 
@@ -59,12 +51,13 @@ spawn(Arg *arg)
 
 	if(!arg->cmd)
 		return;
+	/* the double-fork construct avoids zombie processes */
 	if(fork() == 0) {
 		if(fork() == 0) {
 			if(dpy)
 				close(ConnectionNumber(dpy));
 			setsid();
-			execl(shell, shell, "-c", arg->cmd, NULL);
+			execl(shell, shell, "-c", arg->cmd, (char *)NULL);
 			fprintf(stderr, "dwm: execl '%s -c %s'", shell, arg->cmd);
 			perror(" failed");
 		}