summary |
shortlog |
log |
commit | commitdiff |
tree
raw |
patch |
inline | side by side (from parent 1:
9e034db)
1. Do not hardcode path to coreutils.
2. Do not pass variables to functions where not required.
3. Run top as a batch process to be able to grep its output.
- MEM=`/usr/bin/top | grep Free: | cut -d " " -f6`
+ MEM=$($(which top) -bcn1 | grep Mem: | grep -v grep | cut -d " " -f11)
echo -n "Free mem: $MEM "
}
echo -n "Free mem: $MEM "
}
BAT_STRING="(battery unknown)"
;;
esac;
BAT_STRING="(battery unknown)"
;;
esac;
FULL="${AC_STRING}${BAT_STRING}"
if [ "$FULL" != "" ]; then
echo -n "$FULL"
FULL="${AC_STRING}${BAT_STRING}"
if [ "$FULL" != "" ]; then
echo -n "$FULL"
- CPU_SPEED=`/sbin/sysctl hw.cpuspeed | cut -d "=" -f2`
+ CPU_SPEED=$($(which sysctl) hw.cpuspeed | cut -d "=" -f2)
echo -n "CPU speed: $CPU_SPEED MHz "
}
while :; do
# instead of sleeping, use iostat as the update timer.
# cache the output of apm(8), no need to call that every second.
echo -n "CPU speed: $CPU_SPEED MHz "
}
while :; do
# instead of sleeping, use iostat as the update timer.
# cache the output of apm(8), no need to call that every second.
- /usr/sbin/iostat -C -c 3600 |& # wish infinity was an option
+ $(which iostat) -C -c 3600 |& # wish infinity was an option
PID="$!"
APM_DATA=""
I=0
trap "kill $PID; exit" TERM
while read -p; do
if [ $(( ${I} % 1 )) -eq 0 ]; then
PID="$!"
APM_DATA=""
I=0
trap "kill $PID; exit" TERM
while read -p; do
if [ $(( ${I} % 1 )) -eq 0 ]; then
- APM_DATA=`/usr/sbin/apm -alb`
+ APM_DATA=$($(which apm) -alb)
fi
if [ $I -ge 2 ]; then
# print_date
fi
if [ $I -ge 2 ]; then
# print_date
- print_mem $MEM
- print_cpu $REPLY
print_cpuspeed
print_apm $APM_DATA
echo ""
print_cpuspeed
print_apm $APM_DATA
echo ""