From: David Hill Date: Fri, 20 Jul 2012 16:46:23 +0000 (-0400) Subject: plug memory leak in get_win_name X-Git-Url: https://jasonwoof.com/gitweb/?a=commitdiff_plain;h=018a45a9260ec7808863d7ef0411a443243781a4;p=spectrwm.git plug memory leak in get_win_name --- diff --git a/spectrwm.c b/spectrwm.c index 73e3fc7..c674051 100644 --- a/spectrwm.c +++ b/spectrwm.c @@ -3730,12 +3730,10 @@ get_win_name(xcb_window_t win) if (xcb_icccm_get_wm_name_reply(conn, c, &r, NULL)) { if (r.name_len > 0) { name = malloc(r.name_len + 1); - if (!name) { - xcb_icccm_get_text_property_reply_wipe(&r); - return (NULL); + if (name) { + memcpy(name, r.name, r.name_len); + name[r.name_len] = '\0'; } - memcpy(name, r.name, r.name_len); - name[r.name_len] = '\0'; } xcb_icccm_get_text_property_reply_wipe(&r); }