From: Mark Edgar Date: Sun, 25 Aug 2013 22:10:47 +0000 (+0200) Subject: Correctly initialize altscreen when defaultbg is not 0. X-Git-Url: https://jasonwoof.com/gitweb/?a=commitdiff_plain;h=4245ba0d12a330b3e54c6498e88024d90956ae34;hp=4245ba0d12a330b3e54c6498e88024d90956ae34;p=st.git Correctly initialize altscreen when defaultbg is not 0. The alternate screen is not properly initialized when st starts. To see this, set defaultbg in config.h to anything other than 0 (for example, swap defaultfg and defaultbg), and run: ./st -e sh -c 'tput smcup; read' You should see that the top-left 80x24 rectangle is black (or whatever colorname[0] is), while the rest of the screen (if any) has the desired colorname[defaultbg] color. The attached patch fixes this by initializing term.c.attr in tnew() before calling tresize(). It also removes the unnecessary xcalloc() calls, which misled me on this bug hunt since it is really tclearregion() which initializes term.lines and term.alt in tresize(). ---