JasonWoof Got questions, comments, patches, etc.? Contact Jason Woofenden
spectrwm.git
12 years agoFix get_win_name to try _NET_WM_NAME (UTF-8) before WM_NAME.
Reginald Kennedy [Sat, 28 Jul 2012 18:09:01 +0000 (02:09 +0800)]
Fix get_win_name to try _NET_WM_NAME (UTF-8) before WM_NAME.

12 years agoUse legacy XFontSet when user specifies an X core font for bar_font.
Reginald Kennedy [Fri, 27 Jul 2012 02:59:36 +0000 (10:59 +0800)]
Use legacy XFontSet when user specifies an X core font for bar_font.

12 years agofix some more unused param warnings
Marco Peereboom [Fri, 27 Jul 2012 23:04:24 +0000 (18:04 -0500)]
fix some more unused param warnings

12 years agoshut a bunch of warnings up
Marco Peereboom [Fri, 27 Jul 2012 22:50:18 +0000 (17:50 -0500)]
shut a bunch of warnings up

12 years agoEliminate more shadows.
Reginald Kennedy [Fri, 27 Jul 2012 21:16:04 +0000 (05:16 +0800)]
Eliminate more shadows.

12 years agoFix check_conn.
Reginald Kennedy [Fri, 27 Jul 2012 20:48:27 +0000 (04:48 +0800)]
Fix check_conn.

Resolve declaration shadows.

12 years agoRename a variable.
Reginald Kennedy [Fri, 27 Jul 2012 20:27:56 +0000 (04:27 +0800)]
Rename a variable.

12 years agofix typo
David Hill [Fri, 27 Jul 2012 20:24:54 +0000 (16:24 -0400)]
fix typo

12 years agoFix check_conn to work with older libxcb versions.
Reginald Kennedy [Fri, 27 Jul 2012 15:01:17 +0000 (23:01 +0800)]
Fix check_conn to work with older libxcb versions.

12 years agoAdd another check before attempting to use RandR.
Reginald Kennedy [Fri, 27 Jul 2012 02:56:38 +0000 (10:56 +0800)]
Add another check before attempting to use RandR.

12 years agoDon't query the RandR extension unless it is present.
Reginald Kennedy [Fri, 27 Jul 2012 00:02:47 +0000 (08:02 +0800)]
Don't query the RandR extension unless it is present.

12 years agoAdd a check_conn() function for debugging purposes.
Reginald Kennedy [Thu, 26 Jul 2012 23:38:47 +0000 (07:38 +0800)]
Add a check_conn() function for debugging purposes.

12 years agoAdd variable for debug purposes.
Reginald Kennedy [Thu, 26 Jul 2012 15:26:36 +0000 (23:26 +0800)]
Add variable for debug purposes.

12 years agoCheck return value of get_screen.
Reginald Kennedy [Thu, 26 Jul 2012 11:23:28 +0000 (19:23 +0800)]
Check return value of get_screen.

12 years agoOnly get xrandr extension data if xrandr is supported.
Reginald Kennedy [Wed, 25 Jul 2012 22:58:23 +0000 (06:58 +0800)]
Only get xrandr extension data if xrandr is supported.

12 years agoGet actual LOGIN_NAME_MAX value from sysconf.
Reginald Kennedy [Wed, 25 Jul 2012 22:45:40 +0000 (06:45 +0800)]
Get actual LOGIN_NAME_MAX value from sysconf.

12 years agoFix bar 'random' class:instance bar output.
Reginald Kennedy [Tue, 24 Jul 2012 01:20:42 +0000 (09:20 +0800)]
Fix bar 'random' class:instance bar output.
Actual result pointer was being set to the window struct and then
immediately freed causing unpredictable results.

12 years agoEliminate PSC (path separator char) macro.
Reginald Kennedy [Mon, 23 Jul 2012 19:24:54 +0000 (03:24 +0800)]
Eliminate PSC (path separator char) macro.

12 years agoAdd tilde (~) expansion to bar_action and program[] config options.
Reginald Kennedy [Mon, 23 Jul 2012 19:15:41 +0000 (03:15 +0800)]
Add tilde (~) expansion to bar_action and program[] config options.
(based on xombrero expand_tilde function, reworked to be like strdup)

12 years agoNew debug output for FocusIn and LeaveNotify.
Reginald Kennedy [Mon, 23 Jul 2012 18:51:06 +0000 (02:51 +0800)]
New debug output for FocusIn and LeaveNotify.

Consolidate function prototypes.

12 years agoFix user bar_font not being applied to dmenu.
Reginald Kennedy [Sun, 22 Jul 2012 10:08:39 +0000 (18:08 +0800)]
Fix user bar_font not being applied to dmenu.

12 years agoUse a more generalized check for xcb-util < 0.3.8
Reginald Kennedy [Sat, 21 Jul 2012 19:54:17 +0000 (03:54 +0800)]
Use a more generalized check for xcb-util < 0.3.8

12 years agoRemove unneeded variables and some whitespace.
Reginald Kennedy [Fri, 20 Jul 2012 21:57:26 +0000 (05:57 +0800)]
Remove unneeded variables and some whitespace.

12 years agouse _icccm_ in the function name to stay current
David Hill [Fri, 20 Jul 2012 21:53:03 +0000 (17:53 -0400)]
use _icccm_ in the function name to stay current

12 years agoAdd myself to the copyright
David Hill [Fri, 20 Jul 2012 21:46:36 +0000 (17:46 -0400)]
Add myself to the copyright

12 years agoanother potential memleak
David Hill [Fri, 20 Jul 2012 21:44:47 +0000 (17:44 -0400)]
another potential memleak

12 years agowe don't do anything with xcb_grab_pointer_reply, so get rid of it.
David Hill [Fri, 20 Jul 2012 20:40:40 +0000 (16:40 -0400)]
we don't do anything with xcb_grab_pointer_reply, so get rid of it.

12 years agoplug memleak
David Hill [Fri, 20 Jul 2012 20:32:57 +0000 (16:32 -0400)]
plug memleak

12 years agomove out of the loop.
David Hill [Fri, 20 Jul 2012 20:03:27 +0000 (16:03 -0400)]
move out of the loop.

12 years agoplug some more mem leaks.
David Hill [Fri, 20 Jul 2012 19:15:26 +0000 (15:15 -0400)]
plug some more mem leaks.

12 years agowe need to free what is returned from xcb_key_symbols_get_keycode
David Hill [Fri, 20 Jul 2012 17:24:20 +0000 (13:24 -0400)]
we need to free what is returned from xcb_key_symbols_get_keycode

12 years agocheck replies separately
David Hill [Fri, 20 Jul 2012 16:57:50 +0000 (12:57 -0400)]
check replies separately

12 years agoplug memleak in find_window
David Hill [Fri, 20 Jul 2012 16:54:38 +0000 (12:54 -0400)]
plug memleak in find_window

12 years agoplug memory leak in get_win_name
David Hill [Fri, 20 Jul 2012 16:46:23 +0000 (12:46 -0400)]
plug memory leak in get_win_name

12 years agoremoved unused function
David Hill [Fri, 20 Jul 2012 16:40:16 +0000 (12:40 -0400)]
removed unused function

12 years agoplug memory leak in get_atom_name
David Hill [Fri, 20 Jul 2012 16:39:27 +0000 (12:39 -0400)]
plug memory leak in get_atom_name

12 years agoplug memory leak in get_ws_idx
David Hill [Fri, 20 Jul 2012 16:35:12 +0000 (12:35 -0400)]
plug memory leak in get_ws_idx

12 years agomake sure we test the reply to be not NULL too.
David Hill [Fri, 20 Jul 2012 16:29:52 +0000 (12:29 -0400)]
make sure we test the reply to be not NULL too.

12 years agoFix freebsd makefile.
Reginald Kennedy [Fri, 20 Jul 2012 09:18:55 +0000 (17:18 +0800)]
Fix freebsd makefile.

Submitted by Erandir.

12 years agoBegin checking the xcb_get_property_reply before using the value.
Reginald Kennedy [Fri, 20 Jul 2012 01:38:27 +0000 (09:38 +0800)]
Begin checking the xcb_get_property_reply before using the value.

12 years agorevert getstate change. made windows disappear.
David Hill [Fri, 20 Jul 2012 01:00:24 +0000 (21:00 -0400)]
revert getstate change.  made windows disappear.

12 years agoin getstate(), we need to fetch type XCB_ATOM_ATOM, not the atom.
David Hill [Fri, 20 Jul 2012 00:32:52 +0000 (20:32 -0400)]
in getstate(), we need to fetch type XCB_ATOM_ATOM, not the atom.

12 years agoUse intermediate pointer in getstate().
Reginald Kennedy [Thu, 19 Jul 2012 23:40:29 +0000 (07:40 +0800)]
Use intermediate pointer in getstate().

12 years agoapply XftDraw to search_win
David Hill [Thu, 19 Jul 2012 23:19:03 +0000 (19:19 -0400)]
apply XftDraw to search_win

12 years agoFix bar text vertical positioning.
Reginald Kennedy [Thu, 19 Jul 2012 22:16:28 +0000 (06:16 +0800)]
Fix bar text vertical positioning.

Remove extra vertical padding from bar.

12 years agoallow core fonts to load again. this may need more magic.
David Hill [Thu, 19 Jul 2012 19:52:15 +0000 (15:52 -0400)]
allow core fonts to load again.  this may need more magic.

12 years agospaces no longer allowed in separating fonts. use only , instead.
David Hill [Thu, 19 Jul 2012 18:26:56 +0000 (14:26 -0400)]
spaces no longer allowed in separating fonts.  use only , instead.

Makes use able to use fonts with spaces in their names.

12 years agoDon't try to setup the bar if it already exists.
Reginald Kennedy [Thu, 19 Jul 2012 17:33:42 +0000 (01:33 +0800)]
Don't try to setup the bar if it already exists.

12 years agoUse the same font on all bars.
Reginald Kennedy [Thu, 19 Jul 2012 17:19:19 +0000 (01:19 +0800)]
Use the same font on all bars.

Don't close font and color each time bar_setup is called.

12 years agoFix parse_rgb() 8-bit to 16-bit color conversion
Reginald Kennedy [Thu, 19 Jul 2012 17:01:04 +0000 (01:01 +0800)]
Fix parse_rgb() 8-bit to 16-bit color conversion
For example, 0xff should convert to 0xffff, not 0xff00.

Fix bar_setup to properly convert the color pixel value to XRenderColor.

Rename swm_screen.c[].color to swm_screen.c[].pixel.

Add new get_ws_idx function.

Use 1 and 0 instead of the Xlib macros 'True' and 'False'.

Fix print_win_geom to not crash when the supplied window is invalid.

Fix windows disappearing on restart.
For now, go back to setting the state iconic in unmap_window.

Add '(void)var;' in functions where var is required but unused.
When using the -Wextra compiler flag, the warning for those variables is
suppressed thereby making it easier to spot warnings that could use our
attention.

Fix type conversion warning in swm_hack.c

Use global atoms where applicable.

12 years agoFix some styling.
Reginald Kennedy [Thu, 19 Jul 2012 06:16:57 +0000 (14:16 +0800)]
Fix some styling.

12 years agouse %ld to print longs
David Hill [Thu, 19 Jul 2012 03:14:56 +0000 (23:14 -0400)]
use %ld to print longs

12 years agobetter Xft support.
David Hill [Thu, 19 Jul 2012 03:12:58 +0000 (23:12 -0400)]
better Xft support.

12 years agoSet window state to withdrawn, instead of iconic, when switching ws.
Reginald Kennedy [Wed, 18 Jul 2012 15:17:37 +0000 (23:17 +0800)]
Set window state to withdrawn, instead of iconic, when switching ws.

Add more debug messages.

12 years agoA better fix.
Reginald Kennedy [Wed, 18 Jul 2012 11:54:29 +0000 (19:54 +0800)]
A better fix.
Explicitly set event queue owner to XCB since it is Xlib by default.
Xlib errors are now passed to the XCB event queue!

12 years agoFix Xlib exiting on error.
Reginald Kennedy [Wed, 18 Jul 2012 01:10:47 +0000 (09:10 +0800)]
Fix Xlib exiting on error.

12 years agoOops, bar_font conflicted, renamed bar_font to font in bar_setup.
Reginald Kennedy [Tue, 17 Jul 2012 20:45:24 +0000 (04:45 +0800)]
Oops, bar_font conflicted, renamed bar_font to font in bar_setup.

Add the correct libraries and include to linux Makefile.

12 years agoRemove unneeded bar_fs_height variable.
Reginald Kennedy [Tue, 17 Jul 2012 20:11:55 +0000 (04:11 +0800)]
Remove unneeded bar_fs_height variable.

Rename bar_fs to bar_font.

Remove some whitespace.

12 years agostart of Xft. blows up.
David Hill [Tue, 17 Jul 2012 20:03:30 +0000 (16:03 -0400)]
start of Xft.  blows up.

12 years agoFix linux makefile.
Reginald Kennedy [Tue, 17 Jul 2012 20:59:24 +0000 (04:59 +0800)]
Fix linux makefile.

12 years agodont errx when xcb_query_font_reply fails + spaces
Marco Peereboom [Tue, 17 Jul 2012 19:50:05 +0000 (14:50 -0500)]
dont errx when xcb_query_font_reply fails + spaces

12 years agobring back the Display variable. Will be needed for the font code.
David Hill [Tue, 17 Jul 2012 18:52:32 +0000 (14:52 -0400)]
bring back the Display variable.  Will be needed for the font code.

12 years agomake search_win use the same font as the bar
David Hill [Tue, 17 Jul 2012 06:40:05 +0000 (02:40 -0400)]
make search_win use the same font as the bar

12 years agofix up search_win to use new font code calculations as well.
David Hill [Tue, 17 Jul 2012 06:34:51 +0000 (02:34 -0400)]
fix up search_win to use new font code calculations as well.

12 years agoa reasonable first attempt to get the bar and bar fonts to look nice.
David Hill [Tue, 17 Jul 2012 06:02:07 +0000 (02:02 -0400)]
a reasonable first attempt to get the bar and bar fonts to look nice.

some calculations may need to be adjusted.

12 years agoallow bar_font to work again.
David Hill [Tue, 17 Jul 2012 03:23:40 +0000 (23:23 -0400)]
allow bar_font to work again.

12 years agodrop some X11 includes, begone Xlib!
Marco Peereboom [Tue, 17 Jul 2012 00:49:42 +0000 (19:49 -0500)]
drop some X11 includes, begone Xlib!

12 years agoRemove an empty line.
Reginald Kennedy [Tue, 17 Jul 2012 00:21:19 +0000 (08:21 +0800)]
Remove an empty line.

12 years agoFix xrandr epileptic seizure issue.
Reginald Kennedy [Tue, 17 Jul 2012 00:17:22 +0000 (08:17 +0800)]
Fix xrandr epileptic seizure issue.

12 years agoFix issue where _NET_ACTIVE_WINDOW is ignored on unmapped, unmanaged
Reginald Kennedy [Mon, 16 Jul 2012 19:07:26 +0000 (03:07 +0800)]
Fix issue where _NET_ACTIVE_WINDOW is ignored on unmapped, unmanaged
windows. Skype works!

Move atom name query in propertynotify to a separate function.

Rename active_wm() to enable_wm() since the purpose of the function is
to enable X window management.  The error check is now done within the
function. Like before, return 0 on success; 1 on failure.

New debug type: SWM_D_INIT

More type casting.

12 years agoadd a couple more xcb_flush()'s
David Hill [Mon, 16 Jul 2012 19:04:52 +0000 (15:04 -0400)]
add a couple more xcb_flush()'s

12 years agoFix a few more -Wextra warnings.
Reginald Kennedy [Mon, 16 Jul 2012 10:15:48 +0000 (18:15 +0800)]
Fix a few more -Wextra warnings.

12 years agocast a few types to strtonum
David Hill [Mon, 16 Jul 2012 05:05:05 +0000 (01:05 -0400)]
cast a few types to strtonum

12 years agofix some sign compare warnings
David Hill [Mon, 16 Jul 2012 05:02:34 +0000 (01:02 -0400)]
fix some sign compare warnings

12 years agounused defines
David Hill [Mon, 16 Jul 2012 02:47:39 +0000 (22:47 -0400)]
unused defines

12 years agoremove no longer needed includes.
David Hill [Mon, 16 Jul 2012 01:00:13 +0000 (21:00 -0400)]
remove no longer needed includes.

12 years agoremove no longer used functions
David Hill [Mon, 16 Jul 2012 00:57:58 +0000 (20:57 -0400)]
remove no longer used functions

12 years agoremove unneeded warnings
David Hill [Mon, 16 Jul 2012 00:57:09 +0000 (20:57 -0400)]
remove unneeded warnings

12 years agoprefetch the xcb_randr_id so we don't block later
David Hill [Mon, 16 Jul 2012 00:45:20 +0000 (20:45 -0400)]
prefetch the xcb_randr_id so we don't block later

12 years agoremove extra lib dependancies from Makefile
David Hill [Mon, 16 Jul 2012 00:43:01 +0000 (20:43 -0400)]
remove extra lib dependancies from Makefile

12 years agoremove -lXlib-xcb and -lXtst. Replace with -lX11 and -lxcb.
David Hill [Mon, 16 Jul 2012 00:41:00 +0000 (20:41 -0400)]
remove -lXlib-xcb and -lXtst.  Replace with -lX11 and -lxcb.

-lX11 is still needed for keysym stuff.

12 years agoGet rid of XOpenDisplay. Use xcb_connect now!
David Hill [Mon, 16 Jul 2012 00:38:25 +0000 (20:38 -0400)]
Get rid of XOpenDisplay.  Use xcb_connect now!

12 years agoFix startup error by disabling all traces of xlib font sets.
Reginald Kennedy [Sun, 15 Jul 2012 19:41:18 +0000 (03:41 +0800)]
Fix startup error by disabling all traces of xlib font sets.
The XCreateFontSet() call was failing.

next step is to eliminate the remaining Xlib calls and get bar fonts to
work as they should.

12 years agoredo checking for an active wm with xcb
David Hill [Sun, 15 Jul 2012 18:23:26 +0000 (14:23 -0400)]
redo checking for an active wm with xcb

12 years agoremove commented out Xlib code
David Hill [Sun, 15 Jul 2012 20:27:00 +0000 (16:27 -0400)]
remove commented out Xlib code

12 years agoconvert XkbKeycodeToKeysym to xcb
David Hill [Sun, 15 Jul 2012 20:23:39 +0000 (16:23 -0400)]
convert XkbKeycodeToKeysym to xcb

12 years agoNoSymbol to XCB_NO_SYMBOL
David Hill [Sun, 15 Jul 2012 20:08:59 +0000 (16:08 -0400)]
NoSymbol to XCB_NO_SYMBOL

12 years agorename atom variables to begin with a_
David Hill [Sun, 15 Jul 2012 20:05:27 +0000 (16:05 -0400)]
rename atom variables to begin with a_

12 years agouse xcb instead of RootWindow
David Hill [Sun, 15 Jul 2012 18:50:07 +0000 (14:50 -0400)]
use xcb instead of RootWindow

12 years agomove some things into setup_globals()
David Hill [Sun, 15 Jul 2012 18:00:46 +0000 (14:00 -0400)]
move some things into setup_globals()

12 years agobar_update() on cycle_layout() for the indicator.
Reginald Kennedy [Sun, 15 Jul 2012 15:46:29 +0000 (23:46 +0800)]
bar_update() on cycle_layout() for the indicator.

12 years agoDrain EnterNotify in stack() when appropriate.
Reginald Kennedy [Sun, 15 Jul 2012 15:29:20 +0000 (23:29 +0800)]
Drain EnterNotify in stack() when appropriate.

12 years agoAdd event_drain() and drain EnterNotify where appropriate.
Reginald Kennedy [Sun, 15 Jul 2012 15:24:52 +0000 (23:24 +0800)]
Add event_drain() and drain EnterNotify where appropriate.

12 years agojust some minor cleanup. whitespace, cast types, etc
David Hill [Sun, 15 Jul 2012 14:12:56 +0000 (10:12 -0400)]
just some minor cleanup.  whitespace, cast types, etc

12 years agoget rid of the if 0 code. sick of seeing it.
David Hill [Sun, 15 Jul 2012 13:56:47 +0000 (09:56 -0400)]
get rid of the if 0 code.  sick of seeing it.

12 years agoSome OpenBSD styling cleanup.
Reginald Kennedy [Sun, 15 Jul 2012 13:26:41 +0000 (21:26 +0800)]
Some OpenBSD styling cleanup.
keyfunc names are now uppercase.

Add -Wextra to Linux Makefile for dev purposes.

Remove unneeded dummykeyfunc().

12 years agoUpdate freebsd Makefile.
Reginald Kennedy [Sun, 15 Jul 2012 13:17:19 +0000 (21:17 +0800)]
Update freebsd Makefile.

Submitted by Erandir

12 years agoAdd a few more xcb_flush().
Reginald Kennedy [Sun, 15 Jul 2012 09:26:47 +0000 (17:26 +0800)]
Add a few more xcb_flush().

Remove whitespace.

12 years agoAdd another xcb_flush() into a key position.
Reginald Kennedy [Sun, 15 Jul 2012 09:06:10 +0000 (17:06 +0800)]
Add another xcb_flush() into a key position.

12 years agoundo if 0 the select code.
David Hill [Sun, 15 Jul 2012 06:41:30 +0000 (02:41 -0400)]
undo if 0 the select code.