/*\r
-Copyright (c) 2003-2010, CKSource - Frederico Knabben. All rights reserved.\r
+Copyright (c) 2003-2011, CKSource - Frederico Knabben. All rights reserved.\r
For licensing, see LICENSE.html or http://ckeditor.com/license\r
*/\r
\r
else\r
element.hide();\r
}\r
+\r
+ dialog.layout();\r
};\r
\r
// Loads the parameters in a selected link to the link dialog fields.\r
\r
var parseLink = function( editor, element )\r
{\r
- var href = ( element && ( element.getAttribute( '_cke_saved_href' ) || element.getAttribute( 'href' ) ) ) || '',\r
+ var href = ( element && ( element.data( 'cke-saved-href' ) || element.getAttribute( 'href' ) ) ) || '',\r
javascriptMatch,\r
emailMatch,\r
anchorMatch,\r
// IE BUG: target attribute is an empty string instead of null in IE if it's not set.\r
if ( !target )\r
{\r
- var onclick = element.getAttribute( '_cke_pa_onclick' ) || element.getAttribute( 'onclick' ),\r
+ var onclick = element.data( 'cke-pa-onclick' ) || element.getAttribute( 'onclick' ),\r
onclickMatch = onclick && onclick.match( popupRegex );\r
if ( onclickMatch )\r
{\r
advAttr( 'advId', 'id' );\r
advAttr( 'advLangDir', 'dir' );\r
advAttr( 'advAccessKey', 'accessKey' );\r
- advAttr( 'advName', 'name' );\r
+\r
+ retval.adv.advName =\r
+ element.data( 'cke-saved-name' )\r
+ || element.getAttribute( 'name' )\r
+ || '';\r
advAttr( 'advLangCode', 'lang' );\r
advAttr( 'advTabIndex', 'tabindex' );\r
advAttr( 'advTitle', 'title' );\r
for ( var i = 0; i < elements.count() ; i++ )\r
{\r
var item = elements.getItem( i );\r
- if ( item.getAttribute( '_cke_realelement' ) && item.getAttribute( '_cke_real_element_type' ) == 'anchor' )\r
+ if ( item.data( 'cke-realelement' ) && item.data( 'cke-real-element-type' ) == 'anchor' )\r
anchors.push( editor.restoreRealElement( item ) );\r
}\r
\r
this.allowOnChange = false;\r
var protocolCmb = this.getDialog().getContentElement( 'info', 'protocol' ),\r
url = this.getValue(),\r
- urlOnChangeProtocol = /^(http|https|ftp|news):\/\/(?=.)/gi,\r
- urlOnChangeTestOther = /^((javascript:)|[#\/\.\?])/gi;\r
+ urlOnChangeProtocol = /^(http|https|ftp|news):\/\/(?=.)/i,\r
+ urlOnChangeTestOther = /^((javascript:)|[#\/\.\?])/i;\r
\r
var protocol = urlOnChangeProtocol.exec( url );\r
if ( protocol )\r
setup : function( data )\r
{\r
if ( data.target )\r
- this.setValue( data.target.type );\r
+ this.setValue( data.target.type || 'notSet' );\r
targetChanged.call( this );\r
},\r
commit : function( data )\r
},\r
{\r
type : 'vbox',\r
- width : 260,\r
+ width : '100%',\r
align : 'center',\r
padding : 2,\r
id : 'popupFeatures',\r
[\r
{\r
type : 'text',\r
- widths : [ '30%', '70%' ],\r
+ widths : [ '50%', '50%' ],\r
labelLayout : 'horizontal',\r
- label : linkLang.popupWidth,\r
+ label : commonLang.width,\r
id : 'width',\r
setup : setupPopupParams,\r
commit : commitPopupParams\r
{\r
type : 'text',\r
labelLayout : 'horizontal',\r
- widths : [ '55%', '45%' ],\r
+ widths : [ '50%', '50%' ],\r
label : linkLang.popupLeft,\r
id : 'left',\r
setup : setupPopupParams,\r
{\r
type : 'text',\r
labelLayout : 'horizontal',\r
- widths : [ '30%', '70%' ],\r
- label : linkLang.popupHeight,\r
+ widths : [ '50%', '50%' ],\r
+ label : commonLang.height,\r
id : 'height',\r
setup : setupPopupParams,\r
commit : commitPopupParams\r
type : 'text',\r
labelLayout : 'horizontal',\r
label : linkLang.popupTop,\r
- widths : [ '55%', '45%' ],\r
+ widths : [ '50%', '50%' ],\r
id : 'top',\r
setup : setupPopupParams,\r
commit : commitPopupParams\r
if ( ( element = plugin.getSelectedLink( editor ) ) && element.hasAttribute( 'href' ) )\r
selection.selectElement( element );\r
else if ( ( element = selection.getSelectedElement() ) && element.is( 'img' )\r
- && element.getAttribute( '_cke_real_element_type' )\r
- && element.getAttribute( '_cke_real_element_type' ) == 'anchor' )\r
+ && element.data( 'cke-real-element-type' )\r
+ && element.data( 'cke-real-element-type' ) == 'anchor' )\r
{\r
this.fakeObj = element;\r
element = editor.restoreRealElement( this.fakeObj );\r
},\r
onOk : function()\r
{\r
- var attributes = { href : 'javascript:void(0)/*' + CKEDITOR.tools.getNextNumber() + '*/' },\r
+ var attributes = {},\r
removeAttributes = [],\r
- data = { href : attributes.href },\r
+ data = {},\r
me = this,\r
editor = this.getParentEditor();\r
\r
case 'url':\r
var protocol = ( data.url && data.url.protocol != undefined ) ? data.url.protocol : 'http://',\r
url = ( data.url && data.url.url ) || '';\r
- attributes._cke_saved_href = ( url.indexOf( '/' ) === 0 ) ? url : protocol + url;\r
+ attributes[ 'data-cke-saved-href' ] = ( url.indexOf( '/' ) === 0 ) ? url : protocol + url;\r
break;\r
case 'anchor':\r
var name = ( data.anchor && data.anchor.name ),\r
id = ( data.anchor && data.anchor.id );\r
- attributes._cke_saved_href = '#' + ( name || id || '' );\r
+ attributes[ 'data-cke-saved-href' ] = '#' + ( name || id || '' );\r
break;\r
case 'email':\r
\r
}\r
}\r
\r
- attributes._cke_saved_href = linkHref.join( '' );\r
+ attributes[ 'data-cke-saved-href' ] = linkHref.join( '' );\r
break;\r
}\r
\r
addFeature( 'top' );\r
\r
onclickList.push( featureList.join( ',' ), '\'); return false;' );\r
- attributes[ '_cke_pa_onclick' ] = onclickList.join( '' );\r
+ attributes[ 'data-cke-pa-onclick' ] = onclickList.join( '' );\r
\r
// Add the "target" attribute. (#5074)\r
removeAttributes.push( 'target' );\r
else\r
removeAttributes.push( 'target' );\r
\r
- removeAttributes.push( '_cke_pa_onclick', 'onclick' );\r
+ removeAttributes.push( 'data-cke-pa-onclick', 'onclick' );\r
}\r
}\r
\r
removeAttributes.push( attrName );\r
};\r
\r
- if ( this._.selectedElement )\r
- advAttr( 'advId', 'id' );\r
+ advAttr( 'advId', 'id' );\r
advAttr( 'advLangDir', 'dir' );\r
advAttr( 'advAccessKey', 'accessKey' );\r
- advAttr( 'advName', 'name' );\r
+\r
+ if ( data.adv[ 'advName' ] )\r
+ {\r
+ attributes[ 'name' ] = attributes[ 'data-cke-saved-name' ] = data.adv[ 'advName' ];\r
+ attributes[ 'class' ] = ( attributes[ 'class' ] ? attributes[ 'class' ] + ' ' : '' ) + 'cke_anchor';\r
+ }\r
+ else\r
+ removeAttributes = removeAttributes.concat( [ 'data-cke-saved-name', 'name' ] );\r
+\r
advAttr( 'advLangCode', 'lang' );\r
advAttr( 'advTabIndex', 'tabindex' );\r
advAttr( 'advTitle', 'title' );\r
advAttr( 'advStyles', 'style' );\r
}\r
\r
+\r
+ // Browser need the "href" fro copy/paste link to work. (#6641)\r
+ attributes.href = attributes[ 'data-cke-saved-href' ];\r
+\r
if ( !this._.selectedElement )\r
{\r
// Create element if current selection is collapsed.\r
{\r
// Short mailto link text view (#5736).\r
var text = new CKEDITOR.dom.text( data.type == 'email' ?\r
- data.email.address : attributes._cke_saved_href, editor.document );\r
+ data.email.address : attributes[ 'data-cke-saved-href' ], editor.document );\r
ranges[0].insertNode( text );\r
ranges[0].selectNodeContents( text );\r
selection.selectRanges( ranges );\r
var style = new CKEDITOR.style( { element : 'a', attributes : attributes } );\r
style.type = CKEDITOR.STYLE_INLINE; // need to override... dunno why.\r
style.apply( editor.document );\r
-\r
- // Id. Apply only to the first link.\r
- if ( data.adv && data.adv.advId )\r
- {\r
- var links = this.getParentEditor().document.$.getElementsByTagName( 'a' );\r
- for ( i = 0 ; i < links.length ; i++ )\r
- {\r
- if ( links[i].href == attributes.href )\r
- {\r
- links[i].id = data.adv.advId;\r
- break;\r
- }\r
- }\r
- }\r
}\r
else\r
{\r
// We're only editing an existing link, so just overwrite the attributes.\r
var element = this._.selectedElement,\r
- href = element.getAttribute( '_cke_saved_href' ),\r
+ href = element.data( 'cke-saved-href' ),\r
textView = element.getHtml();\r
\r
// IE BUG: Setting the name attribute to an existing link doesn't work.\r
\r
selection = editor.getSelection();\r
\r
- element.moveChildren( newElement );\r
element.copyAttributes( newElement, { name : 1 } );\r
+ element.moveChildren( newElement );\r
newElement.replace( element );\r
element = newElement;\r
\r
{\r
// Short mailto link text view (#5736).\r
element.setHtml( data.type == 'email' ?\r
- data.email.address : attributes._cke_saved_href );\r
+ data.email.address : attributes[ 'data-cke-saved-href' ] );\r
}\r
// Make the element display as an anchor if a name has been set.\r
if ( element.getAttribute( 'name' ) )\r
Got questions, comments, patches, etc.? Contact Jason Woofenden