X-Git-Url: https://jasonwoof.com/gitweb/?p=dwm.git;a=blobdiff_plain;f=dwm.c;h=29af1bd29499d67dbf7b212b822fef51a54ddc70;hp=997a220f0cacb0bb9af5529d31528b47305b2aa5;hb=016dca4f694cb51c7db77aeeefcb55b8869f3842;hpb=b848f4bda8861115c04aecd9fd87baf928d931de diff --git a/dwm.c b/dwm.c index 997a220..29af1bd 100644 --- a/dwm.c +++ b/dwm.c @@ -16,8 +16,8 @@ * Each child of the root window is called a client, except windows which have * set the override_redirect flag. Clients are organized in a global * doubly-linked client list, the focus history is remembered through a global - * stack list. Each client contains an array of Bools of the same size as the - * global tags array to indicate the tags of a client. + * stack list. Each client contains a bit array to indicate the tags of a + * client. * * Keys and tagging rules are organized as arrays and defined in config.h. * @@ -39,52 +39,48 @@ #include #include #include +#ifdef XINERAMA +#include +#endif /* macros */ -#define MAX(a, b) ((a)>(b)?(a):(b)) -#define MIN(a, b) ((a)<(b)?(a):(b)) -#define BUTTONMASK (ButtonPressMask|ButtonReleaseMask) -#define CLEANMASK(mask) (mask & ~(numlockmask|LockMask)) -#define LENGTH(x) (sizeof x / sizeof x[0]) -#define MAXTAGLEN 16 -#define MOUSEMASK (BUTTONMASK|PointerMotionMask) -#define DEFGEOM(GEONAME,BX,BY,BW,WX,WY,WW,WH,MX,MY,MW,MH,TX,TY,TW,TH,MOX,MOY,MOW,MOH) \ -void GEONAME(void) { \ - bx = (BX); by = (BY); bw = (BW); \ - wx = (WX); wy = (WY); ww = (WW); wh = (WH); \ - mx = (MX); my = (MY); mw = (MW); mh = (MH); \ - tx = (TX); ty = (TY); tw = (TW); th = (TH); \ - mox = (MOX); moy = (MOY); mow = (MOW); moh = (MOH); \ -} +#define MAX(a, b) ((a) > (b) ? (a) : (b)) +#define MIN(a, b) ((a) < (b) ? (a) : (b)) +#define BUTTONMASK (ButtonPressMask|ButtonReleaseMask) +#define CLEANMASK(mask) (mask & ~(numlockmask|LockMask)) +#define LENGTH(x) (sizeof x / sizeof x[0]) +#define MAXTAGLEN 16 +#define MOUSEMASK (BUTTONMASK|PointerMotionMask) +#define TAGMASK ((int)((1LL << LENGTH(tags)) - 1)) +#define TEXTW(x) (textnw(x, strlen(x)) + dc.font.height) /* enums */ -enum { CurNormal, CurResize, CurMove, CurLast }; /* cursor */ -enum { ColBorder, ColFG, ColBG, ColLast }; /* color */ -enum { NetSupported, NetWMName, NetLast }; /* EWMH atoms */ +enum { CurNormal, CurResize, CurMove, CurLast }; /* cursor */ +enum { ColBorder, ColFG, ColBG, ColLast }; /* color */ +enum { NetSupported, NetWMName, NetLast }; /* EWMH atoms */ enum { WMProtocols, WMDelete, WMName, WMState, WMLast };/* default atoms */ /* typedefs */ +typedef unsigned int uint; +typedef unsigned long ulong; typedef struct Client Client; struct Client { char name[256]; int x, y, w, h; - int fx, fy, fw, fh; int basew, baseh, incw, inch, maxw, maxh, minw, minh; - int minax, maxax, minay, maxay; - long flags; - unsigned int bw, oldbw; - Bool isbanned, isfixed, isfloating, isurgent; - Bool *tags; + float mina, maxa; + int bw, oldbw; + Bool isbanned, isfixed, isfloating, ismoved, isurgent; + uint tags; Client *next; - Client *prev; Client *snext; Window win; }; typedef struct { int x, y, w, h; - unsigned long norm[ColLast]; - unsigned long sel[ColLast]; + ulong norm[ColLast]; + ulong sel[ColLast]; Drawable drawable; GC gc; struct { @@ -96,128 +92,114 @@ typedef struct { } font; } DC; /* draw context */ -typedef struct { - const char *symbol; - void (*apply)(void); -} Geom; +typedef union { + int i; + uint ui; + float f; + void *v; +} Arg; typedef struct { - unsigned long mod; + uint mod; KeySym keysym; - void (*func)(const char *arg); - const char *arg; + void (*func)(const Arg *); + const Arg arg; } Key; typedef struct { const char *symbol; void (*arrange)(void); - Bool isfloating; } Layout; typedef struct { const char *class; const char *instance; const char *title; - const char *tag; + uint tags; Bool isfloating; } Rule; /* function declarations */ -void applyrules(Client *c); -void arrange(void); -void attach(Client *c); -void attachstack(Client *c); -void ban(Client *c); -void buttonpress(XEvent *e); -void checkotherwm(void); -void cleanup(void); -void configure(Client *c); -void configurenotify(XEvent *e); -void configurerequest(XEvent *e); -unsigned int counttiled(void); -void destroynotify(XEvent *e); -void detach(Client *c); -void detachstack(Client *c); -void drawbar(void); -void drawsquare(Bool filled, Bool empty, Bool invert, unsigned long col[ColLast]); -void drawtext(const char *text, unsigned long col[ColLast], Bool invert); -void *emallocz(unsigned int size); -void enternotify(XEvent *e); -void eprint(const char *errstr, ...); -void expose(XEvent *e); -void focus(Client *c); -void focusin(XEvent *e); -void focusnext(const char *arg); -void focusprev(const char *arg); -Client *getclient(Window w); -unsigned long getcolor(const char *colstr); -long getstate(Window w); -Bool gettextprop(Window w, Atom atom, char *text, unsigned int size); -void grabbuttons(Client *c, Bool focused); -void grabkeys(void); -unsigned int idxoftag(const char *t); -void initfont(const char *fontstr); -Bool isoccupied(unsigned int t); -Bool isprotodel(Client *c); -Bool isurgent(unsigned int t); -Bool isvisible(Client *c); -void keypress(XEvent *e); -void killclient(const char *arg); -void manage(Window w, XWindowAttributes *wa); -void mappingnotify(XEvent *e); -void maprequest(XEvent *e); -void monocle(void); -void movemouse(Client *c); -Client *nexttiled(Client *c); -void propertynotify(XEvent *e); -void quit(const char *arg); -void reapply(const char *arg); -void resize(Client *c, int x, int y, int w, int h, Bool sizehints); -void resizemouse(Client *c); -void restack(void); -void run(void); -void scan(void); -void setclientstate(Client *c, long state); -void setgeom(const char *arg); -void setlayout(const char *arg); -void setmfact(const char *arg); -void setup(void); -void spawn(const char *arg); -void tag(const char *arg); -unsigned int textnw(const char *text, unsigned int len); -unsigned int textw(const char *text); -void tileh(void); -void tilehstack(unsigned int n); -Client *tilemaster(unsigned int n); -void tileresize(Client *c, int x, int y, int w, int h); -void tilev(void); -void tilevstack(unsigned int n); -void togglefloating(const char *arg); -void toggletag(const char *arg); -void toggleview(const char *arg); -void unban(Client *c); -void unmanage(Client *c); -void unmapnotify(XEvent *e); -void updatebarpos(void); -void updatesizehints(Client *c); -void updatetitle(Client *c); -void updatewmhints(Client *c); -void view(const char *arg); -void viewprevtag(const char *arg); /* views previous selected tags */ -int xerror(Display *dpy, XErrorEvent *ee); -int xerrordummy(Display *dpy, XErrorEvent *ee); -int xerrorstart(Display *dpy, XErrorEvent *ee); -void zoom(const char *arg); +static void applyrules(Client *c); +static void arrange(void); +static void attach(Client *c); +static void attachstack(Client *c); +static void buttonpress(XEvent *e); +static void checkotherwm(void); +static void cleanup(void); +static void configure(Client *c); +static void configurenotify(XEvent *e); +static void configurerequest(XEvent *e); +static void destroynotify(XEvent *e); +static void detach(Client *c); +static void detachstack(Client *c); +static void drawbar(void); +static void drawsquare(Bool filled, Bool empty, Bool invert, ulong col[ColLast]); +static void drawtext(const char *text, ulong col[ColLast], Bool invert); +static void enternotify(XEvent *e); +static void eprint(const char *errstr, ...); +static void expose(XEvent *e); +static void focus(Client *c); +static void focusin(XEvent *e); +static void focusstack(const Arg *arg); +static Client *getclient(Window w); +static ulong getcolor(const char *colstr); +static long getstate(Window w); +static Bool gettextprop(Window w, Atom atom, char *text, uint size); +static void grabbuttons(Client *c, Bool focused); +static void grabkeys(void); +static void initfont(const char *fontstr); +static Bool isoccupied(uint t); +static Bool isprotodel(Client *c); +static Bool isurgent(uint t); +static void keypress(XEvent *e); +static void killclient(const Arg *arg); +static void manage(Window w, XWindowAttributes *wa); +static void mappingnotify(XEvent *e); +static void maprequest(XEvent *e); +static void movemouse(Client *c); +static Client *nexttiled(Client *c); +static void propertynotify(XEvent *e); +static void quit(const Arg *arg); +static void resize(Client *c, int x, int y, int w, int h, Bool sizehints); +static void resizemouse(Client *c); +static void restack(void); +static void run(void); +static void scan(void); +static void setclientstate(Client *c, long state); +static void setmfact(const Arg *arg); +static void setup(void); +static void spawn(const Arg *arg); +static void tag(const Arg *arg); +static int textnw(const char *text, uint len); +static void tile(void); +static void togglebar(const Arg *arg); +static void togglefloating(const Arg *arg); +static void togglelayout(const Arg *arg); +static void togglemax(const Arg *arg); +static void toggletag(const Arg *arg); +static void toggleview(const Arg *arg); +static void unmanage(Client *c); +static void unmapnotify(XEvent *e); +static void updatebar(void); +static void updategeom(void); +static void updatesizehints(Client *c); +static void updatetitle(Client *c); +static void updatewmhints(Client *c); +static void view(const Arg *arg); +static int xerror(Display *dpy, XErrorEvent *ee); +static int xerrordummy(Display *dpy, XErrorEvent *ee); +static int xerrorstart(Display *dpy, XErrorEvent *ee); +static void zoom(const Arg *arg); /* variables */ -char stext[256]; -int screen, sx, sy, sw, sh; -int (*xerrorxlib)(Display *, XErrorEvent *); -int bx, by, bw, bh, blw, bgw, mx, my, mw, mh, mox, moy, mow, moh, tx, ty, tw, th, wx, wy, ww, wh; -int seltags = 0; -double mfact; -unsigned int numlockmask = 0; -void (*handler[LASTEvent]) (XEvent *) = { +static char stext[256]; +static int screen, sx, sy, sw, sh; +static int by, bh, blw, wx, wy, ww, wh; +static uint seltags = 0; +static int (*xerrorxlib)(Display *, XErrorEvent *); +static uint numlockmask = 0; +static void (*handler[LASTEvent]) (XEvent *) = { [ButtonPress] = buttonpress, [ConfigureRequest] = configurerequest, [ConfigureNotify] = configurenotify, @@ -231,32 +213,29 @@ void (*handler[LASTEvent]) (XEvent *) = { [PropertyNotify] = propertynotify, [UnmapNotify] = unmapnotify }; -Atom wmatom[WMLast], netatom[NetLast]; -Bool otherwm, readin; -Bool running = True; -Bool *tagset[2]; -Client *clients = NULL; -Client *sel = NULL; -Client *stack = NULL; -Cursor cursor[CurLast]; -Display *dpy; -DC dc = {0}; -Geom geoms[]; -Geom *geom = geoms; -Layout layouts[]; -Layout *lt = layouts; -Window root, barwin; - +static Atom wmatom[WMLast], netatom[NetLast]; +static Bool ismax = False; +static Bool otherwm, readin; +static Bool running = True; +static uint tagset[] = {1, 1}; /* after start, first tag is selected */ +static Client *clients = NULL; +static Client *sel = NULL; +static Client *stack = NULL; +static Cursor cursor[CurLast]; +static Display *dpy; +static DC dc = {0}; +static Layout *lt = NULL; +static Window root, barwin; /* configuration, allows nested code to access above variables */ #include "config.h" -#define TAGSZ (LENGTH(tags) * sizeof(Bool)) -/* function implementations */ +/* compile-time check if all tags fit into an uint bit array. */ +struct NumTags { char limitexceeded[sizeof(uint) * 8 < LENGTH(tags) ? -1 : 1]; }; +/* function implementations */ void applyrules(Client *c) { - unsigned int i; - Bool matched = False; + uint i; Rule *r; XClassHint ch = { 0 }; @@ -268,18 +247,15 @@ applyrules(Client *c) { && (!r->class || (ch.res_class && strstr(ch.res_class, r->class))) && (!r->instance || (ch.res_name && strstr(ch.res_name, r->instance)))) { c->isfloating = r->isfloating; - if(r->tag) { - c->tags[idxoftag(r->tag)] = True; - matched = True; - } + c->tags |= r->tags & TAGMASK; } } if(ch.res_class) XFree(ch.res_class); if(ch.res_name) XFree(ch.res_name); - if(!matched) - memcpy(c->tags, tagset[seltags], TAGSZ); + if(!c->tags) + c->tags = tagset[seltags]; } void @@ -287,24 +263,28 @@ arrange(void) { Client *c; for(c = clients; c; c = c->next) - if(isvisible(c)) { - unban(c); - if(lt->isfloating || c->isfloating) - resize(c, c->fx, c->fy, c->fw, c->fh, True); + if(c->tags & tagset[seltags]) { /* is visible */ + if(ismax && !c->isfixed) { + XMoveResizeWindow(dpy, c->win, wx, wy, ww - 2 * c->bw, wh - 2 * c->bw); + c->ismoved = True; + } + else if(!lt->arrange || c->isfloating) + resize(c, c->x, c->y, c->w, c->h, True); + c->isbanned = False; + } + else if(!c->isbanned) { + XMoveWindow(dpy, c->win, c->x + 2 * sw, c->y); + c->isbanned = c->ismoved = True; } - else - ban(c); focus(NULL); - if(lt->arrange) + if(lt->arrange && !ismax) lt->arrange(); restack(); } void attach(Client *c) { - if(clients) - clients->prev = c; c->next = clients; clients = c; } @@ -316,64 +296,50 @@ attachstack(Client *c) { } void -ban(Client *c) { - if(c->isbanned) - return; - XMoveWindow(dpy, c->win, c->x + 2 * sw, c->y); - c->isbanned = True; -} - -void buttonpress(XEvent *e) { - unsigned int i, x; + uint i, mask; + int x; Client *c; XButtonPressedEvent *ev = &e->xbutton; if(ev->window == barwin) { - if((ev->x < bgw) && ev->button == Button1) { - setgeom(NULL); - return; - } - x = bgw; + x = 0; for(i = 0; i < LENGTH(tags); i++) { - x += textw(tags[i]); - if(ev->x >= bgw && ev->x < x) { + x += TEXTW(tags[i]); + if(ev->x < x) { + mask = 1 << i; if(ev->button == Button1) { if(ev->state & MODKEY) - tag(tags[i]); + tag((Arg*)&mask); else - view(tags[i]); + view((Arg*)&mask); } else if(ev->button == Button3) { if(ev->state & MODKEY) - toggletag(tags[i]); + toggletag((Arg*)&mask); else - toggleview(tags[i]); + toggleview((Arg*)&mask); } return; } } - if((ev->x < x + blw) && ev->button == Button1) - setlayout(NULL); + if(ev->x < x + blw) { + if(ev->button == Button1) + togglelayout(NULL); + else if(ev->button == Button3) + togglemax(NULL); + } } else if((c = getclient(ev->window))) { focus(c); - if(CLEANMASK(ev->state) != MODKEY) + if(CLEANMASK(ev->state) != MODKEY || (ismax && !c->isfixed)) return; - if(ev->button == Button1) { - restack(); + if(ev->button == Button1) movemouse(c); - } - else if(ev->button == Button2) { - if(!lt->isfloating && c->isfloating) - togglefloating(NULL); - else - zoom(NULL); - } - else if(ev->button == Button3 && !c->isfixed) { - restack(); + else if(ev->button == Button2) + togglefloating(NULL); + else if(ev->button == Button3 && !c->isfixed) resizemouse(c); - } } } @@ -387,7 +353,6 @@ checkotherwm(void) { XSync(dpy, False); if(otherwm) eprint("dwm: another window manager is already running\n"); - XSync(dpy, False); XSetErrorHandler(NULL); xerrorxlib = XSetErrorHandler(xerror); XSync(dpy, False); @@ -395,11 +360,14 @@ checkotherwm(void) { void cleanup(void) { + Arg a = {.i = ~0}; + Layout foo = { "", NULL }; + close(STDIN_FILENO); - while(stack) { - unban(stack); + view(&a); + lt = &foo; + while(stack) unmanage(stack); - } if(dc.font.set) XFreeFontSet(dpy, dc.font.set); else @@ -440,7 +408,9 @@ configurenotify(XEvent *e) { if(ev->window == root && (ev->width != sw || ev->height != sh)) { sw = ev->width; sh = ev->height; - setgeom(geom->symbol); + updategeom(); + updatebar(); + arrange(); } } @@ -453,7 +423,9 @@ configurerequest(XEvent *e) { if((c = getclient(ev->window))) { if(ev->value_mask & CWBorderWidth) c->bw = ev->border_width; - if(c->isfixed || c->isfloating || lt->isfloating) { + if(ismax && !c->isbanned && !c->isfixed) + XMoveResizeWindow(dpy, c->win, wx, wy, ww - 2 * c->bw, wh + 2 * c->bw); + else if(c->isfloating || !lt->arrange) { if(ev->value_mask & CWX) c->x = sx + ev->x; if(ev->value_mask & CWY) @@ -469,7 +441,7 @@ configurerequest(XEvent *e) { if((ev->value_mask & (CWX|CWY)) && !(ev->value_mask & (CWWidth|CWHeight))) configure(c); - if(isvisible(c)) + if(!c->isbanned) XMoveResizeWindow(dpy, c->win, c->x, c->y, c->w, c->h); } else @@ -488,15 +460,6 @@ configurerequest(XEvent *e) { XSync(dpy, False); } -unsigned int -counttiled(void) { - unsigned int n; - Client *c; - - for(n = 0, c = nexttiled(clients); c; c = nexttiled(c->next), n++); - return n; -} - void destroynotify(XEvent *e) { Client *c; @@ -508,20 +471,23 @@ destroynotify(XEvent *e) { void detach(Client *c) { - if(c->prev) - c->prev->next = c->next; - if(c->next) - c->next->prev = c->prev; - if(c == clients) + Client *i; + + if (c != clients) { + for(i = clients; i->next != c; i = i->next); + i->next = c->next; + } + else { clients = c->next; - c->next = c->prev = NULL; + } + c->next = NULL; } void detachstack(Client *c) { Client **tc; - for(tc=&stack; *tc && *tc != c; tc=&(*tc)->snext); + for(tc = &stack; *tc && *tc != c; tc = &(*tc)->snext); *tc = c->snext; } @@ -531,53 +497,48 @@ drawbar(void) { Client *c; dc.x = 0; - if(bgw > 0) { - dc.w = bgw; - drawtext(geom->symbol, dc.norm, False); - dc.x += bgw; - } - for(c = stack; c && !isvisible(c); c = c->snext); + for(c = stack; c && c->isbanned; c = c->snext); for(i = 0; i < LENGTH(tags); i++) { - dc.w = textw(tags[i]); - if(tagset[seltags][i]) { + dc.w = TEXTW(tags[i]); + if(tagset[seltags] & 1 << i) { drawtext(tags[i], dc.sel, isurgent(i)); - drawsquare(c && c->tags[i], isoccupied(i), isurgent(i), dc.sel); + drawsquare(c && c->tags & 1 << i, isoccupied(i), isurgent(i), dc.sel); } else { drawtext(tags[i], dc.norm, isurgent(i)); - drawsquare(c && c->tags[i], isoccupied(i), isurgent(i), dc.norm); + drawsquare(c && c->tags & 1 << i, isoccupied(i), isurgent(i), dc.norm); } dc.x += dc.w; } if(blw > 0) { dc.w = blw; - drawtext(lt->symbol, dc.norm, False); + drawtext(lt->symbol, dc.norm, ismax); x = dc.x + dc.w; } else x = dc.x; - dc.w = textw(stext); - dc.x = bw - dc.w; + dc.w = TEXTW(stext); + dc.x = ww - dc.w; if(dc.x < x) { dc.x = x; - dc.w = bw - x; + dc.w = ww - x; } drawtext(stext, dc.norm, False); if((dc.w = dc.x - x) > bh) { dc.x = x; if(c) { drawtext(c->name, dc.sel, False); - drawsquare(False, c->isfloating, False, dc.sel); + drawsquare(c->isfixed, c->isfloating, False, dc.sel); } else drawtext(NULL, dc.norm, False); } - XCopyArea(dpy, dc.drawable, barwin, dc.gc, 0, 0, bw, bh, 0, 0); + XCopyArea(dpy, dc.drawable, barwin, dc.gc, 0, 0, ww, bh, 0, 0); XSync(dpy, False); } void -drawsquare(Bool filled, Bool empty, Bool invert, unsigned long col[ColLast]) { +drawsquare(Bool filled, Bool empty, Bool invert, ulong col[ColLast]) { int x; XGCValues gcv; XRectangle r = { dc.x, dc.y, dc.w, dc.h }; @@ -598,9 +559,8 @@ drawsquare(Bool filled, Bool empty, Bool invert, unsigned long col[ColLast]) { } void -drawtext(const char *text, unsigned long col[ColLast], Bool invert) { - int x, y, w, h; - unsigned int len, olen; +drawtext(const char *text, ulong col[ColLast], Bool invert) { + int i, x, y, h, len, olen; XRectangle r = { dc.x, dc.y, dc.w, dc.h }; char buf[256]; @@ -611,22 +571,15 @@ drawtext(const char *text, unsigned long col[ColLast], Bool invert) { olen = strlen(text); len = MIN(olen, sizeof buf); memcpy(buf, text, len); - w = 0; h = dc.font.ascent + dc.font.descent; y = dc.y + (dc.h / 2) - (h / 2) + dc.font.ascent; x = dc.x + (h / 2); /* shorten text if necessary */ - for(; len && (w = textnw(buf, len)) > dc.w - h; len--); - if (!len) + for(; len && (i = textnw(buf, len)) > dc.w - h; len--); + if(!len) return; - if(len < olen) { - if(len > 1) - buf[len - 1] = '.'; - if(len > 2) - buf[len - 2] = '.'; - if(len > 3) - buf[len - 3] = '.'; - } + if(len < olen) + for(i = len; i && i > len - 3; buf[--i] = '.'); XSetForeground(dpy, dc.gc, col[invert ? ColBG : ColFG]); if(dc.font.set) XmbDrawString(dpy, dc.drawable, dc.font.set, dc.gc, x, y, buf, len); @@ -634,15 +587,6 @@ drawtext(const char *text, unsigned long col[ColLast], Bool invert) { XDrawString(dpy, dc.drawable, dc.gc, x, y, buf, len); } -void * -emallocz(unsigned int size) { - void *res = calloc(1, size); - - if(!res) - eprint("fatal: could not malloc() %u bytes\n", size); - return res; -} - void enternotify(XEvent *e) { Client *c; @@ -676,8 +620,8 @@ expose(XEvent *e) { void focus(Client *c) { - if(!c || (c && !isvisible(c))) - for(c = stack; c && !isvisible(c); c = c->snext); + if(!c || c->isbanned) + for(c = stack; c && c->isbanned; c = c->snext); if(sel && sel != c) { grabbuttons(sel, False); XSetWindowBorder(dpy, sel->win, dc.norm[ColBorder]); @@ -686,14 +630,12 @@ focus(Client *c) { detachstack(c); attachstack(c); grabbuttons(c, True); - } - sel = c; - if(c) { XSetWindowBorder(dpy, c->win, dc.sel[ColBorder]); XSetInputFocus(dpy, c->win, RevertToPointerRoot, CurrentTime); } else XSetInputFocus(dpy, root, RevertToPointerRoot, CurrentTime); + sel = c; drawbar(); } @@ -706,30 +648,24 @@ focusin(XEvent *e) { /* there are some broken focus acquiring clients */ } void -focusnext(const char *arg) { - Client *c; +focusstack(const Arg *arg) { + Client *c = NULL, *i; if(!sel) return; - for(c = sel->next; c && !isvisible(c); c = c->next); - if(!c) - for(c = clients; c && !isvisible(c); c = c->next); - if(c) { - focus(c); - restack(); + if (arg->i > 0) { + for(c = sel->next; c && c->isbanned; c = c->next); + if(!c) + for(c = clients; c && c->isbanned; c = c->next); } -} - -void -focusprev(const char *arg) { - Client *c; - - if(!sel) - return; - for(c = sel->prev; c && !isvisible(c); c = c->prev); - if(!c) { - for(c = clients; c && c->next; c = c->next); - for(; c && !isvisible(c); c = c->prev); + else { + for(i = clients; i != sel; i = i->next) + if (!i->isbanned) + c = i; + if(!c) + for(; i; i = i->next) + if (!i->isbanned) + c = i; } if(c) { focus(c); @@ -745,7 +681,7 @@ getclient(Window w) { return c; } -unsigned long +ulong getcolor(const char *colstr) { Colormap cmap = DefaultColormap(dpy, screen); XColor color; @@ -760,7 +696,7 @@ getstate(Window w) { int format, status; long result = -1; unsigned char *p = NULL; - unsigned long n, extra; + ulong n, extra; Atom real; status = XGetWindowProperty(dpy, w, wmatom[WMState], 0L, 2L, False, wmatom[WMState], @@ -774,7 +710,7 @@ getstate(Window w) { } Bool -gettextprop(Window w, Atom atom, char *text, unsigned int size) { +gettextprop(Window w, Atom atom, char *text, uint size) { char **list = NULL; int n; XTextProperty name; @@ -802,24 +738,23 @@ gettextprop(Window w, Atom atom, char *text, unsigned int size) { void grabbuttons(Client *c, Bool focused) { int i, j; - unsigned int buttons[] = { Button1, Button2, Button3 }; - unsigned int modifiers[] = { MODKEY, MODKEY|LockMask, MODKEY|numlockmask, - MODKEY|numlockmask|LockMask} ; + uint buttons[] = { Button1, Button2, Button3 }; + uint modifiers[] = { MODKEY, MODKEY|LockMask, MODKEY|numlockmask, MODKEY|numlockmask|LockMask }; XUngrabButton(dpy, AnyButton, AnyModifier, c->win); if(focused) for(i = 0; i < LENGTH(buttons); i++) for(j = 0; j < LENGTH(modifiers); j++) XGrabButton(dpy, buttons[i], modifiers[j], c->win, False, - BUTTONMASK, GrabModeAsync, GrabModeSync, None, None); + BUTTONMASK, GrabModeAsync, GrabModeSync, None, None); else XGrabButton(dpy, AnyButton, AnyModifier, c->win, False, - BUTTONMASK, GrabModeAsync, GrabModeSync, None, None); + BUTTONMASK, GrabModeAsync, GrabModeSync, None, None); } void -grabkeys(void) { - unsigned int i, j; +grabkeys(void) { + uint i, j; KeyCode code; XModifierKeymap *modmap; @@ -846,14 +781,6 @@ grabkeys(void) { } } -unsigned int -idxoftag(const char *t) { - unsigned int i; - - for(i = 0; (i < LENGTH(tags)) && t && strcmp(tags[i], t); i++); - return (i < LENGTH(tags)) ? i : 0; -} - void initfont(const char *fontstr) { char *def, **missing; @@ -895,11 +822,11 @@ initfont(const char *fontstr) { } Bool -isoccupied(unsigned int t) { +isoccupied(uint t) { Client *c; for(c = clients; c; c = c->next) - if(c->tags[t]) + if(c->tags & 1 << t) return True; return False; } @@ -920,28 +847,18 @@ isprotodel(Client *c) { } Bool -isurgent(unsigned int t) { +isurgent(uint t) { Client *c; for(c = clients; c; c = c->next) - if(c->isurgent && c->tags[t]) - return True; - return False; -} - -Bool -isvisible(Client *c) { - unsigned int i; - - for(i = 0; i < LENGTH(tags); i++) - if(c->tags[i] && tagset[seltags][i]) + if(c->isurgent && c->tags & 1 << t) return True; return False; } void keypress(XEvent *e) { - unsigned int i; + uint i; KeySym keysym; XKeyEvent *ev; @@ -949,15 +866,13 @@ keypress(XEvent *e) { keysym = XKeycodeToKeysym(dpy, (KeyCode)ev->keycode, 0); for(i = 0; i < LENGTH(keys); i++) if(keysym == keys[i].keysym - && CLEANMASK(keys[i].mod) == CLEANMASK(ev->state)) - { - if(keys[i].func) - keys[i].func(keys[i].arg); - } + && CLEANMASK(keys[i].mod) == CLEANMASK(ev->state) + && keys[i].func) + keys[i].func(&(keys[i].arg)); } void -killclient(const char *arg) { +killclient(const Arg *arg) { XEvent ev; if(!sel) @@ -982,15 +897,15 @@ manage(Window w, XWindowAttributes *wa) { Window trans; XWindowChanges wc; - c = emallocz(sizeof(Client)); - c->tags = emallocz(TAGSZ); + if(!(c = calloc(1, sizeof(Client)))) + eprint("fatal: could not calloc() %u bytes\n", sizeof(Client)); c->win = w; /* geometry */ c->x = wa->x; c->y = wa->y; - c->w = c->fw = wa->width; - c->h = c->fh = wa->height; + c->w = wa->width; + c->h = wa->height; c->oldbw = wa->border_width; if(c->w == sw && c->h == sh) { c->x = sx; @@ -998,16 +913,14 @@ manage(Window w, XWindowAttributes *wa) { c->bw = wa->border_width; } else { - if(c->x + c->w + 2 * c->bw > wx + ww) - c->x = wx + ww - c->w - 2 * c->bw; - if(c->y + c->h + 2 * c->bw > wy + wh) - c->y = wy + wh - c->h - 2 * c->bw; - c->x = MAX(c->x, wx); - c->y = MAX(c->y, wy); - c->bw = BORDERPX; + if(c->x + c->w + 2 * c->bw > sx + sw) + c->x = sx + sw - c->w - 2 * c->bw; + if(c->y + c->h + 2 * c->bw > sy + sh) + c->y = sy + sh - c->h - 2 * c->bw; + c->x = MAX(c->x, sx); + c->y = MAX(c->y, by == 0 ? bh : sy); + c->bw = borderpx; } - c->fx = c->x; - c->fy = c->y; wc.border_width = c->bw; XConfigureWindow(dpy, w, CWBorderWidth, &wc); @@ -1020,15 +933,16 @@ manage(Window w, XWindowAttributes *wa) { if((rettrans = XGetTransientForHint(dpy, w, &trans) == Success)) for(t = clients; t && t->win != trans; t = t->next); if(t) - memcpy(c->tags, t->tags, TAGSZ); + c->tags = t->tags; else applyrules(c); if(!c->isfloating) c->isfloating = (rettrans == Success) || c->isfixed; + if(c->isfloating) + XRaiseWindow(dpy, c->win); attach(c); attachstack(c); XMoveResizeWindow(dpy, c->win, c->x, c->y, c->w, c->h); /* some windows require this */ - ban(c); XMapWindow(dpy, c->win); setclientstate(c, NormalState); arrange(); @@ -1057,25 +971,17 @@ maprequest(XEvent *e) { } void -monocle(void) { - Client *c; - - for(c = clients; c; c = c->next) - if((lt->isfloating || !c->isfloating) && isvisible(c)) - resize(c, mox, moy, mow - 2 * c->bw, moh - 2 * c->bw, RESIZEHINTS); -} - -void movemouse(Client *c) { int x1, y1, ocx, ocy, di, nx, ny; - unsigned int dui; + uint dui; Window dummy; XEvent ev; + restack(); ocx = nx = c->x; ocy = ny = c->y; if(XGrabPointer(dpy, root, False, MOUSEMASK, GrabModeAsync, GrabModeAsync, - None, cursor[CurMove], CurrentTime) != GrabSuccess) + None, cursor[CurMove], CurrentTime) != GrabSuccess) return; XQueryPointer(dpy, root, &dummy, &dummy, &x1, &y1, &di, &di, &dui); for(;;) { @@ -1093,21 +999,21 @@ movemouse(Client *c) { XSync(dpy, False); nx = ocx + (ev.xmotion.x - x1); ny = ocy + (ev.xmotion.y - y1); - if(abs(wx - nx) < SNAP) - nx = wx; - else if(abs((wx + ww) - (nx + c->w + 2 * c->bw)) < SNAP) - nx = wx + ww - c->w - 2 * c->bw; - if(abs(wy - ny) < SNAP) - ny = wy; - else if(abs((wy + wh) - (ny + c->h + 2 * c->bw)) < SNAP) - ny = wy + wh - c->h - 2 * c->bw; - if(!c->isfloating && !lt->isfloating && (abs(nx - c->x) > SNAP || abs(ny - c->y) > SNAP)) - togglefloating(NULL); - if(lt->isfloating || c->isfloating) { - c->fx = nx; - c->fy = ny; - resize(c, nx, ny, c->w, c->h, False); + if(snap && nx >= wx && nx <= wx + ww + && ny >= wy && ny <= wy + wh) { + if(abs(wx - nx) < snap) + nx = wx; + else if(abs((wx + ww) - (nx + c->w + 2 * c->bw)) < snap) + nx = wx + ww - c->w - 2 * c->bw; + if(abs(wy - ny) < snap) + ny = wy; + else if(abs((wy + wh) - (ny + c->h + 2 * c->bw)) < snap) + ny = wy + wh - c->h - 2 * c->bw; + if(!c->isfloating && lt->arrange && (abs(nx - c->x) > snap || abs(ny - c->y) > snap)) + togglefloating(NULL); } + if(!lt->arrange || c->isfloating) + resize(c, nx, ny, c->w, c->h, False); break; } } @@ -1115,7 +1021,7 @@ movemouse(Client *c) { Client * nexttiled(Client *c) { - for(; c && (c->isfloating || !isvisible(c)); c = c->next); + for(; c && (c->isfloating || c->isbanned); c = c->next); return c; } @@ -1152,22 +1058,11 @@ propertynotify(XEvent *e) { } void -quit(const char *arg) { +quit(const Arg *arg) { readin = running = False; } void -reapply(const char *arg) { - Client *c; - - for(c = clients; c; c = c->next) { - memset(c->tags, 0, TAGSZ); - applyrules(c); - } - arrange(); -} - -void resize(Client *c, int x, int y, int w, int h, Bool sizehints) { XWindowChanges wc; @@ -1181,13 +1076,11 @@ resize(Client *c, int x, int y, int w, int h, Bool sizehints) { h -= c->baseh; /* adjust for aspect limits */ - if(c->minax != c->maxax && c->minay != c->maxay - && c->minax > 0 && c->maxax > 0 && c->minay > 0 && c->maxay > 0) - { - if(w * c->maxay > h * c->maxax) - w = h * c->maxax / c->maxay; - else if(w * c->minay < h * c->minax) - h = w * c->minay / c->minax; + if(c->mina > 0 && c->maxa > 0) { + if(c->maxa < (float) w/h) + w = h * c->maxa; + else if(c->mina > (float) h/w) + h = w * c->mina; } /* adjust for increment value */ @@ -1219,7 +1112,12 @@ resize(Client *c, int x, int y, int w, int h, Bool sizehints) { x = sx; if(y + h + 2 * c->bw < sy) y = sy; - if(c->x != x || c->y != y || c->w != w || c->h != h) { + if(h < bh) + h = bh; + if(w < bh) + w = bh; + if(c->x != x || c->y != y || c->w != w || c->h != h || c->ismoved) { + c->ismoved = False; c->x = wc.x = x; c->y = wc.y = y; c->w = wc.width = w; @@ -1238,10 +1136,11 @@ resizemouse(Client *c) { int nw, nh; XEvent ev; + restack(); ocx = c->x; ocy = c->y; if(XGrabPointer(dpy, root, False, MOUSEMASK, GrabModeAsync, GrabModeAsync, - None, cursor[CurResize], CurrentTime) != GrabSuccess) + None, cursor[CurResize], CurrentTime) != GrabSuccess) return; XWarpPointer(dpy, None, c->win, 0, 0, 0, 0, c->w + c->bw - 1, c->h + c->bw - 1); for(;;) { @@ -1262,16 +1161,15 @@ resizemouse(Client *c) { XSync(dpy, False); nw = MAX(ev.xmotion.x - ocx - 2 * c->bw + 1, 1); nh = MAX(ev.xmotion.y - ocy - 2 * c->bw + 1, 1); - if(!c->isfloating && !lt->isfloating && (abs(nw - c->w) > SNAP || abs(nh - c->h) > SNAP)) { - c->fx = c->x; - c->fy = c->y; - togglefloating(NULL); + + if(snap && nw >= wx && nw <= wx + ww + && nh >= wy && nh <= wy + wh) { + if(!c->isfloating && lt->arrange + && (abs(nw - c->w) > snap || abs(nh - c->h) > snap)) + togglefloating(NULL); } - if((lt->isfloating) || c->isfloating) { + if(!lt->arrange || c->isfloating) resize(c, c->x, c->y, nw, nh, True); - c->fw = nw; - c->fh = nh; - } break; } } @@ -1286,13 +1184,13 @@ restack(void) { drawbar(); if(!sel) return; - if(sel->isfloating || lt->isfloating) + if(ismax || sel->isfloating || !lt->arrange) XRaiseWindow(dpy, sel->win); - if(!lt->isfloating) { + if(!ismax && lt->arrange) { wc.stack_mode = Below; wc.sibling = barwin; for(c = stack; c; c = c->snext) - if(!c->isfloating && isvisible(c)) { + if(!c->isfloating && !c->isbanned) { XConfigureWindow(dpy, c->win, CWSibling|CWStackMode, &wc); wc.sibling = c->win; } @@ -1307,7 +1205,7 @@ run(void) { char sbuf[sizeof stext]; fd_set rd; int r, xfd; - unsigned int len, offset; + uint len, offset; XEvent ev; /* main event loop, also reads status text from stdin */ @@ -1363,7 +1261,7 @@ run(void) { void scan(void) { - unsigned int i, num; + uint i, num; Window *wins, d1, d2; XWindowAttributes wa; @@ -1371,7 +1269,7 @@ scan(void) { if(XQueryTree(dpy, root, &d1, &d2, &wins, &num)) { for(i = 0; i < num; i++) { if(!XGetWindowAttributes(dpy, wins[i], &wa) - || wa.override_redirect || XGetTransientForHint(dpy, wins[i], &d1)) + || wa.override_redirect || XGetTransientForHint(dpy, wins[i], &d1)) continue; if(wa.map_state == IsViewable || getstate(wins[i]) == IconicState) manage(wins[i], &wa); @@ -1380,7 +1278,7 @@ scan(void) { if(!XGetWindowAttributes(dpy, wins[i], &wa)) continue; if(XGetTransientForHint(dpy, wins[i], &d1) - && (wa.map_state == IsViewable || getstate(wins[i]) == IconicState)) + && (wa.map_state == IsViewable || getstate(wins[i]) == IconicState)) manage(wins[i], &wa); } } @@ -1396,86 +1294,37 @@ setclientstate(Client *c, long state) { PropModeReplace, (unsigned char *)data, 2); } +/* arg > 1.0 will set mfact absolutly */ void -setgeom(const char *arg) { - unsigned int i; - - if(!arg) { - if(++geom == &geoms[LENGTH(geoms)]) - geom = &geoms[0]; - } - else { - for(i = 0; i < LENGTH(geoms); i++) - if(!strcmp(geoms[i].symbol, arg)) - break; - if(i == LENGTH(geoms)) - return; - geom = &geoms[i]; - } - geom->apply(); - updatebarpos(); - arrange(); -} - -void -setlayout(const char *arg) { - unsigned int i; - - if(!arg) { - if(++lt == &layouts[LENGTH(layouts)]) - lt = &layouts[0]; - } - else { - for(i = 0; i < LENGTH(layouts); i++) - if(!strcmp(arg, layouts[i].symbol)) - break; - if(i == LENGTH(layouts)) - return; - lt = &layouts[i]; - } - if(sel) - arrange(); - else - drawbar(); -} - -void -setmfact(const char *arg) { - double d; +setmfact(const Arg *arg) { + float f; - if(lt->isfloating) + if(!arg || !lt->arrange) return; - if(!arg) - mfact = MFACT; - else { - d = strtod(arg, NULL); - if(arg[0] == '-' || arg[0] == '+') - d += mfact; - if(d < 0.1 || d > 0.9) - return; - mfact = d; - } - setgeom(geom->symbol); + f = arg->f < 1.0 ? arg->f + mfact : arg->f - 1.0; + if(f < 0.1 || f > 0.9) + return; + mfact = f; + arrange(); } void setup(void) { - unsigned int i, w; + uint i; + int w; XSetWindowAttributes wa; /* init screen */ screen = DefaultScreen(dpy); root = RootWindow(dpy, screen); initfont(FONT); - - /* apply default geometry */ sx = 0; sy = 0; sw = DisplayWidth(dpy, screen); sh = DisplayHeight(dpy, screen); bh = dc.font.height + 2; - mfact = MFACT; - geom->apply(); + lt = layouts; + updategeom(); /* init atoms */ wmatom[WMProtocols] = XInternAtom(dpy, "WM_PROTOCOLS", False); @@ -1505,28 +1354,19 @@ setup(void) { if(!dc.font.set) XSetFont(dpy, dc.gc, dc.font.xfont->fid); - /* init tags */ - tagset[0] = emallocz(TAGSZ); - tagset[1] = emallocz(TAGSZ); - tagset[0][0] = tagset[1][0] = True; - /* init bar */ for(blw = i = 0; LENGTH(layouts) > 1 && i < LENGTH(layouts); i++) { - w = textw(layouts[i].symbol); + w = TEXTW(layouts[i].symbol); blw = MAX(blw, w); } - for(bgw = i = 0; LENGTH(geoms) > 1 && i < LENGTH(geoms); i++) { - w = textw(geoms[i].symbol); - bgw = MAX(bgw, w); - } wa.override_redirect = 1; wa.background_pixmap = ParentRelative; wa.event_mask = ButtonPressMask|ExposureMask; - barwin = XCreateWindow(dpy, root, bx, by, bw, bh, 0, DefaultDepth(dpy, screen), - CopyFromParent, DefaultVisual(dpy, screen), - CWOverrideRedirect|CWBackPixmap|CWEventMask, &wa); + barwin = XCreateWindow(dpy, root, wx, by, ww, bh, 0, DefaultDepth(dpy, screen), + CopyFromParent, DefaultVisual(dpy, screen), + CWOverrideRedirect|CWBackPixmap|CWEventMask, &wa); XDefineCursor(dpy, barwin, cursor[CurNormal]); XMapRaised(dpy, barwin); strcpy(stext, "dwm-"VERSION); @@ -1548,13 +1388,7 @@ setup(void) { } void -spawn(const char *arg) { - static char *shell = NULL; - - if(!shell && !(shell = getenv("SHELL"))) - shell = "/bin/sh"; - if(!arg) - return; +spawn(const Arg *arg) { /* The double-fork construct avoids zombie processes and keeps the code * clean from stupid signal handlers. */ if(fork() == 0) { @@ -1562,8 +1396,8 @@ spawn(const char *arg) { if(dpy) close(ConnectionNumber(dpy)); setsid(); - execl(shell, shell, "-c", arg, (char *)NULL); - fprintf(stderr, "dwm: execl '%s -c %s'", shell, arg); + execvp(((char **)arg->v)[0], (char **)arg->v); + fprintf(stderr, "dwm: execvp %s", ((char **)arg->v)[0]); perror(" failed"); } exit(0); @@ -1572,19 +1406,15 @@ spawn(const char *arg) { } void -tag(const char *arg) { - unsigned int i; - - if(!sel) - return; - for(i = 0; i < LENGTH(tags); i++) - sel->tags[i] = (NULL == arg); - sel->tags[idxoftag(arg)] = True; - arrange(); +tag(const Arg *arg) { + if(sel && arg->ui & TAGMASK) { + sel->tags = arg->ui & TAGMASK; + arrange(); + } } -unsigned int -textnw(const char *text, unsigned int len) { +int +textnw(const char *text, uint len) { XRectangle r; if(dc.font.set) { @@ -1594,126 +1424,86 @@ textnw(const char *text, unsigned int len) { return XTextWidth(dc.font.xfont, text, len); } -unsigned int -textw(const char *text) { - return textnw(text, strlen(text)) + dc.font.height; -} - void -tileh(void) { - int x, w; - unsigned int i, n = counttiled(); +tile(void) { + int x, y, h, w, mw; + uint i, n; Client *c; + for(n = 0, c = nexttiled(clients); c; c = nexttiled(c->next), n++); if(n == 0) return; - c = tilemaster(n); - if(--n == 0) - return; - - x = tx; - w = tw / n; - if(w < bh) - w = tw; - - for(i = 0, c = nexttiled(c->next); c; c = nexttiled(c->next), i++) { - if(i + 1 == n) /* remainder */ - tileresize(c, x, ty, (tx + tw) - x - 2 * c->bw, th - 2 * c->bw); - else - tileresize(c, x, ty, w - 2 * c->bw, th - 2 * c->bw); - if(w != tw) - x = c->x + c->w + 2 * c->bw; - } -} -Client * -tilemaster(unsigned int n) { - Client *c = nexttiled(clients); + /* master */ + c = nexttiled(clients); + mw = mfact * ww; + resize(c, wx, wy, (n == 1 ? ww : mw) - 2 * c->bw, wh - 2 * c->bw, resizehints); - if(n == 1) - tileresize(c, mox, moy, mow - 2 * c->bw, moh - 2 * c->bw); - else - tileresize(c, mx, my, mw - 2 * c->bw, mh - 2 * c->bw); - return c; -} - -void -tileresize(Client *c, int x, int y, int w, int h) { - resize(c, x, y, w, h, RESIZEHINTS); - if((RESIZEHINTS) && ((c->h < bh) || (c->h > h) || (c->w < bh) || (c->w > w))) - /* client doesn't accept size constraints */ - resize(c, x, y, w, h, False); -} - -void -tilev(void) { - int y, h; - unsigned int i, n = counttiled(); - Client *c; - - if(n == 0) - return; - c = tilemaster(n); if(--n == 0) return; - y = ty; - h = th / n; + /* tile stack */ + x = (wx + mw > c->x + c->w) ? c->x + c->w + 2 * c->bw : wx + mw; + y = wy; + w = (wx + mw > c->x + c->w) ? wx + ww - x : ww - mw; + h = wh / n; if(h < bh) - h = th; + h = wh; for(i = 0, c = nexttiled(c->next); c; c = nexttiled(c->next), i++) { - if(i + 1 == n) /* remainder */ - tileresize(c, tx, y, tw - 2 * c->bw, (ty + th) - y - 2 * c->bw); - else - tileresize(c, tx, y, tw - 2 * c->bw, h - 2 * c->bw); - if(h != th) + resize(c, x, y, w - 2 * c->bw, /* remainder */ ((i + 1 == n) + ? (wy + wh) - y : h) - 2 * c->bw, resizehints); + if(h != wh) y = c->y + c->h + 2 * c->bw; } } void -togglefloating(const char *arg) { +togglebar(const Arg *arg) { + showbar = !showbar; + updategeom(); + updatebar(); + arrange(); +} + +void +togglefloating(const Arg *arg) { if(!sel) return; - sel->isfloating = !sel->isfloating; + sel->isfloating = !sel->isfloating || sel->isfixed; if(sel->isfloating) resize(sel, sel->x, sel->y, sel->w, sel->h, True); arrange(); } void -toggletag(const char *arg) { - unsigned int i, j; +togglelayout(const Arg *arg) { + if(arg && arg->v) + lt = (Layout *)arg->v; + else if(++lt == &layouts[LENGTH(layouts)]) + lt = &layouts[0]; + if(sel) + arrange(); + else + drawbar(); +} - if(!sel) - return; - i = idxoftag(arg); - sel->tags[i] = !sel->tags[i]; - for(j = 0; j < LENGTH(tags) && !sel->tags[j]; j++); - if(j == LENGTH(tags)) - sel->tags[i] = True; /* at least one tag must be enabled */ +void +togglemax(const Arg *arg) { + ismax = !ismax; arrange(); } void -toggleview(const char *arg) { - unsigned int i, j; - - i = idxoftag(arg); - tagset[seltags][i] = !tagset[seltags][i]; - for(j = 0; j < LENGTH(tags) && !tagset[seltags][j]; j++); - if(j == LENGTH(tags)) - tagset[seltags][i] = True; /* at least one tag must be viewed */ - arrange(); +toggletag(const Arg *arg) { + if(sel && (sel->tags ^= (arg->ui & TAGMASK))) + arrange(); } void -unban(Client *c) { - if(!c->isbanned) - return; - XMoveWindow(dpy, c->win, c->x, c->y); - c->isbanned = False; +toggleview(const Arg *arg) { + if((tagset[seltags] ^= (arg->ui & TAGMASK))) + arrange(); } void @@ -1731,7 +1521,6 @@ unmanage(Client *c) { focus(NULL); XUngrabButton(dpy, AnyButton, AnyModifier, c->win); setclientstate(c, WithdrawnState); - free(c->tags); free(c); XSync(dpy, False); XSetErrorHandler(xerror); @@ -1749,12 +1538,39 @@ unmapnotify(XEvent *e) { } void -updatebarpos(void) { - +updatebar(void) { if(dc.drawable != 0) XFreePixmap(dpy, dc.drawable); - dc.drawable = XCreatePixmap(dpy, root, bw, bh, DefaultDepth(dpy, screen)); - XMoveResizeWindow(dpy, barwin, bx, by, bw, bh); + dc.drawable = XCreatePixmap(dpy, root, ww, bh, DefaultDepth(dpy, screen)); + XMoveResizeWindow(dpy, barwin, wx, by, ww, bh); +} + +void +updategeom(void) { +#ifdef XINERAMA + int i; + XineramaScreenInfo *info = NULL; + + /* window area geometry */ + if(XineramaIsActive(dpy)) { + info = XineramaQueryScreens(dpy, &i); + wx = info[0].x_org; + wy = showbar && topbar ? info[0].y_org + bh : info[0].y_org; + ww = info[0].width; + wh = showbar ? info[0].height - bh : info[0].height; + XFree(info); + } + else +#endif + { + wx = sx; + wy = showbar && topbar ? sy + bh : sy; + ww = sw; + wh = showbar ? sh - bh : sh; + } + + /* bar position */ + by = showbar ? (topbar ? wy - bh : wy + wh) : -bh; } void @@ -1762,49 +1578,45 @@ updatesizehints(Client *c) { long msize; XSizeHints size; - if(!XGetWMNormalHints(dpy, c->win, &size, &msize) || !size.flags) - size.flags = PSize; - c->flags = size.flags; - if(c->flags & PBaseSize) { + XGetWMNormalHints(dpy, c->win, &size, &msize); + if(size.flags & PBaseSize) { c->basew = size.base_width; c->baseh = size.base_height; } - else if(c->flags & PMinSize) { + else if(size.flags & PMinSize) { c->basew = size.min_width; c->baseh = size.min_height; } else c->basew = c->baseh = 0; - if(c->flags & PResizeInc) { + if(size.flags & PResizeInc) { c->incw = size.width_inc; c->inch = size.height_inc; } else c->incw = c->inch = 0; - if(c->flags & PMaxSize) { + if(size.flags & PMaxSize) { c->maxw = size.max_width; c->maxh = size.max_height; } else c->maxw = c->maxh = 0; - if(c->flags & PMinSize) { + if(size.flags & PMinSize) { c->minw = size.min_width; c->minh = size.min_height; } - else if(c->flags & PBaseSize) { + else if(size.flags & PBaseSize) { c->minw = size.base_width; c->minh = size.base_height; } else c->minw = c->minh = 0; - if(c->flags & PAspect) { - c->minax = size.min_aspect.x; - c->maxax = size.max_aspect.x; - c->minay = size.min_aspect.y; - c->maxay = size.max_aspect.y; + if(size.flags & PAspect) { + c->mina = (float)size.min_aspect.y / (float)size.min_aspect.x; + c->maxa = (float)size.max_aspect.x / (float)size.max_aspect.y; } else - c->minax = c->maxax = c->minay = c->maxay = 0; + c->maxa = c->mina = 0.0; c->isfixed = (c->maxw && c->minw && c->maxh && c->minh && c->maxw == c->minw && c->maxh == c->minh); } @@ -1829,16 +1641,10 @@ updatewmhints(Client *c) { } void -view(const char *arg) { - seltags ^= 1; - memset(tagset[seltags], (NULL == arg), TAGSZ); - tagset[seltags][idxoftag(arg)] = True; - arrange(); -} - -void -viewprevtag(const char *arg) { +view(const Arg *arg) { seltags ^= 1; /* toggle sel tagset */ + if(arg && (arg->ui & TAGMASK)) + tagset[seltags] = arg->i & TAGMASK; arrange(); } @@ -1858,7 +1664,7 @@ xerror(Display *dpy, XErrorEvent *ee) { || (ee->request_code == X_CopyArea && ee->error_code == BadDrawable)) return 0; fprintf(stderr, "dwm: fatal error: request code=%d, error code=%d\n", - ee->request_code, ee->error_code); + ee->request_code, ee->error_code); return xerrorxlib(dpy, ee); /* may call exit */ } @@ -1876,17 +1682,17 @@ xerrorstart(Display *dpy, XErrorEvent *ee) { } void -zoom(const char *arg) { +zoom(const Arg *arg) { Client *c = sel; + if(ismax || !lt->arrange || (sel && sel->isfloating)) + return; if(c == nexttiled(clients)) if(!c || !(c = nexttiled(c->next))) return; - if(!lt->isfloating && !sel->isfloating) { - detach(c); - attach(c); - focus(c); - } + detach(c); + attach(c); + focus(c); arrange(); } @@ -1910,4 +1716,3 @@ main(int argc, char *argv[]) { XCloseDisplay(dpy); return 0; } -