X-Git-Url: https://jasonwoof.com/gitweb/?p=dwm.git;a=blobdiff_plain;f=dwm.c;h=66a2cb4712f6cc344c4c68551601dacc5c06a7c6;hp=b417167c866436645379575cbff994a4386197e2;hb=39d1ecd5b0b22dbd61ba5206c9f08a187f911b2a;hpb=96ee9d888cc3cf90da3b6a6852d605255d25d020 diff --git a/dwm.c b/dwm.c index b417167..66a2cb4 100644 --- a/dwm.c +++ b/dwm.c @@ -33,7 +33,6 @@ #include #include #include -#include #include #include #include @@ -45,18 +44,19 @@ #endif /* macros */ -#define BUTTONMASK (ButtonPressMask|ButtonReleaseMask) -#define CLEANMASK(mask) (mask & ~(numlockmask|LockMask)) -#define LENGTH(x) (sizeof x / sizeof x[0]) -#define MAXTAGLEN 16 -#define MOUSEMASK (BUTTONMASK|PointerMotionMask) - +#define MAX(a, b) ((a) > (b) ? (a) : (b)) +#define MIN(a, b) ((a) < (b) ? (a) : (b)) +#define BUTTONMASK (ButtonPressMask|ButtonReleaseMask) +#define CLEANMASK(mask) (mask & ~(numlockmask|LockMask)) +#define LENGTH(x) (sizeof x / sizeof x[0]) +#define MAXTAGLEN 16 +#define MOUSEMASK (BUTTONMASK|PointerMotionMask) +#define TAGMASK ((int)((1LL << LENGTH(tags)) - 1)) /* enums */ -enum { BarTop, BarBot, BarOff }; /* bar position */ -enum { CurNormal, CurResize, CurMove, CurLast }; /* cursor */ -enum { ColBorder, ColFG, ColBG, ColLast }; /* color */ -enum { NetSupported, NetWMName, NetLast }; /* EWMH atoms */ +enum { CurNormal, CurResize, CurMove, CurLast }; /* cursor */ +enum { ColBorder, ColFG, ColBG, ColLast }; /* color */ +enum { NetSupported, NetWMName, NetLast }; /* EWMH atoms */ enum { WMProtocols, WMDelete, WMName, WMState, WMLast };/* default atoms */ /* typedefs */ @@ -67,9 +67,9 @@ struct Client { int basew, baseh, incw, inch, maxw, maxh, minw, minh; int minax, maxax, minay, maxay; long flags; - unsigned int border, oldborder; + unsigned int bw, oldbw; Bool isbanned, isfixed, isfloating, isurgent; - Bool *tags; + unsigned int tags; Client *next; Client *prev; Client *snext; @@ -94,18 +94,21 @@ typedef struct { typedef struct { unsigned long mod; KeySym keysym; - void (*func)(const char *arg); - const char *arg; + void (*func)(void *arg); + void *arg; } Key; typedef struct { const char *symbol; void (*arrange)(void); + void (*updategeom)(void); } Layout; typedef struct { - const char *prop; - const char *tag; + const char *class; + const char *instance; + const char *title; + unsigned int tags; Bool isfloating; } Rule; @@ -131,74 +134,72 @@ void *emallocz(unsigned int size); void enternotify(XEvent *e); void eprint(const char *errstr, ...); void expose(XEvent *e); -void floating(void); /* default floating layout */ void focus(Client *c); void focusin(XEvent *e); -void focusnext(const char *arg); -void focusprev(const char *arg); +void focusnext(void *arg); +void focusprev(void *arg); Client *getclient(Window w); unsigned long getcolor(const char *colstr); long getstate(Window w); Bool gettextprop(Window w, Atom atom, char *text, unsigned int size); void grabbuttons(Client *c, Bool focused); void grabkeys(void); -unsigned int idxoftag(const char *t); void initfont(const char *fontstr); Bool isoccupied(unsigned int t); Bool isprotodel(Client *c); Bool isurgent(unsigned int t); Bool isvisible(Client *c); void keypress(XEvent *e); -void killclient(const char *arg); +void killclient(void *arg); void manage(Window w, XWindowAttributes *wa); void mappingnotify(XEvent *e); void maprequest(XEvent *e); -void monocle(void); void movemouse(Client *c); -Client *nexttiled(Client *c); +Client *nextunfloating(Client *c); void propertynotify(XEvent *e); -void quit(const char *arg); -void reapply(const char *arg); +void quit(void *arg); void resize(Client *c, int x, int y, int w, int h, Bool sizehints); void resizemouse(Client *c); void restack(void); void run(void); void scan(void); void setclientstate(Client *c, long state); -void setlayout(const char *arg); -void setmwfact(const char *arg); +void setmfact(void *arg); void setup(void); -void spawn(const char *arg); -void tag(const char *arg); +void spawn(void *arg); +void tag(void *arg); unsigned int textnw(const char *text, unsigned int len); unsigned int textw(const char *text); void tile(void); -void togglebar(const char *arg); -void togglefloating(const char *arg); -void toggletag(const char *arg); -void toggleview(const char *arg); +void tileresize(Client *c, int x, int y, int w, int h); +void togglebar(void *arg); +void togglefloating(void *arg); +void togglelayout(void *arg); +void toggletag(void *arg); +void toggleview(void *arg); void unban(Client *c); void unmanage(Client *c); void unmapnotify(XEvent *e); -void updatebarpos(void); +void updatebar(void); +void updategeom(void); void updatesizehints(Client *c); +void updatetilegeom(void); void updatetitle(Client *c); void updatewmhints(Client *c); -void view(const char *arg); -void viewprevtag(const char *arg); /* views previous selected tags */ +void view(void *arg); +void viewprevtag(void *arg); int xerror(Display *dpy, XErrorEvent *ee); int xerrordummy(Display *dpy, XErrorEvent *ee); int xerrorstart(Display *dpy, XErrorEvent *ee); -void zoom(const char *arg); -void selectview(const char *arg); +void zoom(void *arg); /* variables */ -char stext[256], buf[256]; -double mwfact; -int screen, sx, sy, sw, sh, wax, way, waw, wah, xscreens; +char stext[256]; +int screen, sx, sy, sw, sh; +int bx, by, bw, bh, blw, wx, wy, ww, wh; +int mx, my, mw, mh, tx, ty, tw, th; +unsigned int seltags = 0; int (*xerrorxlib)(Display *, XErrorEvent *); -unsigned int bh, bpos; -unsigned int blw = 0; unsigned int numlockmask = 0; void (*handler[LASTEvent]) (XEvent *) = { [ButtonPress] = buttonpress, @@ -215,35 +216,30 @@ void (*handler[LASTEvent]) (XEvent *) = { [UnmapNotify] = unmapnotify }; Atom wmatom[WMLast], netatom[NetLast]; -Bool domwfact = True; -Bool dozoom = True; Bool otherwm, readin; Bool running = True; -Bool *prevtags; -Bool *seltags; +unsigned int tagset[] = {1, 1}; /* after start, first tag is selected */ Client *clients = NULL; Client *sel = NULL; Client *stack = NULL; Cursor cursor[CurLast]; Display *dpy; DC dc = {0}; -Layout *lt; +Layout layouts[]; +Layout *lt = layouts; Window root, barwin; -#ifdef XINERAMA -XineramaScreenInfo *info = NULL; -#endif /* configuration, allows nested code to access above variables */ #include "config.h" -#define TAGSZ (LENGTH(tags) * sizeof(Bool)) -static Bool tmp[LENGTH(tags)]; + +/* check if all tags will fit into a unsigned int bitarray. */ +static char tags_is_a_sign_that_your_IQ[sizeof(int) * 8 < LENGTH(tags) ? -1 : 1]; /* function implementations */ void applyrules(Client *c) { unsigned int i; - Bool matched = False; Rule *r; XClassHint ch = { 0 }; @@ -251,23 +247,19 @@ applyrules(Client *c) { XGetClassHint(dpy, c->win, &ch); for(i = 0; i < LENGTH(rules); i++) { r = &rules[i]; - if(strstr(c->name, r->prop) - || (ch.res_class && strstr(ch.res_class, r->prop)) - || (ch.res_name && strstr(ch.res_name, r->prop))) - { + if((!r->title || strstr(c->name, r->title)) + && (!r->class || (ch.res_class && strstr(ch.res_class, r->class))) + && (!r->instance || (ch.res_name && strstr(ch.res_name, r->instance)))) { c->isfloating = r->isfloating; - if(r->tag) { - c->tags[idxoftag(r->tag)] = True; - matched = True; - } + c->tags |= r->tags & TAGMASK; } } if(ch.res_class) XFree(ch.res_class); if(ch.res_name) XFree(ch.res_name); - if(!matched) - memcpy(c->tags, seltags, TAGSZ); + if(!c->tags) + c->tags = tagset[seltags]; } void @@ -275,13 +267,17 @@ arrange(void) { Client *c; for(c = clients; c; c = c->next) - if(isvisible(c)) + if(isvisible(c)) { unban(c); + if(!lt->arrange || c->isfloating) + resize(c, c->x, c->y, c->w, c->h, True); + } else ban(c); focus(NULL); - lt->arrange(); + if(lt->arrange) + lt->arrange(); restack(); } @@ -303,13 +299,13 @@ void ban(Client *c) { if(c->isbanned) return; - XMoveWindow(dpy, c->win, c->x + 3 * sw, c->y); + XMoveWindow(dpy, c->win, c->x + 2 * sw, c->y); c->isbanned = True; } void buttonpress(XEvent *e) { - unsigned int i, x; + unsigned int i, x, mask; Client *c; XButtonPressedEvent *ev = &e->xbutton; @@ -318,23 +314,24 @@ buttonpress(XEvent *e) { for(i = 0; i < LENGTH(tags); i++) { x += textw(tags[i]); if(ev->x < x) { + mask = 1 << i; if(ev->button == Button1) { if(ev->state & MODKEY) - tag(tags[i]); + tag(&mask); else - view(tags[i]); + view(&mask); } else if(ev->button == Button3) { if(ev->state & MODKEY) - toggletag(tags[i]); + toggletag(&mask); else - toggleview(tags[i]); + toggleview(&mask); } return; } } - if((ev->x < x + blw) && ev->button == Button1) - setlayout(NULL); + if((ev->x < x + blw) && ev->button == Button1) + togglelayout(NULL); } else if((c = getclient(ev->window))) { focus(c); @@ -344,12 +341,8 @@ buttonpress(XEvent *e) { restack(); movemouse(c); } - else if(ev->button == Button2) { - if((floating != lt->arrange) && c->isfloating) - togglefloating(NULL); - else - zoom(NULL); - } + else if(ev->button == Button2) + togglefloating(NULL); else if(ev->button == Button3 && !c->isfixed) { restack(); resizemouse(c); @@ -375,7 +368,6 @@ checkotherwm(void) { void cleanup(void) { - close(STDIN_FILENO); while(stack) { unban(stack); @@ -385,7 +377,6 @@ cleanup(void) { XFreeFontSet(dpy, dc.font.set); else XFreeFont(dpy, dc.font.xfont); - XUngrabKey(dpy, AnyKey, AnyModifier, root); XFreePixmap(dpy, dc.drawable); XFreeGC(dpy, dc.gc); @@ -393,10 +384,6 @@ cleanup(void) { XFreeCursor(dpy, cursor[CurResize]); XFreeCursor(dpy, cursor[CurMove]); XDestroyWindow(dpy, barwin); -#if XINERAMA - if(info) - XFree(info); -#endif XSync(dpy, False); XSetInputFocus(dpy, PointerRoot, RevertToPointerRoot, CurrentTime); } @@ -413,7 +400,7 @@ configure(Client *c) { ce.y = c->y; ce.width = c->w; ce.height = c->h; - ce.border_width = c->border; + ce.border_width = c->bw; ce.above = None; ce.override_redirect = False; XSendEvent(dpy, c->win, False, StructureNotifyMask, (XEvent *)&ce); @@ -424,13 +411,10 @@ configurenotify(XEvent *e) { XConfigureEvent *ev = &e->xconfigure; if(ev->window == root && (ev->width != sw || ev->height != sh)) { - /* TODO -- use Xinerama dimensions here ? */ sw = ev->width; sh = ev->height; - XFreePixmap(dpy, dc.drawable); - dc.drawable = XCreatePixmap(dpy, root, DisplayWidth(root, screen), bh, DefaultDepth(dpy, screen)); - XResizeWindow(dpy, barwin, sw, bh); - updatebarpos(); + updategeom(); + updatebar(); arrange(); } } @@ -441,11 +425,10 @@ configurerequest(XEvent *e) { XConfigureRequestEvent *ev = &e->xconfigurerequest; XWindowChanges wc; - /* TODO -- consider Xinerama if necessary when centering */ if((c = getclient(ev->window))) { if(ev->value_mask & CWBorderWidth) - c->border = ev->border_width; - if(c->isfixed || c->isfloating || (floating == lt->arrange)) { + c->bw = ev->border_width; + if(c->isfixed || c->isfloating || !lt->arrange) { if(ev->value_mask & CWX) c->x = sx + ev->x; if(ev->value_mask & CWY) @@ -480,16 +463,6 @@ configurerequest(XEvent *e) { XSync(dpy, False); } -Bool -conflicts(Client *c, unsigned int tidx) { - unsigned int i; - - for(i = 0; i < LENGTH(tags); i++) - if(c->tags[i]) - return True; /* conflict */ - return False; -} - void destroynotify(XEvent *e) { Client *c; @@ -514,7 +487,7 @@ void detachstack(Client *c) { Client **tc; - for(tc=&stack; *tc && *tc != c; tc=&(*tc)->snext); + for(tc = &stack; *tc && *tc != c; tc = &(*tc)->snext); *tc = c->snext; } @@ -527,24 +500,28 @@ drawbar(void) { for(c = stack; c && !isvisible(c); c = c->snext); for(i = 0; i < LENGTH(tags); i++) { dc.w = textw(tags[i]); - if(seltags[i]) { + if(tagset[seltags] & 1 << i) { drawtext(tags[i], dc.sel, isurgent(i)); - drawsquare(c && c->tags[i], isoccupied(i), isurgent(i), dc.sel); + drawsquare(c && c->tags & 1 << i, isoccupied(i), isurgent(i), dc.sel); } else { drawtext(tags[i], dc.norm, isurgent(i)); - drawsquare(c && c->tags[i], isoccupied(i), isurgent(i), dc.norm); + drawsquare(c && c->tags & 1 << i, isoccupied(i), isurgent(i), dc.norm); } dc.x += dc.w; } - dc.w = blw; - drawtext(lt->symbol, dc.norm, False); - x = dc.x + dc.w; + if(blw > 0) { + dc.w = blw; + drawtext(lt->symbol, dc.norm, False); + x = dc.x + dc.w; + } + else + x = dc.x; dc.w = textw(stext); - dc.x = sw - dc.w; + dc.x = bw - dc.w; if(dc.x < x) { dc.x = x; - dc.w = sw - x; + dc.w = bw - x; } drawtext(stext, dc.norm, False); if((dc.w = dc.x - x) > bh) { @@ -556,7 +533,7 @@ drawbar(void) { else drawtext(NULL, dc.norm, False); } - XCopyArea(dpy, dc.drawable, barwin, dc.gc, 0, 0, sw, bh, 0, 0); + XCopyArea(dpy, dc.drawable, barwin, dc.gc, 0, 0, bw, bh, 0, 0); XSync(dpy, False); } @@ -586,23 +563,23 @@ drawtext(const char *text, unsigned long col[ColLast], Bool invert) { int x, y, w, h; unsigned int len, olen; XRectangle r = { dc.x, dc.y, dc.w, dc.h }; + char buf[256]; XSetForeground(dpy, dc.gc, col[invert ? ColFG : ColBG]); XFillRectangles(dpy, dc.drawable, dc.gc, &r, 1); if(!text) return; - w = 0; - olen = len = strlen(text); - if(len >= sizeof buf) - len = sizeof buf - 1; + olen = strlen(text); + len = MIN(olen, sizeof buf); memcpy(buf, text, len); - buf[len] = 0; + w = 0; h = dc.font.ascent + dc.font.descent; y = dc.y + (dc.h / 2) - (h / 2) + dc.font.ascent; x = dc.x + (h / 2); /* shorten text if necessary */ - while(len && (w = textnw(buf, len)) > dc.w - h) - buf[--len] = 0; + for(; len && (w = textnw(buf, len)) > dc.w - h; len--); + if(!len) + return; if(len < olen) { if(len > 1) buf[len - 1] = '.'; @@ -611,8 +588,6 @@ drawtext(const char *text, unsigned long col[ColLast], Bool invert) { if(len > 3) buf[len - 3] = '.'; } - if(w > dc.w) - return; /* too long */ XSetForeground(dpy, dc.gc, col[invert ? ColBG : ColFG]); if(dc.font.set) XmbDrawString(dpy, dc.drawable, dc.font.set, dc.gc, x, y, buf, len); @@ -661,16 +636,6 @@ expose(XEvent *e) { } void -floating(void) { /* default floating layout */ - Client *c; - - domwfact = dozoom = False; - for(c = clients; c; c = c->next) - if(isvisible(c)) - resize(c, c->x, c->y, c->w, c->h, True); -} - -void focus(Client *c) { if(!c || (c && !isvisible(c))) for(c = stack; c && !isvisible(c); c = c->snext); @@ -702,7 +667,7 @@ focusin(XEvent *e) { /* there are some broken focus acquiring clients */ } void -focusnext(const char *arg) { +focusnext(void *arg) { Client *c; if(!sel) @@ -717,7 +682,7 @@ focusnext(const char *arg) { } void -focusprev(const char *arg) { +focusprev(void *arg) { Client *c; if(!sel) @@ -797,43 +762,24 @@ gettextprop(Window w, Atom atom, char *text, unsigned int size) { void grabbuttons(Client *c, Bool focused) { - XUngrabButton(dpy, AnyButton, AnyModifier, c->win); + int i, j; + unsigned int buttons[] = { Button1, Button2, Button3 }; + unsigned int modifiers[] = { MODKEY, MODKEY|LockMask, MODKEY|numlockmask, + MODKEY|numlockmask|LockMask} ; - if(focused) { - XGrabButton(dpy, Button1, MODKEY, c->win, False, BUTTONMASK, - GrabModeAsync, GrabModeSync, None, None); - XGrabButton(dpy, Button1, MODKEY|LockMask, c->win, False, BUTTONMASK, - GrabModeAsync, GrabModeSync, None, None); - XGrabButton(dpy, Button1, MODKEY|numlockmask, c->win, False, BUTTONMASK, - GrabModeAsync, GrabModeSync, None, None); - XGrabButton(dpy, Button1, MODKEY|numlockmask|LockMask, c->win, False, BUTTONMASK, - GrabModeAsync, GrabModeSync, None, None); - - XGrabButton(dpy, Button2, MODKEY, c->win, False, BUTTONMASK, - GrabModeAsync, GrabModeSync, None, None); - XGrabButton(dpy, Button2, MODKEY|LockMask, c->win, False, BUTTONMASK, - GrabModeAsync, GrabModeSync, None, None); - XGrabButton(dpy, Button2, MODKEY|numlockmask, c->win, False, BUTTONMASK, - GrabModeAsync, GrabModeSync, None, None); - XGrabButton(dpy, Button2, MODKEY|numlockmask|LockMask, c->win, False, BUTTONMASK, - GrabModeAsync, GrabModeSync, None, None); - - XGrabButton(dpy, Button3, MODKEY, c->win, False, BUTTONMASK, - GrabModeAsync, GrabModeSync, None, None); - XGrabButton(dpy, Button3, MODKEY|LockMask, c->win, False, BUTTONMASK, - GrabModeAsync, GrabModeSync, None, None); - XGrabButton(dpy, Button3, MODKEY|numlockmask, c->win, False, BUTTONMASK, - GrabModeAsync, GrabModeSync, None, None); - XGrabButton(dpy, Button3, MODKEY|numlockmask|LockMask, c->win, False, BUTTONMASK, - GrabModeAsync, GrabModeSync, None, None); - } + XUngrabButton(dpy, AnyButton, AnyModifier, c->win); + if(focused) + for(i = 0; i < LENGTH(buttons); i++) + for(j = 0; j < LENGTH(modifiers); j++) + XGrabButton(dpy, buttons[i], modifiers[j], c->win, False, + BUTTONMASK, GrabModeAsync, GrabModeSync, None, None); else - XGrabButton(dpy, AnyButton, AnyModifier, c->win, False, BUTTONMASK, - GrabModeAsync, GrabModeSync, None, None); + XGrabButton(dpy, AnyButton, AnyModifier, c->win, False, + BUTTONMASK, GrabModeAsync, GrabModeSync, None, None); } void -grabkeys(void) { +grabkeys(void) { unsigned int i, j; KeyCode code; XModifierKeymap *modmap; @@ -861,14 +807,6 @@ grabkeys(void) { } } -unsigned int -idxoftag(const char *t) { - unsigned int i; - - for(i = 0; (i < LENGTH(tags)) && (tags[i] != t); i++); - return (i < LENGTH(tags)) ? i : 0; -} - void initfont(const char *fontstr) { char *def, **missing; @@ -891,10 +829,8 @@ initfont(const char *fontstr) { font_extents = XExtentsOfFontSet(dc.font.set); n = XFontsOfFontSet(dc.font.set, &xfonts, &font_names); for(i = 0, dc.font.ascent = 0, dc.font.descent = 0; i < n; i++) { - if(dc.font.ascent < (*xfonts)->ascent) - dc.font.ascent = (*xfonts)->ascent; - if(dc.font.descent < (*xfonts)->descent) - dc.font.descent = (*xfonts)->descent; + dc.font.ascent = MAX(dc.font.ascent, (*xfonts)->ascent); + dc.font.descent = MAX(dc.font.descent,(*xfonts)->descent); xfonts++; } } @@ -916,7 +852,7 @@ isoccupied(unsigned int t) { Client *c; for(c = clients; c; c = c->next) - if(c->tags[t]) + if(c->tags & 1 << t) return True; return False; } @@ -941,19 +877,14 @@ isurgent(unsigned int t) { Client *c; for(c = clients; c; c = c->next) - if(c->isurgent && c->tags[t]) + if(c->isurgent && c->tags & 1 << t) return True; return False; } Bool isvisible(Client *c) { - unsigned int i; - - for(i = 0; i < LENGTH(tags); i++) - if(c->tags[i] && seltags[i]) - return True; - return False; + return c->tags & tagset[seltags]; } void @@ -974,7 +905,7 @@ keypress(XEvent *e) { } void -killclient(const char *arg) { +killclient(void *arg) { XEvent ev; if(!sel) @@ -1000,32 +931,30 @@ manage(Window w, XWindowAttributes *wa) { XWindowChanges wc; c = emallocz(sizeof(Client)); - c->tags = emallocz(TAGSZ); c->win = w; - c->x = wa->x + sx; - c->y = wa->y + sy; + /* geometry */ + c->x = wa->x; + c->y = wa->y; c->w = wa->width; c->h = wa->height; - c->oldborder = wa->border_width; - + c->oldbw = wa->border_width; if(c->w == sw && c->h == sh) { c->x = sx; c->y = sy; - c->border = wa->border_width; + c->bw = wa->border_width; } else { - if(c->x + c->w + 2 * c->border > wax + waw) - c->x = wax + waw - c->w - 2 * c->border; - if(c->y + c->h + 2 * c->border > way + wah) - c->y = way + wah - c->h - 2 * c->border; - if(c->x < wax) - c->x = wax; - if(c->y < way) - c->y = way; - c->border = BORDERPX; + if(c->x + c->w + 2 * c->bw > sx + sw) + c->x = sx + sw - c->w - 2 * c->bw; + if(c->y + c->h + 2 * c->bw > sy + sh) + c->y = sy + sh - c->h - 2 * c->bw; + c->x = MAX(c->x, sx); + c->y = MAX(c->y, by == 0 ? bh : sy); + c->bw = borderpx; } - wc.border_width = c->border; + + wc.border_width = c->bw; XConfigureWindow(dpy, w, CWBorderWidth, &wc); XSetWindowBorder(dpy, w, dc.norm[ColBorder]); configure(c); /* propagates border_width, if size doesn't change */ @@ -1036,7 +965,7 @@ manage(Window w, XWindowAttributes *wa) { if((rettrans = XGetTransientForHint(dpy, w, &trans) == Success)) for(t = clients; t && t->win != trans; t = t->next); if(t) - memcpy(c->tags, t->tags, TAGSZ); + c->tags = t->tags; else applyrules(c); if(!c->isfloating) @@ -1073,16 +1002,6 @@ maprequest(XEvent *e) { } void -monocle(void) { - Client *c; - - domwfact = dozoom = False; - for(c = clients; c; c = c->next) - if(isvisible(c)) - resize(c, wax, way, waw - 2 * c->border, wah - 2 * c->border, RESIZEHINTS); -} - -void movemouse(Client *c) { int x1, y1, ocx, ocy, di, nx, ny; unsigned int dui; @@ -1092,7 +1011,7 @@ movemouse(Client *c) { ocx = nx = c->x; ocy = ny = c->y; if(XGrabPointer(dpy, root, False, MOUSEMASK, GrabModeAsync, GrabModeAsync, - None, cursor[CurMove], CurrentTime) != GrabSuccess) + None, cursor[CurMove], CurrentTime) != GrabSuccess) return; XQueryPointer(dpy, root, &dummy, &dummy, &x1, &y1, &di, &di, &dui); for(;;) { @@ -1110,17 +1029,20 @@ movemouse(Client *c) { XSync(dpy, False); nx = ocx + (ev.xmotion.x - x1); ny = ocy + (ev.xmotion.y - y1); - if(abs(wax - nx) < SNAP) - nx = wax; - else if(abs((wax + waw) - (nx + c->w + 2 * c->border)) < SNAP) - nx = wax + waw - c->w - 2 * c->border; - if(abs(way - ny) < SNAP) - ny = way; - else if(abs((way + wah) - (ny + c->h + 2 * c->border)) < SNAP) - ny = way + wah - c->h - 2 * c->border; - if(!c->isfloating && (lt->arrange != floating) && (abs(nx - c->x) > SNAP || abs(ny - c->y) > SNAP)) - togglefloating(NULL); - if((lt->arrange == floating) || c->isfloating) + if(snap && nx >= wx && nx <= wx + ww + && ny >= wy && ny <= wy + wh) { + if(abs(wx - nx) < snap) + nx = wx; + else if(abs((wx + ww) - (nx + c->w + 2 * c->bw)) < snap) + nx = wx + ww - c->w - 2 * c->bw; + if(abs(wy - ny) < snap) + ny = wy; + else if(abs((wy + wh) - (ny + c->h + 2 * c->bw)) < snap) + ny = wy + wh - c->h - 2 * c->bw; + if(!c->isfloating && lt->arrange && (abs(nx - c->x) > snap || abs(ny - c->y) > snap)) + togglefloating(NULL); + } + if(!lt->arrange || c->isfloating) resize(c, nx, ny, c->w, c->h, False); break; } @@ -1128,7 +1050,7 @@ movemouse(Client *c) { } Client * -nexttiled(Client *c) { +nextunfloating(Client *c) { for(; c && (c->isfloating || !isvisible(c)); c = c->next); return c; } @@ -1166,42 +1088,29 @@ propertynotify(XEvent *e) { } void -quit(const char *arg) { +quit(void *arg) { readin = running = False; } void -reapply(const char *arg) { - static Bool zerotags[LENGTH(tags)] = { 0 }; - Client *c; - - for(c = clients; c; c = c->next) { - memcpy(c->tags, zerotags, sizeof zerotags); - applyrules(c); - } - arrange(); -} - -void resize(Client *c, int x, int y, int w, int h, Bool sizehints) { XWindowChanges wc; if(sizehints) { /* set minimum possible */ - if (w < 1) - w = 1; - if (h < 1) - h = 1; + w = MAX(1, w); + h = MAX(1, h); /* temporarily remove base dimensions */ w -= c->basew; h -= c->baseh; /* adjust for aspect limits */ - if (c->minay > 0 && c->maxay > 0 && c->minax > 0 && c->maxax > 0) { - if (w * c->maxay > h * c->maxax) + if(c->minax != c->maxax && c->minay != c->maxay + && c->minax > 0 && c->maxax > 0 && c->minay > 0 && c->maxay > 0) { + if(w * c->maxay > h * c->maxax) w = h * c->maxax / c->maxay; - else if (w * c->minay < h * c->minax) + else if(w * c->minay < h * c->minax) h = w * c->minay / c->minax; } @@ -1215,31 +1124,31 @@ resize(Client *c, int x, int y, int w, int h, Bool sizehints) { w += c->basew; h += c->baseh; - if(c->minw > 0 && w < c->minw) - w = c->minw; - if(c->minh > 0 && h < c->minh) - h = c->minh; - if(c->maxw > 0 && w > c->maxw) - w = c->maxw; - if(c->maxh > 0 && h > c->maxh) - h = c->maxh; + w = MAX(w, c->minw); + h = MAX(h, c->minh); + + if (c->maxw) + w = MIN(w, c->maxw); + + if (c->maxh) + h = MIN(h, c->maxh); } if(w <= 0 || h <= 0) return; if(x > sx + sw) - x = sw - w - 2 * c->border; + x = sw - w - 2 * c->bw; if(y > sy + sh) - y = sh - h - 2 * c->border; - if(x + w + 2 * c->border < sx) + y = sh - h - 2 * c->bw; + if(x + w + 2 * c->bw < sx) x = sx; - if(y + h + 2 * c->border < sy) + if(y + h + 2 * c->bw < sy) y = sy; if(c->x != x || c->y != y || c->w != w || c->h != h) { c->x = wc.x = x; c->y = wc.y = y; c->w = wc.width = w; c->h = wc.height = h; - wc.border_width = c->border; + wc.border_width = c->bw; XConfigureWindow(dpy, c->win, CWX|CWY|CWWidth|CWHeight|CWBorderWidth, &wc); configure(c); @@ -1256,15 +1165,15 @@ resizemouse(Client *c) { ocx = c->x; ocy = c->y; if(XGrabPointer(dpy, root, False, MOUSEMASK, GrabModeAsync, GrabModeAsync, - None, cursor[CurResize], CurrentTime) != GrabSuccess) + None, cursor[CurResize], CurrentTime) != GrabSuccess) return; - XWarpPointer(dpy, None, c->win, 0, 0, 0, 0, c->w + c->border - 1, c->h + c->border - 1); + XWarpPointer(dpy, None, c->win, 0, 0, 0, 0, c->w + c->bw - 1, c->h + c->bw - 1); for(;;) { XMaskEvent(dpy, MOUSEMASK|ExposureMask|SubstructureRedirectMask , &ev); switch(ev.type) { case ButtonRelease: XWarpPointer(dpy, None, c->win, 0, 0, 0, 0, - c->w + c->border - 1, c->h + c->border - 1); + c->w + c->bw - 1, c->h + c->bw - 1); XUngrabPointer(dpy, CurrentTime); while(XCheckMaskEvent(dpy, EnterWindowMask, &ev)); return; @@ -1275,13 +1184,16 @@ resizemouse(Client *c) { break; case MotionNotify: XSync(dpy, False); - if((nw = ev.xmotion.x - ocx - 2 * c->border + 1) <= 0) - nw = 1; - if((nh = ev.xmotion.y - ocy - 2 * c->border + 1) <= 0) - nh = 1; - if(!c->isfloating && (lt->arrange != floating) && (abs(nw - c->w) > SNAP || abs(nh - c->h) > SNAP)) - togglefloating(NULL); - if((lt->arrange == floating) || c->isfloating) + nw = MAX(ev.xmotion.x - ocx - 2 * c->bw + 1, 1); + nh = MAX(ev.xmotion.y - ocy - 2 * c->bw + 1, 1); + + if(snap && nw >= wx && nw <= wx + ww + && nh >= wy && nh <= wy + wh) { + if(!c->isfloating && lt->arrange + && (abs(nw - c->w) > snap || abs(nh - c->h) > snap)) + togglefloating(NULL); + } + if(!lt->arrange || c->isfloating) resize(c, c->x, c->y, nw, nh, True); break; } @@ -1297,21 +1209,16 @@ restack(void) { drawbar(); if(!sel) return; - if(sel->isfloating || (lt->arrange == floating)) + if(sel->isfloating || !lt->arrange) XRaiseWindow(dpy, sel->win); - if(lt->arrange != floating) { + if(lt->arrange) { wc.stack_mode = Below; wc.sibling = barwin; - if(!sel->isfloating) { - XConfigureWindow(dpy, sel->win, CWSibling|CWStackMode, &wc); - wc.sibling = sel->win; - } - for(c = nexttiled(clients); c; c = nexttiled(c->next)) { - if(c == sel) - continue; - XConfigureWindow(dpy, c->win, CWSibling|CWStackMode, &wc); - wc.sibling = c->win; - } + for(c = stack; c; c = c->snext) + if(!c->isfloating && isvisible(c)) { + XConfigureWindow(dpy, c->win, CWSibling|CWStackMode, &wc); + wc.sibling = c->win; + } } XSync(dpy, False); while(XCheckMaskEvent(dpy, EnterWindowMask, &ev)); @@ -1387,7 +1294,7 @@ scan(void) { if(XQueryTree(dpy, root, &d1, &d2, &wins, &num)) { for(i = 0; i < num; i++) { if(!XGetWindowAttributes(dpy, wins[i], &wa) - || wa.override_redirect || XGetTransientForHint(dpy, wins[i], &d1)) + || wa.override_redirect || XGetTransientForHint(dpy, wins[i], &d1)) continue; if(wa.map_state == IsViewable || getstate(wins[i]) == IconicState) manage(wins[i], &wa); @@ -1396,7 +1303,7 @@ scan(void) { if(!XGetWindowAttributes(dpy, wins[i], &wa)) continue; if(XGetTransientForHint(dpy, wins[i], &d1) - && (wa.map_state == IsViewable || getstate(wins[i]) == IconicState)) + && (wa.map_state == IsViewable || getstate(wins[i]) == IconicState)) manage(wins[i], &wa); } } @@ -1412,63 +1319,36 @@ setclientstate(Client *c, long state) { PropModeReplace, (unsigned char *)data, 2); } +/* arg > 1.0 will set mfact absolutly */ void -setlayout(const char *arg) { - unsigned int i; - - if(!arg) { - lt++; - if(lt == &layouts[LENGTH(layouts)]) - lt = &layouts[0]; - } - else { - for(i = 0; i < LENGTH(layouts); i++) - if(!strcmp(arg, layouts[i].symbol)) - break; - if(i == LENGTH(layouts)) - return; - lt = &layouts[i]; - } - if(sel) - arrange(); - else - drawbar(); -} - -void -setmwfact(const char *arg) { - double delta; +setmfact(void *arg) { + double d = *((double*) arg); - if(!domwfact) + if(!d || lt->arrange != tile) return; - /* arg handling, manipulate mwfact */ - if(arg == NULL) - mwfact = MWFACT; - else if(sscanf(arg, "%lf", &delta) == 1) { - if(arg[0] == '+' || arg[0] == '-') - mwfact += delta; - else - mwfact = delta; - if(mwfact < 0.1) - mwfact = 0.1; - else if(mwfact > 0.9) - mwfact = 0.9; - } + d = d < 1.0 ? d + mfact : d - 1.0; + if(d < 0.1 || d > 0.9) + return; + mfact = d; + updatetilegeom(); arrange(); } void setup(void) { - unsigned int i; + unsigned int i, w; XSetWindowAttributes wa; /* init screen */ screen = DefaultScreen(dpy); root = RootWindow(dpy, screen); + initfont(FONT); sx = 0; sy = 0; sw = DisplayWidth(dpy, screen); sh = DisplayHeight(dpy, screen); + bh = dc.font.height + 2; + updategeom(); /* init atoms */ wmatom[WMProtocols] = XInternAtom(dpy, "WM_PROTOCOLS", False); @@ -1483,11 +1363,6 @@ setup(void) { cursor[CurResize] = XCreateFontCursor(dpy, XC_sizing); cursor[CurMove] = XCreateFontCursor(dpy, XC_fleur); -#ifdef XINERAMA - if(XineramaIsActive(dpy)) - info = XineramaQueryScreens(dpy, &xscreens); -#endif - /* init appearance */ dc.norm[ColBorder] = getcolor(NORMBORDERCOLOR); dc.norm[ColBG] = getcolor(NORMBGCOLOR); @@ -1496,40 +1371,27 @@ setup(void) { dc.sel[ColBG] = getcolor(SELBGCOLOR); dc.sel[ColFG] = getcolor(SELFGCOLOR); initfont(FONT); - dc.h = bh = dc.font.height + 2; + dc.h = bh; dc.drawable = XCreatePixmap(dpy, root, DisplayWidth(dpy, screen), bh, DefaultDepth(dpy, screen)); dc.gc = XCreateGC(dpy, root, 0, 0); XSetLineAttributes(dpy, dc.gc, 1, LineSolid, CapButt, JoinMiter); if(!dc.font.set) XSetFont(dpy, dc.gc, dc.font.xfont->fid); - /* init tags */ - seltags = emallocz(TAGSZ); - prevtags = emallocz(TAGSZ); - seltags[0] = prevtags[0] = True; - - /* init layouts */ - mwfact = MWFACT; - lt = &layouts[0]; - - /* TODO: Xinerama hints ? */ /* init bar */ - for(blw = i = 0; i < LENGTH(layouts); i++) { - i = textw(layouts[i].symbol); - if(i > blw) - blw = i; + for(blw = i = 0; LENGTH(layouts) > 1 && i < LENGTH(layouts); i++) { + w = textw(layouts[i].symbol); + blw = MAX(blw, w); } - bpos = BARPOS; wa.override_redirect = 1; wa.background_pixmap = ParentRelative; wa.event_mask = ButtonPressMask|ExposureMask; - barwin = XCreateWindow(dpy, root, sx, sy, sw, bh, 0, DefaultDepth(dpy, screen), - CopyFromParent, DefaultVisual(dpy, screen), - CWOverrideRedirect|CWBackPixmap|CWEventMask, &wa); + barwin = XCreateWindow(dpy, root, bx, by, bw, bh, 0, DefaultDepth(dpy, screen), + CopyFromParent, DefaultVisual(dpy, screen), + CWOverrideRedirect|CWBackPixmap|CWEventMask, &wa); XDefineCursor(dpy, barwin, cursor[CurNormal]); - updatebarpos(); XMapRaised(dpy, barwin); strcpy(stext, "dwm-"VERSION); drawbar(); @@ -1550,13 +1412,11 @@ setup(void) { } void -spawn(const char *arg) { +spawn(void *arg) { static char *shell = NULL; if(!shell && !(shell = getenv("SHELL"))) shell = "/bin/sh"; - if(!arg) - return; /* The double-fork construct avoids zombie processes and keeps the code * clean from stupid signal handlers. */ if(fork() == 0) { @@ -1564,8 +1424,8 @@ spawn(const char *arg) { if(dpy) close(ConnectionNumber(dpy)); setsid(); - execl(shell, shell, "-c", arg, (char *)NULL); - fprintf(stderr, "dwm: execl '%s -c %s'", shell, arg); + execl(shell, shell, "-c", (char *)arg, (char *)NULL); + fprintf(stderr, "dwm: execl '%s -c %s'", shell, (char *)arg); perror(" failed"); } exit(0); @@ -1574,15 +1434,11 @@ spawn(const char *arg) { } void -tag(const char *arg) { - unsigned int i; - - if(!sel) - return; - for(i = 0; i < LENGTH(tags); i++) - sel->tags[i] = (NULL == arg); - sel->tags[idxoftag(arg)] = True; - arrange(); +tag(void *arg) { + if(sel && *(int *)arg & TAGMASK) { + sel->tags = *(int *)arg & TAGMASK; + arrange(); + } } unsigned int @@ -1603,60 +1459,61 @@ textw(const char *text) { void tile(void) { - unsigned int i, n, nx, ny, nw, nh, mw, th; - Client *c, *mc; - - domwfact = dozoom = True; - nx = wax; - ny = way; - nw = 0; - for(n = 0, c = nexttiled(clients); c; c = nexttiled(c->next)) - n++; - - /* window geoms */ - mw = (n == 1) ? waw : mwfact * waw; - th = (n > 1) ? wah / (n - 1) : 0; - if(n > 1 && th < bh) - th = wah; - - for(i = 0, c = mc = nexttiled(clients); c; c = nexttiled(c->next)) { - if(i == 0) { /* master */ - nw = mw - 2 * c->border; - nh = wah - 2 * c->border; - } - else { /* tile window */ - if(i == 1) { - ny = way; - nx += mc->w + 2 * mc->border; - nw = waw - mw - 2 * c->border; - } - if(i + 1 == n) /* remainder */ - nh = (way + wah) - ny - 2 * c->border; - else - nh = th - 2 * c->border; - } - resize(c, nx, ny, nw, nh, RESIZEHINTS); - if((RESIZEHINTS) && ((c->h < bh) || (c->h > nh) || (c->w < bh) || (c->w > nw))) - /* client doesn't accept size constraints */ - resize(c, nx, ny, nw, nh, False); - if(n > 1 && th != wah) - ny = c->y + c->h + 2 * c->border; - i++; + int x, y, h, w; + unsigned int i, n; + Client *c; + + for(n = 0, c = nextunfloating(clients); c; c = nextunfloating(c->next), n++); + if(n == 0) + return; + + /* master */ + c = nextunfloating(clients); + + if(n == 1) + tileresize(c, wx, wy, ww - 2 * c->bw, wh - 2 * c->bw); + else + tileresize(c, mx, my, mw - 2 * c->bw, mh - 2 * c->bw); + + if(--n == 0) + return; + + /* tile stack */ + x = (tx > c->x + c->w) ? c->x + c->w + 2 * c->bw : tw; + y = ty; + w = (tx > c->x + c->w) ? wx + ww - x : tw; + h = th / n; + if(h < bh) + h = th; + + for(i = 0, c = nextunfloating(c->next); c; c = nextunfloating(c->next), i++) { + if(i + 1 == n) /* remainder */ + tileresize(c, x, y, w - 2 * c->bw, (ty + th) - y - 2 * c->bw); + else + tileresize(c, x, y, w - 2 * c->bw, h - 2 * c->bw); + if(h != th) + y = c->y + c->h + 2 * c->bw; } } void -togglebar(const char *arg) { - if(bpos == BarOff) - bpos = (BARPOS == BarOff) ? BarTop : BARPOS; - else - bpos = BarOff; - updatebarpos(); +tileresize(Client *c, int x, int y, int w, int h) { + resize(c, x, y, w, h, resizehints); + if(resizehints && ((c->h < bh) || (c->h > h) || (c->w < bh) || (c->w > w))) + /* client doesn't accept size constraints */ + resize(c, x, y, w, h, False); +} + +void +togglebar(void *arg) { + showbar = !showbar; + updategeom(); + updatebar(); arrange(); } void -togglefloating(const char *arg) { +togglefloating(void *arg) { if(!sel) return; sel->isfloating = !sel->isfloating; @@ -1666,31 +1523,49 @@ togglefloating(const char *arg) { } void -toggletag(const char *arg) { - unsigned int i, j; +togglelayout(void *arg) { + unsigned int i; - if(!sel) - return; - i = idxoftag(arg); - if(conflicts(sel, i)) - return; - sel->tags[i] = !sel->tags[i]; - for(j = 0; j < LENGTH(tags) && !sel->tags[j]; j++); - if(j == LENGTH(tags)) - sel->tags[i] = True; /* at least one tag must be enabled */ - arrange(); + if(!arg) { + if(++lt == &layouts[LENGTH(layouts)]) + lt = &layouts[0]; + } + else { + for(i = 0; i < LENGTH(layouts); i++) + if(!strcmp((char *)arg, layouts[i].symbol)) + break; + if(i == LENGTH(layouts)) + return; + lt = &layouts[i]; + } + if(sel) + arrange(); + else + drawbar(); } void -toggleview(const char *arg) { - unsigned int i, j; +toggletag(void *arg) { + int i, m = *(int *)arg; + for(i = 0; i < sizeof(int) * 8; i++) + fputc(m & 1 << i ? '1' : '0', stdout); + puts(""); + for(i = 0; i < sizeof(int) * 8; i++) + fputc(TAGMASK & 1 << i ? '1' : '0', stdout); + puts("aaa"); - i = idxoftag(arg); - seltags[i] = !seltags[i]; - for(j = 0; j < LENGTH(tags) && !seltags[j]; j++); - if(j == LENGTH(tags)) - seltags[i] = True; /* at least one tag must be viewed */ - arrange(); + if(sel && (sel->tags ^ ((*(int *)arg) & TAGMASK))) { + sel->tags ^= (*(int *)arg) & TAGMASK; + arrange(); + } +} + +void +toggleview(void *arg) { + if((tagset[seltags] ^ ((*(int *)arg) & TAGMASK))) { + tagset[seltags] ^= (*(int *)arg) & TAGMASK; + arrange(); + } } void @@ -1705,7 +1580,7 @@ void unmanage(Client *c) { XWindowChanges wc; - wc.border_width = c->oldborder; + wc.border_width = c->oldbw; /* The server grab construct avoids race conditions. */ XGrabServer(dpy); XSetErrorHandler(xerrordummy); @@ -1716,7 +1591,6 @@ unmanage(Client *c) { focus(NULL); XUngrabButton(dpy, AnyButton, AnyModifier, c->win); setclientstate(c, WithdrawnState); - free(c->tags); free(c); XSync(dpy, False); XSetErrorHandler(xerror); @@ -1734,29 +1608,46 @@ unmapnotify(XEvent *e) { } void -updatebarpos(void) { - XEvent ev; +updatebar(void) { + if(dc.drawable != 0) + XFreePixmap(dpy, dc.drawable); + dc.drawable = XCreatePixmap(dpy, root, bw, bh, DefaultDepth(dpy, screen)); + XMoveResizeWindow(dpy, barwin, bx, by, bw, bh); +} - wax = sx; - way = sy; - wah = sh; - waw = sw; - switch(bpos) { - default: - wah -= bh; - way += bh; - XMoveWindow(dpy, barwin, sx, sy); - break; - case BarBot: - wah -= bh; - XMoveWindow(dpy, barwin, sx, sy + wah); - break; - case BarOff: - XMoveWindow(dpy, barwin, sx, sy - bh); - break; +void +updategeom(void) { + int i; +#ifdef XINERAMA + XineramaScreenInfo *info = NULL; + + /* window area geometry */ + if(XineramaIsActive(dpy)) { + info = XineramaQueryScreens(dpy, &i); + wx = info[0].x_org; + wy = showbar && topbar ? info[0].y_org + bh : info[0].y_org; + ww = info[0].width; + wh = showbar ? info[0].height - bh : info[0].height; + XFree(info); } - XSync(dpy, False); - while(XCheckMaskEvent(dpy, EnterWindowMask, &ev)); + else +#endif + { + wx = sx; + wy = showbar && topbar ? sy + bh : sy; + ww = sw; + wh = showbar ? sh - bh : sh; + } + + /* bar geometry */ + bx = wx; + by = showbar ? (topbar ? wy - bh : wy + wh) : -bh; + bw = ww; + + /* update layout geometries */ + for(i = 0; i < LENGTH(layouts); i++) + if(layouts[i].updategeom) + layouts[i].updategeom(); } void @@ -1812,6 +1703,21 @@ updatesizehints(Client *c) { } void +updatetilegeom(void) { + /* master area geometry */ + mx = wx; + my = wy; + mw = mfact * ww; + mh = wh; + + /* tile area geometry */ + tx = mx + mw; + ty = wy; + tw = ww - mw; + th = wh; +} + +void updatetitle(Client *c) { if(!gettextprop(c->win, netatom[NetWMName], c->name, sizeof c->name)) gettextprop(c->win, wmatom[WMName], c->name, sizeof c->name); @@ -1822,33 +1728,26 @@ updatewmhints(Client *c) { XWMHints *wmh; if((wmh = XGetWMHints(dpy, c->win))) { - c->isurgent = (wmh->flags & XUrgencyHint) ? True : False; + if(c == sel) + sel->isurgent = False; + else + c->isurgent = (wmh->flags & XUrgencyHint) ? True : False; XFree(wmh); } } - void -view(const char *arg) { - unsigned int i; - - for(i = 0; i < LENGTH(tags); i++) - tmp[i] = (NULL == arg); - tmp[idxoftag(arg)] = True; - - if(memcmp(seltags, tmp, TAGSZ) != 0) { - memcpy(prevtags, seltags, TAGSZ); - memcpy(seltags, tmp, TAGSZ); +view(void *arg) { + if(*(int *)arg & TAGMASK) { + seltags ^= 1; /* toggle sel tagset */ + tagset[seltags] = *(int *)arg & TAGMASK; arrange(); } } void -viewprevtag(const char *arg) { - - memcpy(tmp, seltags, TAGSZ); - memcpy(seltags, prevtags, TAGSZ); - memcpy(prevtags, tmp, TAGSZ); +viewprevtag(void *arg) { + seltags ^= 1; /* toggle sel tagset */ arrange(); } @@ -1863,11 +1762,12 @@ xerror(Display *dpy, XErrorEvent *ee) { || (ee->request_code == X_PolyFillRectangle && ee->error_code == BadDrawable) || (ee->request_code == X_PolySegment && ee->error_code == BadDrawable) || (ee->request_code == X_ConfigureWindow && ee->error_code == BadMatch) + || (ee->request_code == X_GrabButton && ee->error_code == BadAccess) || (ee->request_code == X_GrabKey && ee->error_code == BadAccess) || (ee->request_code == X_CopyArea && ee->error_code == BadDrawable)) return 0; fprintf(stderr, "dwm: fatal error: request code=%d, error code=%d\n", - ee->request_code, ee->error_code); + ee->request_code, ee->error_code); return xerrorxlib(dpy, ee); /* may call exit */ } @@ -1885,17 +1785,17 @@ xerrorstart(Display *dpy, XErrorEvent *ee) { } void -zoom(const char *arg) { +zoom(void *arg) { Client *c = sel; - if(!sel || !dozoom || sel->isfloating) - return; - if(c == nexttiled(clients)) - if(!(c = nexttiled(c->next))) + if(c == nextunfloating(clients)) + if(!c || !(c = nextunfloating(c->next))) return; - detach(c); - attach(c); - focus(c); + if(lt->arrange == tile && !sel->isfloating) { + detach(c); + attach(c); + focus(c); + } arrange(); }