X-Git-Url: https://jasonwoof.com/gitweb/?p=dwm.git;a=blobdiff_plain;f=dwm.c;h=af0763804620812d5903392033fef1e682867bce;hp=9932974ad57c0fe973d931c3f22f8de9c525d1e9;hb=24c125cc8a90405f9e0a1d63013e934d5480e6bb;hpb=9449ea3e002990372383835b85ed18ceaf75e400 diff --git a/dwm.c b/dwm.c index 9932974..af07638 100644 --- a/dwm.c +++ b/dwm.c @@ -21,23 +21,23 @@ * creates a small title window, which is resized whenever the (_NET_)WM_NAME * properties are updated or the client is moved/resized. * - * Keys and tagging rules are organized as arrays and defined in the config.h - * file. These arrays are kept static in event.o and tag.o respectively, - * because no other part of dwm needs access to them. The current layout is - * represented by the lt pointer. + * Keys and tagging rules are organized as arrays and defined in config.h. * * To understand everything else, start reading main(). */ +#include "dwm.h" + #include #include -#include #include #include #include #include #include #include +#include #include +#include #include #include #include @@ -57,23 +57,6 @@ enum { NetSupported, NetWMName, NetLast }; /* EWMH atoms */ enum { WMProtocols, WMDelete, WMName, WMState, WMLast };/* default atoms */ /* typedefs */ -typedef struct Client Client; -struct Client { - char name[256]; - int x, y, w, h; - int rx, ry, rw, rh; /* revert geometry */ - int basew, baseh, incw, inch, maxw, maxh, minw, minh; - int minax, maxax, minay, maxay; - long flags; - unsigned int border, oldborder; - Bool isbanned, isfixed, ismax, isfloating; - Bool *tags; - Client *next; - Client *prev; - Client *snext; - Window win; -}; - typedef struct { int x, y, w, h; unsigned long norm[ColLast]; @@ -113,96 +96,97 @@ typedef struct { } Regs; /* forward declarations */ -static void applyrules(Client *c); -static void arrange(void); -static void attach(Client *c); -static void attachstack(Client *c); -static void ban(Client *c); -static void buttonpress(XEvent *e); -static void checkotherwm(void); -static void cleanup(void); -static void compileregs(void); -static void configure(Client *c); -static void configurenotify(XEvent *e); -static void configurerequest(XEvent *e); -static void destroynotify(XEvent *e); -static void detach(Client *c); -static void detachstack(Client *c); -static void drawbar(void); -static void drawsquare(Bool filled, Bool empty, unsigned long col[ColLast]); -static void drawtext(const char *text, unsigned long col[ColLast]); -static void *emallocz(unsigned int size); -static void enternotify(XEvent *e); -static void eprint(const char *errstr, ...); -static void expose(XEvent *e); -static void floating(void); /* default floating layout */ -static void focus(Client *c); -static void focusnext(const char *arg); -static void focusprev(const char *arg); -static Client *getclient(Window w); -static unsigned long getcolor(const char *colstr); -static long getstate(Window w); -static Bool gettextprop(Window w, Atom atom, char *text, unsigned int size); -static void grabbuttons(Client *c, Bool focused); -static unsigned int idxoftag(const char *tag); -static void initfont(const char *fontstr); -static Bool isarrange(void (*func)()); -static Bool isoccupied(unsigned int t); -static Bool isprotodel(Client *c); -static Bool isvisible(Client *c); -static void keypress(XEvent *e); -static void killclient(const char *arg); -static void leavenotify(XEvent *e); -static void manage(Window w, XWindowAttributes *wa); -static void mappingnotify(XEvent *e); -static void maprequest(XEvent *e); -static void movemouse(Client *c); -static Client *nexttiled(Client *c); -static void propertynotify(XEvent *e); -static void quit(const char *arg); -static void resize(Client *c, int x, int y, int w, int h, Bool sizehints); -static void resizemouse(Client *c); -static void restack(void); -static void run(void); -static void scan(void); -static void setclientstate(Client *c, long state); -static void setlayout(const char *arg); -static void setmwfact(const char *arg); -static void setup(void); -static void spawn(const char *arg); -static void tag(const char *arg); -static unsigned int textnw(const char *text, unsigned int len); -static unsigned int textw(const char *text); -static void tile(void); -static void togglebar(const char *arg); -static void togglefloating(const char *arg); -static void togglemax(const char *arg); -static void toggletag(const char *arg); -static void toggleview(const char *arg); -static void unban(Client *c); -static void unmanage(Client *c); -static void unmapnotify(XEvent *e); -static void updatebarpos(void); -static void updatesizehints(Client *c); -static void updatetitle(Client *c); -static void view(const char *arg); -static int xerror(Display *dpy, XErrorEvent *ee); -static int xerrordummy(Display *dsply, XErrorEvent *ee); -static int xerrorstart(Display *dsply, XErrorEvent *ee); -static void zoom(const char *arg); +void applyrules(Client *c); +void arrange(void); +void attach(Client *c); +void attachstack(Client *c); +void ban(Client *c); +void buttonpress(XEvent *e); +void checkotherwm(void); +void cleanup(void); +void compileregs(void); +void configure(Client *c); +void configurenotify(XEvent *e); +void configurerequest(XEvent *e); +void destroynotify(XEvent *e); +void detach(Client *c); +void detachstack(Client *c); +void drawbar(void); +void drawsquare(Bool filled, Bool empty, unsigned long col[ColLast]); +void drawtext(const char *text, unsigned long col[ColLast]); +void *emallocz(unsigned int size); +void enternotify(XEvent *e); +void eprint(const char *errstr, ...); +void expose(XEvent *e); +void floating(void); /* default floating layout */ +void focus(Client *c); +void focusnext(const char *arg); +void focusprev(const char *arg); +Client *getclient(Window w); +unsigned long getcolor(const char *colstr); +long getstate(Window w); +Bool gettextprop(Window w, Atom atom, char *text, unsigned int size); +void grabbuttons(Client *c, Bool focused); +unsigned int idxoftag(const char *tag); +void initfont(const char *fontstr); +Bool isarrange(void (*func)()); +Bool isoccupied(unsigned int t); +Bool isprotodel(Client *c); +Bool isvisible(Client *c); +void keypress(XEvent *e); +void killclient(const char *arg); +void leavenotify(XEvent *e); +void manage(Window w, XWindowAttributes *wa); +void mappingnotify(XEvent *e); +void maprequest(XEvent *e); +void movemouse(Client *c); +Client *nexttiled(Client *c); +void propertynotify(XEvent *e); +void quit(const char *arg); +void resize(Client *c, int x, int y, int w, int h, Bool sizehints); +void resizemouse(Client *c); +void restack(void); +void run(void); +void scan(void); +void setclientstate(Client *c, long state); +void setlayout(const char *arg); +void setmwfact(const char *arg); +void setup(void); +void spawn(const char *arg); +void tag(const char *arg); +unsigned int textnw(const char *text, unsigned int len); +unsigned int textw(const char *text); +void tile(void); +void togglebar(const char *arg); +void togglefloating(const char *arg); +void togglemax(const char *arg); +void toggletag(const char *arg); +void toggleview(const char *arg); +void unban(Client *c); +void unmanage(Client *c); +void unmapnotify(XEvent *e); +void updatebarpos(void); +void updatesizehints(Client *c); +void updatetitle(Client *c); +void view(const char *arg); +void viewprevtag(const char *arg); /* views previous selected tags */ +int xerror(Display *dpy, XErrorEvent *ee); +int xerrordummy(Display *dsply, XErrorEvent *ee); +int xerrorstart(Display *dsply, XErrorEvent *ee); +void zoom(const char *arg); /* variables */ -static char stext[256]; -static double mwfact; -static int screen, sx, sy, sw, sh, wax, way, waw, wah; -static int (*xerrorxlib)(Display *, XErrorEvent *); -static unsigned int bh, bpos, ntags; -static unsigned int blw = 0; -static unsigned int ltidx = 0; /* default */ -static unsigned int nlayouts = 0; -static unsigned int nrules = 0; -static unsigned int numlockmask = 0; -static void (*handler[LASTEvent]) (XEvent *) = { +char stext[256]; +double mwfact; +int screen, sx, sy, sw, sh, wax, way, waw, wah; +int (*xerrorxlib)(Display *, XErrorEvent *); +unsigned int bh, bpos; +unsigned int blw = 0; +unsigned int ltidx = 0; /* default */ +unsigned int nlayouts = 0; +unsigned int nrules = 0; +unsigned int numlockmask = 0; +void (*handler[LASTEvent]) (XEvent *) = { [ButtonPress] = buttonpress, [ConfigureRequest] = configurerequest, [ConfigureNotify] = configurenotify, @@ -216,25 +200,29 @@ static void (*handler[LASTEvent]) (XEvent *) = { [PropertyNotify] = propertynotify, [UnmapNotify] = unmapnotify }; -static Atom wmatom[WMLast], netatom[NetLast]; -static Bool otherwm, readin; -static Bool running = True; -static Bool *seltags; -static Bool selscreen = True; -static Client *clients = NULL; -static Client *sel = NULL; -static Client *stack = NULL; -static Cursor cursor[CurLast]; -static Display *dpy; -static DC dc = {0}; -static Window barwin, root; -static Regs *regs = NULL; +Atom wmatom[WMLast], netatom[NetLast]; +Bool otherwm, readin; +Bool running = True; +Bool selscreen = True; +Client *clients = NULL; +Client *sel = NULL; +Client *stack = NULL; +Cursor cursor[CurLast]; +Display *dpy; +DC dc = {0}; +Window barwin, root; +Regs *regs = NULL; /* configuration, allows nested code to access above variables */ #include "config.h" +/* Statically define the number of tags. */ +unsigned int ntags = sizeof tags / sizeof tags[0]; +Bool seltags[sizeof tags / sizeof tags[0]] = {[0] = True}; +Bool prevtags[sizeof tags / sizeof tags[0]] = {[0] = True}; + /* functions*/ -static void +void applyrules(Client *c) { static char buf[512]; unsigned int i, j; @@ -262,11 +250,10 @@ applyrules(Client *c) { if(ch.res_name) XFree(ch.res_name); if(!matched) - for(i = 0; i < ntags; i++) - c->tags[i] = seltags[i]; + memcpy(c->tags, seltags, sizeof seltags); } -static void +void arrange(void) { Client *c; @@ -280,7 +267,7 @@ arrange(void) { restack(); } -static void +void attach(Client *c) { if(clients) clients->prev = c; @@ -288,13 +275,13 @@ attach(Client *c) { clients = c; } -static void +void attachstack(Client *c) { c->snext = stack; stack = c; } -static void +void ban(Client *c) { if(c->isbanned) return; @@ -302,7 +289,7 @@ ban(Client *c) { c->isbanned = True; } -static void +void buttonpress(XEvent *e) { unsigned int i, x; Client *c; @@ -335,22 +322,30 @@ buttonpress(XEvent *e) { focus(c); if(CLEANMASK(ev->state) != MODKEY) return; - if(ev->button == Button1 && (isarrange(floating) || c->isfloating)) { - restack(); + if(ev->button == Button1) { + if(isarrange(floating) || c->isfloating) + restack(); + else + togglefloating(NULL); movemouse(c); } - else if(ev->button == Button2) - zoom(NULL); - else if(ev->button == Button3 - && (isarrange(floating) || c->isfloating) && !c->isfixed) - { - restack(); + else if(ev->button == Button2) { + if(ISTILE && !c->isfixed && c->isfloating) + togglefloating(NULL); + else + zoom(NULL); + } + else if(ev->button == Button3 && !c->isfixed) { + if(isarrange(floating) || c->isfloating) + restack(); + else + togglefloating(NULL); resizemouse(c); } } } -static void +void checkotherwm(void) { otherwm = False; XSetErrorHandler(xerrorstart); @@ -366,7 +361,7 @@ checkotherwm(void) { XSync(dpy, False); } -static void +void cleanup(void) { close(STDIN_FILENO); while(stack) { @@ -386,10 +381,9 @@ cleanup(void) { XFreeCursor(dpy, cursor[CurMove]); XSetInputFocus(dpy, PointerRoot, RevertToPointerRoot, CurrentTime); XSync(dpy, False); - free(seltags); } -static void +void compileregs(void) { unsigned int i; regex_t *reg; @@ -416,7 +410,7 @@ compileregs(void) { } } -static void +void configure(Client *c) { XConfigureEvent ce; @@ -434,11 +428,11 @@ configure(Client *c) { XSendEvent(dpy, c->win, False, StructureNotifyMask, (XEvent *)&ce); } -static void +void configurenotify(XEvent *e) { XConfigureEvent *ev = &e->xconfigure; - if (ev->window == root && (ev->width != sw || ev->height != sh)) { + if(ev->window == root && (ev->width != sw || ev->height != sh)) { sw = ev->width; sh = ev->height; XFreePixmap(dpy, dc.drawable); @@ -449,7 +443,7 @@ configurenotify(XEvent *e) { } } -static void +void configurerequest(XEvent *e) { Client *c; XConfigureRequestEvent *ev = &e->xconfigurerequest; @@ -494,7 +488,7 @@ configurerequest(XEvent *e) { XSync(dpy, False); } -static void +void destroynotify(XEvent *e) { Client *c; XDestroyWindowEvent *ev = &e->xdestroywindow; @@ -503,7 +497,7 @@ destroynotify(XEvent *e) { unmanage(c); } -static void +void detach(Client *c) { if(c->prev) c->prev->next = c->next; @@ -514,7 +508,7 @@ detach(Client *c) { c->next = c->prev = NULL; } -static void +void detachstack(Client *c) { Client **tc; @@ -522,7 +516,7 @@ detachstack(Client *c) { *tc = c->snext; } -static void +void drawbar(void) { int i, x; @@ -562,7 +556,7 @@ drawbar(void) { XSync(dpy, False); } -static void +void drawsquare(Bool filled, Bool empty, unsigned long col[ColLast]) { int x; XGCValues gcv; @@ -583,7 +577,7 @@ drawsquare(Bool filled, Bool empty, unsigned long col[ColLast]) { } } -static void +void drawtext(const char *text, unsigned long col[ColLast]) { int x, y, w, h; static char buf[256]; @@ -623,7 +617,7 @@ drawtext(const char *text, unsigned long col[ColLast]) { XDrawString(dpy, dc.drawable, dc.gc, x, y, buf, len); } -static void * +void * emallocz(unsigned int size) { void *res = calloc(1, size); @@ -632,7 +626,7 @@ emallocz(unsigned int size) { return res; } -static void +void enternotify(XEvent *e) { Client *c; XCrossingEvent *ev = &e->xcrossing; @@ -647,7 +641,7 @@ enternotify(XEvent *e) { } } -static void +void eprint(const char *errstr, ...) { va_list ap; @@ -657,7 +651,7 @@ eprint(const char *errstr, ...) { exit(EXIT_FAILURE); } -static void +void expose(XEvent *e) { XExposeEvent *ev = &e->xexpose; @@ -667,7 +661,7 @@ expose(XEvent *e) { } } -static void +void floating(void) { /* default floating layout */ Client *c; @@ -676,7 +670,7 @@ floating(void) { /* default floating layout */ resize(c, c->x, c->y, c->w, c->h, True); } -static void +void focus(Client *c) { if((!c && selscreen) || (c && !isvisible(c))) for(c = stack; c && !isvisible(c); c = c->snext); @@ -701,7 +695,7 @@ focus(Client *c) { XSetInputFocus(dpy, root, RevertToPointerRoot, CurrentTime); } -static void +void focusnext(const char *arg) { Client *c; @@ -716,7 +710,7 @@ focusnext(const char *arg) { } } -static void +void focusprev(const char *arg) { Client *c; @@ -733,7 +727,7 @@ focusprev(const char *arg) { } } -static Client * +Client * getclient(Window w) { Client *c; @@ -741,7 +735,7 @@ getclient(Window w) { return c; } -static unsigned long +unsigned long getcolor(const char *colstr) { Colormap cmap = DefaultColormap(dpy, screen); XColor color; @@ -751,7 +745,7 @@ getcolor(const char *colstr) { return color.pixel; } -static long +long getstate(Window w) { int format, status; long result = -1; @@ -769,7 +763,7 @@ getstate(Window w) { return result; } -static Bool +Bool gettextprop(Window w, Atom atom, char *text, unsigned int size) { char **list = NULL; int n; @@ -796,7 +790,7 @@ gettextprop(Window w, Atom atom, char *text, unsigned int size) { return True; } -static void +void grabbuttons(Client *c, Bool focused) { XUngrabButton(dpy, AnyButton, AnyModifier, c->win); @@ -833,7 +827,7 @@ grabbuttons(Client *c, Bool focused) { GrabModeAsync, GrabModeSync, None, None); } -static unsigned int +unsigned int idxoftag(const char *tag) { unsigned int i; @@ -843,7 +837,7 @@ idxoftag(const char *tag) { return 0; } -static void +void initfont(const char *fontstr) { char *def, **missing; int i, n; @@ -877,7 +871,7 @@ initfont(const char *fontstr) { XFreeFont(dpy, dc.font.xfont); dc.font.xfont = NULL; if(!(dc.font.xfont = XLoadQueryFont(dpy, fontstr)) - || !(dc.font.xfont = XLoadQueryFont(dpy, "fixed"))) + && !(dc.font.xfont = XLoadQueryFont(dpy, "fixed"))) eprint("error, cannot load font: '%s'\n", fontstr); dc.font.ascent = dc.font.xfont->ascent; dc.font.descent = dc.font.xfont->descent; @@ -885,13 +879,13 @@ initfont(const char *fontstr) { dc.font.height = dc.font.ascent + dc.font.descent; } -static Bool +Bool isarrange(void (*func)()) { return func == layouts[ltidx].arrange; } -static Bool +Bool isoccupied(unsigned int t) { Client *c; @@ -901,7 +895,7 @@ isoccupied(unsigned int t) { return False; } -static Bool +Bool isprotodel(Client *c) { int i, n; Atom *protocols; @@ -916,7 +910,7 @@ isprotodel(Client *c) { return ret; } -static Bool +Bool isvisible(Client *c) { unsigned int i; @@ -926,7 +920,7 @@ isvisible(Client *c) { return False; } -static void +void keypress(XEvent *e) { KEYS unsigned int len = sizeof keys / sizeof keys[0]; @@ -961,7 +955,7 @@ keypress(XEvent *e) { } } -static void +void killclient(const char *arg) { XEvent ev; @@ -980,7 +974,7 @@ killclient(const char *arg) { XKillClient(dpy, sel->win); } -static void +void leavenotify(XEvent *e) { XCrossingEvent *ev = &e->xcrossing; @@ -990,16 +984,15 @@ leavenotify(XEvent *e) { } } -static void +void manage(Window w, XWindowAttributes *wa) { - unsigned int i; Client *c, *t = NULL; Window trans; Status rettrans; XWindowChanges wc; c = emallocz(sizeof(Client)); - c->tags = emallocz(ntags * sizeof(Bool)); + c->tags = emallocz(sizeof seltags); c->win = w; c->x = wa->x; c->y = wa->y; @@ -1034,8 +1027,7 @@ manage(Window w, XWindowAttributes *wa) { if((rettrans = XGetTransientForHint(dpy, w, &trans) == Success)) for(t = clients; t && t->win != trans; t = t->next); if(t) - for(i = 0; i < ntags; i++) - c->tags[i] = t->tags[i]; + memcpy(c->tags, t->tags, sizeof seltags); applyrules(c); if(!c->isfloating) c->isfloating = (rettrans == Success) || c->isfixed; @@ -1048,7 +1040,7 @@ manage(Window w, XWindowAttributes *wa) { arrange(); } -static void +void mappingnotify(XEvent *e) { XMappingEvent *ev = &e->xmapping; @@ -1057,7 +1049,7 @@ mappingnotify(XEvent *e) { keypress(NULL); } -static void +void maprequest(XEvent *e) { static XWindowAttributes wa; XMapRequestEvent *ev = &e->xmaprequest; @@ -1070,7 +1062,7 @@ maprequest(XEvent *e) { manage(ev->window, &wa); } -static void +void movemouse(Client *c) { int x1, y1, ocx, ocy, di, nx, ny; unsigned int dui; @@ -1113,13 +1105,13 @@ movemouse(Client *c) { } } -static Client * +Client * nexttiled(Client *c) { for(; c && (c->isfloating || !isvisible(c)); c = c->next); return c; } -static void +void propertynotify(XEvent *e) { Client *c; Window trans; @@ -1147,15 +1139,15 @@ propertynotify(XEvent *e) { } } -static void +void quit(const char *arg) { readin = running = False; } -static void +void resize(Client *c, int x, int y, int w, int h, Bool sizehints) { double dx, dy, max, min, ratio; - XWindowChanges wc; + XWindowChanges wc; if(sizehints) { if(c->minay > 0 && c->maxay > 0 && (h - c->baseh) > 0 && (w - c->basew) > 0) { @@ -1215,7 +1207,7 @@ resize(Client *c, int x, int y, int w, int h, Bool sizehints) { } } -static void +void resizemouse(Client *c) { int ocx, ocy; int nw, nh; @@ -1254,7 +1246,7 @@ resizemouse(Client *c) { } } -static void +void restack(void) { Client *c; XEvent ev; @@ -1283,7 +1275,7 @@ restack(void) { while(XCheckMaskEvent(dpy, EnterWindowMask, &ev)); } -static void +void run(void) { char *p; int r, xfd; @@ -1331,7 +1323,7 @@ run(void) { } } -static void +void scan(void) { unsigned int i, num; Window *wins, d1, d2; @@ -1358,7 +1350,7 @@ scan(void) { XFree(wins); } -static void +void setclientstate(Client *c, long state) { long data[] = {state, None}; @@ -1366,7 +1358,7 @@ setclientstate(Client *c, long state) { PropModeReplace, (unsigned char *)data, 2); } -static void +void setlayout(const char *arg) { unsigned int i; @@ -1388,20 +1380,20 @@ setlayout(const char *arg) { drawbar(); } -static void +void setmwfact(const char *arg) { double delta; - if(!isarrange(tile)) + if(!ISTILE) return; /* arg handling, manipulate mwfact */ if(arg == NULL) mwfact = MWFACT; else if(1 == sscanf(arg, "%lf", &delta)) { - if(arg[0] != '+' && arg[0] != '-') - mwfact = delta; - else + if(arg[0] == '+' || arg[0] == '-') mwfact += delta; + else + mwfact = delta; if(mwfact < 0.1) mwfact = 0.1; else if(mwfact > 0.9) @@ -1410,8 +1402,9 @@ setmwfact(const char *arg) { arrange(); } -static void +void setup(void) { + int d; unsigned int i, j, mask; Window w; XModifierKeymap *modmap; @@ -1459,9 +1452,6 @@ setup(void) { /* init tags */ compileregs(); - for(ntags = 0; tags[ntags]; ntags++); - seltags = emallocz(sizeof(Bool) * ntags); - seltags[0] = True; /* init appearance */ dc.norm[ColBorder] = getcolor(NORMBORDERCOLOR); @@ -1501,10 +1491,10 @@ setup(void) { XSetFont(dpy, dc.gc, dc.font.xfont->fid); /* multihead support */ - selscreen = XQueryPointer(dpy, root, &w, &w, &i, &i, &i, &i, &mask); + selscreen = XQueryPointer(dpy, root, &w, &w, &d, &d, &d, &d, &mask); } -static void +void spawn(const char *arg) { static char *shell = NULL; @@ -1528,7 +1518,7 @@ spawn(const char *arg) { wait(0); } -static void +void tag(const char *arg) { unsigned int i; @@ -1542,7 +1532,7 @@ tag(const char *arg) { arrange(); } -static unsigned int +unsigned int textnw(const char *text, unsigned int len) { XRectangle r; @@ -1553,15 +1543,15 @@ textnw(const char *text, unsigned int len) { return XTextWidth(dc.font.xfont, text, len); } -static unsigned int +unsigned int textw(const char *text) { return textnw(text, strlen(text)) + dc.font.height; } -static void +void tile(void) { unsigned int i, n, nx, ny, nw, nh, mw, th; - Client *c; + Client *c, *mc; for(n = 0, c = nexttiled(clients); c; c = nexttiled(c->next)) n++; @@ -1574,7 +1564,8 @@ tile(void) { nx = wax; ny = way; - for(i = 0, c = nexttiled(clients); c; c = nexttiled(c->next), i++) { + nw = 0; /* gcc stupidity requires this */ + for(i = 0, c = mc = nexttiled(clients); c; c = nexttiled(c->next), i++) { c->ismax = False; if(i == 0) { /* master */ nw = mw - 2 * c->border; @@ -1583,9 +1574,9 @@ tile(void) { else { /* tile window */ if(i == 1) { ny = way; - nx += mw; + nx += mc->w + 2 * mc->border; + nw = waw - nx - 2 * c->border; } - nw = waw - mw - 2 * c->border; if(i + 1 == n) /* remainder */ nh = (way + wah) - ny - 2 * c->border; else @@ -1593,11 +1584,11 @@ tile(void) { } resize(c, nx, ny, nw, nh, RESIZEHINTS); if(n > 1 && th != wah) - ny += nh + 2 * c->border; + ny = c->y + c->h + 2 * c->border; } } -static void +void togglebar(const char *arg) { if(bpos == BarOff) bpos = (BARPOS == BarOff) ? BarTop : BARPOS; @@ -1607,7 +1598,7 @@ togglebar(const char *arg) { arrange(); } -static void +void togglefloating(const char *arg) { if(!sel) return; @@ -1617,26 +1608,35 @@ togglefloating(const char *arg) { arrange(); } -static void +void togglemax(const char *arg) { XEvent ev; - if(!sel || (!isarrange(floating) && !sel->isfloating) || sel->isfixed) + if(!sel || sel->isfixed) return; if((sel->ismax = !sel->ismax)) { + if(isarrange(floating) || sel->isfloating) + sel->wasfloating = True; + else { + togglefloating(NULL); + sel->wasfloating = False; + } sel->rx = sel->x; sel->ry = sel->y; sel->rw = sel->w; sel->rh = sel->h; resize(sel, wax, way, waw - 2 * sel->border, wah - 2 * sel->border, True); } - else + else { resize(sel, sel->rx, sel->ry, sel->rw, sel->rh, True); + if(!sel->wasfloating) + togglefloating(NULL); + } drawbar(); while(XCheckMaskEvent(dpy, EnterWindowMask, &ev)); } -static void +void toggletag(const char *arg) { unsigned int i, j; @@ -1650,7 +1650,7 @@ toggletag(const char *arg) { arrange(); } -static void +void toggleview(const char *arg) { unsigned int i, j; @@ -1658,11 +1658,11 @@ toggleview(const char *arg) { seltags[i] = !seltags[i]; for(j = 0; j < ntags && !seltags[j]; j++); if(j == ntags) - seltags[i] = True; /* cannot toggle last view */ + seltags[i] = True; /* at least one tag must be viewed */ arrange(); } -static void +void unban(Client *c) { if(!c->isbanned) return; @@ -1670,7 +1670,7 @@ unban(Client *c) { c->isbanned = False; } -static void +void unmanage(Client *c) { XWindowChanges wc; @@ -1693,7 +1693,7 @@ unmanage(Client *c) { arrange(); } -static void +void unmapnotify(XEvent *e) { Client *c; XUnmapEvent *ev = &e->xunmap; @@ -1702,7 +1702,7 @@ unmapnotify(XEvent *e) { unmanage(c); } -static void +void updatebarpos(void) { XEvent ev; @@ -1728,7 +1728,7 @@ updatebarpos(void) { while(XCheckMaskEvent(dpy, EnterWindowMask, &ev)); } -static void +void updatesizehints(Client *c) { long msize; XSizeHints size; @@ -1780,7 +1780,7 @@ updatesizehints(Client *c) { && c->maxw == c->minw && c->maxh == c->minh); } -static void +void updatetitle(Client *c) { if(!gettextprop(c->win, netatom[NetWMName], c->name, sizeof c->name)) gettextprop(c->win, wmatom[WMName], c->name, sizeof c->name); @@ -1789,7 +1789,7 @@ updatetitle(Client *c) { /* There's no way to check accesses to destroyed windows, thus those cases are * ignored (especially on UnmapNotify's). Other types of errors call Xlibs * default error handler, which may call exit. */ -static int +int xerror(Display *dpy, XErrorEvent *ee) { if(ee->error_code == BadWindow || (ee->request_code == X_SetInputFocus && ee->error_code == BadMatch) @@ -1805,23 +1805,24 @@ xerror(Display *dpy, XErrorEvent *ee) { return xerrorxlib(dpy, ee); /* may call exit */ } -static int +int xerrordummy(Display *dsply, XErrorEvent *ee) { return 0; } /* Startup Error handler to check if another window manager * is already running. */ -static int +int xerrorstart(Display *dsply, XErrorEvent *ee) { otherwm = True; return -1; } -static void +void view(const char *arg) { unsigned int i; + memcpy(prevtags, seltags, sizeof seltags); for(i = 0; i < ntags; i++) seltags[i] = arg == NULL; i = idxoftag(arg); @@ -1830,11 +1831,21 @@ view(const char *arg) { arrange(); } -static void +void +viewprevtag(const char *arg) { + static Bool tmptags[sizeof tags / sizeof tags[0]]; + + memcpy(tmptags, seltags, sizeof seltags); + memcpy(seltags, prevtags, sizeof seltags); + memcpy(prevtags, tmptags, sizeof seltags); + arrange(); +} + +void zoom(const char *arg) { Client *c; - if(!sel || !isarrange(tile) || sel->isfloating) + if(!sel || !ISTILE || sel->isfloating) return; if((c = sel) == nexttiled(clients)) if(!(c = nexttiled(c->next)))