X-Git-Url: https://jasonwoof.com/gitweb/?p=dwm.git;a=blobdiff_plain;f=dwm.c;h=e2f306c1e64fbf20bfee3a6a7dd3da5667b2d815;hp=c7fd99bac19cbef15af1da91cef5f74dc5fba7de;hb=8ef465d592fada11dab075bb7569239c03e3afa4;hpb=6cbe47d4814f1341a5230e21c205a18591d43f6f diff --git a/dwm.c b/dwm.c index c7fd99b..e2f306c 100644 --- a/dwm.c +++ b/dwm.c @@ -1,4 +1,3 @@ -//#define XINULATOR /* debug, simulates dual head */ /* See LICENSE file for copyright and license details. * * dynamic window manager is designed like any other X client as well. It is @@ -12,9 +11,9 @@ * in O(1) time. * * Each child of the root window is called a client, except windows which have - * set the override_redirect flag. Clients are organized in a global - * linked client list, the focus history is remembered through a global - * stack list. Each client contains a bit array to indicate the tags of a + * set the override_redirect flag. Clients are organized in a linked client + * list on each monitor, the focus history is remembered through a stack list + * on each monitor. Each client contains a bit array to indicate the tags of a * client. * * Keys and tagging rules are organized as arrays and defined in config.h. @@ -52,7 +51,7 @@ #define MOUSEMASK (BUTTONMASK|PointerMotionMask) #define WIDTH(X) ((X)->w + 2 * (X)->bw) #define HEIGHT(X) ((X)->h + 2 * (X)->bw) -#define TAGMASK ((int)((1LL << LENGTH(tags)) - 1)) +#define TAGMASK ((1 << LENGTH(tags)) - 1) #define TEXTW(X) (textnw(X, strlen(X)) + dc.font.height) /* enums */ @@ -67,7 +66,7 @@ typedef union { int i; unsigned int ui; float f; - void *v; + const void *v; } Arg; typedef struct { @@ -122,10 +121,10 @@ typedef struct { } Layout; struct Monitor { - int screen_number; float mfact; - int by, btx; /* bar geometry */ - int mx, my, mw, mh; /* screen size */ + int num; + int by; /* bar geometry */ + int mx, my, mw, mh; /* screen size */ int wx, wy, ww, wh; /* window area */ unsigned int seltags; unsigned int sellt; @@ -137,6 +136,7 @@ struct Monitor { Client *stack; Monitor *next; Window barwin; + const Layout *lt[2]; }; typedef struct { @@ -145,11 +145,12 @@ typedef struct { const char *title; unsigned int tags; Bool isfloating; + int monitor; } Rule; /* function declarations */ static void applyrules(Client *c); -static Bool applysizehints(Client *c, int *x, int *y, int *w, int *h); +static Bool applysizehints(Client *c, int *x, int *y, int *w, int *h, Bool interact); static void arrange(void); static void attach(Client *c); static void attachstack(Client *c); @@ -165,6 +166,7 @@ static void destroynotify(XEvent *e); static void detach(Client *c); static void detachstack(Client *c); static void die(const char *errstr, ...); +static Monitor *dirtomon(int dir); static void drawbar(Monitor *m); static void drawbars(void); static void drawsquare(Bool filled, Bool empty, Bool invert, unsigned long col[ColLast]); @@ -173,13 +175,10 @@ static void enternotify(XEvent *e); static void expose(XEvent *e); static void focus(Client *c); static void focusin(XEvent *e); +static void focusmon(const Arg *arg); static void focusstack(const Arg *arg); -static Client *getclient(Window w); static unsigned long getcolor(const char *colstr); -static Monitor *getmon(Window w); -static Monitor *getmonn(unsigned int n); -static Monitor *getmonxy(int x, int y); -static Bool getrootpointer(int *x, int *y); +static Bool getrootptr(int *x, int *y); static long getstate(Window w); static Bool gettextprop(Window w, Atom atom, char *text, unsigned int size); static void grabbuttons(Client *c, Bool focused); @@ -194,9 +193,10 @@ static void maprequest(XEvent *e); static void monocle(Monitor *m); static void movemouse(const Arg *arg); static Client *nexttiled(Client *c); +static Monitor *ptrtomon(int x, int y); static void propertynotify(XEvent *e); static void quit(const Arg *arg); -static void resize(Client *c, int x, int y, int w, int h); +static void resize(Client *c, int x, int y, int w, int h, Bool interact); static void resizemouse(const Arg *arg); static void restack(Monitor *m); static void run(void); @@ -207,9 +207,10 @@ static void setlayout(const Arg *arg); static void setmfact(const Arg *arg); static void setup(void); static void showhide(Client *c); -static void sigchld(int signal); +static void sigchld(int unused); static void spawn(const Arg *arg); static void tag(const Arg *arg); +static void tagmon(const Arg *arg); static int textnw(const char *text, unsigned int len); static void tile(Monitor *); static void togglebar(const Arg *arg); @@ -228,19 +229,18 @@ static void updatestatus(void); static void updatetitle(Client *c); static void updatewmhints(Client *c); static void view(const Arg *arg); +static Client *wintoclient(Window w); +static Monitor *wintomon(Window w); static int xerror(Display *dpy, XErrorEvent *ee); static int xerrordummy(Display *dpy, XErrorEvent *ee); static int xerrorstart(Display *dpy, XErrorEvent *ee); static void zoom(const Arg *arg); -#ifdef XINERAMA -static void focusmon(const Arg *arg); -static void tagmon(const Arg *arg); -#endif /* XINERAMA */ /* variables */ -static char stext[256]; +static const char broken[] = "broken"; +static char stext[256], ntext[8]; static int screen; -static int sx, sy, sw, sh; /* X display screen geometry x, y, width, height */ +static int sw, sh; /* X display screen geometry width, height */ static int bh, blw = 0; /* bar geometry */ static int (*xerrorxlib)(Display *, XErrorEvent *); static unsigned int numlockmask = 0; @@ -264,32 +264,40 @@ static Bool running = True; static Cursor cursor[CurLast]; static Display *dpy; static DC dc; -static Layout *lt[] = { NULL, NULL }; static Monitor *mons = NULL, *selmon = NULL; static Window root; + /* configuration, allows nested code to access above variables */ #include "config.h" /* compile-time check if all tags fit into an unsigned int bit array. */ -struct NumTags { char limitexceeded[sizeof(unsigned int) * 8 < LENGTH(tags) ? -1 : 1]; }; +struct NumTags { char limitexceeded[LENGTH(tags) > 31 ? -1 : 1]; }; /* function implementations */ void applyrules(Client *c) { + const char *class, *instance; unsigned int i; - Rule *r; + const Rule *r; + Monitor *m; XClassHint ch = { 0 }; /* rule matching */ c->isfloating = c->tags = 0; if(XGetClassHint(dpy, c->win, &ch)) { + class = ch.res_class ? ch.res_class : broken; + instance = ch.res_name ? ch.res_name : broken; for(i = 0; i < LENGTH(rules); i++) { r = &rules[i]; if((!r->title || strstr(c->name, r->title)) - && (!r->class || (ch.res_class && strstr(ch.res_class, r->class))) - && (!r->instance || (ch.res_name && strstr(ch.res_name, r->instance)))) { + && (!r->class || strstr(class, r->class)) + && (!r->instance || strstr(instance, r->instance))) + { c->isfloating = r->isfloating; c->tags |= r->tags; + for(m = mons; m && m->num != r->monitor; m = m->next); + if(m) + c->mon = m; } } if(ch.res_class) @@ -301,64 +309,67 @@ applyrules(Client *c) { } Bool -applysizehints(Client *c, int *x, int *y, int *w, int *h) { +applysizehints(Client *c, int *x, int *y, int *w, int *h, Bool interact) { Bool baseismin; + Monitor *m = c->mon; /* set minimum possible */ *w = MAX(1, *w); *h = MAX(1, *h); - - if(*x > sx + sw) - *x = sw - WIDTH(c); - if(*y > sy + sh) - *y = sh - HEIGHT(c); - if(*x + *w + 2 * c->bw < sx) - *x = sx; - if(*y + *h + 2 * c->bw < sy) - *y = sy; + if(interact) { + if(*x > sw) + *x = sw - WIDTH(c); + if(*y > sh) + *y = sh - HEIGHT(c); + if(*x + *w + 2 * c->bw < 0) + *x = 0; + if(*y + *h + 2 * c->bw < 0) + *y = 0; + } + else { + if(*x > m->mx + m->mw) + *x = m->mx + m->mw - WIDTH(c); + if(*y > m->my + m->mh) + *y = m->my + m->mh - HEIGHT(c); + if(*x + *w + 2 * c->bw < m->mx) + *x = m->mx; + if(*y + *h + 2 * c->bw < m->my) + *y = m->my; + } if(*h < bh) *h = bh; if(*w < bh) *w = bh; - if(resizehints || c->isfloating) { /* see last two sentences in ICCCM 4.1.2.3 */ baseismin = c->basew == c->minw && c->baseh == c->minh; - if(!baseismin) { /* temporarily remove base dimensions */ *w -= c->basew; *h -= c->baseh; } - /* adjust for aspect limits */ if(c->mina > 0 && c->maxa > 0) { if(c->maxa < (float)*w / *h) - *w = *h * c->maxa; + *w = *h * c->maxa + 0.5; else if(c->mina < (float)*h / *w) - *h = *w * c->mina; + *h = *w * c->mina + 0.5; } - if(baseismin) { /* increment calculation requires this */ *w -= c->basew; *h -= c->baseh; } - /* adjust for increment value */ if(c->incw) *w -= *w % c->incw; if(c->inch) *h -= *h % c->inch; - /* restore base dimensions */ *w += c->basew; *h += c->baseh; - *w = MAX(*w, c->minw); *h = MAX(*h, c->minh); - if(c->maxw) *w = MIN(*w, c->maxw); - if(c->maxh) *h = MIN(*h, c->maxh); } @@ -369,13 +380,12 @@ void arrange(void) { Monitor *m; - /* optimise two loops into one, check focus(NULL) */ for(m = mons; m; m = m->next) showhide(m->stack); focus(NULL); for(m = mons; m; m = m->next) { - if(lt[m->sellt]->arrange) - lt[m->sellt]->arrange(m); + if(m->lt[m->sellt]->arrange) + m->lt[m->sellt]->arrange(m); restack(m); } } @@ -402,17 +412,16 @@ buttonpress(XEvent *e) { click = ClkRootWin; /* focus monitor if necessary */ - if((m = getmon(ev->window)) && m != selmon) { + if((m = wintomon(ev->window)) && m != selmon) { unfocus(selmon->sel); selmon = m; focus(NULL); } - if(ev->window == selmon->barwin && ev->x >= selmon->btx) { - i = 0; - x = selmon->btx; - do + if(ev->window == selmon->barwin) { + i = x = 0; + do { x += TEXTW(tags[i]); - while(ev->x >= x && ++i < LENGTH(tags)); + } while(ev->x >= x && ++i < LENGTH(tags)); if(i < LENGTH(tags)) { click = ClkTagBar; arg.ui = 1 << i; @@ -424,14 +433,13 @@ buttonpress(XEvent *e) { else click = ClkWinTitle; } - else if((c = getclient(ev->window))) { + else if((c = wintoclient(ev->window))) { focus(c); click = ClkClientWin; } - for(i = 0; i < LENGTH(buttons); i++) if(click == buttons[i].click && buttons[i].func && buttons[i].button == ev->button - && CLEANMASK(buttons[i].mask) == CLEANMASK(ev->state)) + && CLEANMASK(buttons[i].mask) == CLEANMASK(ev->state)) buttons[i].func(click == ClkTagBar && buttons[i].arg.i == 0 ? &arg : &buttons[i].arg); } @@ -439,7 +447,6 @@ void checkotherwm(void) { otherwm = False; xerrorxlib = XSetErrorHandler(xerrorstart); - /* this causes an error if some other window manager is running */ XSelectInput(dpy, DefaultRootWindow(dpy), SubstructureRedirectMask); XSync(dpy, False); @@ -456,9 +463,7 @@ cleanup(void) { Monitor *m; view(&a); - lt[selmon->sellt] = &foo; - - /* TODO: consider simplifying cleanup code of the stack, perhaps do that in cleanmons() ? */ + selmon->lt[selmon->sellt] = &foo; for(m = mons; m; m = m->next) while(m->stack) unmanage(m->stack); @@ -546,10 +551,10 @@ configurerequest(XEvent *e) { XConfigureRequestEvent *ev = &e->xconfigurerequest; XWindowChanges wc; - if((c = getclient(ev->window))) { + if((c = wintoclient(ev->window))) { if(ev->value_mask & CWBorderWidth) c->bw = ev->border_width; - else if(c->isfloating || !lt[selmon->sellt]->arrange) { + else if(c->isfloating || !selmon->lt[selmon->sellt]->arrange) { m = c->mon; if(ev->value_mask & CWX) c->x = m->mx + ev->x; @@ -589,7 +594,7 @@ destroynotify(XEvent *e) { Client *c; XDestroyWindowEvent *ev = &e->xdestroywindow; - if((c = getclient(ev->window))) + if((c = wintoclient(ev->window))) unmanage(c); } @@ -603,10 +608,15 @@ detach(Client *c) { void detachstack(Client *c) { - Client **tc; + Client **tc, *t; for(tc = &c->mon->stack; *tc && *tc != c; tc = &(*tc)->snext); *tc = c->snext; + + if(c == c->mon->sel) { + for(t = c->mon->stack; t && !ISVISIBLE(t); t = t->snext); + c->mon->sel = t; + } } void @@ -619,31 +629,38 @@ die(const char *errstr, ...) { exit(EXIT_FAILURE); } +Monitor * +dirtomon(int dir) { + Monitor *m = NULL; + + if(dir > 0) { + if(!(m = selmon->next)) + m = mons; + } + else { + if(selmon == mons) + for(m = mons; m->next; m = m->next); + else + for(m = mons; m->next != selmon; m = m->next); + } + return m; +} + void drawbar(Monitor *m) { int x; - unsigned int i, occ = 0, urg = 0; + unsigned int i, n = 0, occ = 0, urg = 0; unsigned long *col; Client *c; for(c = m->clients; c; c = c->next) { + if(ISVISIBLE(c)) + n++; occ |= c->tags; if(c->isurgent) urg |= c->tags; } - dc.x = 0; -#ifdef XINERAMA - { - char buf[2]; - buf[0] = m->screen_number + '0'; - buf[1] = '\0'; - dc.w = TEXTW(buf); - drawtext(buf, selmon == m ? dc.sel : dc.norm, True); - dc.x += dc.w; - } -#endif /* XINERAMA */ - m->btx = dc.x; for(i = 0; i < LENGTH(tags); i++) { dc.w = TEXTW(tags[i]); col = m->tagset[m->seltags] & 1 << i ? dc.sel : dc.norm; @@ -654,11 +671,13 @@ drawbar(Monitor *m) { } if(blw > 0) { dc.w = blw; - drawtext(lt[m->sellt]->symbol, dc.norm, False); - x = dc.x + dc.w; + drawtext(m->lt[m->sellt]->symbol, dc.norm, False); + dc.x += dc.w; } - else - x = dc.x; + snprintf(ntext, sizeof ntext, "%u", n); + dc.w = TEXTW(ntext); + drawtext(ntext, dc.norm, False); + x = (dc.x += dc.w); if(m == selmon) { /* status is only drawn on selected monitor */ dc.w = TEXTW(stext); dc.x = m->ww - dc.w; @@ -668,9 +687,8 @@ drawbar(Monitor *m) { } drawtext(stext, dc.norm, False); } - else { + else dc.x = m->ww; - } if((dc.w = dc.x - x) > bh) { dc.x = x; if(m->sel) { @@ -750,11 +768,11 @@ enternotify(XEvent *e) { if((ev->mode != NotifyNormal || ev->detail == NotifyInferior) && ev->window != root) return; - if((m = getmon(ev->window)) && m != selmon) { + if((m = wintomon(ev->window)) && m != selmon) { unfocus(selmon->sel); selmon = m; } - if((c = getclient(ev->window))) + if((c = wintoclient(ev->window))) focus(c); else focus(NULL); @@ -765,7 +783,7 @@ expose(XEvent *e) { Monitor *m; XExposeEvent *ev = &e->xexpose; - if(ev->count == 0 && (m = getmon(ev->window))) + if(ev->count == 0 && (m = wintomon(ev->window))) drawbar(m); } @@ -800,18 +818,17 @@ focusin(XEvent *e) { /* there are some broken focus acquiring clients */ XSetInputFocus(dpy, selmon->sel->win, RevertToPointerRoot, CurrentTime); } -#ifdef XINERAMA void focusmon(const Arg *arg) { - Monitor *m; + Monitor *m = NULL; - if(!(m = getmonn(arg->ui)) || m == selmon) + if(!mons->next) return; + m = dirtomon(arg->i); unfocus(selmon->sel); selmon = m; focus(NULL); } -#endif /* XINERAMA */ void focusstack(const Arg *arg) { @@ -839,18 +856,6 @@ focusstack(const Arg *arg) { } } -Client * -getclient(Window w) { - Client *c; - Monitor *m; - - for(m = mons; m; m = m->next) - for(c = m->clients; c; c = c->next) - if(c->win == w) - return c; - return NULL; -} - unsigned long getcolor(const char *colstr) { Colormap cmap = DefaultColormap(dpy, screen); @@ -861,46 +866,12 @@ getcolor(const char *colstr) { return color.pixel; } -Monitor * -getmon(Window w) { - int x, y; - Client *c; - Monitor *m; - - if(w == root && getrootpointer(&x, &y)) - return getmonxy(x, y); - for(m = mons; m; m = m->next) - if(w == m->barwin) - return m; - if((c = getclient(w))) - return c->mon; - return selmon; -} - -Monitor * -getmonn(unsigned int n) { - unsigned int i; - Monitor *m; - - for(m = mons, i = 0; m && i != n; m = m->next, i++); - return m; -} - -Monitor * -getmonxy(int x, int y) { - Monitor *m; - - for(m = mons; m; m = m->next) - if(INRECT(x, y, m->wx, m->wy, m->ww, m->wh)) - return m; - return selmon; -} - Bool -getrootpointer(int *x, int *y) { +getrootptr(int *x, int *y) { int di; unsigned int dui; Window dummy; + return XQueryPointer(dpy, root, &dummy, &dummy, x, y, &di, &di, &dui); } @@ -913,7 +884,7 @@ getstate(Window w) { Atom real; status = XGetWindowProperty(dpy, w, wmatom[WMState], 0L, 2L, False, wmatom[WMState], - &real, &format, &n, &extra, (unsigned char **)&p); + &real, &format, &n, &extra, (unsigned char **)&p); if(status != Success) return -1; if(n != 0) @@ -937,8 +908,7 @@ gettextprop(Window w, Atom atom, char *text, unsigned int size) { if(name.encoding == XA_STRING) strncpy(text, (char *)name.value, size - 1); else { - if(XmbTextPropertyToTextList(dpy, &name, &list, &n) >= Success - && n > 0 && *list) { + if(XmbTextPropertyToTextList(dpy, &name, &list, &n) >= Success && n > 0 && *list) { strncpy(text, *list, size - 1); XFreeStringList(list); } @@ -963,7 +933,8 @@ grabbuttons(Client *c, Bool focused) { buttons[i].mask | modifiers[j], c->win, False, BUTTONMASK, GrabModeAsync, GrabModeSync, None, None); - } else + } + else XGrabButton(dpy, AnyButton, AnyModifier, c->win, False, BUTTONMASK, GrabModeAsync, GrabModeSync, None, None); } @@ -972,7 +943,7 @@ grabbuttons(Client *c, Bool focused) { void grabkeys(void) { updatenumlockmask(); - { /* grab keys */ + { unsigned int i, j; unsigned int modifiers[] = { 0, LockMask, numlockmask, numlockmask|LockMask }; KeyCode code; @@ -1003,6 +974,7 @@ initfont(const char *fontstr) { XFontSetExtents *font_extents; XFontStruct **xfonts; char **font_names; + dc.font.ascent = dc.font.descent = 0; font_extents = XExtentsOfFontSet(dc.font.set); n = XFontsOfFontSet(dc.font.set, &xfonts, &font_names); @@ -1047,8 +1019,8 @@ keypress(XEvent *e) { keysym = XKeycodeToKeysym(dpy, (KeyCode)ev->keycode, 0); for(i = 0; i < LENGTH(keys); i++) if(keysym == keys[i].keysym - && CLEANMASK(keys[i].mod) == CLEANMASK(ev->state) - && keys[i].func) + && CLEANMASK(keys[i].mod) == CLEANMASK(ev->state) + && keys[i].func) keys[i].func(&(keys[i].arg)); } @@ -1082,31 +1054,39 @@ manage(Window w, XWindowAttributes *wa) { die("fatal: could not malloc() %u bytes\n", sizeof(Client)); *c = cz; c->win = w; - c->mon = selmon; - + updatetitle(c); + if(XGetTransientForHint(dpy, w, &trans)) + t = wintoclient(trans); + if(t) { + c->mon = t->mon; + c->tags = t->tags; + } + else { + c->mon = selmon; + applyrules(c); + } /* geometry */ - c->x = wa->x + selmon->wx; - c->y = wa->y + selmon->wy; + c->x = wa->x + c->mon->wx; + c->y = wa->y + c->mon->wy; c->w = wa->width; c->h = wa->height; c->oldbw = wa->border_width; - if(c->w == selmon->mw && c->h == selmon->mh) { - c->x = selmon->mx; - c->y = selmon->my; + if(c->w == c->mon->mw && c->h == c->mon->mh) { + c->x = c->mon->mx; + c->y = c->mon->my; c->bw = 0; } else { - if(c->x + WIDTH(c) > selmon->mx + selmon->mw) - c->x = selmon->mx + selmon->mw - WIDTH(c); - if(c->y + HEIGHT(c) > selmon->my + selmon->mh) - c->y = selmon->my + selmon->mh - HEIGHT(c); - c->x = MAX(c->x, selmon->mx); + if(c->x + WIDTH(c) > c->mon->mx + c->mon->mw) + c->x = c->mon->mx + c->mon->mw - WIDTH(c); + if(c->y + HEIGHT(c) > c->mon->my + c->mon->mh) + c->y = c->mon->my + c->mon->mh - HEIGHT(c); + c->x = MAX(c->x, c->mon->mx); /* only fix client y-offset, if the client center might cover the bar */ c->y = MAX(c->y, ((c->mon->by == 0) && (c->x + (c->w / 2) >= c->mon->wx) - && (c->x + (c->w / 2) < c->mon->wx + c->mon->ww)) ? bh : selmon->my); + && (c->x + (c->w / 2) < c->mon->wx + c->mon->ww)) ? bh : c->mon->my); c->bw = borderpx; } - wc.border_width = c->bw; XConfigureWindow(dpy, w, CWBorderWidth, &wc); XSetWindowBorder(dpy, w, dc.norm[ColBorder]); @@ -1114,13 +1094,6 @@ manage(Window w, XWindowAttributes *wa) { updatesizehints(c); XSelectInput(dpy, w, EnterWindowMask|FocusChangeMask|PropertyChangeMask|StructureNotifyMask); grabbuttons(c, False); - updatetitle(c); - if(XGetTransientForHint(dpy, w, &trans)) - t = getclient(trans); - if(t) - c->tags = t->tags; - else - applyrules(c); if(!c->isfloating) c->isfloating = trans != None || c->isfixed; if(c->isfloating) @@ -1151,7 +1124,7 @@ maprequest(XEvent *e) { return; if(wa.override_redirect) return; - if(!getclient(ev->window)) + if(!wintoclient(ev->window)) manage(ev->window, &wa); } @@ -1160,7 +1133,7 @@ monocle(Monitor *m) { Client *c; for(c = nexttiled(m->clients); c; c = nexttiled(c->next)) - resize(c, m->wx, m->wy, m->ww - 2 * c->bw, m->wh - 2 * c->bw); + resize(c, m->wx, m->wy, m->ww - 2 * c->bw, m->wh - 2 * c->bw, False); } void @@ -1178,7 +1151,7 @@ movemouse(const Arg *arg) { if(XGrabPointer(dpy, root, False, MOUSEMASK, GrabModeAsync, GrabModeAsync, None, cursor[CurMove], CurrentTime) != GrabSuccess) return; - if(!getrootpointer(&x, &y)) + if(!getrootptr(&x, &y)) return; do { XMaskEvent(dpy, MOUSEMASK|ExposureMask|SubstructureRedirectMask, &ev); @@ -1192,7 +1165,7 @@ movemouse(const Arg *arg) { nx = ocx + (ev.xmotion.x - x); ny = ocy + (ev.xmotion.y - y); if(snap && nx >= selmon->wx && nx <= selmon->wx + selmon->ww - && ny >= selmon->wy && ny <= selmon->wy + selmon->wh) { + && ny >= selmon->wy && ny <= selmon->wy + selmon->wh) { if(abs(selmon->wx - nx) < snap) nx = selmon->wx; else if(abs((selmon->wx + selmon->ww) - (nx + WIDTH(c))) < snap) @@ -1201,18 +1174,17 @@ movemouse(const Arg *arg) { ny = selmon->wy; else if(abs((selmon->wy + selmon->wh) - (ny + HEIGHT(c))) < snap) ny = selmon->wy + selmon->wh - HEIGHT(c); - if(!c->isfloating && lt[selmon->sellt]->arrange - && (abs(nx - c->x) > snap || abs(ny - c->y) > snap)) + if(!c->isfloating && selmon->lt[selmon->sellt]->arrange + && (abs(nx - c->x) > snap || abs(ny - c->y) > snap)) togglefloating(NULL); } - if(!lt[selmon->sellt]->arrange || c->isfloating) - resize(c, nx, ny, c->w, c->h); + if(!selmon->lt[selmon->sellt]->arrange || c->isfloating) + resize(c, nx, ny, c->w, c->h, True); break; } - } - while(ev.type != ButtonRelease); + } while(ev.type != ButtonRelease); XUngrabPointer(dpy, CurrentTime); - if((m = getmonxy(c->x + c->w / 2, c->y + c->h / 2)) != selmon) { + if((m = ptrtomon(c->x + c->w / 2, c->y + c->h / 2)) != selmon) { sendmon(c, m); selmon = m; focus(NULL); @@ -1225,6 +1197,16 @@ nexttiled(Client *c) { return c; } +Monitor * +ptrtomon(int x, int y) { + Monitor *m; + + for(m = mons; m; m = m->next) + if(INRECT(x, y, m->wx, m->wy, m->ww, m->wh)) + return m; + return selmon; +} + void propertynotify(XEvent *e) { Client *c; @@ -1235,12 +1217,12 @@ propertynotify(XEvent *e) { updatestatus(); else if(ev->state == PropertyDelete) return; /* ignore */ - else if((c = getclient(ev->window))) { + else if((c = wintoclient(ev->window))) { switch (ev->atom) { default: break; case XA_WM_TRANSIENT_FOR: XGetTransientForHint(dpy, c->win, &trans); - if(!c->isfloating && (c->isfloating = (getclient(trans) != NULL))) + if(!c->isfloating && (c->isfloating = (wintoclient(trans) != NULL))) arrange(); break; case XA_WM_NORMAL_HINTS: @@ -1265,10 +1247,10 @@ quit(const Arg *arg) { } void -resize(Client *c, int x, int y, int w, int h) { +resize(Client *c, int x, int y, int w, int h, Bool interact) { XWindowChanges wc; - if(applysizehints(c, &x, &y, &w, &h)) { + if(applysizehints(c, &x, &y, &w, &h, interact)) { c->x = wc.x = x; c->y = wc.y = y; c->w = wc.width = w; @@ -1294,7 +1276,7 @@ resizemouse(const Arg *arg) { ocx = c->x; ocy = c->y; if(XGrabPointer(dpy, root, False, MOUSEMASK, GrabModeAsync, GrabModeAsync, - None, cursor[CurResize], CurrentTime) != GrabSuccess) + None, cursor[CurResize], CurrentTime) != GrabSuccess) return; XWarpPointer(dpy, None, c->win, 0, 0, 0, 0, c->w + c->bw - 1, c->h + c->bw - 1); do { @@ -1308,23 +1290,22 @@ resizemouse(const Arg *arg) { case MotionNotify: nw = MAX(ev.xmotion.x - ocx - 2 * c->bw + 1, 1); nh = MAX(ev.xmotion.y - ocy - 2 * c->bw + 1, 1); - if(snap && nw >= selmon->wx && nw <= selmon->wx + selmon->ww - && nh >= selmon->wy && nh <= selmon->wy + selmon->wh) { - if(!c->isfloating && lt[selmon->sellt]->arrange - && (abs(nw - c->w) > snap || abs(nh - c->h) > snap)) + && nh >= selmon->wy && nh <= selmon->wy + selmon->wh) + { + if(!c->isfloating && selmon->lt[selmon->sellt]->arrange + && (abs(nw - c->w) > snap || abs(nh - c->h) > snap)) togglefloating(NULL); } - if(!lt[selmon->sellt]->arrange || c->isfloating) - resize(c, c->x, c->y, nw, nh); + if(!selmon->lt[selmon->sellt]->arrange || c->isfloating) + resize(c, c->x, c->y, nw, nh, True); break; } - } - while(ev.type != ButtonRelease); + } while(ev.type != ButtonRelease); XWarpPointer(dpy, None, c->win, 0, 0, 0, 0, c->w + c->bw - 1, c->h + c->bw - 1); XUngrabPointer(dpy, CurrentTime); while(XCheckMaskEvent(dpy, EnterWindowMask, &ev)); - if((m = getmonxy(c->x + c->w / 2, c->y + c->h / 2)) != selmon) { + if((m = ptrtomon(c->x + c->w / 2, c->y + c->h / 2)) != selmon) { sendmon(c, m); selmon = m; focus(NULL); @@ -1340,9 +1321,9 @@ restack(Monitor *m) { drawbars(); if(!m->sel) return; - if(m->sel->isfloating || !lt[m->sellt]->arrange) + if(m->sel->isfloating || !m->lt[m->sellt]->arrange) XRaiseWindow(dpy, m->sel->win); - if(lt[m->sellt]->arrange) { + if(m->lt[m->sellt]->arrange) { wc.stack_mode = Below; wc.sibling = m->barwin; for(c = m->stack; c; c = c->snext) @@ -1361,10 +1342,9 @@ run(void) { /* main event loop */ XSync(dpy, False); - while(running && !XNextEvent(dpy, &ev)) { + while(running && !XNextEvent(dpy, &ev)) if(handler[ev.type]) - (handler[ev.type])(&ev); /* call handler */ - } + handler[ev.type](&ev); /* call handler */ } void @@ -1397,6 +1377,7 @@ void sendmon(Client *c, Monitor *m) { if(c->mon == m) return; + unfocus(c); detach(c); detachstack(c); c->mon = m; @@ -1409,7 +1390,7 @@ sendmon(Client *c, Monitor *m) { void setclientstate(Client *c, long state) { - long data[] = {state, None}; + long data[] = { state, None }; XChangeProperty(dpy, c->win, wmatom[WMState], wmatom[WMState], 32, PropModeReplace, (unsigned char *)data, 2); @@ -1417,10 +1398,10 @@ setclientstate(Client *c, long state) { void setlayout(const Arg *arg) { - if(!arg || !arg->v || arg->v != lt[selmon->sellt]) + if(!arg || !arg->v || arg->v != selmon->lt[selmon->sellt]) selmon->sellt ^= 1; if(arg && arg->v) - lt[selmon->sellt] = (Layout *)arg->v; + selmon->lt[selmon->sellt] = (Layout *)arg->v; if(selmon->sel) arrange(); else @@ -1432,7 +1413,7 @@ void setmfact(const Arg *arg) { float f; - if(!arg || !lt[selmon->sellt]->arrange) + if(!arg || !selmon->lt[selmon->sellt]->arrange) return; f = arg->f < 1.0 ? arg->f + selmon->mfact : arg->f - 1.0; if(f < 0.1 || f > 0.9) @@ -1447,31 +1428,27 @@ setup(void) { int w; XSetWindowAttributes wa; + /* clean up any zombies immediately */ + sigchld(0); + /* init screen */ screen = DefaultScreen(dpy); root = RootWindow(dpy, screen); initfont(font); - sx = 0; - sy = 0; sw = DisplayWidth(dpy, screen); sh = DisplayHeight(dpy, screen); bh = dc.h = dc.font.height + 2; - lt[0] = &layouts[0]; - lt[1] = &layouts[1 % LENGTH(layouts)]; updategeom(); - /* init atoms */ wmatom[WMProtocols] = XInternAtom(dpy, "WM_PROTOCOLS", False); wmatom[WMDelete] = XInternAtom(dpy, "WM_DELETE_WINDOW", False); wmatom[WMState] = XInternAtom(dpy, "WM_STATE", False); netatom[NetSupported] = XInternAtom(dpy, "_NET_SUPPORTED", False); netatom[NetWMName] = XInternAtom(dpy, "_NET_WM_NAME", False); - /* init cursors */ cursor[CurNormal] = XCreateFontCursor(dpy, XC_left_ptr); cursor[CurResize] = XCreateFontCursor(dpy, XC_sizing); cursor[CurMove] = XCreateFontCursor(dpy, XC_fleur); - /* init appearance */ dc.norm[ColBorder] = getcolor(normbordercolor); dc.norm[ColBG] = getcolor(normbgcolor); @@ -1484,7 +1461,6 @@ setup(void) { XSetLineAttributes(dpy, dc.gc, 1, LineSolid, CapButt, JoinMiter); if(!dc.font.set) XSetFont(dpy, dc.gc, dc.font.xfont->fid); - /* init bars */ for(blw = i = 0; LENGTH(layouts) > 1 && i < LENGTH(layouts); i++) { w = TEXTW(layouts[i].symbol); @@ -1492,19 +1468,16 @@ setup(void) { } updatebars(); updatestatus(); - /* EWMH support per view */ XChangeProperty(dpy, root, netatom[NetSupported], XA_ATOM, 32, PropModeReplace, (unsigned char *) netatom, NetLast); - /* select for events */ wa.cursor = cursor[CurNormal]; wa.event_mask = SubstructureRedirectMask|SubstructureNotifyMask|ButtonPressMask - |EnterWindowMask|LeaveWindowMask|StructureNotifyMask - |PropertyChangeMask; + |EnterWindowMask|LeaveWindowMask|StructureNotifyMask + |PropertyChangeMask; XChangeWindowAttributes(dpy, root, CWEventMask|CWCursor, &wa); XSelectInput(dpy, root, wa.event_mask); - grabkeys(); } @@ -1514,8 +1487,8 @@ showhide(Client *c) { return; if(ISVISIBLE(c)) { /* show clients top down */ XMoveWindow(dpy, c->win, c->x, c->y); - if(!lt[c->mon->sellt]->arrange || c->isfloating) - resize(c, c->x, c->y, c->w, c->h); + if(!c->mon->lt[c->mon->sellt]->arrange || c->isfloating) + resize(c, c->x, c->y, c->w, c->h, False); showhide(c->snext); } else { /* hide clients bottom up */ @@ -1526,13 +1499,14 @@ showhide(Client *c) { void -sigchld(int signal) { +sigchld(int unused) { + if(signal(SIGCHLD, sigchld) == SIG_ERR) + die("Can't install SIGCHLD handler"); while(0 < waitpid(-1, NULL, WNOHANG)); } void spawn(const Arg *arg) { - signal(SIGCHLD, sigchld); if(fork() == 0) { if(dpy) close(ConnectionNumber(dpy)); @@ -1552,16 +1526,12 @@ tag(const Arg *arg) { } } -#ifdef XINERAMA void tagmon(const Arg *arg) { - Monitor *m; - - if(!selmon->sel || !(m = getmonn(arg->ui))) + if(!selmon->sel || !mons->next) return; - sendmon(selmon->sel, m); + sendmon(selmon->sel, dirtomon(arg->i)); } -#endif /* XINERAMA */ int textnw(const char *text, unsigned int len) { @@ -1583,15 +1553,12 @@ tile(Monitor *m) { for(n = 0, c = nexttiled(m->clients); c; c = nexttiled(c->next), n++); if(n == 0) return; - /* master */ c = nexttiled(m->clients); mw = m->mfact * m->ww; - resize(c, m->wx, m->wy, (n == 1 ? m->ww : mw) - 2 * c->bw, m->wh - 2 * c->bw); - + resize(c, m->wx, m->wy, (n == 1 ? m->ww : mw) - 2 * c->bw, m->wh - 2 * c->bw, False); if(--n == 0) return; - /* tile stack */ x = (m->wx + mw > c->x + c->w) ? c->x + c->w + 2 * c->bw : m->wx + mw; y = m->wy; @@ -1599,10 +1566,9 @@ tile(Monitor *m) { h = m->wh / n; if(h < bh) h = m->wh; - for(i = 0, c = nexttiled(c->next); c; c = nexttiled(c->next), i++) { resize(c, x, y, w - 2 * c->bw, /* remainder */ ((i + 1 == n) - ? m->wy + m->wh - y - 2 * c->bw : h - 2 * c->bw)); + ? m->wy + m->wh - y - 2 * c->bw : h - 2 * c->bw), False); if(h != m->wh) y = c->y + HEIGHT(c); } @@ -1622,7 +1588,8 @@ togglefloating(const Arg *arg) { return; selmon->sel->isfloating = !selmon->sel->isfloating || selmon->sel->isfixed; if(selmon->sel->isfloating) - resize(selmon->sel, selmon->sel->x, selmon->sel->y, selmon->sel->w, selmon->sel->h); + resize(selmon->sel, selmon->sel->x, selmon->sel->y, + selmon->sel->w, selmon->sel->h, False); arrange(); } @@ -1632,7 +1599,6 @@ toggletag(const Arg *arg) { if(!selmon->sel) return; - mask = selmon->sel->tags ^ (arg->ui & TAGMASK); if(mask) { selmon->sel->tags = mask; @@ -1670,19 +1636,13 @@ unmanage(Client *c) { XConfigureWindow(dpy, c->win, CWBorderWidth, &wc); /* restore border */ detach(c); detachstack(c); - if(c->mon->sel == c) { - /* TODO: consider separate the next code into a function or into detachstack? */ - Client *tc; - for(tc = c->mon->stack; tc && !ISVISIBLE(tc); tc = tc->snext); - c->mon->sel = tc; - focus(NULL); - } XUngrabButton(dpy, AnyButton, AnyModifier, c->win); setclientstate(c, WithdrawnState); free(c); XSync(dpy, False); XSetErrorHandler(xerror); XUngrabServer(dpy); + focus(NULL); arrange(); } @@ -1691,7 +1651,7 @@ unmapnotify(XEvent *e) { Client *c; XUnmapEvent *ev = &e->xunmap; - if((c = getclient(ev->window))) + if((c = wintoclient(ev->window))) unmanage(c); } @@ -1703,10 +1663,8 @@ updatebars(void) { wa.override_redirect = True; wa.background_pixmap = ParentRelative; wa.event_mask = ButtonPressMask|ExposureMask; - for(m = mons; m; m = m->next) { m->barwin = XCreateWindow(dpy, root, m->wx, m->by, m->ww, bh, 0, DefaultDepth(dpy, screen), - CopyFromParent, DefaultVisual(dpy, screen), CWOverrideRedirect|CWBackPixmap|CWEventMask, &wa); XDefineCursor(dpy, m->barwin, cursor[CurNormal]); @@ -1731,44 +1689,32 @@ void updategeom(void) { int i, n = 1; Client *c; - Monitor *newmons = NULL, *m, *tm; + Monitor *newmons = NULL, *m = NULL, *tm; -#ifdef XINULATOR - n = 2; -#elif defined(XINERAMA) +#ifdef XINERAMA + int nn; XineramaScreenInfo *info = NULL; if(XineramaIsActive(dpy)) info = XineramaQueryScreens(dpy, &n); -#endif + for(i = 1, nn = n; i < n; i++) + if(info[i - 1].x_org == info[i].x_org && info[i - 1].y_org == info[i].y_org + && info[i - 1].width == info[i].width && info[i - 1].height == info[i].height) + --nn; + n = nn; /* we only consider unique geometries as separate screens */ +#endif /* XINERAMA */ /* allocate monitor(s) for the new geometry setup */ for(i = 0; i < n; i++) { - m = (Monitor *)malloc(sizeof(Monitor)); + if(!(m = (Monitor *)malloc(sizeof(Monitor)))) + die("fatal: could not malloc() %u bytes\n", sizeof(Monitor)); m->next = newmons; newmons = m; } - /* initialise monitor(s) */ -#ifdef XINULATOR - if(1) { - m = newmons; - m->screen_number = 0; - m->wx = sx; - m->my = m->wy = sy; - m->ww = sw; - m->mh = m->wh = sh / 2; - m = newmons->next; - m->screen_number = 1; - m->wx = sx; - m->my = m->wy = sy + sh / 2; - m->ww = sw; - m->mh = m->wh = sh / 2; - } - else -#elif defined(XINERAMA) +#ifdef XINERAMA if(XineramaIsActive(dpy)) { for(i = 0, m = newmons; m; m = m->next, i++) { - m->screen_number = info[i].screen_number; + m->num = info[i].screen_number; m->mx = m->wx = info[i].x_org; m->my = m->wy = info[i].y_org; m->mw = m->ww = info[i].width; @@ -1777,31 +1723,28 @@ updategeom(void) { XFree(info); } else -#endif +#endif /* XINERAMA */ /* default monitor setup */ { - m->screen_number = 0; - m->wx = sx; - m->my = m->wy = sy; - m->ww = sw; + m->num = 0; + m->mx = m->wx = 0; + m->my = m->wy = 0; + m->mw = m->ww = sw; m->mh = m->wh = sh; } - /* bar geometry setup */ for(m = newmons; m; m = m->next) { - /* TODO: consider removing the following values from config.h */ - m->clients = NULL; - m->sel = NULL; - m->stack = NULL; + m->sel = m->stack = m->clients = NULL; m->seltags = 0; m->sellt = 0; m->tagset[0] = m->tagset[1] = 1; m->mfact = mfact; m->showbar = showbar; m->topbar = topbar; + m->lt[0] = &layouts[0]; + m->lt[1] = &layouts[1 % LENGTH(layouts)]; updatebarpos(m); } - /* reassign left over clients of disappeared monitors */ for(tm = mons; tm; tm = tm->next) while(tm->clients) { @@ -1812,11 +1755,10 @@ updategeom(void) { attach(c); attachstack(c); } - /* select focused monitor */ cleanupmons(); - mons = newmons; - selmon = getmon(root); + selmon = mons = newmons; + selmon = wintomon(root); } void @@ -1875,8 +1817,8 @@ updatesizehints(Client *c) { else c->minw = c->minh = 0; if(size.flags & PAspect) { - c->mina = (float)size.min_aspect.y / (float)size.min_aspect.x; - c->maxa = (float)size.max_aspect.x / (float)size.max_aspect.y; + c->mina = (float)size.min_aspect.y / size.min_aspect.x; + c->maxa = (float)size.max_aspect.x / size.max_aspect.y; } else c->maxa = c->mina = 0.0; @@ -1888,6 +1830,8 @@ void updatetitle(Client *c) { if(!gettextprop(c->win, netatom[NetWMName], c->name, sizeof c->name)) gettextprop(c->win, XA_WM_NAME, c->name, sizeof c->name); + if(c->name[0] == '\0') /* hack to mark broken clients */ + strcpy(c->name, broken); } void @@ -1908,7 +1852,6 @@ updatewmhints(Client *c) { } else c->isurgent = (wmh->flags & XUrgencyHint) ? True : False; - XFree(wmh); } } @@ -1923,6 +1866,34 @@ view(const Arg *arg) { arrange(); } +Client * +wintoclient(Window w) { + Client *c; + Monitor *m; + + for(m = mons; m; m = m->next) + for(c = m->clients; c; c = c->next) + if(c->win == w) + return c; + return NULL; +} + +Monitor * +wintomon(Window w) { + int x, y; + Client *c; + Monitor *m; + + if(w == root && getrootptr(&x, &y)) + return ptrtomon(x, y); + for(m = mons; m; m = m->next) + if(w == m->barwin) + return m; + if((c = wintoclient(w))) + return c->mon; + return selmon; +} + /* There's no way to check accesses to destroyed windows, thus those cases are * ignored (especially on UnmapNotify's). Other types of errors call Xlibs * default error handler, which may call exit. */ @@ -1960,7 +1931,9 @@ void zoom(const Arg *arg) { Client *c = selmon->sel; - if(!lt[selmon->sellt]->arrange || lt[selmon->sellt]->arrange == monocle || (selmon->sel && selmon->sel->isfloating)) + if(!selmon->lt[selmon->sellt]->arrange + || selmon->lt[selmon->sellt]->arrange == monocle + || (selmon->sel && selmon->sel->isfloating)) return; if(c == nexttiled(selmon->clients)) if(!c || !(c = nexttiled(c->next))) @@ -1977,19 +1950,15 @@ main(int argc, char *argv[]) { die("dwm-"VERSION", © 2006-2009 dwm engineers, see LICENSE for details\n"); else if(argc != 1) die("usage: dwm [-v]\n"); - if(!setlocale(LC_CTYPE, "") || !XSupportsLocale()) fputs("warning: no locale support\n", stderr); - if(!(dpy = XOpenDisplay(NULL))) die("dwm: cannot open display\n"); - checkotherwm(); setup(); scan(); run(); cleanup(); - XCloseDisplay(dpy); return 0; }