JasonWoof Got questions, comments, patches, etc.? Contact Jason Woofenden
added F1-12 key, fixed DCH and ICH.
[st.git] / st.c
diff --git a/st.c b/st.c
index c360900..6e34f1e 100644 (file)
--- a/st.c
+++ b/st.c
@@ -20,8 +20,6 @@
 #include <X11/keysym.h>
 #include <X11/Xutil.h>
 
-#define TNAME "xterm"
-
 /* Arbitrary sizes */
 #define ESC_TITLE_SIZ 256
 #define ESC_BUF_SIZ   256
@@ -39,7 +37,8 @@
 
 /* Attribute, Cursor, Character state, Terminal mode, Screen draw mode */
 enum { ATTR_NULL=0 , ATTR_REVERSE=1 , ATTR_UNDERLINE=2, ATTR_BOLD=4, ATTR_GFX=8 };
-enum { CURSOR_UP, CURSOR_DOWN, CURSOR_LEFT, CURSOR_RIGHT, CURSOR_HIDE, CURSOR_DRAW, CURSOR_SAVE, CURSOR_LOAD };
+enum { CURSOR_UP, CURSOR_DOWN, CURSOR_LEFT, CURSOR_RIGHT, CURSOR_HIDE, CURSOR_DRAW, 
+       CURSOR_SAVE, CURSOR_LOAD };
 enum { GLYPH_SET=1, GLYPH_DIRTY=2 };
 enum { MODE_WRAP=1, MODE_INSERT=2, MODE_APPKEYPAD=4 };
 enum { ESC_START=1, ESC_CSI=2, ESC_OSC=4, ESC_TITLE=8, ESC_ALTCHARSET=16 };
@@ -56,8 +55,7 @@ typedef struct {
 typedef Glyph* Line;
 
 typedef struct {
-       Glyph attr;  /* current char attributes */
-       char hidden;
+       Glyph attr;      /* current char attributes */
        int x;
        int y;
 } TCursor;
@@ -66,23 +64,24 @@ typedef struct {
 /* ESC '[' [[ [<priv>] <arg> [;]] <mode>] */
 typedef struct {
        char buf[ESC_BUF_SIZ]; /* raw string */
-       int len;               /* raw string length */
+       int len;                           /* raw string length */
        char priv;
        int arg[ESC_ARG_SIZ];
-       int narg;              /* nb of args */
+       int narg;                          /* nb of args */
        char mode;
 } CSIEscape;
 
 /* Internal representation of the screen */
 typedef struct {
-       int row;    /* nb row */  
-       int col;    /* nb col */
+       int row;        /* nb row */  
+       int col;        /* nb col */
        Line* line; /* screen */
-       TCursor c;  /* cursor */
-       int top;    /* top    scroll limit */
-       int bot;    /* bottom scroll limit */
-       int mode;   /* terminal mode flags */
-       int esc;    /* escape state flags */
+       TCursor c;      /* cursor */
+       char hidec;
+       int top;        /* top    scroll limit */
+       int bot;        /* bottom scroll limit */
+       int mode;       /* terminal mode flags */
+       int esc;        /* escape state flags */
        char title[ESC_TITLE_SIZ];
        int titlelen;
 } Term;
@@ -91,9 +90,12 @@ typedef struct {
 typedef struct {
        Display* dis;
        Window win;
+       Pixmap buf;
        int scr;
-       int w;  /* window width  */
-       int h;  /* window height */
+       int w;  /* window width  */
+       int h;  /* window height */
+       int bufw; /* pixmap width  */
+       int bufh; /* pixmap height */
        int ch; /* char height */
        int cw; /* char width  */
 } XWindow; 
@@ -103,15 +105,16 @@ typedef struct {
        char s[ESC_BUF_SIZ];
 } Key;
 
-#include "config.h"
-
 /* Drawing Context */
 typedef struct {
-       unsigned long col[LEN(colorname)];
+       unsigned long col[256];
        XFontStruct* font;
+       XFontStruct* bfont;
        GC gc;
 } DC;
 
+#include "config.h"
+
 static void die(const char *errstr, ...);
 static void draw(int);
 static void execsh(void);
@@ -135,8 +138,11 @@ static void tnew(int, int);
 static void tnewline(void);
 static void tputc(char);
 static void tputs(char*, int);
+static void treset(void);
 static void tresize(int, int);
 static void tscroll(void);
+static void tscrollup(int);
+static void tscrolldown(int);
 static void tsetattr(int*, int);
 static void tsetchar(char);
 static void tsetscroll(int, int);
@@ -146,15 +152,13 @@ static void ttyread(void);
 static void ttyresize(int, int);
 static void ttywrite(const char *, size_t);
 
-static unsigned long xgetcol(const char *);
 static void xclear(int, int, int, int);
 static void xcursor(int);
-static void xdrawc(int, int, Glyph);
 static void xinit(void);
-static void xscroll(void);
+static void xloadcols(void);
 
 static void expose(XEvent *);
-static char * kmap(KeySym);
+static char* kmap(KeySym);
 static void kpress(XEvent *);
 static void resize(XEvent *);
 
@@ -205,14 +209,15 @@ die(const char *errstr, ...) {
 
 void
 execsh(void) {
-       char *args[3] = {SHELL, "-i", NULL};
+       char *args[3] = {getenv("SHELL"), "-i", NULL};
+       DEFAULT(args[0], "/bin/sh"); /* default shell if getenv() failed */
        putenv("TERM=" TNAME);
-       execvp(SHELL, args);
+       execvp(args[0], args);
 }
 
 void
 xbell(void) { /* visual bell */
-       XRectangle r = { 0, 0, xw.w, xw.h };
+       XRectangle r = { BORDER, BORDER, xw.bufw, xw.bufh };
        XSetForeground(xw.dis, dc.gc, dc.col[BellCol]);
        XFillRectangles(xw.dis, xw.win, dc.gc, &r, 1);
        /* usleep(30000); */
@@ -313,6 +318,18 @@ tcursor(int mode) {
 }
 
 void
+treset(void) {
+       term.c.attr.mode = ATTR_NULL;
+       term.c.attr.fg = DefaultFG;
+       term.c.attr.bg = DefaultBG;
+       term.c.x = term.c.y = 0;
+       term.hidec = 0;
+       term.top = 0, term.bot = term.row - 1;
+       term.mode = MODE_WRAP;
+       tclearregion(0, 0, term.col-1, term.row-1);
+}
+
+void
 tnew(int col, int row) {   /* screen size */
        term.row = row, term.col = col;
        term.top = 0, term.bot = term.row - 1;
@@ -323,19 +340,19 @@ tnew(int col, int row) {   /* screen size */
        term.c.attr.fg = DefaultFG;
        term.c.attr.bg = DefaultBG;
        term.c.x = term.c.y = 0;
-       term.c.hidden = 0;
+       term.hidec = 0;
        /* allocate screen */
        term.line = calloc(term.row, sizeof(Line));
        for(row = 0 ; row < term.row; row++)
                term.line[row] = calloc(term.col, sizeof(Glyph));
 }
 
+/* TODO: Replace with scrollup/scolldown */
 void
 tscroll(void) {
        Line temp = term.line[term.top];
        int i;
-       /* X stuff _before_ the line swapping (results in wrong line index) */
-       xscroll();
+
        for(i = term.top; i < term.bot; i++)
                term.line[i] = term.line[i+1];
        memset(temp, 0, sizeof(Glyph) * term.col);
@@ -343,6 +360,39 @@ tscroll(void) {
 }
 
 void
+tscrolldown (int n) {
+       int i;
+       Line temp;
+       
+       LIMIT(n, 0, term.bot-term.top+1);
+
+       for(i = 0; i < n; i++)
+               memset(term.line[term.bot-i], 0, term.col*sizeof(Glyph));
+       
+       for(i = term.bot; i >= term.top+n; i--) {
+               temp = term.line[i];
+               term.line[i] = term.line[i-n];
+               term.line[i-n] = temp;
+       }
+}
+
+void
+tscrollup (int n) {
+       int i;
+       Line temp;
+       LIMIT(n, 0, term.bot-term.top+1);
+       
+       for(i = 0; i < n; i++)
+               memset(term.line[term.top+i], 0, term.col*sizeof(Glyph));
+       
+        for(i = term.top; i <= term.bot-n; i++) { 
+                temp = term.line[i];
+                term.line[i] = term.line[i+n]; 
+                term.line[i+n] = temp;
+        }
+}
+
+void
 tnewline(void) {
        int y = term.c.y + 1;
        if(y > term.bot)
@@ -415,24 +465,25 @@ void
 tsetchar(char c) {
        term.line[term.c.y][term.c.x] = term.c.attr;
        term.line[term.c.y][term.c.x].c = c;
-       term.line[term.c.y][term.c.x].state |= GLYPH_SET | GLYPH_DIRTY;
+       term.line[term.c.y][term.c.x].state |= GLYPH_SET;
 }
 
 void
 tclearregion(int x1, int y1, int x2, int y2) {
-       int x, y;
+       int y, temp;
+
+       if(x1 > x2)
+               temp = x1, x1 = x2, x2 = temp;
+       if(y1 > y2)
+               temp = y1, y1 = y2, y2 = temp;
 
        LIMIT(x1, 0, term.col-1);
        LIMIT(x2, 0, term.col-1);
        LIMIT(y1, 0, term.row-1);
        LIMIT(y2, 0, term.row-1);
 
-       /* XXX: could be optimized */
-       for(x = x1; x <= x2; x++)
-               for(y = y1; y <= y2; y++)
-                       memset(&term.line[y][x], 0, sizeof(Glyph));
-
-       xclear(x1, y1, x2, y2);
+       for(y = y1; y <= y2; y++)
+               memset(&term.line[y][x1], 0, sizeof(Glyph)*(x2-x1+1));
 }
 
 void
@@ -446,28 +497,21 @@ tdeletechar(int n) {
                return;
        }
        memmove(&term.line[term.c.y][dst], &term.line[term.c.y][src], size * sizeof(Glyph));
-       tclearregion(term.col-size, term.c.y, term.col-1, term.c.y);
+       tclearregion(term.col-n, term.c.y, term.col-1, term.c.y);
 }
 
 void
 tinsertblank(int n) {
        int src = term.c.x;
        int dst = src + n;
-       int size = term.col - n - src;
+       int size = term.col - dst;
 
        if(dst >= term.col) {
                tclearregion(term.c.x, term.c.y, term.col-1, term.c.y);
                return;
        }
        memmove(&term.line[term.c.y][dst], &term.line[term.c.y][src], size * sizeof(Glyph));
-       tclearregion(src, term.c.y, dst, term.c.y);
-}
-
-void
-tsetlinestate(int n, int state) {
-       int i;
-       for(i = 0; i < term.col; i++)
-               term.line[n][i].state |= state;
+       tclearregion(src, term.c.y, dst - 1, term.c.y);
 }
 
 void
@@ -491,8 +535,6 @@ tinsertblankline(int n) {
                term.line[i-n] = blank;
                /* blank it */
                memset(blank, 0, term.col * sizeof(Glyph));
-               tsetlinestate(i, GLYPH_DIRTY);
-               tsetlinestate(i-n, GLYPH_DIRTY);
        }
 }
 
@@ -517,8 +559,6 @@ tdeleteline(int n) {
                term.line[i+n] = blank;
                /* blank it */
                memset(blank, 0, term.col * sizeof(Glyph));
-               tsetlinestate(i, GLYPH_DIRTY);
-               tsetlinestate(i-n, GLYPH_DIRTY);
        }
 }
 
@@ -542,11 +582,8 @@ tsetattr(int *attr, int l) {
                case 7: 
                        term.c.attr.mode |= ATTR_REVERSE;       
                        break;
-               case 8:
-                       term.c.hidden = CURSOR_HIDE;
-                       break;
                case 22: 
-                       term.c.attr.mode &= ~ATTR_BOLD;  
+                       term.c.attr.mode &= ~ATTR_BOLD;  
                        break;
                case 24: 
                        term.c.attr.mode &= ~ATTR_UNDERLINE;
@@ -554,17 +591,45 @@ tsetattr(int *attr, int l) {
                case 27: 
                        term.c.attr.mode &= ~ATTR_REVERSE;       
                        break;
+               case 38:
+                       if (i + 2 < l && attr[i + 1] == 5) {
+                               i += 2;
+                               if (BETWEEN(attr[i], 0, 255))
+                                       term.c.attr.fg = attr[i];
+                               else
+                                       fprintf(stderr, "erresc: bad fgcolor %d\n", attr[i]);
+                       }
+                       else
+                               fprintf(stderr, "erresc: gfx attr %d unknown\n", attr[i]); 
+                       break;
                case 39:
                        term.c.attr.fg = DefaultFG;
                        break;
+               case 48:
+                       if (i + 2 < l && attr[i + 1] == 5) {
+                               i += 2;
+                               if (BETWEEN(attr[i], 0, 255))
+                                       term.c.attr.bg = attr[i];
+                               else
+                                       fprintf(stderr, "erresc: bad bgcolor %d\n", attr[i]);
+                       }
+                       else
+                               fprintf(stderr, "erresc: gfx attr %d unknown\n", attr[i]); 
+                       break;
                case 49:
-                       term.c.attr.fg = DefaultBG;
+                       term.c.attr.bg = DefaultBG;
                        break;
                default:
                        if(BETWEEN(attr[i], 30, 37))
                                term.c.attr.fg = attr[i] - 30;
                        else if(BETWEEN(attr[i], 40, 47))
                                term.c.attr.bg = attr[i] - 40;
+                       else if(BETWEEN(attr[i], 90, 97))
+                               term.c.attr.fg = attr[i] - 90 + 8;
+                       else if(BETWEEN(attr[i], 100, 107))
+                               term.c.attr.fg = attr[i] - 100 + 8;
+                       else 
+                               fprintf(stderr, "erresc: gfx attr %d unknown\n", attr[i]); 
                        break;
                }
        }
@@ -590,7 +655,7 @@ csihandle(void) {
        switch(escseq.mode) {
        default:
        unknown:
-               printf("erresc: unknown sequence -- ");
+               printf("erresc: unknown csi ");
                csidump();
                /* die(""); */
                break;
@@ -627,7 +692,7 @@ csihandle(void) {
        case 'G': /* CHA -- Move to <col> */
        case '`': /* XXX: HPA -- same? */
                DEFAULT(escseq.arg[0], 1);
-       tmoveto(escseq.arg[0]-1, term.c.y);
+               tmoveto(escseq.arg[0]-1, term.c.y);
                break;
        case 'H': /* CUP -- Move to <row> <col> */
        case 'f': /* XXX: HVP -- same? */
@@ -665,7 +730,14 @@ csihandle(void) {
                        break;
                }
                break;
-       case 'S': /* XXX: SU -- Scroll <n> line up (faked) */ 
+       case 'S': /* SU -- Scroll <n> line up */
+               DEFAULT(escseq.arg[0], 1);
+               tscrollup(escseq.arg[0]);
+               break;
+       case 'T': /* SD -- Scroll <n> line down */
+               DEFAULT(escseq.arg[0], 1);
+               tscrolldown(escseq.arg[0]);
+               break;
        case 'L': /* IL -- Insert <n> blank lines */
                DEFAULT(escseq.arg[0], 1);
                tinsertblankline(escseq.arg[0]);
@@ -682,7 +754,7 @@ csihandle(void) {
                        case 12: /* att610 -- Stop blinking cursor (IGNORED) */
                                break;
                        case 25:
-                               term.c.hidden = 1;
+                               term.hidec = 1;
                                break;
                        case 1048: /* XXX: no alt. screen to erase/save */
                        case 1049:
@@ -731,7 +803,7 @@ csihandle(void) {
                        case 12: /* att610 -- Start blinking cursor (IGNORED) */
                                break;
                        case 25:
-                               term.c.hidden = 0;
+                               term.hidec = 0;
                                break;
                        case 1048: 
                        case 1049: /* XXX: no alt. screen to erase/save */
@@ -800,7 +872,6 @@ tputtab(void) {
 
 void
 tputc(char c) {
-       /* dump(c); */
        if(term.esc & ESC_START) {
                if(term.esc & ESC_CSI) {
                        escseq.buf[escseq.len++] = c;
@@ -833,7 +904,7 @@ tputc(char c) {
                                printf("esc unhandled charset: ESC ( %c\n", c);
                        }
                        term.esc = 0;
-               } else {                
+               } else {
                        switch(c) {
                        case '[':
                                term.esc |= ESC_CSI;
@@ -856,17 +927,25 @@ tputc(char c) {
                                tmoveto(term.c.x+1, term.c.y);
                                term.esc = 0;
                                break;
-                       case 'D':
+                       case 'D': /* XXX: CUP (VT100) or IND (VT52) ... */
                                tmoveto(term.c.x-1, term.c.y);
                                term.esc = 0;
                                break;
+                       case 'E': /* NEL -- Next line */
+                               tnewline();
+                               term.esc = 0;
+                               break;
                        case 'M': /* RI -- Reverse index */
                                if(term.c.y == term.top)
-                                       tinsertblankline(1);
+                                       tscrolldown(1);
                                else
                                        tmoveto(term.c.x, term.c.y-1);
                                term.esc = 0;
                                break;
+                       case 'c': /* RIS -- Reset to inital state */
+                               treset();
+                               term.esc = 0;
+                               break;
                        case '=': /* DECPAM */
                                term.mode |= MODE_APPKEYPAD;
                                term.esc = 0;
@@ -884,7 +963,7 @@ tputc(char c) {
                                term.esc = 0;
                                break;
                        default:
-                               fprintf(stderr, "erresc: unknown sequence ESC %02X '%c'\n", c, isprint(c)?c:'.');
+                               fprintf(stderr, "erresc: unknown sequence ESC 0x%02X '%c'\n", c, isprint(c)?c:'.');
                                term.esc = 0;
                        }
                }
@@ -918,7 +997,7 @@ tputc(char c) {
 }
 
 void
-tputs(char *s, int len) { 
+tputs(char *s, int len) {
        for(; len > 0; len--)
                tputc(*s++);
 }
@@ -954,88 +1033,107 @@ tresize(int col, int row) {
        term.col = col, term.row = row;
 }
 
-unsigned long
-xgetcol(const char *s) {
+void
+xloadcols(void) {
+       int i, r, g, b;
        XColor color;
        Colormap cmap = DefaultColormap(xw.dis, xw.scr);
+       unsigned long white = WhitePixel(xw.dis, xw.scr);
+
+       for(i = 0; i < 16; i++) {
+               if (!XAllocNamedColor(xw.dis, cmap, colorname[i], &color, &color)) {
+                       dc.col[i] = white;
+                       fprintf(stderr, "Could not allocate color '%s'\n", colorname[i]);
+               } else
+                       dc.col[i] = color.pixel;
+       }
+
+       /* same colors as xterm */
+       for(r = 0; r < 6; r++)
+               for(g = 0; g < 6; g++)
+                       for(b = 0; b < 6; b++) {
+                               color.red = r == 0 ? 0 : 0x3737 + 0x2828 * r;
+                               color.green = g == 0 ? 0 : 0x3737 + 0x2828 * g;
+                               color.blue = b == 0 ? 0 : 0x3737 + 0x2828 * b;
+                               if (!XAllocColor(xw.dis, cmap, &color)) {
+                                       dc.col[i] = white;
+                                       fprintf(stderr, "Could not allocate color %d\n", i);
+                               } else
+                                       dc.col[i] = color.pixel;
+                               i++;
+                       }
 
-       if(!XAllocNamedColor(xw.dis, cmap, s, &color, &color)) {
-               color.pixel = WhitePixel(xw.dis, xw.scr);
-               fprintf(stderr, "Could not allocate color '%s'\n", s);
+       for(r = 0; r < 24; r++, i++) {
+               color.red = color.green = color.blue = 0x0808 + 0x0a0a * r;
+               if (!XAllocColor(xw.dis, cmap, &color)) {
+                       dc.col[i] = white;
+                       fprintf(stderr, "Could not allocate color %d\n", i);
+               } else
+                       dc.col[i] = color.pixel;
        }
-       return color.pixel;
 }
 
 void
 xclear(int x1, int y1, int x2, int y2) {
-       XClearArea(xw.dis, xw.win, 
-                       x1 * xw.cw, y1 * xw.ch, 
-                       (x2-x1+1) * xw.cw, (y2-y1+1) * xw.ch, 
-                       False);
+       XSetForeground(xw.dis, dc.gc, dc.col[DefaultBG]);
+       XFillRectangle(xw.dis, xw.buf, dc.gc,
+                      x1 * xw.cw, y1 * xw.ch,
+                      (x2-x1+1) * xw.cw, (y2-y1+1) * xw.ch);
 }
 
 void
-xscroll(void) {
-       int srcy = (term.top+1) * xw.ch;
-       int dsty = term.top * xw.ch;
-       int height = (term.bot-term.top) * xw.ch;
-
-       xcursor(CURSOR_HIDE);
-       XCopyArea(xw.dis, xw.win, xw.win, dc.gc, 0, srcy, xw.w, height, 0, dsty);
-       xclear(0, term.bot, term.col-1, term.bot);
+xhints(void)
+{
+       XClassHint class = {TNAME, TNAME};
+       XWMHints wm = {.flags = InputHint, .input = 1};
+       XSizeHints size = {
+               .flags = PSize | PResizeInc | PBaseSize,
+               .height = xw.h,
+               .width = xw.w,
+               .height_inc = xw.ch,
+               .width_inc = xw.cw,
+               .base_height = 2*BORDER,
+               .base_width = 2*BORDER,
+       };
+       XSetWMProperties(xw.dis, xw.win, NULL, NULL, NULL, 0, &size, &wm, &class);
 }
 
 void
 xinit(void) {
-       XGCValues values;
-       unsigned long valuemask;
-       XClassHint chint;
-       XWMHints wmhint;
-       XSizeHints shint;
-       char *args[] = {NULL};
-       int i;
-
        xw.dis = XOpenDisplay(NULL);
        xw.scr = XDefaultScreen(xw.dis);
        if(!xw.dis)
                die("Can't open display\n");
        
        /* font */
-       if(!(dc.font = XLoadQueryFont(xw.dis, FONT)))
-               die("Can't load font %s\n", FONT);
+       if(!(dc.font = XLoadQueryFont(xw.dis, FONT)) || !(dc.bfont = XLoadQueryFont(xw.dis, BOLDFONT)))
+               die("Can't load font %s\n", dc.font ? BOLDFONT : FONT);
 
+       /* XXX: Assuming same size for bold font */
        xw.cw = dc.font->max_bounds.rbearing - dc.font->min_bounds.lbearing;
-       xw.ch = dc.font->ascent + dc.font->descent + LINESPACE;
+       xw.ch = dc.font->ascent + dc.font->descent;
 
        /* colors */
-       for(i = 0; i < LEN(colorname); i++)
-               dc.col[i] = xgetcol(colorname[i]);
+       xloadcols();
 
        term.c.attr.fg = DefaultFG;
        term.c.attr.bg = DefaultBG;
        term.c.attr.mode = ATTR_NULL;
        /* windows */
-       xw.h = term.row * xw.ch;
-       xw.w = term.col * xw.cw;
-       /* XXX: this BORDER is useless after the first resize, handle it in xdraws() */
+       xw.h = term.row * xw.ch + 2*BORDER;
+       xw.w = term.col * xw.cw + 2*BORDER;
        xw.win = XCreateSimpleWindow(xw.dis, XRootWindow(xw.dis, xw.scr), 0, 0,
-                       xw.w, xw.h, BORDER, 
+                       xw.w, xw.h, 0,
                        dc.col[DefaultBG],
                        dc.col[DefaultBG]);
+       xw.bufw = xw.w - 2*BORDER;
+       xw.bufh = xw.h - 2*BORDER;
+       xw.buf = XCreatePixmap(xw.dis, xw.win, xw.bufw, xw.bufh, XDefaultDepth(xw.dis, xw.scr));
        /* gc */
-       values.foreground = XWhitePixel(xw.dis, xw.scr);
-       values.font = dc.font->fid;
-       valuemask = GCForeground | GCFont;
-       dc.gc = XCreateGC(xw.dis, xw.win, valuemask, &values);
+       dc.gc = XCreateGC(xw.dis, xw.win, 0, NULL);
        XMapWindow(xw.dis, xw.win);
-       /* wm stuff */
-       chint.res_name = TNAME, chint.res_class = TNAME;
-       wmhint.input = 1, wmhint.flags = InputHint;
-       shint.height_inc = xw.ch, shint.width_inc = xw.cw;
-       shint.height = xw.h, shint.width = xw.w;
-       shint.flags = PSize | PResizeInc;
-       XSetWMProperties(xw.dis, xw.win, NULL, NULL, &args[0], 0, &shint, &wmhint, &chint);
-       XStoreName(xw.dis, xw.win, TNAME);
+       xhints();
+       XStoreName(xw.dis, xw.win, "st");
        XSync(xw.dis, 0);
 }
 
@@ -1055,28 +1153,13 @@ xdraws(char *s, Glyph base, int x, int y, int len) {
        
        if(base.mode & ATTR_GFX)
                for(i = 0; i < len; i++)
-                       s[i] = gfx[s[i]];
-       
-       XDrawImageString(xw.dis, xw.win, dc.gc, winx, winy, s, len);
+                       s[i] = gfx[(int)s[i]];
+
+       XSetFont(xw.dis, dc.gc, base.mode & ATTR_BOLD ? dc.bfont->fid : dc.font->fid);
+       XDrawImageString(xw.dis, xw.buf, dc.gc, winx, winy, s, len);
        
        if(base.mode & ATTR_UNDERLINE)
-               XDrawLine(xw.dis, xw.win, dc.gc, winx, winy+1, winx+width-1, winy+1);
-}
-
-void
-xdrawc(int x, int y, Glyph g) {
-       XRectangle r = { x * xw.cw, y * xw.ch, xw.cw, xw.ch };
-       unsigned long xfg, xbg;
-
-       /* reverse video */
-       if(g.mode & ATTR_REVERSE)
-               xfg = dc.col[g.bg], xbg = dc.col[g.fg];
-       else
-               xfg = dc.col[g.fg], xbg = dc.col[g.bg];
-       /* background */
-       XSetBackground(xw.dis, dc.gc, xbg);
-       XSetForeground(xw.dis, dc.gc, xfg);
-       XDrawImageString(xw.dis, xw.win, dc.gc, r.x, r.y+dc.font->ascent, &g.c, 1);
+               XDrawLine(xw.dis, xw.buf, dc.gc, winx, winy+1, winx+width-1, winy+1);
 }
 
 void
@@ -1090,24 +1173,57 @@ xcursor(int mode) {
        
        if(term.line[term.c.y][term.c.x].state & GLYPH_SET)
                g.c = term.line[term.c.y][term.c.x].c;
+       
        /* remove the old cursor */
        if(term.line[oldy][oldx].state & GLYPH_SET)
-               xdrawc(oldx, oldy, term.line[oldy][oldx]);
-       else 
+               xdraws(&term.line[oldy][oldx].c, term.line[oldy][oldx], oldx, oldy, 1);
+       else
                xclear(oldx, oldy, oldx, oldy);
+       
        /* draw the new one */
        if(mode == CURSOR_DRAW) {
-               xdrawc(term.c.x, term.c.y, g);
+               xdraws(&g.c, g, term.c.x, term.c.y, 1);
                oldx = term.c.x, oldy = term.c.y;
        }
 }
 
+#ifdef DEBUG
+/* basic drawing routines */
+void
+xdrawc(int x, int y, Glyph g) {
+       XRectangle r = { x * xw.cw, y * xw.ch, xw.cw, xw.ch };
+       XSetBackground(xw.dis, dc.gc, dc.col[g.bg]);
+       XSetForeground(xw.dis, dc.gc, dc.col[g.fg]);
+       XSetFont(xw.dis, dc.gc, g.mode & ATTR_BOLD ? dc.bfont->fid : dc.font->fid);
+       XDrawImageString(xw.dis, xw.buf, dc.gc, r.x, r.y+dc.font->ascent, &g.c, 1);
+}
+
+void
+draw(int dummy) {
+       int x, y;
+
+       xclear(0, 0, term.col-1, term.row-1);
+       for(y = 0; y < term.row; y++)
+               for(x = 0; x < term.col; x++)
+                       if(term.line[y][x].state & GLYPH_SET)
+                               xdrawc(x, y, term.line[y][x]);
+
+       if(!term.hidec)
+               xcursor(CURSOR_DRAW);
+       XCopyArea(xw.dis, xw.buf, xw.win, dc.gc, 0, 0, xw.bufw, xw.bufh, BORDER, BORDER);
+       XFlush(xw.dis);
+}
+
+#else
+/* optimized drawing routine */
 void
 draw(int redraw_all) {
        int i, x, y, ox;
        Glyph base, new;
        char buf[DRAW_BUF_SIZ];
        
+       XSetForeground(xw.dis, dc.gc, dc.col[DefaultBG]);
+       XFillRectangle(xw.dis, xw.buf, dc.gc, 0, 0, xw.w, xw.h);
        for(y = 0; y < term.row; y++) {
                base = term.line[y][0];
                i = ox = 0;
@@ -1125,10 +1241,13 @@ draw(int redraw_all) {
                }
                xdraws(buf, base, ox, y, i);
        }
-       if(!term.c.hidden)
-               xcursor(CURSOR_DRAW);
+       xcursor(term.hidec ? CURSOR_HIDE : CURSOR_DRAW);
+       XCopyArea(xw.dis, xw.buf, xw.win, dc.gc, 0, 0, xw.bufw, xw.bufh, BORDER, BORDER);
+       XFlush(xw.dis);
 }
 
+#endif
+
 void
 expose(XEvent *ev) {
        draw(SCREEN_REDRAW);
@@ -1153,11 +1272,11 @@ kpress(XEvent *ev) {
        int meta;
        int shift;
 
-       meta  = e->state & Mod1Mask;
+       meta = e->state & Mod1Mask;
        shift = e->state & ShiftMask;
        len = XLookupString(e, buf, sizeof(buf), &ksym, NULL);
 
-       if(customkey = kmap(ksym))
+       if((customkey = kmap(ksym)))
                ttywrite(customkey, strlen(customkey));
        else if(len > 0) {
                buf[sizeof(buf)-1] = '\0';
@@ -1175,7 +1294,7 @@ kpress(XEvent *ev) {
                        break;
                case XK_Insert:
                        if(shift)
-                               /* XXX: paste X clipboard */;
+                               draw(1), puts("draw!")/* XXX: paste X clipboard */;
                        break;
                default:
                        fprintf(stderr, "errkey: %d\n", (int)ksym);
@@ -1186,16 +1305,21 @@ kpress(XEvent *ev) {
 void
 resize(XEvent *e) {
        int col, row;
-       col = e->xconfigure.width / xw.cw;
-       row = e->xconfigure.height / xw.ch;
        
-       if(term.col != col || term.row != row) {
-               tresize(col, row);
-               ttyresize(col, row);
-               xw.w = e->xconfigure.width;
-               xw.h = e->xconfigure.height;
-               draw(SCREEN_REDRAW);
-       }
+       if(e->xconfigure.width == xw.w && e->xconfigure.height == xw.h)
+               return;
+       
+       xw.w = e->xconfigure.width;
+       xw.h = e->xconfigure.height;
+       xw.bufw = xw.w - 2*BORDER;
+       xw.bufh = xw.h - 2*BORDER;
+       col = xw.bufw / xw.cw;
+       row = xw.bufh / xw.ch;
+       tresize(col, row);
+       ttyresize(col, row);
+       XFreePixmap(xw.dis, xw.buf);
+       xw.buf = XCreatePixmap(xw.dis, xw.win, xw.bufw, xw.bufh, XDefaultDepth(xw.dis, xw.scr));
+       draw(SCREEN_REDRAW);
 }
 
 void
@@ -1206,7 +1330,7 @@ run(void) {
 
        running = 1;
        XSelectInput(xw.dis, xw.win, ExposureMask | KeyPressMask | StructureNotifyMask);
-       XResizeWindow(xw.dis, xw.win, xw.w , xw.h); /* fix resize bug in wmii (?) */
+       XResizeWindow(xw.dis, xw.win, xw.w, xw.h); /* XXX: fix resize bug in wmii (?) */
 
        while(running) {
                FD_ZERO(&rfd);
@@ -1219,7 +1343,7 @@ run(void) {
                }
                if(FD_ISSET(cmdfd, &rfd)) {
                        ttyread();
-                       draw(SCREEN_UPDATE);
+                       draw(SCREEN_UPDATE); 
                }
                while(XPending(xw.dis)) {
                        XNextEvent(xw.dis, &ev);