JasonWoof Got questions, comments, patches, etc.? Contact Jason Woofenden
st.git
6 years agomake the backspace and delete keys work like it's the new millenium
Jason Woofenden [Wed, 10 Dec 2014 17:56:18 +0000 (12:56 -0500)]
make the backspace and delete keys work like it's the new millenium

6 years agoinstall into /home/jasonwoof/software/virt
Jason Woofenden [Wed, 10 Dec 2014 17:14:54 +0000 (12:14 -0500)]
install into /home/jasonwoof/software/virt

6 years agoCheck for presence of SHELL environment variable
Eric Pruitt [Wed, 29 Oct 2014 00:51:42 +0000 (17:51 -0700)]
Check for presence of SHELL environment variable

- POSIX states the SHELL environment variable "... shall represent a
  pathname of the user's preferred command language interpreter." As
  such, st should check for its presence when deciding what shell to
  use; just as HOME can be defined to override one's passwd-defined home
  directory, a user should also be able to override their passwd-defined
  shell using the SHELL environment variable.

6 years agoReplace character with U+FFFD if wcwidth() is -1
czarkoff@gmail.com [Tue, 28 Oct 2014 11:55:28 +0000 (12:55 +0100)]
Replace character with U+FFFD if wcwidth() is -1

Helpful when new Unicode codepoints are not recognized by libc.

7 years agoAvoid failing when embedding with a Window id of 0
Quentin Rameau [Wed, 15 Oct 2014 22:42:53 +0000 (00:42 +0200)]
Avoid failing when embedding with a Window id of 0

I'd like to let st run with its own window when trying to embed it to a window with id 0 instead of exiting with an error.

7 years agoReverting smacs and rmacs to the xterm defaults.
Christoph Lohmann [Tue, 21 Oct 2014 14:36:01 +0000 (16:36 +0200)]
Reverting smacs and rmacs to the xterm defaults.

These are needed by ncurses to correctly handle the switch between line
drawing. The changes to the alternative characterset code already fixed the
urwid hack.

7 years agoDo not set SHELL to utmp ever
Roberto E. Vargas Caballero [Wed, 15 Oct 2014 17:42:20 +0000 (19:42 +0200)]
Do not set SHELL to utmp ever

SHELL must be set to the SHELL of the user, but it was possible set
it to utmp.

7 years agopatch for bell in st
CustaiCo [Fri, 3 Oct 2014 19:25:21 +0000 (19:25 +0000)]
patch for bell in st

The XBell() call currently used when a bell is recieved sends a message
to the X server, but if the X server doesn't know how to sound it,
it just gets ignored and I have not been able to find anywhere in x.org's
code a way to configure the action that the server does.

However, if you use XkbBell() then you can have a process listening for
the XkbBellNotifyEvent that is produced and either alert you visually or
play an audio file or whatever you want as your notification. You have
to include one more header file but the function seems to be compiled as
part of Xlib, at least on my installation.

CustaiCo

7 years agoUse G1 for alternate charset
Roberto E. Vargas Caballero [Wed, 8 Oct 2014 09:35:45 +0000 (11:35 +0200)]
Use G1 for alternate charset

St has enacs, which must be printed if a program requires to use
the alternate charset (graphic charset), that in st case was to
select charset graphic for G1, but it was not useful
at all because smacs and rmacs were always redefining the value
of G0.

7 years agoAdd LS2 and LS3
Roberto E. Vargas Caballero [Wed, 8 Oct 2014 09:33:36 +0000 (11:33 +0200)]
Add LS2 and LS3

These sequences are the equivalents of LS0 and LS1, but for G2 and
G3.

7 years agoFix SI and SO
Roberto E. Vargas Caballero [Wed, 8 Oct 2014 08:30:20 +0000 (10:30 +0200)]
Fix SI and SO

SI (0x0F or ^O) means Shift In, and it selects G1 charset definition,
and SO (0x0E or ^N) means Shift Out, and it selects G0 charset
definition, but st was doing just the inverse.

7 years agoRemoving an extra space.
Christoph Lohmann [Mon, 29 Sep 2014 13:41:10 +0000 (15:41 +0200)]
Removing an extra space.

7 years agoMinor style changes for the last patch.
Christoph Lohmann [Mon, 29 Sep 2014 13:40:37 +0000 (15:40 +0200)]
Minor style changes for the last patch.

7 years agoImplementing xzoomreset.
Christoph Lohmann [Mon, 29 Sep 2014 13:38:21 +0000 (15:38 +0200)]
Implementing xzoomreset.

Thanks mvdan@mvdan.cc for proposing this.

7 years agoAdd missed names of charset sequences
Roberto E. Vargas Caballero [Wed, 20 Aug 2014 08:41:41 +0000 (10:41 +0200)]
Add missed names of charset sequences

7 years agoAdd support for utmp in st
Roberto E. Vargas Caballero [Thu, 28 Aug 2014 10:48:29 +0000 (12:48 +0200)]
Add support for utmp in st

St runs an interactive shell and not a login shell, and it means
that profile is not loaded. The default terminal configuration
in some system is not the correct for st, but since profile is
not loaded there is no way of getting a script configures the
correct values.

St doesn't update the utmp files, this is the job of another
suckless tool, utmp. Utmp also opens a login shell (it is the
logical behaviour when you create a new user record) it is a
good option execute utmp and then get a correct input in
utmp, wtmp and lastlog file, and execute the content of the
profile.

7 years agoRemove indentation level in xdrawcursor
Roberto E. Vargas Caballero [Sun, 24 Aug 2014 14:27:28 +0000 (16:27 +0200)]
Remove indentation level in xdrawcursor

7 years agoRemoving wrapping newlines from selection
Ben Hendrickson [Fri, 22 Aug 2014 16:25:04 +0000 (09:25 -0700)]
Removing wrapping newlines from selection

When getting selected text, lines that were wrapped because of length
ought not include the wrapping newline in the selection.

This comes up, for example, when copying a bash command that is long
enough to wrap from the console and pasting it back into the console.
The extra newline breaks it.

Similiarly, changes behavior when trimming whitespace from the end of a
physical line to only do so if the line does not wrap. Otherwise we are
trimming whitespace from the middle of a logical line, which may change
its meaning.

Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>

7 years agoChange the behavior of word snapping on delimiters
Ivan Delalande [Wed, 20 Aug 2014 19:20:44 +0000 (21:20 +0200)]
Change the behavior of word snapping on delimiters

This makes any sequence of identical delimiters be considered a single
word in word-snapping mode. This seems more coherent for this mode and
is similar to what xterm does.

Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>

7 years agoMove calls to selsnap into selnormalize
Ivan Delalande [Wed, 20 Aug 2014 19:14:08 +0000 (21:14 +0200)]
Move calls to selsnap into selnormalize

This simplifies getbuttoninfo() and bpress(), and fixes a bug which made word
snapping behave incorrectly when a delimiter was at the beginning or end of
line.

Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>

7 years agoImprove readability of enum members
Alexander Huemer [Wed, 20 Aug 2014 10:05:12 +0000 (12:05 +0200)]
Improve readability of enum members

The 'left shift from one' notation of power of two integers is more
expressive than the result.

Signed-off-by: Alexander Huemer <alexander.huemer@xx.vu>
Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>

7 years agoAdd eschandle()
Roberto E. Vargas Caballero [Wed, 20 Aug 2014 07:56:24 +0000 (09:56 +0200)]
Add eschandle()

We already have a csihandle() function, where is located code about
CSI sequences, so it is logical do the same with ESC sequences.
This change helps to simplify tcontrol(), which has a complex flow
and should be rewritten.

7 years agoImprove execsh() and don't allow anonymous shells
Roberto E. Vargas Caballero [Mon, 18 Aug 2014 22:55:02 +0000 (00:55 +0200)]
Improve execsh() and don't allow anonymous shells

This patch improves the shell selection on execsh and forbid
shell with users don't registered in the passwd file.

7 years agoFix definition of CONTROLC0
Roberto E. Vargas Caballero [Mon, 18 Aug 2014 21:23:51 +0000 (23:23 +0200)]
Fix definition of CONTROLC0

DEL character is not thecnically talking a C0 control character,
although it has some common properties with them, so it is useful
for us consider it as C0. Before this patch DEL (\177), was not
ignored as it ought to be.

7 years agoMake useful DEL in application mode
Roberto E. Vargas Caballero [Mon, 18 Aug 2014 21:19:58 +0000 (23:19 +0200)]
Make useful DEL in application mode

DEL key has to generate the sequence ^[P in application mode,
because such sequence means delete current character. It implies
that the character sent in keypad mode must be ^? (DEL character).

7 years agoreset the alt screen in treset
Quentin Carbonneaux [Mon, 18 Aug 2014 17:20:41 +0000 (19:20 +0200)]
reset the alt screen in treset

Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>

7 years agosimplify loop in tresize
Quentin Carbonneaux [Mon, 18 Aug 2014 17:19:42 +0000 (19:19 +0200)]
simplify loop in tresize

Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>

7 years agoSimplify README
Alexander Huemer [Sun, 17 Aug 2014 23:52:53 +0000 (01:52 +0200)]
Simplify README

The term 'virtual terminal emulator' was broken. There is nothing
virtual about it, it's a terminal emulator.

Signed-off-by: Alexander Huemer <alexander.huemer@xx.vu>
Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>

7 years agoFix man page and usage()
Roberto E. Vargas Caballero [Sun, 17 Aug 2014 18:49:33 +0000 (20:49 +0200)]
Fix man page and usage()

Man page was repeating -f option, the second time instead of -i,
and this option was lost in usage() message. This patch also indent
the output of usage().

7 years agoConvert VT102ID to a config variable
Roberto E. Vargas Caballero [Fri, 15 Aug 2014 13:00:48 +0000 (15:00 +0200)]
Convert VT102ID to a config variable

VT102ID is the sequence that the terminal returns when it is inquired
to identify itself. This value should be configurable in the same
way that another st parameters.

7 years agoFix portability problem in techo()
Roberto E. Vargas Caballero [Fri, 15 Aug 2014 12:48:16 +0000 (14:48 +0200)]
Fix portability problem in techo()

ISCONTROL chechks if a value is between 0 and 0x1f or
between 0x80 and 0x9f. Char signess depends of architecture
and compiler, so in some environment the second case is
always false (and wrong), Techo() calls ISCONTROL with a
char variable, whose type cannot be changed because tpuc()
expects a pointer to char, so the solution is to insert a
cast in the call to ISCONTROL.

7 years agoDon't set dirty all lines because tswapcreen do it
noname [Sun, 27 Apr 2014 22:16:21 +0000 (02:16 +0400)]
Don't set dirty all lines because tswapcreen do it

Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>

7 years agotresize return value is not used
noname [Sun, 27 Apr 2014 22:03:04 +0000 (02:03 +0400)]
tresize return value is not used

Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>

7 years agoRemove ul capability
Roberto E. Vargas Caballero [Thu, 7 Aug 2014 08:19:48 +0000 (10:19 +0200)]
Remove ul capability

This capability indicates that underscore '_' overstrike current
letter under the cursor. It means that you can generate a
underline 'b' using 'b^H_', because it writes a 'b' then backward
one characther and then overstrike '_'. St has not such behaviour,
so it is an error to have this capability.

7 years agoUnset mode when clearing regions
Roberto E. Vargas Caballero [Thu, 7 Aug 2014 08:11:38 +0000 (10:11 +0200)]
Unset mode when clearing regions

tclearregion() was clearing regions using spaces and the current
attributes of the terminal. It was correct with all the modes excepct
underline, because they didn't affect the space character, but in
the case of underline it was a problem. A easy way of seeing this
problem is writing this in the last line of the terminal:

tput smul ; echo first; tput rmul; echo second; echo third

Fist was underlined, and second and third were not underlined, but
the spaces at the right of second was underlined becuause in the
previous scrool underline mode was set.

7 years agoAdd error message when child exits whit error
Roberto E. Vargas Caballero [Mon, 4 Aug 2014 20:07:04 +0000 (22:07 +0200)]
Add error message when child exits whit error

Master proccess was not showing any error message when the child
died with an error, and it was very confusing for the user (for
example with incorrect -e command).

7 years agoRemove difference between fast and slow blinking
Roberto E. Vargas Caballero [Thu, 31 Jul 2014 17:37:59 +0000 (19:37 +0200)]
Remove difference between fast and slow blinking

One blinking mode is good enough, and two is too much. The best aproach
is emulate the fast blinking with the slow blinking, that it is more
used.
It is removed the flag ATTR_FASTBLINK because it has not a different
meaning of ATTR_BLINK, so it is not needed.

Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>

7 years agoFix disabling of bold and fastblink
Michael Forney [Sat, 26 Jul 2014 07:48:15 +0000 (00:48 -0700)]
Fix disabling of bold and fastblink

According to ECMA-48¹ 8.3.117, an attribute value of 21 is "doubly
underlined", while 22 is "normal colour or normal intensity (neither
bold nor faint)".

Additionally, 25 is "steady (not blinking)", which likely means neither
slow blink nor fast blink.

¹: http://www.ecma-international.org/publications/files/ECMA-ST/Ecma-048.pdf

Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>

7 years agoAdd info about Backspace and Delete to the FAQ
Wolfgang Corcoran-Mathe [Fri, 25 Jul 2014 17:32:29 +0000 (13:32 -0400)]
Add info about Backspace and Delete to the FAQ

Here is a modest attempt at cleaning it up a little bit. I changed a
few phrases that seemed awkward, but I think the content is the same.

--
Wolfgang Corcoran-Mathe

Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>

7 years agoAdd info about Backspace and Delete to the FAQ
Roberto E. Vargas Caballero [Thu, 24 Jul 2014 17:56:58 +0000 (19:56 +0200)]
Add info about Backspace and Delete to the FAQ

7 years agoAdd information about librt and OpenBSD to the FAQ
Roberto E. Vargas Caballero [Sun, 20 Jul 2014 08:31:16 +0000 (10:31 +0200)]
Add information about librt and OpenBSD to the FAQ

7 years agoAdd information about librt and OpenBSD to the FAQ
Roberto E. Vargas Caballero [Sun, 20 Jul 2014 08:31:16 +0000 (10:31 +0200)]
Add information about librt and OpenBSD to the FAQ

7 years agoAdd information about librt and OpenBSD to the FAQ
Roberto E. Vargas Caballero [Sun, 20 Jul 2014 08:31:16 +0000 (10:31 +0200)]
Add information about librt and OpenBSD to the FAQ

7 years agoVery minor grammar fixes in FAQ
Wolfgang Corcoran-Mathe [Sun, 20 Jul 2014 15:05:39 +0000 (11:05 -0400)]
Very minor grammar fixes in FAQ

Self-explanatory.

Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>

7 years agoFix st with input method.
Weng Xuetian [Wed, 16 Jul 2014 22:36:46 +0000 (18:36 -0400)]
Fix st with input method.

XFilterEvent need to be called against every event, otherwise it would
missing some message in the xim protocol and misbehave on some im server.

Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>

7 years agoChanged inconsistent indent
Eric Pruitt [Mon, 14 Jul 2014 14:05:07 +0000 (09:05 -0500)]
Changed inconsistent indent

- A line was indented using spaces despite the rest of the code using
  tabs.

Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>

7 years agoAdd 8 bit version of DCS, APC, PM, OSC
Roberto E. Vargas Caballero [Fri, 20 Jun 2014 07:51:18 +0000 (09:51 +0200)]
Add 8 bit version of DCS, APC, PM, OSC

DCS, APC, PM, OSC version for 7 bits environments already was implemented
in st.  This patch adds the 8 bit version of it.

7 years agoAdd 8 bit version of HTS
Roberto E. Vargas Caballero [Fri, 20 Jun 2014 07:51:18 +0000 (09:51 +0200)]
Add 8 bit version of HTS

HTS version for 7 bits environments already was implemented in st.
This patch adds the 8 bit version of it.

7 years agoAdd 8 bit version of NEL
Roberto E. Vargas Caballero [Fri, 20 Jun 2014 07:51:18 +0000 (09:51 +0200)]
Add 8 bit version of NEL

NEL version for 7 bits environments already was implemented in st.
This patch adds the 8 bit version of it.

7 years agoAdd 8 bit version of DECID
Roberto E. Vargas Caballero [Fri, 20 Jun 2014 07:51:18 +0000 (09:51 +0200)]
Add 8 bit version of DECID

DECID version for 7 bits environments already was implemented in st.
This patch adds the 8 bit version of it.

7 years agoRender faint attribute
Anders Eurenius [Sat, 21 Jun 2014 22:10:59 +0000 (00:10 +0200)]
Render faint attribute

Faint text is implemented by allocating a new color at one-half
intensity of each of the r, g, b components, or if the text bold at the
same time, it is not made lighter.

Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>
Signed-off-by: Christoph Lohmann <20h@r-36.net>

7 years agoRemove all strcmp and strlen calls on Glyph.c[]
Ivan Delalande [Fri, 27 Jun 2014 07:15:56 +0000 (09:15 +0200)]
Remove all strcmp and strlen calls on Glyph.c[]

There were a few occurrences of strcmp and strlen being called on Glyph.c[],
which is not always null-terminated (this actually depends on the last values in
the buffer s in ttyread()). This patch replace all the calls to strcmp with a
test on c[0] directly or a call to tlinelen, and the one to strlen with utf8len.
I also took the opportunity to refactor getsel and tdumpline.

Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>

7 years agoMaking surf compile again with rt.
Christoph Lohmann [Mon, 30 Jun 2014 15:33:43 +0000 (17:33 +0200)]
Making surf compile again with rt.

The clock_gettime patch needs librt to be linked to surf.

Thanks _odie for the hint.

7 years agoRender struck-out attribute
Anders Eurenius [Sat, 21 Jun 2014 18:32:34 +0000 (20:32 +0200)]
Render struck-out attribute

Implement crossed-out text with an XftDrawRect call, similar to how
underline is implemented. The line is drawn at 2/3 of the font ascent,
which seems to work nicely in practice.

Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>

7 years agoRender invisible attribute
Anders Eurenius [Sat, 21 Jun 2014 18:30:22 +0000 (20:30 +0200)]
Render invisible attribute

Implement invisible mode by setting the foreground color to be the same
as the background color. Not rendering anything would also be an
alternative, but this seems less likely to cause surprises in
conjunction with any hacks.

Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>

7 years agoReorder and extend glyph attributes
Anders Eurenius [Sat, 21 Jun 2014 18:29:36 +0000 (20:29 +0200)]
Reorder and extend glyph attributes

Faint, invisible, struck and fast blink are added as glyph attributes.
Since there's an edit here, let's take the opportunity to reorder them
so that they correspond to the two's power of the corresponding escape
code. (just for neatness, let's hope that property never gets used for
anything.)

Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>

7 years agoRemove CEIL macro
Roberto E. Vargas Caballero [Thu, 26 Jun 2014 10:37:06 +0000 (12:37 +0200)]
Remove CEIL macro

This macro was not correct in some cases, and it was used only in
one place, where we did'nt get any benefit in performance of in size,
so the macro is removed and ceilf is used instead of it. The only
function needed from math.h is ceilf, so this patch defines the
prototype of it instead of including math.h.

7 years agoFixed wrong nanosecond factor 10E6.
Ivan Delalande [Thu, 26 Jun 2014 02:30:43 +0000 (04:30 +0200)]
Fixed wrong nanosecond factor 10E6.

Commit 5edeec1 introduced a wrong factor for nanosecond computation, the correct
value is 1E6. Time and timeout values are 10 times less than they should be and
this cause high CPU usage.

Reported by pyroh on IRC. Thanks!

Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>

7 years agoUse monotonic clock to prevent timing issues
FRIGN [Mon, 23 Jun 2014 14:51:51 +0000 (16:51 +0200)]
Use monotonic clock to prevent timing issues

This patch replaces the gettimeofday()/timeval-system with
uses of clock_gettime() with a monolithic clock and timespec-structs.
gettimeofday() is not accurate and prone to jumps and POSIX.1-2008
marks it as obsolete. Read more here [0].

The patch should speak for itself and decreases the binary
size for me by almost 200K(!).

[0]: http://blog.habets.pp.se/2010/09/gettimeofday-should-never-be-used-to-measure-time

Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>

7 years agoFix typo in config.def.h
Eric Pruitt [Wed, 18 Jun 2014 13:39:57 +0000 (08:39 -0500)]
Fix typo in config.def.h

Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>

7 years agoupdate size hints on zoom
Troy Sankey [Wed, 18 Jun 2014 17:41:26 +0000 (10:41 -0700)]
update size hints on zoom

On font zooming (i.e. xzoom()), window size hints are not updated.  This
patch does that.

Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>

7 years agoRefactor the innermost loop of the xdraws function
Silvan Jegen [Fri, 6 Jun 2014 20:09:22 +0000 (22:09 +0200)]
Refactor the innermost loop of the xdraws function

Signed-off-by: Silvan Jegen <s.jegen@gmail.com>
Signed-off-by: Christoph Lohmann <20h@r-36.net>

7 years agoFAQ: update typo and escape code for smkx
Hiltjo Posthuma [Mon, 9 Jun 2014 15:19:15 +0000 (17:19 +0200)]
FAQ: update typo and escape code for smkx

Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>

7 years agoStyle police.
Christoph Lohmann [Sat, 7 Jun 2014 11:49:04 +0000 (13:49 +0200)]
Style police.

7 years agoSimplify tdeftrans
Roberto E. Vargas Caballero [Sat, 7 Jun 2014 11:23:45 +0000 (13:23 +0200)]
Simplify tdeftrans

7 years agoRemove unnecessary typedef
FRIGN [Fri, 6 Jun 2014 12:08:51 +0000 (14:08 +0200)]
Remove unnecessary typedef

This should also fix compiling-errors on OpenBSD,
as reported by Nils R. Thanks!

Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>

7 years agoRefactor selsnap SNAP_WORD.
Colona [Thu, 5 Jun 2014 04:32:01 +0000 (06:32 +0200)]
Refactor selsnap SNAP_WORD.

Refactor the SNAP_WORD part in selsnap, and fix a bug that caused the word
delimiters to be ignored if it was at the very beginning or end of a wrapped
line.

Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>

7 years agoFix rectangular selection.
Colona [Wed, 4 Jun 2014 04:47:55 +0000 (21:47 -0700)]
Fix rectangular selection.

selsort computes the wrong normalized coordinates when rectangular
selection is enabled, causing rectangular selection to only work
when going toward either the top left corner, or the bottom right
one.

Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>

7 years agotiny cleanup
Hiltjo Posthuma [Tue, 3 Jun 2014 15:55:53 +0000 (17:55 +0200)]
tiny cleanup

Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>

7 years agoMake selection consistent over line breaks.
Colona [Tue, 3 Jun 2014 02:34:58 +0000 (04:34 +0200)]
Make selection consistent over line breaks.

Currently, selection is expanded to the end of the line over line breaks only in
regular selection mode, when the line in not empty and when going down and/or
right. This covers all the cases including word selection mode, with the
exception of rectangular selection because it would make this mode too rigid.
This adjustment is made in selsort so I renamed it to selnormalize to better
reflect what it does now.

Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>

7 years agoFixing color and refactor xsetcolorname.
Christoph Lohmann [Sun, 1 Jun 2014 15:08:16 +0000 (17:08 +0200)]
Fixing color and refactor xsetcolorname.

By  the recommendation of FRIGN I refactored xsetcolorname to remove the
unnecessary r, g, b variables when allocating a new  color.  Colors  are
now freed and set to the new color. A die() should not happen here. Oth‐
erwise it is easy for applications to kill st. St should be resilent  to
malicious input.

Second  this  patch  standardises  the  naming  of  »color«. There is no
»colour« here. Maybe in some parts of the world.

7 years agoRevert "Refactor xsetcolorname()"
Christoph Lohmann [Sun, 1 Jun 2014 14:52:19 +0000 (16:52 +0200)]
Revert "Refactor xsetcolorname()"

This reverts commit a32c5f5726f514b49bd396f27aab0e78c40126d3.

7 years agoRefactor xsetcolorname()
FRIGN [Sun, 25 May 2014 10:13:22 +0000 (12:13 +0200)]
Refactor xsetcolorname()

I mainly improved the slightly off algorithm used to load colours in the 256-colour-space and
removed unnecessary local values (r,g,b,colour).
"colour" is not necessary as a punchbag for XftColorAlloc[Value,Name], as they don't mess with
the result-adress until they are absolutely sure everything worked out[0].

Being at it, I changed the error-returns for AllocValue to dies (just like in xloadcols()), as
a failure is most likely an OOM-situation you better catch early.
In case of an invalid name everything stays the same.

[0]: http://www.opensource.apple.com/source/X11libs/X11libs-40/libXft/libXft-2.1.13/src/xftcolor.c

Signed-off-by: Christoph Lohmann <20h@r-36.net>

7 years agoDon't report release events for mouse wheel
Balazs Kezes [Sat, 31 May 2014 21:24:58 +0000 (22:24 +0100)]
Don't report release events for mouse wheel

Signed-off-by: Christoph Lohmann <20h@r-36.net>

7 years agoFixing italic bold.
Christoph Lohmann [Sun, 1 Jun 2014 13:54:28 +0000 (15:54 +0200)]
Fixing italic bold.

Thanks Felipe Spychalski <spychalski@gmail.com> for the patch!

7 years agoFixed copying empty lines inside selection.
Alexander [Mon, 26 May 2014 05:23:56 +0000 (09:23 +0400)]
Fixed copying empty lines inside selection.

The code was assuming that empty lines have implicit wrap-around attribute.

Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>

7 years agoFix some more LICENSE changes.
Christoph Lohmann [Sat, 24 May 2014 19:27:54 +0000 (21:27 +0200)]
Fix some more LICENSE changes.

7 years agoAdd FRIGN to License, remove trailing whitespace
FRIGN [Sat, 24 May 2014 19:07:53 +0000 (21:07 +0200)]
Add FRIGN to License, remove trailing whitespace

Signed-off-by: Christoph Lohmann <20h@r-36.net>

7 years agoBrightening is again on the TODO list.
Christoph Lohmann [Sat, 24 May 2014 11:52:24 +0000 (13:52 +0200)]
Brightening is again on the TODO list.

7 years agoFixing trailing whitespaces.
Christoph Lohmann [Sat, 24 May 2014 11:48:44 +0000 (13:48 +0200)]
Fixing trailing whitespaces.

7 years agoFix colour-model and simplify xloadcols()
FRIGN [Thu, 22 May 2014 13:00:33 +0000 (15:00 +0200)]
Fix colour-model and simplify xloadcols()

Signed-off-by: Christoph Lohmann <20h@r-36.net>

7 years agoAllow mouse selection override using ShiftMask
Hiltjo Posthuma [Mon, 12 May 2014 12:39:37 +0000 (14:39 +0200)]
Allow mouse selection override using ShiftMask

Similar to xterm or urxvt holding shift before selecting text with the mouse
allows to override copying text. For example in tmux with "mode-mouse on" or
vim (compiled with --with-x), mc, htop, etc.

forceselmod in config.h sets the modifier to use this mode, by default
ShiftMask.

Signed-off-by: Hiltjo Posthuma <hiltjo@codemadness.org>

7 years agoRedraw needs all dirty lines to have flash etc. work.
Christoph Lohmann [Fri, 9 May 2014 15:12:58 +0000 (17:12 +0200)]
Redraw needs all dirty lines to have flash etc. work.

7 years agoEnd a sequence only on CAN, SUB, \a and C1s.
Colona [Fri, 9 May 2014 08:23:53 +0000 (10:23 +0200)]
End a sequence only on CAN, SUB, \a and C1s.

7 years agoAlso clears ESC_START on interrupt characters during sequences.
Colona [Wed, 7 May 2014 08:05:27 +0000 (10:05 +0200)]
Also clears ESC_START on interrupt characters during sequences.

Otherwise, the rest of the input is interpreted as a new escape
sequence.
For the ESC character, ESC_START is re-set in tcontrolcode.

7 years agoConsistent FALLTHROUGH comments.
noname [Fri, 25 Apr 2014 14:26:54 +0000 (18:26 +0400)]
Consistent FALLTHROUGH comments.

7 years agoFix displaying control code
Roberto E. Vargas Caballero [Tue, 29 Apr 2014 07:58:55 +0000 (09:58 +0200)]
Fix displaying control code

Control code are never displayed. It is not important if graphic
charset is displayed or not.

7 years agoRemove ATTR_GFX and tselcs
Roberto E. Vargas Caballero [Tue, 29 Apr 2014 06:58:10 +0000 (08:58 +0200)]
Remove ATTR_GFX and tselcs

ATTR_GFX was used long time ago to detect when terminal was in
graphic mode. Today graphic mode is implemented using a charset
pointer, so ATTR_GFX is not needed anymore because graphic
condition can be detected directly checking if current charset
is GRAPHICS C0.

7 years agoDo not save cursor in tresize.
noname [Mon, 28 Apr 2014 22:35:22 +0000 (02:35 +0400)]
Do not save cursor in tresize.

This patch fixes the bug introduced in
8f11e1cd034ff28ca47bb4955505db7fa8016ba8

To reproduce the bug:
1. Save cursor: printf '\e[s'
2. Load cursor: printf '\e[u'
3. Resize st window.
4. Load cursor again: printf '\e[u'

7 years agoSimplify selected().
noname [Sun, 27 Apr 2014 11:16:41 +0000 (15:16 +0400)]
Simplify selected().

7 years agoDo not export chscale and cwscale.
noname [Sun, 27 Apr 2014 11:39:53 +0000 (15:39 +0400)]
Do not export chscale and cwscale.

7 years agoSimplify xunloadfonts.
noname [Sun, 27 Apr 2014 22:41:17 +0000 (02:41 +0400)]
Simplify xunloadfonts.

7 years agoRemove one indentation level in getsel().
noname [Sun, 27 Apr 2014 11:40:23 +0000 (15:40 +0400)]
Remove one indentation level in getsel().

7 years agoRemove unused dump() function.
noname [Sun, 27 Apr 2014 11:40:01 +0000 (15:40 +0400)]
Remove unused dump() function.

7 years agoAdd missing function prototypes.
noname [Sun, 27 Apr 2014 11:39:47 +0000 (15:39 +0400)]
Add missing function prototypes.

7 years agoUse MODBIT in xseturgency.
noname [Sun, 27 Apr 2014 11:39:39 +0000 (15:39 +0400)]
Use MODBIT in xseturgency.

7 years agoCompute ena_sel as one expression.
noname [Sun, 27 Apr 2014 11:39:29 +0000 (15:39 +0400)]
Compute ena_sel as one expression.

7 years agoSimplify expressions in tputc()
Roberto E. Vargas Caballero [Sun, 27 Apr 2014 08:25:15 +0000 (10:25 +0200)]
Simplify expressions in tputc()

7 years agoFix misplaced break
Roberto E. Vargas Caballero [Sat, 26 Apr 2014 07:30:53 +0000 (09:30 +0200)]
Fix misplaced break

This misplaced break was causing an incorrect fall through
from DSR to DECSTBM.

7 years agoCreate a function for DEC test
Roberto E. Vargas Caballero [Sat, 26 Apr 2014 07:24:04 +0000 (09:24 +0200)]
Create a function for DEC test

Almost of the sequences execute their action in a separate function,
which is good because helps to read the full set of sequences
faster.