X-Git-Url: https://jasonwoof.com/gitweb/?p=wfpl.git;a=blobdiff_plain;f=upload.php;h=e9ff5db4f0c3a255ad1da8a81fc2036ef4ef83e6;hp=f52f0cfe3887ce89cc3a2f294567b96e0c976bde;hb=062d46e16429f2e55573567518cb01c83b319ac4;hpb=423f31ad0add74bbb6066d3c9f760ad0a5580cda

diff --git a/upload.php b/upload.php
index f52f0cf..e9ff5db 100644
--- a/upload.php
+++ b/upload.php
@@ -34,9 +34,9 @@
 # Example:
 # 
 # <form action="foo.php" enctype="multipart/form-data" method="post">
-# <input type="hidden" name="MAX_FILE_SIZE" value="2097152" />
-# <input type="file" name="photo" />
-# <input type="submit" name="save" value="Save" />
+# <input type="hidden" name="MAX_FILE_SIZE" value="2097152">
+# <input type="file" name="photo">
+# <input type="submit" name="save" value="Save">
 # </form>
 # 
 # #######
@@ -111,10 +111,10 @@ function generate_filename($path, $mime = 'text/plain') {
 	}
 
 	# replace symbols with underscores
-	$filename = ereg_replace('[^a-z0-9_.]', '_', $filename);
+	$filename = preg_replace('|[^a-z0-9_.]|', '_', $filename);
 
 	# remove dots from the beginning (no invisible files)
-	$filename = ereg_replace('^\.*', '', $filename);
+	$filename = preg_replace('|^\.*|', '', $filename);
 
 	if(strlen($filename > 80)) {
 		$filename = substr($filename, -80);
@@ -152,7 +152,7 @@ function generate_filename($path, $mime = 'text/plain') {
 # the client's name appended. Otherwise $path will be used as the filename
 # exactly as is, even if extensions differ between the client's name and $path.
 #
-# where user uploads "c:\foo\Bar baz.PDF" at <input name="in" type="file" />
+# where user uploads "c:\foo\Bar baz.PDF" at <input name="in" type="file">
 #    save_uploaded_file('in', 'uploaded_pdfs/'); yeilds:
 #       "uploaded_pdfs/bar_baz.pdf"
 #    save_uploaded_file('in', 'uploaded_pdfs/prefix.'); yeilds:
@@ -181,8 +181,8 @@ function save_uploaded_file($key, $path) {
 # standard places (like /usr/bin or /usr/local bin) and PHP's PATH environment
 # variable is not set appropriately.
 function path_to($prog, $or_die = true) {
-	$prog = ereg_replace('[^a-zA-Z0-9_.-]', '', $prog);
-	$prog = ereg_replace('^[-.]*', '', $prog);
+	$prog = preg_replace('|[^a-z0-9_.-]|i', '', $prog);
+	$prog = preg_replace('|^[-.]*|', '', $prog);
 	if($prog == '') {
 		die('Invalid argument to path_to()');
 	}
@@ -224,7 +224,7 @@ function gif_to_png($filename, $new_filename = 'just change extension') {
 		$new_filename .= '.png';
 	}
 
-	imagemagick_convert($filename, $new_filename, "$convert -colorspace RGB", 'GIF to PNG conversion');
+	imagemagick_convert($filename, $new_filename, "-colorspace sRGB", 'GIF to PNG conversion');
 
 	unlink($filename);
 	return $new_filename;
@@ -258,7 +258,7 @@ function make_thumbnail($filename, $max_width = '70', $max_height = '70') {
 function exec_or_die($command, $doing_what) {
 	exec($command, $dummy, $ret);
 	if($ret != 0) {
-		$base = basename(ereg_replace(' .*', '', $command));
+		$base = basename(preg_replace('| .*|', '', $command));
 		die("$doing_what failed. $base called exit($ret)");
 	}
 }
@@ -280,7 +280,7 @@ function imagemagick_mogrify($in_filename, $args, $doing_what = "Image conversio
 }
 
 function format_int_70($str) {
-	$str = ereg_replace('[^0-9]', '', $str);
+	$str = preg_replace('|[^0-9]|', '', $str);
 	if($str == '') {
 		$str = '70';
 	}
@@ -331,7 +331,7 @@ function image_w_h_or_die($filename) {
 
 
 # Like save_uploaded_file() (above) except that it converts all images to PNG
-# or JPEG, converts to RGB colorspace, and optionally scales and/or creates a
+# or JPEG, converts to sRGB colorspace, and optionally scales and/or creates a
 # thumbnail. And, if $path ends with a period, the correct extension will be
 # appended.
 #
@@ -352,7 +352,7 @@ function image_w_h_or_die($filename) {
 # and names, call convert_uploaded_image().
 function save_uploaded_image($key, $path, $image_width = 0, $image_height = 0, $thumbnail_width = 0, $thumbnail_height = 0) {
      $image_w_h_thumb_w_h = convert_uploaded_image($key, $path, $image_width, $image_height, $thumbnail_width, $thumbnail_height);
-     return ereg_replace(' .*', '', $image_w_h_thumb_w_h);
+     return preg_replace('| .*|', '', $image_w_h_thumb_w_h);
 }
 
 function ext_to_web_image_ext($in) {
@@ -392,7 +392,7 @@ function convert_uploaded_image($key, $path, $image_width = 0, $image_height = 0
 		$filename = $path;
 	}
 
-	$convert_params = '-colorspace RGB';
+	$convert_params = '-colorspace sRGB -auto-orient';
 	if($image_width > 0 && $image_height > 0) {
 		$convert_params .= " -geometry ${image_width}x$image_height";
 	}