Mark Edgar [Sat, 5 Oct 2013 09:45:17 +0000 (11:45 +0200)]
Simplify Mod1 logic in kpress(), eliminating locals and a memcpy.
Roberto E. Vargas Caballero [Tue, 1 Oct 2013 19:23:11 +0000 (21:23 +0200)]
Add support for multiple charset definitions
vt100 has support for two defined charset, G0 and G1. Each charset
can be defined, but in each moment is selected only one of both
charset. This is usually used selecting a national charset in G0
and graphic charset in G1, so you can switch between graphic
charset and text charset without losing the national charset
already defined.
st hasn't support for national charsets, because it is an utf8
based terminal emulator, but it has support for graphic
charset because it is heavily used, but it only supports G0,
without understanding G1 selection sequences, which causes some
programs in some moments can print some garbage in the screen.
This patch adds a fake support for multiple charset definitions,
where we only support graphic charset and us-ascii charset, but
we allow more of one charset definition.
This patch allow define G0 until G3 charsets, but only accepts
select G0 or G1, and it accepts some national charset definitions
but all of them are mapped to us-ascii.
Christoph Lohmann [Wed, 2 Oct 2013 19:06:50 +0000 (21:06 +0200)]
People, learn to keep to styles. Thanks.
Mihail Zenkov [Tue, 1 Oct 2013 18:02:24 +0000 (20:02 +0200)]
Fix save/restore cursor
st was assuming that save/restore cursor position was independent
of the screen that was shown in each moment, but it is not true,
because each screen has a different save/restore buffer. This
patch fixes it.
Mihail Zenkov [Tue, 1 Oct 2013 18:01:15 +0000 (20:01 +0200)]
Add DSR cursor position sequence
Maurice Quennet [Sat, 21 Sep 2013 21:33:56 +0000 (23:33 +0200)]
Fix core in multi-line selection on OpenBSD
OpenBSD 5.3 amd64 release version with the most current st
version from git, crash and dump core when selecting multiple
lines whith the cursor. This happens, because on line 964
of st.c (gp-1)->mode is accessed, although gp is still
pointing at the beginning of the array term.line[y] (see
line 939 for initialization of gp).
Egmont Koblinger [Mon, 23 Sep 2013 07:22:47 +0000 (09:22 +0200)]
Add bracketed paste mode
This patch enables bracketed paste mode (
http://invisible-island.net/xterm/ctlseqs/ctlseqs.html#Bracketed%20Paste%20Mode
).
It's mainly useful for text editors to disable line wrapping and auto
indentation when text is being pasted, rather than typed from keyboard.
On the emulator side, it is supported by at least xterm, urxvt,
gnome-terminal, putty, iterm2; and I have a patch for konsole.
On the application side, vim can be configured easily to handle this, and
I have pending patches for mcedit and joe. Probably many others also
support it.
Michael Forney [Thu, 25 Jul 2013 23:19:19 +0000 (16:19 -0700)]
Fix some bugs in mouse tracking logic
* Button number in X10 mode:
I believe the button - 1 came from "C b is button - 1" from [0].
However, above this section, it states
"Normally, parameters (such as pointer poisition and button number)
for all mouse tracking escape sequences generated by xterm encode
numeric parameters in a single character as value+32. For example, !
specifies the value 1."
Also, from the description of SGR,
"The encoded button value in this case does not add 32 since that
was useful only in the X10 scheme for ensuring that the byte
containing the button value is a printable code."
This suggests that we should still add 32 to the button value when in
MODE_MOUSEX10.
* No button release reporting in X10 mode:
"X10 compatibility mode sends an escape sequence only on button press,
encoding the location and the mouse button pressed."
* Fix MODE_MOUSEMOTION:
Currently, motion reporting is skipped when oldbutton == 3
(corresponding to no button being pressed). However, oldbutton is
only set on a button press, which will never be 3.
[0]: http://invisible-island.net/xterm/ctlseqs/ctlseqs.html
Christoph Lohmann [Thu, 12 Sep 2013 18:52:10 +0000 (20:52 +0200)]
Default volume of the bell is 0.
Roberto E. Vargas Caballero [Thu, 12 Sep 2013 18:41:34 +0000 (20:41 +0200)]
Add audible bell
\a is the character for bell, and st is only marking the window as urgent
if it is not active. This patch adds an audible bell which can be disable
with bellvolume variable.
Signed-off-by: Christoph Lohmann <20h@r-36.net>
Christoph Lohmann [Sat, 7 Sep 2013 10:41:36 +0000 (12:41 +0200)]
Wide character support.
Thanks "Eon S. Jeon" <esjeon@hyunmu.am>!
Christoph Lohmann [Sat, 7 Sep 2013 10:29:44 +0000 (12:29 +0200)]
Adding some contributors. Thanks to you all!
Mark Edgar [Sun, 25 Aug 2013 22:10:47 +0000 (00:10 +0200)]
Correctly initialize altscreen when defaultbg is not 0.
The alternate screen is not properly initialized when st starts. To see
this, set defaultbg in config.h to anything other than 0 (for example, swap
defaultfg and defaultbg), and run:
./st -e sh -c 'tput smcup; read'
You should see that the top-left 80x24 rectangle is black (or whatever
colorname[0] is), while the rest of the screen (if any) has the desired
colorname[defaultbg] color.
The attached patch fixes this by initializing term.c.attr in tnew() before
calling tresize(). It also removes the unnecessary xcalloc() calls, which
misled me on this bug hunt since it is really tclearregion() which
initializes term.lines and term.alt in tresize().
Eon S. Jeon [Sun, 11 Aug 2013 10:42:30 +0000 (06:42 -0400)]
Regarding commit 7e3cff3
Hello.
I reviewed and tested commit 7e3cff3, and made a patch that fixes some
problems in it.
1. There's a semicolon after an if statement, which is obviously a
typo.
2. The current way of calculating text position in "xdraws" yields
inconsistent results in some cases. This is due to the use of
"font->width", which varies. Instead, "xw.cw" has to be used as the
character width.
Sincerely,
Eon
Christoph Lohmann [Thu, 22 Aug 2013 17:32:49 +0000 (19:32 +0200)]
Tmux is using C-b by default.
Thanks for noticing Fidel Barrera Cruz!
Christoph Lohmann [Tue, 20 Aug 2013 16:18:48 +0000 (18:18 +0200)]
Correcting the bitmask value check.
Roberto E. Vargas Caballero [Mon, 12 Aug 2013 13:25:18 +0000 (15:25 +0200)]
Add terminfo definitions for terminals with meta key
Some programs don't check the value of km and use smm and rmm
capabilites, and they cause the terminal change to meta enabled
mode even in cases where is not desirable.
Allmost all people is using the terminal waiting that meta sends
escape, so rmm and smm are not needed. If someone needs meta
sets 8 bit he can use the correct terminfo definition in TERM.
Eon S. Jeon [Mon, 5 Aug 2013 20:37:59 +0000 (16:37 -0400)]
Fix signess of tdefcolor
tdefcolor() returns -1 on error, while its return type is
unsigned long. At the same time, line 1724 and 1731 are checking the
positivity of its unsigned return value.
Alexander Sedov [Mon, 29 Jul 2013 07:50:44 +0000 (11:50 +0400)]
Fixed memory leak in xsettitle().
Michael Forney [Thu, 25 Jul 2013 23:24:16 +0000 (16:24 -0700)]
Fix blink mode check
ATTR_BLINK is an attribute for a Glyph and will not be set in term.mode.
Eric Pruitt [Mon, 5 Aug 2013 09:33:37 +0000 (11:33 +0200)]
Use character size scaling factors
The bounding boxes for characters can be scaled using "cwscale" and "chscale"
to scale the width and height respectively.
Roberto E. Vargas Caballero [Sat, 20 Jul 2013 19:52:40 +0000 (21:52 +0200)]
Reload colors in reset
Colors definition can be changed using a OSC sequence, so
we have to reload them if we want be sure all the colors
are the correct.
Could be desirable free the colors allocated due to rgb
colors and inverse colors (XftColorAllocValues in xdraws),
but it is impossible due we use the same structure for all
of them.
Roberto E. Vargas Caballero [Fri, 19 Jul 2013 18:34:36 +0000 (20:34 +0200)]
Add RGB color definition
This patch uses the bit 24 in the color descriptor as an indicator
of RGB color, so we can take the values and generating the XftColour
directly in xdraws.
Eon S. Jeon [Fri, 19 Jul 2013 05:07:02 +0000 (01:07 -0400)]
Improved font caching
I made a patch that improves the performance of font caching mechanism.
This is based on a funny behaviour of FontConfig: it was handling
FcCharSet in a somewhat unexpected way.
So, we are currently adding "a character" to a new FcCharSet, and then
add it to a FcPattern. However, if we toss the FcPattern to FontConfig,
it loads the entire language(charset) that contains the character we
gave. That is, we don't always have to load a new font for each unknown
character. Instead, we can reused cached fonts, and this significantly
reduces the number of calls to extremely slow FontConfig matching
functions.
One more thing. I found that, in libXft, there's a function called
XftCharExists. XftCharIndex internally calls this function, and
does more stuffs if the character does exist. Since the returned index
is never used in st, we should call XftCharExists instead of
XftCharIndex. Please note that I already made this change in the patch.
Markus Teich [Sat, 22 Jun 2013 21:07:00 +0000 (23:07 +0200)]
fix: whitespace
Alexander Sedov [Sun, 23 Jun 2013 17:05:29 +0000 (21:05 +0400)]
Remove long text being cropped/wrapped to standard 80x24 on launch.
To be more specific, now tty creation is delayed until X window is
actually mapped; last ConfigureNotify before mapping determines
initial tty size.
Please report problems if there are any.
Markus Teich [Sat, 22 Jun 2013 21:06:49 +0000 (23:06 +0200)]
fix: consistent usage of bitmask operations on unicode functions
Markus Teich [Sat, 22 Jun 2013 21:05:03 +0000 (23:05 +0200)]
fix: do not need an extra variable for a single read
Roberto E. Vargas Caballero [Sun, 23 Jun 2013 08:33:53 +0000 (10:33 +0200)]
Fix match function bugs
There were two problems with match denfinition.
1) There was a forward declaration in the form:
static inline bool match(uint, uint);
but later the function was defined as:
inline bool
match(uint mask, uint state) {
This causes that there were two different functions in the code, one local
and inline, and other inline but extern. All was working without problems
due to we were using -Os, and the compiler was using the extern definition
and it was no expanding the static declaration. If you removed the -Os flag,
then you got linker errors due it was no able to find the static definition
of the static declaration.
2) The mask checking was incorrect because we were doing the test:
(state & mask) != state
and this test only was saying that at least all the enabled bits of state
were enabled also in mask, but no all the possible bits in mask. This was
the origin of the bug reported by Xavier Cartron, where he said it was
possible activated some shortcuts with some of the modifiers defined in the
config.h file.
Roberto E. Vargas Caballero [Sun, 23 Jun 2013 10:13:26 +0000 (12:13 +0200)]
Remove unneded call to draw
draw is the function which update the Xwindow with the information st has,
and it is designed in a way that it must be called once in the main loop
(run function), and calling it in other places it is a waste of time.
Roberto E. Vargas Caballero [Sun, 23 Jun 2013 10:09:19 +0000 (12:09 +0200)]
Fix selection clearing
The way st knows if there is a selection activated is checking if sel.ob.x
is equal to -1. In some parts of the code the way of disabling the selection
was only setting it to -1, but after it you can't be sure if the selection
is clearing from the terminal representation, because it is necessary mark
all the lines affected by the selection as dirty. Already there is a functon
which perform this task, selclear.
Markus Teich [Sat, 22 Jun 2013 14:22:41 +0000 (16:22 +0200)]
fix PageUp Modifier Mask in config.def.h
Signed-off-by: Christoph Lohmann <20h@r-36.net>
Christoph Lohmann [Sun, 9 Jun 2013 13:52:35 +0000 (15:52 +0200)]
Fixing title setting with the title argument.
Christoph Lohmann [Thu, 6 Jun 2013 17:09:18 +0000 (19:09 +0200)]
Adding xterm behaviour to setting the title.
Thanks Airwave!
Christoph Lohmann [Sat, 1 Jun 2013 12:39:13 +0000 (14:39 +0200)]
Bumping up the xfps so mouse motion won't reap the CPU.
Christoph Lohmann [Sat, 1 Jun 2013 12:37:30 +0000 (14:37 +0200)]
Adding true mouse motion support.
Christoph Lohmann [Sat, 1 Jun 2013 11:17:20 +0000 (13:17 +0200)]
This is a shorter bit handling in MODE_MOUSE.
Christoph Lohmann [Sat, 1 Jun 2013 11:13:01 +0000 (13:13 +0200)]
Add some comments about the other mouse reporting modes.
Christoph Lohmann [Sat, 1 Jun 2013 11:06:53 +0000 (13:06 +0200)]
Implementing mouse focus and all events.
Christoph Lohmann [Sat, 1 Jun 2013 10:23:55 +0000 (12:23 +0200)]
Fixing bad highlighting on first SNAP_WORD multiline select.
Christoph Lohmann [Sun, 26 May 2013 14:10:22 +0000 (16:10 +0200)]
Fixing the selection in a single line again.
Thanks p37sitdu@lavabit.com!
Christoph Lohmann [Sun, 26 May 2013 11:07:26 +0000 (13:07 +0200)]
Fixing the selection scrolling and the selection naming.
Thanks p37sitdu@lavabit.com!
Christoph Lohmann [Sat, 11 May 2013 19:59:55 +0000 (21:59 +0200)]
Lazy font unloading too.
Christoph Lohmann [Sat, 11 May 2013 06:54:26 +0000 (08:54 +0200)]
Lazy fontset loading.
Thanks Johannes Hofmann <Johannes.Hofmann@gmx.de>!
Christoph Lohmann [Mon, 6 May 2013 17:50:14 +0000 (19:50 +0200)]
Removing an old select() regression.
Christoph Lohmann [Sat, 4 May 2013 17:04:20 +0000 (19:04 +0200)]
Allow more complex delimiters for word selections.
Thanks Alexander Rezinsky <alexrez@gmail.com>!
Christoph Lohmann [Sat, 4 May 2013 17:00:32 +0000 (19:00 +0200)]
Expand the last line with '\n' in case of overselection.
Thanks Alexander Rezinsky <alexrez@gmail.com>!
Christoph Lohmann [Sat, 4 May 2013 06:05:11 +0000 (08:05 +0200)]
Select to the end of row if end of line is reached.
Thanks Alexander Rezinsky <alexrez@gmail.com>!
Christoph Lohmann [Sat, 4 May 2013 06:01:17 +0000 (08:01 +0200)]
Better comments for the snapping code.
Christoph Lohmann [Wed, 1 May 2013 11:14:46 +0000 (13:14 +0200)]
More stable blinking.
Christoph Lohmann [Sun, 28 Apr 2013 19:32:42 +0000 (21:32 +0200)]
Explaining blinking for the dummies.
Christoph Lohmann [Sun, 28 Apr 2013 16:14:15 +0000 (18:14 +0200)]
Selection snapping is now considering wrapping.
Thanks Alexander Rezinsky <alexrez@gmail.com> for mentioning this!
Christoph Lohmann [Sun, 28 Apr 2013 15:42:30 +0000 (17:42 +0200)]
Add a possibility to modify the string sent by mouse buttons.
Thanks Alexander Rezinsky <alexrez@gmail.com> for the suggestion!
Christoph Lohmann [Fri, 26 Apr 2013 16:55:40 +0000 (18:55 +0200)]
Be more efficient in blinking.
Christoph Lohmann [Fri, 26 Apr 2013 16:41:54 +0000 (18:41 +0200)]
Enable blinking in st.
Christoph Lohmann [Thu, 25 Apr 2013 04:28:11 +0000 (06:28 +0200)]
Fixing the selection handling to allow one char selection.
Thanks Alexander Sedov <alex0player@gmail.com> for suggesting the fix!
Christoph Lohmann [Wed, 24 Apr 2013 19:30:59 +0000 (21:30 +0200)]
Fixing the selection issue in altscreens.
Alexander Sedov [Tue, 23 Apr 2013 22:34:59 +0000 (02:34 +0400)]
Removed redundant check in draw code.
We're now clearing empty areas with spaces, so there is no point to check
if character contains non-empty string.
Signed-off-by: Christoph Lohmann <20h@r-36.net>
Roberto E. Vargas Caballero [Tue, 23 Apr 2013 18:34:52 +0000 (20:34 +0200)]
Fix selecting clearing and BCE
The commit
b78c5085f72 changed the st behaviour enabling BCE capability,
that means erase regions using background color. Problem comes when you
clear a region with a selection, because in this case the real mode of the
Glyph is not the value of term.line[y][x], due in drawregion we had enabled
the ATTR_REVERSE bit.
Signed-off-by: Christoph Lohmann <20h@r-36.net>
Christoph Lohmann [Tue, 23 Apr 2013 17:37:28 +0000 (19:37 +0200)]
Now clipping is more clear.
Christoph Lohmann [Tue, 23 Apr 2013 17:17:50 +0000 (19:17 +0200)]
Removing the overdrawing of some fonts.
Christoph Lohmann [Tue, 23 Apr 2013 13:38:48 +0000 (15:38 +0200)]
Yes, rs2 != is2.
Christoph Lohmann [Tue, 23 Apr 2013 13:33:21 +0000 (15:33 +0200)]
There is no 8bit by default and reset 8bit too.
Christoph Lohmann [Tue, 23 Apr 2013 13:22:14 +0000 (15:22 +0200)]
Implementing 8 bit mode for meta.
Christoph Lohmann [Sun, 21 Apr 2013 11:01:16 +0000 (13:01 +0200)]
Adding wrap handling in selection.
Alexander Sedov [Mon, 15 Apr 2013 06:28:31 +0000 (10:28 +0400)]
Added support for double/triple click+dragging.
Now double-click+dragging automatically snaps both ends to word boundaries
(unless on series of spaces), and triple-click selects whole lines.
As a side effect, snapping now occurs on button press, not button release
like it previously was, but I hope that won't be inconvenient for anyone.
Signed-off-by: Christoph Lohmann <20h@r-36.net>
Christoph Lohmann [Sat, 20 Apr 2013 13:29:39 +0000 (15:29 +0200)]
0.4.1 release.
Christoph Lohmann [Fri, 19 Apr 2013 19:11:29 +0000 (21:11 +0200)]
Making st compile on OpenBSD again.
Alexander Sedov [Thu, 18 Apr 2013 08:47:23 +0000 (12:47 +0400)]
Selection now handles empty lines less counter-intuitively.
Now, when you are selecting a region, you will get all empty lines that happen
to be in it, including trailing ones. Last line terminator is omitted as it previously
was, though.
Signed-off-by: Christoph Lohmann <20h@r-36.net>
Christoph Lohmann [Thu, 18 Apr 2013 04:51:18 +0000 (06:51 +0200)]
Removing trailing whitespace.
Alexander Sedov [Mon, 15 Apr 2013 13:13:19 +0000 (17:13 +0400)]
Got rid of redundant Glyph state.
Now, newly allocated Glyphs are set to spaces and current cursor colors
with tclearregion() routine.
Signed-off-by: Christoph Lohmann <20h@r-36.net>
Christoph Lohmann [Thu, 18 Apr 2013 04:41:54 +0000 (06:41 +0200)]
Removing unneeded comments.
Alexander Sedov [Sun, 14 Apr 2013 20:12:10 +0000 (00:12 +0400)]
Got rid of code duplication in tnew() and tresize().
Signed-off-by: Christoph Lohmann <20h@r-36.net>
Alexander Sedov [Sun, 14 Apr 2013 19:17:44 +0000 (23:17 +0400)]
Strip trailing spaces from lines when copying selection.
Signed-off-by: Christoph Lohmann <20h@r-36.net>
Christoph Lohmann [Sun, 14 Apr 2013 16:30:10 +0000 (18:30 +0200)]
Enable BCE everywhere.
Christoph Lohmann [Sat, 13 Apr 2013 13:24:26 +0000 (15:24 +0200)]
Fix the geometry handling.
Christoph Lohmann [Sat, 13 Apr 2013 10:26:17 +0000 (12:26 +0200)]
\033 should be used in printf in the FAQ.
Never apply patches of Apple users without shouting at them. The basic rule of
nature is that when you apply Appl users patches without shouting at them that
something will go horribly wrong.
Christoph Lohmann [Sat, 13 Apr 2013 07:49:11 +0000 (09:49 +0200)]
Resize now uses xclear().
Christoph Lohmann [Sat, 13 Apr 2013 07:44:00 +0000 (09:44 +0200)]
Drawing a more visible rectangle as cursor on unfocus.
To have a more visible cursor on unfocused windows this patch makes st draw a
rectangle around the terminal cell.
Thanks Mark Hills <mark@xwax.org> for the suggestion!
Christoph Lohmann [Sat, 13 Apr 2013 06:51:30 +0000 (08:51 +0200)]
Patching while not really woken up.
Christoph Lohmann [Sat, 13 Apr 2013 06:50:38 +0000 (08:50 +0200)]
Minor naming issue fixed.
Christoph Lohmann [Sat, 13 Apr 2013 06:48:17 +0000 (08:48 +0200)]
Making the copy and pasting consistent.
The copying and pasting in the terminald and GUI world is flawed. Due to the
discussion on the mailinglist it seems that sending '\n' is what GUIs expect
and '\r' what terminal applications want. St now implements that behaviour.
Kai Hendry [Tue, 9 Apr 2013 21:13:54 +0000 (22:13 +0100)]
Convert FAQ into Markdown, to make it easier to integrate it into st.suckless.org/
Signed-off-by: Christoph Lohmann <20h@r-36.net>
Christoph Lohmann [Wed, 10 Apr 2013 15:48:32 +0000 (17:48 +0200)]
Make st work with a plain -e command.
Christoph Lohmann [Wed, 3 Apr 2013 19:00:38 +0000 (21:00 +0200)]
Adopting arg.h with more flexible cmd handling.
Christoph Lohmann [Wed, 3 Apr 2013 18:42:27 +0000 (20:42 +0200)]
Add an option to disable alternative screens.
Christoph Lohmann [Fri, 29 Mar 2013 18:44:37 +0000 (19:44 +0100)]
Updating the TODO file for after 0.4.
Christoph Lohmann [Fri, 29 Mar 2013 18:13:26 +0000 (19:13 +0100)]
Releasing 0.4.
Christoph Lohmann [Fri, 29 Mar 2013 18:01:24 +0000 (19:01 +0100)]
Add the possibility to have default highlight colors.
Thanks to stargrave@stargrave.org for the suggestion!
Christoph Lohmann [Fri, 29 Mar 2013 17:45:09 +0000 (18:45 +0100)]
Adding PgUp + Ctrl.
Thanks stargrave@stargrave.org!
Christoph Lohmann [Fri, 29 Mar 2013 17:43:32 +0000 (18:43 +0100)]
Adding PgUp and PgDown + Ctrl to config.def.h
Thanks stargrave@stargrave.org!
Christoph Lohmann [Fri, 29 Mar 2013 17:39:01 +0000 (18:39 +0100)]
Removing an undefined case. just do regular selections.
Christoph Lohmann [Wed, 20 Mar 2013 20:19:28 +0000 (21:19 +0100)]
Making rectangular selection work again.
People sending me patches against strange revisions and basing on their own
revisions make me having to reapply them. Then such errors appear.
Thanks Alexander Sedov <alex0player@gmail.com> for noticing this.
Christoph Lohmann [Sun, 10 Mar 2013 20:16:51 +0000 (21:16 +0100)]
Pange seems to use ascent + descent instead of height.
Thanks Bobby Powers <bobbypowers@gmail.com> for noticing this!
Christoph Lohmann [Tue, 5 Mar 2013 21:12:11 +0000 (22:12 +0100)]
Making st compile on OS X.
Christoph Lohmann [Tue, 26 Feb 2013 20:43:40 +0000 (21:43 +0100)]
Using strsep and fixing null termination in csiparse.
Thanks for the hint from Alexander Sedov <alex0player@gmail.com>!
Christoph Lohmann [Tue, 26 Feb 2013 18:08:51 +0000 (19:08 +0100)]
Changing the way how paste is handled, just for the nano people.
Christoph Lohmann [Tue, 26 Feb 2013 18:07:23 +0000 (19:07 +0100)]
Fixing a bug while parsing empty arguments in csiparse.
Christoph Lohmann [Tue, 26 Feb 2013 17:19:44 +0000 (18:19 +0100)]
Fixing bugs in the strtol and strtok_r replacements.
Thanks "Roberto E. Vargas Caballero" <k0ga@shike2.com> for the comments!
Christoph Lohmann [Mon, 25 Feb 2013 12:36:40 +0000 (13:36 +0100)]
Using strtok_r for the string parsing.