using a global stack for focus recovery on arrange() - seems to work great

[dwm.git] / client.c

diff --git a/client.c b/client.c
index 9c0428a..3578beb 100644 (file)
--- a/client.c
+++ b/client.c
@@ -11,6 +11,14 @@
 /* static functions */
 
 static void
+detachstack(Client *c)
+{
+       Client **tc;
+       for(tc=&stack; *tc && *tc != c; tc=&(*tc)->snext);
+       *tc = c->snext;
+}
+
+static void
 grabbuttons(Client *c, Bool focus)
 {
        XUngrabButton(dpy, AnyButton, AnyModifier, c->win);
@@ -82,22 +90,32 @@ ban(Client *c)
 void
 focus(Client *c)
 {
-       Client *old = sel;
+       Client *old;
 
        if(!issel)
                return;
        if(!sel)
                sel = c;
        else if(sel != c) {
-               if(sel->ismax)
+               if(maximized)
                        togglemax(NULL);
+               old = sel;
                sel = c;
-               grabbuttons(old, False);
-               drawtitle(old);
+               if(old) {
+                       grabbuttons(old, False);
+                       drawtitle(old);
+               }
        }
-       grabbuttons(c, True);
-       drawtitle(c);
-       XSetInputFocus(dpy, c->win, RevertToPointerRoot, CurrentTime);
+       if(c) {
+               detachstack(c);
+               c->snext = stack;
+               stack = c;
+               grabbuttons(c, True);
+               drawtitle(c);
+               XSetInputFocus(dpy, c->win, RevertToPointerRoot, CurrentTime);
+       }
+       else
+               XSetInputFocus(dpy, root, RevertToPointerRoot, CurrentTime);
 }
 
 Client *
@@ -191,8 +209,7 @@ killclient(Arg *arg)
 void
 manage(Window w, XWindowAttributes *wa)
 {
-       unsigned int i;
-       Client *c, *tc;
+       Client *c;
        Window trans;
        XSetWindowAttributes twa;
 
@@ -230,30 +247,26 @@ manage(Window w, XWindowAttributes *wa)
                        DefaultVisual(dpy, screen),
                        CWOverrideRedirect | CWBackPixmap | CWEventMask, &twa);
 
-       if(clients)
-               clients->prev = c;
-       c->next = clients;
-       clients = c;
-
        grabbuttons(c, False);
-
-       if((tc = getclient(trans))) /* inherit tags */
-               for(i = 0; i < ntags; i++)
-                       c->tags[i] = tc->tags[i];
-       else
-               settags(c);
+       settags(c, getclient(trans));
        if(!c->isfloat)
                c->isfloat = trans
                        || (c->maxw && c->minw &&
                                c->maxw == c->minw && c->maxh == c->minh);
+
+       if(clients)
+               clients->prev = c;
+       c->next = clients;
+       c->snext = stack;
+       stack = clients = c;
+
        settitle(c);
-       if(isvisible(c))
-               sel = c;
-       arrange(NULL);
+       ban(c);
        XMapWindow(dpy, c->win);
        XMapWindow(dpy, c->twin);
        if(isvisible(c))
                focus(c);
+       arrange(NULL);
 }
 
 void
@@ -366,12 +379,13 @@ void
 togglemax(Arg *arg)
 {
        int ox, oy, ow, oh;
+       Client *c;
        XEvent ev;
 
        if(!sel)
                return;
 
-       if((sel->ismax = !sel->ismax)) {
+       if((maximized = !maximized)) {
                ox = sel->x;
                oy = sel->y;
                ow = sel->w;
@@ -382,6 +396,9 @@ togglemax(Arg *arg)
                sel->h = sh - 2 - bh;
 
                restack();
+               for(c = getnext(clients); c; c = getnext(c->next))
+                       if(c != sel)
+                               ban(c);
                resize(sel, arrange == dofloat, TopLeft);
 
                sel->x = ox;
@@ -390,42 +407,37 @@ togglemax(Arg *arg)
                sel->h = oh;
        }
        else
-               resize(sel, False, TopLeft);
+               arrange(NULL);
        while(XCheckMaskEvent(dpy, EnterWindowMask, &ev));
 }
 
 void
 unmanage(Client *c)
 {
-       Client *tc;
+       Client *tc, *fc;
        Window trans;
        XGrabServer(dpy);
        XSetErrorHandler(xerrordummy);
 
-       XGetTransientForHint(dpy, c->win, &trans);
-
-       XUngrabButton(dpy, AnyButton, AnyModifier, c->win);
-       XDestroyWindow(dpy, c->twin);
-
-       if(c->prev)
-               c->prev->next = c->next;
-       if(c->next)
-               c->next->prev = c->prev;
-       if(c == clients)
-               clients = c->next;
+       detach(c);
        if(sel == c) {
+               XGetTransientForHint(dpy, c->win, &trans);
                if(trans && (tc = getclient(trans)) && isvisible(tc))
-                       sel = tc;
+                       fc = tc;
                else
-                       sel = getnext(clients);
+                       fc = getnext(clients);
+               focus(fc);
        }
+
+       XUngrabButton(dpy, AnyButton, AnyModifier, c->win);
+       XDestroyWindow(dpy, c->twin);
+
+       detachstack(c);
        free(c->tags);
        free(c);
 
        XSync(dpy, False);
        XSetErrorHandler(xerror);
        XUngrabServer(dpy);
-       if(sel)
-               focus(sel);
        arrange(NULL);
 }