code polishing, removed unnecessary newlines

[dwm.git] / client.c

diff --git a/client.c b/client.c
index dce06e9..60f1cbe 100644 (file)
--- a/client.c
+++ b/client.c
@@ -1,5 +1,4 @@
-/*
- * (C)opyright MMVI Anselm R. Garbe <garbeam at gmail dot com>
+/* (C)opyright MMVI Anselm R. Garbe <garbeam at gmail dot com>
  * See LICENSE file for license details.
  */
 #include "dwm.h"
@@ -54,19 +53,6 @@ grabbuttons(Client *c, Bool focused) {
                                GrabModeAsync, GrabModeSync, None, None);
 }
 
-static void
-resizetitle(Client *c) {
-       c->tw = textw(c->name);
-       if(c->tw > c->w)
-               c->tw = c->w + 2;
-       c->tx = c->x + c->w - c->tw + 2;
-       c->ty = c->y;
-       if(isvisible(c))
-               XMoveResizeWindow(dpy, c->twin, c->tx, c->ty, c->tw, c->th);
-       else
-               XMoveResizeWindow(dpy, c->twin, c->tx + 2 * sw, c->ty, c->tw, c->th);
-}
-
 static int
 xerrordummy(Display *dsply, XErrorEvent *ee) {
        return 0;
@@ -81,6 +67,23 @@ ban(Client *c) {
 }
 
 void
+configure(Client *c) {
+       XEvent synev;
+
+       synev.type = ConfigureNotify;
+       synev.xconfigure.display = dpy;
+       synev.xconfigure.event = c->win;
+       synev.xconfigure.window = c->win;
+       synev.xconfigure.x = c->x;
+       synev.xconfigure.y = c->y;
+       synev.xconfigure.width = c->w;
+       synev.xconfigure.height = c->h;
+       synev.xconfigure.border_width = c->border;
+       synev.xconfigure.above = None;
+       XSendEvent(dpy, c->win, True, NoEventMask, &synev);
+}
+
+void
 focus(Client *c) {
        Client *old;
 
@@ -89,8 +92,6 @@ focus(Client *c) {
        if(!sel)
                sel = c;
        else if(sel != c) {
-               if(maximized)
-                       togglemax(NULL);
                old = sel;
                sel = c;
                if(old) {
@@ -154,7 +155,6 @@ gravitate(Client *c, Bool invert) {
                dy = -(c->h);
                break;
        }
-
        switch (c->grav) {
        default:
                break;
@@ -175,7 +175,6 @@ gravitate(Client *c, Bool invert) {
                dx = -(c->w + c->border);
                break;
        }
-
        if(invert) {
                dx = -dx;
                dy = -dy;
@@ -208,19 +207,16 @@ manage(Window w, XWindowAttributes *wa) {
        c->w = c->tw = wa->width;
        c->h = wa->height;
        c->th = bh;
-
        c->border = 0;
        updatesize(c);
-
-       if(c->x + c->w + 2 > sw)
-               c->x = sw - c->w - 2;
-       if(c->x < 0)
-               c->x = 0;
-       if(c->y + c->h + 2 > sh)
-               c->y = sh - c->h - 2;
+       if(c->x + c->w + 2 * BORDERPX > sw)
+               c->x = sw - c->w - 2 * BORDERPX;
+       if(c->x < sx)
+               c->x = sx;
+       if(c->y + c->h + 2 * BORDERPX > sh)
+               c->y = sh - c->h - 2 * BORDERPX;
        if(c->h != sh && c->y < bh)
                c->y = bh;
-
        c->proto = getproto(c->win);
        XSelectInput(dpy, c->win,
                StructureNotifyMask | PropertyChangeMask | EnterWindowMask);
@@ -228,26 +224,23 @@ manage(Window w, XWindowAttributes *wa) {
        twa.override_redirect = 1;
        twa.background_pixmap = ParentRelative;
        twa.event_mask = ExposureMask | EnterWindowMask;
-
        c->twin = XCreateWindow(dpy, root, c->tx, c->ty, c->tw, c->th,
                        0, DefaultDepth(dpy, screen), CopyFromParent,
                        DefaultVisual(dpy, screen),
                        CWOverrideRedirect | CWBackPixmap | CWEventMask, &twa);
-
        grabbuttons(c, False);
+       updatetitle(c);
        settags(c, getclient(trans));
        if(!c->isfloat)
                c->isfloat = trans
                        || (c->maxw && c->minw &&
                                c->maxw == c->minw && c->maxh == c->minh);
-
+       resizetitle(c);
        if(clients)
                clients->prev = c;
        c->next = clients;
        c->snext = stack;
        stack = clients = c;
-
-       updatetitle(c);
        ban(c);
        XMapWindow(dpy, c->win);
        XMapWindow(dpy, c->twin);
@@ -280,7 +273,15 @@ resize(Client *c, Bool sizehints, Corner sticky) {
                c->x = right - c->w;
        if(sticky == BotLeft || sticky == BotRight)
                c->y = bottom - c->h;
-
+       /* offscreen appearance fixes */
+       if(c->x + c->w < sx)
+               c->x = sx;
+       if(c->y + c->h < bh)
+               c->y = bh;
+       if(c->x > sw)
+               c->x = sw - c->w;
+       if(c->y > sh)
+               c->y = sh - c->h;
        resizetitle(c);
        wc.x = c->x;
        wc.y = c->y;
@@ -289,12 +290,26 @@ resize(Client *c, Bool sizehints, Corner sticky) {
        if(c->w == sw && c->h == sh)
                wc.border_width = 0;
        else
-               wc.border_width = 1;
+               wc.border_width = BORDERPX;
        XConfigureWindow(dpy, c->win, CWX | CWY | CWWidth | CWHeight | CWBorderWidth, &wc);
+       configure(c);
        XSync(dpy, False);
 }
 
 void
+resizetitle(Client *c) {
+       c->tw = textw(c->name);
+       if(c->tw > c->w)
+               c->tw = c->w + 2 * BORDERPX;
+       c->tx = c->x + c->w - c->tw + 2 * BORDERPX;
+       c->ty = c->y;
+       if(isvisible(c))
+               XMoveResizeWindow(dpy, c->twin, c->tx, c->ty, c->tw, c->th);
+       else
+               XMoveResizeWindow(dpy, c->twin, c->tx + 2 * sw, c->ty, c->tw, c->th);
+}
+
+void
 updatesize(Client *c) {
        long msize;
        XSizeHints size;
@@ -356,64 +371,25 @@ updatetitle(Client *c) {
                }
        }
        XFree(name.value);
-       resizetitle(c);
-}
-
-void
-togglemax(Arg *arg) {
-       int ox, oy, ow, oh;
-       Client *c;
-       XEvent ev;
-
-       if(!sel)
-               return;
-
-       if((maximized = !maximized)) {
-               ox = sel->x;
-               oy = sel->y;
-               ow = sel->w;
-               oh = sel->h;
-               sel->x = sx;
-               sel->y = sy + bh;
-               sel->w = sw - 2;
-               sel->h = sh - 2 - bh;
-
-               restack();
-               for(c = getnext(clients); c; c = getnext(c->next))
-                       if(c != sel)
-                               ban(c);
-               resize(sel, arrange == dofloat, TopLeft);
-
-               sel->x = ox;
-               sel->y = oy;
-               sel->w = ow;
-               sel->h = oh;
-       }
-       else
-               arrange(NULL);
-       while(XCheckMaskEvent(dpy, EnterWindowMask, &ev));
 }
 
 void
 unmanage(Client *c) {
        Client *nc;
 
+       /* The server grab construct avoids race conditions. */
        XGrabServer(dpy);
        XSetErrorHandler(xerrordummy);
-
        detach(c);
        detachstack(c);
        if(sel == c) {
                for(nc = stack; nc && !isvisible(nc); nc = nc->snext);
                focus(nc);
        }
-
        XUngrabButton(dpy, AnyButton, AnyModifier, c->win);
        XDestroyWindow(dpy, c->twin);
-
        free(c->tags);
        free(c);
-
        XSync(dpy, False);
        XSetErrorHandler(xerror);
        XUngrabServer(dpy);