JasonWoof Got questions, comments, patches, etc.? Contact Jason Woofenden
re-applied Neale's spawn patch, credited Neale in LICENSE
[dwm.git] / dwm.c
diff --git a/dwm.c b/dwm.c
index b390294..d6dc467 100644 (file)
--- a/dwm.c
+++ b/dwm.c
@@ -6,12 +6,9 @@
  * events about window (dis-)appearance.  Only one X connection at a time is
  * allowed to select for this event mask.
  *
- * Calls to fetch an X event from the event queue are blocking.  Due reading
- * status text from standard input, a select()-driven main loop has been
- * implemented which selects for reads on the X connection and STDIN_FILENO to
- * handle all data smoothly. The event handlers of dwm are organized in an
- * array which is accessed whenever a new event has been fetched. This allows
- * event dispatching in O(1) time.
+ * The event handlers of dwm are organized in an array which is accessed
+ * whenever a new event has been fetched. This allows event dispatching
+ * in O(1) time.
  *
  * Each child of the root window is called a client, except windows which have
  * set the override_redirect flag.  Clients are organized in a global
@@ -30,7 +27,6 @@
 #include <stdlib.h>
 #include <string.h>
 #include <unistd.h>
-#include <sys/select.h>
 #include <sys/types.h>
 #include <sys/wait.h>
 #include <X11/cursorfont.h>
@@ -138,7 +134,7 @@ static void attachstack(Client *c);
 static void buttonpress(XEvent *e);
 static void checkotherwm(void);
 static void cleanup(void);
-static void clearurgent(void);
+static void clearurgent(Client *c);
 static void configure(Client *c);
 static void configurenotify(XEvent *e);
 static void configurerequest(XEvent *e);
@@ -197,6 +193,7 @@ static void updatebar(void);
 static void updategeom(void);
 static void updatenumlockmask(void);
 static void updatesizehints(Client *c);
+static void updatestatus(void);
 static void updatetitle(Client *c);
 static void updatewmhints(Client *c);
 static void view(const Arg *arg);
@@ -366,20 +363,15 @@ cleanup(void) {
 }
 
 void
-clearurgent(void) {
+clearurgent(Client *c) {
        XWMHints *wmh;
-       Client *c;
-
-       for(c = clients; c; c = c->next)
-               if(ISVISIBLE(c) && c->isurgent) {
-                       c->isurgent = False;
-                       if (!(wmh = XGetWMHints(dpy, c->win)))
-                               continue;
 
-                       wmh->flags &= ~XUrgencyHint;
-                       XSetWMHints(dpy, c->win, wmh);
-                       XFree(wmh);
-               }
+       c->isurgent = False;
+       if(!(wmh = XGetWMHints(dpy, c->win)))
+               return;
+       wmh->flags &= ~XUrgencyHint;
+       XSetWMHints(dpy, c->win, wmh);
+       XFree(wmh);
 }
 
 void
@@ -618,6 +610,8 @@ focus(Client *c) {
                XSetWindowBorder(dpy, sel->win, dc.norm[ColBorder]);
        }
        if(c) {
+               if(c->isurgent)
+                       clearurgent(c);
                detachstack(c);
                attachstack(c);
                grabbuttons(c, True);
@@ -1002,9 +996,11 @@ propertynotify(XEvent *e) {
        Window trans;
        XPropertyEvent *ev = &e->xproperty;
 
-       if(ev->state == PropertyDelete)
+       if((ev->window == root) && (ev->atom = XA_WM_NAME))
+               updatestatus();
+       else if(ev->state == PropertyDelete)
                return; /* ignore */
-       if((c = getclient(ev->window))) {
+       else if((c = getclient(ev->window))) {
                switch (ev->atom) {
                default: break;
                case XA_WM_TRANSIENT_FOR:
@@ -1030,7 +1026,7 @@ propertynotify(XEvent *e) {
 
 void
 quit(const Arg *arg) {
-       readin = running = False;
+       running = False;
 }
 
 void
@@ -1184,60 +1180,13 @@ restack(void) {
 
 void
 run(void) {
-       char *p;
-       char sbuf[sizeof stext];
-       fd_set rd;
-       int r, xfd;
-       unsigned int len, offset;
        XEvent ev;
 
-       /* main event loop, also reads status text from stdin */
+       /* main event loop */
        XSync(dpy, False);
-       xfd = ConnectionNumber(dpy);
-       offset = 0;
-       len = sizeof stext - 1;
-       sbuf[len] = stext[len] = '\0'; /* 0-terminator is never touched */
-       while(running) {
-               FD_ZERO(&rd);
-               if(readin)
-                       FD_SET(STDIN_FILENO, &rd);
-               FD_SET(xfd, &rd);
-               if(select(xfd + 1, &rd, NULL, NULL, NULL) == -1) {
-                       if(errno == EINTR)
-                               continue;
-                       die("select failed\n");
-               }
-               if(FD_ISSET(STDIN_FILENO, &rd)) {
-                       switch((r = read(STDIN_FILENO, sbuf + offset, len - offset))) {
-                       case -1:
-                               strncpy(stext, strerror(errno), len);
-                               readin = False;
-                               break;
-                       case 0:
-                               strncpy(stext, "EOF", 4);
-                               readin = False;
-                               break;
-                       default:
-                               for(p = sbuf + offset; r > 0; p++, r--, offset++)
-                                       if(*p == '\n' || *p == '\0') {
-                                               *p = '\0';
-                                               strncpy(stext, sbuf, len);
-                                               p += r - 1; /* p is sbuf + offset + r - 1 */
-                                               for(r = 0; *(p - r) && *(p - r) != '\n'; r++);
-                                               offset = r;
-                                               if(r)
-                                                       memmove(sbuf, p - r + 1, r);
-                                               break;
-                                       }
-                               break;
-                       }
-                       drawbar();
-               }
-               while(XPending(dpy)) {
-                       XNextEvent(dpy, &ev);
-                       if(handler[ev.type])
-                               (handler[ev.type])(&ev); /* call handler */
-               }
+       while(running && !XNextEvent(dpy, &ev)) {
+               if(handler[ev.type])
+                       (handler[ev.type])(&ev); /* call handler */
        }
 }
 
@@ -1360,8 +1309,7 @@ setup(void) {
                        CWOverrideRedirect|CWBackPixmap|CWEventMask, &wa);
        XDefineCursor(dpy, barwin, cursor[CurNormal]);
        XMapRaised(dpy, barwin);
-       strcpy(stext, "dwm-"VERSION);
-       drawbar();
+       updatestatus();
 
        /* EWMH support per view */
        XChangeProperty(dpy, root, netatom[NetSupported], XA_ATOM, 32,
@@ -1369,7 +1317,8 @@ setup(void) {
 
        /* select for events */
        wa.event_mask = SubstructureRedirectMask|SubstructureNotifyMask|ButtonPressMask
-                       |EnterWindowMask|LeaveWindowMask|StructureNotifyMask;
+                       |EnterWindowMask|LeaveWindowMask|StructureNotifyMask
+                       |PropertyChangeMask;
        XChangeWindowAttributes(dpy, root, CWEventMask|CWCursor, &wa);
        XSelectInput(dpy, root, wa.event_mask);
 
@@ -1503,7 +1452,6 @@ toggleview(const Arg *arg) {
 
        if(mask) {
                tagset[seltags] = mask;
-               clearurgent();
                arrange();
        }
 }
@@ -1654,11 +1602,18 @@ updatetitle(Client *c) {
 }
 
 void
+updatestatus() {
+       if(!gettextprop(root, XA_WM_NAME, stext, sizeof(stext)))
+               strcpy(stext, "dwm-"VERSION);
+       drawbar();
+}
+
+void
 updatewmhints(Client *c) {
        XWMHints *wmh;
 
        if((wmh = XGetWMHints(dpy, c->win))) {
-               if(ISVISIBLE(c) && wmh->flags & XUrgencyHint) {
+               if(c == sel && wmh->flags & XUrgencyHint) {
                        wmh->flags &= ~XUrgencyHint;
                        XSetWMHints(dpy, c->win, wmh);
                }
@@ -1676,7 +1631,6 @@ view(const Arg *arg) {
        seltags ^= 1; /* toggle sel tagset */
        if(arg->ui & TAGMASK)
                tagset[seltags] = arg->ui & TAGMASK;
-       clearurgent();
        arrange();
 }