JasonWoof Got questions, comments, patches, etc.? Contact Jason Woofenden
fixing some minor issues
[dwm.git] / view.c
diff --git a/view.c b/view.c
index daf0711..9bd7584 100644 (file)
--- a/view.c
+++ b/view.c
@@ -1,4 +1,4 @@
-/* (C)opyright MMVI Anselm R. Garbe <garbeam at gmail dot com>
+/* (C)opyright MMVI-MMVII Anselm R. Garbe <garbeam at gmail dot com>
  * See LICENSE file for license details.
  */
 #include "dwm.h"
@@ -6,50 +6,57 @@
 /* static */
 
 static Client *
-minclient(void) {
-       Client *c, *min;
-
-       if((clients && clients->isfloat) || arrange == dofloat)
-               return clients; /* don't touch floating order */
-       for(min = c = clients; c; c = c->next)
-               if(c->weight < min->weight)
-                       min = c;
-       return min;
-}
-
-static Client *
 nexttiled(Client *c) {
        for(c = getnext(c); c && c->isfloat; c = getnext(c->next));
        return c;
 }
 
+static Bool
+ismaster(Client *c) {
+       Client *cl;
+       unsigned int i;
+
+       for(cl = nexttiled(clients), i = 0; cl && cl != c; cl = nexttiled(cl->next), i++);
+       return i < nmaster;
+}
+
 static void
-reorder(void) {
-       Client *c, *newclients, *tail;
-
-       newclients = tail = NULL;
-       while((c = minclient())) {
-               detach(c);
-               if(tail) {
-                       c->prev = tail;
-                       tail->next = c;
-                       tail = c;
-               }
-               else
-                       tail = newclients = c;
-       }
-       clients = newclients;
+pop(Client *c) {
+       detach(c);
+       if(clients)
+               clients->prev = c;
+       c->next = clients;
+       clients = c;
+}
+
+static void
+swap(Client *c1, Client *c2) {
+       Client tmp = *c1;
+       Client *c1p = c1->prev;
+       Client *c1n = c1->next;
+       Client *c2p = c2->prev;
+       Client *c2n = c2->next;
+
+       *c1 = *c2;
+       *c2 = tmp;
+       c1->prev = c1p;
+       c1->next = c1n;
+       c2->prev = c2p;
+       c2->next = c2n;
 }
 
 static void
 togglemax(Client *c) {
        XEvent ev;
+               
+       if(c->isfixed)
+               return;
 
        if((c->ismax = !c->ismax)) {
-               c->rx = c->x; c->x = sx;
-               c->ry = c->y; c->y = bh;
-               c->rw = c->w; c->w = sw - 2 * BORDERPX;
-               c->rh = c->h; c->h = sh - bh - 2 * BORDERPX;
+               c->rx = c->x; c->x = wax;
+               c->ry = c->y; c->y = way;
+               c->rw = c->w; c->w = waw - 2 * BORDERPX;
+               c->rh = c->h; c->h = wah - 2 * BORDERPX;
        }
        else {
                c->x = c->rx;
@@ -61,6 +68,15 @@ togglemax(Client *c) {
        while(XCheckMaskEvent(dpy, EnterWindowMask, &ev));
 }
 
+static Client *
+topofstack() {
+       Client *c;
+       unsigned int i;
+
+       for(c = nexttiled(clients), i = 0; c && i < nmaster; c = nexttiled(c->next), i++);
+       return (i < nmaster) ? NULL : c;
+}
+
 /* extern */
 
 void (*arrange)(void) = DEFMODE;
@@ -96,17 +112,16 @@ dofloat(void) {
 
 void
 dotile(void) {
-       unsigned int i, n, mpx, stackw, stackh, th;
+       unsigned int i, n, mw, mh, tw, th;
        Client *c;
 
        for(n = 0, c = nexttiled(clients); c; c = nexttiled(c->next))
                n++;
-       mpx = (sw * master) / 1000;
-       stackw = sw - mpx;
-       stackh = sh - bh;
-       th = stackh;
-       if(n > 1)
-               th /= (n - 1);
+       /* window geoms */
+       mw = (n > nmaster) ? (waw * master) / 1000 : waw;
+       mh = (n > nmaster) ? wah / nmaster : wah / (n > 0 ? n : 1);
+       tw = waw - mw;
+       th = (n > nmaster) ? wah / (n - nmaster) : 0;
 
        for(i = 0, c = clients; c; c = c->next)
                if(isvisible(c)) {
@@ -115,28 +130,22 @@ dotile(void) {
                                continue;
                        }
                        c->ismax = False;
-                       c->x = sx;
-                       c->y = sy + bh;
-                       if(n == 1) { /* only 1 window */
-                               c->w = sw - 2 * BORDERPX;
-                               c->h = sh - 2 * BORDERPX - bh;
-                       }
-                       else if(i == 0) { /* master window */
-                               c->w = mpx - 2 * BORDERPX;
-                               c->h = sh - bh - 2 * BORDERPX;
+                       c->x = wax;
+                       c->y = way;
+                       if(i < nmaster) {
+                               c->y += i * mh;
+                               c->w = mw - 2 * BORDERPX;
+                               c->h = mh - 2 * BORDERPX;
                        }
                        else {  /* tile window */
-                               c->x += mpx;
-                               c->w = stackw - 2 * BORDERPX;
+                               c->x += mw;
+                               c->w = tw - 2 * BORDERPX;
                                if(th > bh) {
-                                       c->y = sy + (i - 1) * th + bh;
-                                       if(i + 1 == n)
-                                               c->h = sh - c->y - 2 * BORDERPX;
-                                       else
-                                               c->h = th - 2 * BORDERPX;
+                                       c->y += (i - nmaster) * th;
+                                       c->h = th - 2 * BORDERPX;
                                }
                                else /* fallback if th < bh */
-                                       c->h = stackh - 2 * BORDERPX;
+                                       c->h = wah - 2 * BORDERPX;
                        }
                        resize(c, False, TopLeft);
                        i++;
@@ -181,6 +190,14 @@ focusprev(Arg *arg) {
        }
 }
 
+void
+incnmaster(Arg *arg) {
+       if((nmaster + arg->i < 1) || (wah / (nmaster + arg->i) < bh))
+               return;
+       nmaster += arg->i;
+       arrange();
+}
+
 Bool
 isvisible(Client *c) {
        unsigned int i;
@@ -192,25 +209,14 @@ isvisible(Client *c) {
 }
 
 void
-resizecol(Arg *arg) {
-       unsigned int n;
-       Client *c;
-
-       for(n = 0, c = clients; c; c = c->next)
-               if(isvisible(c) && !c->isfloat)
-                       n++;
-       if(!sel || sel->isfloat || n < 2 || (arrange == dofloat))
-               return;
-       if(sel == getnext(clients)) {
+resizemaster(Arg *arg) {
+       if(arg->i == 0)
+               master = MASTER;
+       else {
                if(master + arg->i > 950 || master + arg->i < 50)
                        return;
                master += arg->i;
        }
-       else {
-               if(master - arg->i > 950 || master - arg->i < 50)
-                       return;
-               master -= arg->i;
-       }
        arrange();
 }
 
@@ -245,6 +251,14 @@ restack(void) {
 }
 
 void
+togglefloat(Arg *arg) {
+       if (!sel || arrange == dofloat)
+               return;
+       sel->isfloat = !sel->isfloat;
+       arrange();
+}
+
+void
 togglemode(Arg *arg) {
        arrange = (arrange == dofloat) ? dotile : dofloat;
        if(sel)
@@ -261,7 +275,6 @@ toggleview(Arg *arg) {
        for(i = 0; i < ntags && !seltag[i]; i++);
        if(i == ntags)
                seltag[arg->i] = True; /* cannot toggle last view */
-       reorder();
        arrange();
 }
 
@@ -270,19 +283,9 @@ view(Arg *arg) {
        unsigned int i;
 
        for(i = 0; i < ntags; i++)
-               seltag[i] = False;
-       seltag[arg->i] = True;
-       reorder();
-       arrange();
-}
-
-void
-viewall(Arg *arg) {
-       unsigned int i;
-
-       for(i = 0; i < ntags; i++)
-               seltag[i] = True;
-       reorder();
+               seltag[i] = (arg->i == -1) ? True : False;
+       if(arg->i >= 0 && arg->i < ntags)
+               seltag[arg->i] = True;
        arrange();
 }
 
@@ -297,19 +300,23 @@ zoom(Arg *arg) {
                togglemax(sel);
                return;
        }
-       for(n = 0, c = clients; c; c = c->next)
-               if(isvisible(c) && !c->isfloat)
-                       n++;
-       if(n < 2 || (arrange == dofloat))
+       for(n = 0, c = nexttiled(clients); c; c = nexttiled(c->next))
+               n++;
+
+       c = sel;
+       if(arrange == dofloat)
                return;
-       if((c = sel) == nexttiled(clients))
-               if(!(c = nexttiled(c->next)))
+       else if(n <= nmaster)
+               pop(c);
+       else if(ismaster(sel)) {
+               if(!(c = topofstack()))
                        return;
-       detach(c);
-       if(clients)
-               clients->prev = c;
-       c->next = clients;
-       clients = c;
+               swap(c, sel);
+               c = sel;
+       }
+       else
+               pop(c);
+
        focus(c);
        arrange();
 }