applied sanders patch to remove unnecessary commit()

[dwm.git] / view.c

diff --git a/view.c b/view.c
index ac336e3..aa0a23a 100644 (file)
--- a/view.c
+++ b/view.c
@@ -3,30 +3,39 @@
  * See LICENSE file for license details.
  */
 #include "dwm.h"
+#include <stdio.h>
 
 /* static */
 
 static Client *
-getslot(Client *c)
+minclient()
 {
-       unsigned int i, tic;
-       Client *p;
-
-       for(tic = 0; tic < ntags && !c->tags[tic]; tic++);
-       for(p = clients; p; p = p->next) {
-               for(i = 0; i < ntags && !p->tags[i]; i++);
-               if(tic < i)
-                       return p;
-       }
-       return p;
+       Client *c, *min;
+
+       for(min = c = clients; c; c = c->next)
+               if(c->weight < min->weight)
+                       min = c;
+       return min;
 }
 
-static Client *
-tail()
+
+static void
+reorder()
 {
-       Client *c;
-       for(c = clients; c && c->next; c = c->next);
-       return c;
+       Client *c, *newclients, *tail;
+
+       newclients = tail = NULL;
+       while((c = minclient())) {
+               detach(c);
+               if(tail) {
+                       c->prev = tail;
+                       tail->next = c;
+                       tail = c;
+               }
+               else
+                       tail = newclients = c;
+       }
+       clients = newclients;
 }
 
 /* extern */
@@ -34,35 +43,6 @@ tail()
 void (*arrange)(Arg *) = DEFMODE;
 
 void
-attach(Client *c)
-{
-       Client *p;
-
-       if(!clients) {
-               clients = c;
-               return;
-       }
-       if(!(p = getnext(clients)) && !(p = getslot(c))) {
-               p = tail();
-               c->prev = p;
-               p->next = c;
-               return;
-       }
-
-       if(p == clients) {
-               c->next = clients;
-               clients->prev = c;
-               clients = c;
-       }
-       else {
-               p->prev->next = c;
-               c->prev = p->prev;
-               p->prev = c;
-               c->next = p;
-       }
-}
-
-void
 detach(Client *c)
 {
        if(c->prev)
@@ -277,6 +257,7 @@ toggleview(Arg *arg)
        for(i = 0; i < ntags && !seltag[i]; i++);
        if(i == ntags)
                seltag[arg->i] = True; /* cannot toggle last view */
+       reorder();
        arrange(NULL);
 }
 
@@ -288,6 +269,7 @@ view(Arg *arg)
        for(i = 0; i < ntags; i++)
                seltag[i] = False;
        seltag[arg->i] = True;
+       reorder();
        arrange(NULL);
 }
 
@@ -303,7 +285,9 @@ zoom(Arg *arg)
                if(!(c = getnext(c->next)))
                        return;
        detach(c);
-       attach(c);
+       c->next = clients;
+       clients->prev = c;
+       clients = c;
        focus(c);
        arrange(NULL);
 }